--- Log opened Sun May 29 00:00:41 2011 | ||
@sonney2k | more involved than I thought... | 00:25 |
---|---|---|
CIA-32 | shogun: Soeren Sonnenburg master * r52ce59f / (82 files in 9 dirs): rename preproc -> preprocessor - http://bit.ly/kgUDUq | 00:25 |
@sonney2k | now for the CClassifier rename... | 00:32 |
-!- alesis-novik [~alesis@188.74.87.84] has quit [Quit: Leaving] | 01:59 | |
-!- blackburn [~qdrgsm@188.168.3.22] has joined #shogun | 10:18 | |
@sonney2k | blackburn, around? | 10:52 |
@sonney2k | I've done the preproc PreProc etc transition | 10:52 |
@sonney2k | does it that look good to you or do you have any other ideas for improvement? | 10:52 |
@sonney2k | I am doing the machine transition now | 10:53 |
@sonney2k | Current plan is to create a directory machine and then move the KernelMachine DistanceMachine in there | 10:53 |
@sonney2k | in addition Classifier and rename it to Machine | 10:53 |
@sonney2k | and also LinearClassifier - and name it LinearMachine | 10:54 |
sploving | sonney2k, I debug one day for lua MatrixTest.lua example and now it works. I pushed it. when you have time please take a look at it. l8r | 11:31 |
@sonney2k | sploving, nice | 11:32 |
@sonney2k | sploving, not sure why but this thing cannot be applied | 11:35 |
@sonney2k | I think you need to rebase your patch against git master | 11:35 |
CIA-32 | shogun: Soeren Sonnenburg master * r54150e8 / (65 files in 10 dirs): | 11:41 |
CIA-32 | shogun: Transistion: rename CClassifier to CMachine | 11:41 |
CIA-32 | shogun: correspondingly rename CLinearClassifier -> CLinearMachine | 11:41 |
CIA-32 | shogun: and move them to the machine/ subdirectory - http://bit.ly/kKpVM6 | 11:41 |
@sonney2k | blackburn, ok we have Machines now :D | 11:41 |
@sonney2k | sploving, btw thanks for the status email to the mailinglist! | 11:42 |
sploving | sonney2k, you are welcome. git fetch && git merge upstream/master. fatal: Entry 'src/configure' would be overwritten by merge. Cannot merge | 12:01 |
-!- Tanmoy [56ce19a2@gateway/web/freenode/ip.86.206.25.162] has joined #shogun | 12:10 | |
-!- Tanmoy [56ce19a2@gateway/web/freenode/ip.86.206.25.162] has quit [Client Quit] | 12:13 | |
blackburn | sonney2k: now yes | 12:35 |
blackburn | reading.. | 12:35 |
blackburn | sonney2k: I have only one idea about preproc - to structurize it some another way, i.e. now dim reduction processor are all inherited from SimplePreproc<float64_t> - looks strange | 12:41 |
blackburn | I'd like to study more about MDS for genomic data sets :) will try a bit later | 12:47 |
@bettyboo | blackburn, smart! | 12:48 |
blackburn | bettyboo: just like you | 12:48 |
@bettyboo | blackburn: well then send another request: btw I also noted that you don't have newlines after and before loops ... that is also sth I would like to have for readability | 12:48 |
sploving | blackburn, /root/shogun/src/libshogun/classifier/DistanceMachine.cpp:32: multiple definition of `shogun::CDistanceMachine::~CDistanceMachine()' | 12:50 |
blackburn | yees? | 12:50 |
sploving | what does that mean? I reset my repo to the trunk, but when compile it shows the following error | 12:51 |
blackburn | sploving: will try it now too | 12:51 |
sploving | sonney2k, I reset it to the uptream, change my files need commit and pushed it! | 12:58 |
blackburn | compiling.. | 13:00 |
sploving | blackburn, what is going? | 13:06 |
blackburn | sploving: compiling :) | 13:07 |
sploving | blackburn,so slow? how many cors of you machine? | 13:10 |
blackburn | it is 2 core T4300 processor in my notebook | 13:11 |
sploving | you could use make -j4 | 13:11 |
blackburn | what it is? | 13:11 |
blackburn | hehe | 13:12 |
blackburn | jobs, see now | 13:12 |
blackburn | sploving: done, everything is ok | 13:13 |
blackburn | no error you mentioned before | 13:13 |
sploving | you mean libshogun and python? | 13:15 |
sploving | I compile lua | 13:15 |
blackburn | ah | 13:15 |
sploving | I will have a try again | 13:16 |
blackburn | anyway I think there is no difference | 13:16 |
blackburn | because the error is in libshogun | 13:16 |
blackburn | damn it is fast! | 13:16 |
blackburn | thank you for -j4 advice | 13:16 |
-!- sploving [~root@124.16.139.196] has quit [Ping timeout: 240 seconds] | 13:20 | |
@sonney2k | blackburn, so looks ok for you ? | 14:36 |
blackburn | sonney2k: preproc? | 14:38 |
@sonney2k | blackburn, preproc and machine | 14:55 |
blackburn | sonney2k: yeah it is ok | 14:55 |
@sonney2k | hmmhh sploving above didn't do make distclean or git clean -dfx before | 14:55 |
@sonney2k | blackburn, I am not sure if the machine directory shouldn't have the regression etc stuff as subdirs | 14:55 |
@sonney2k | blackburn, should machine's classify function be renamed to apply ? | 14:56 |
@sonney2k | or do you have a better name? | 14:56 |
blackburn | sonney2k: train - apply, right? | 14:56 |
@sonney2k | blackburn, good for me | 14:56 |
@sonney2k | train we have | 14:56 |
blackburn | sonney2k: for me too | 14:56 |
@sonney2k | but classify needs a rename to apply() then | 14:57 |
@sonney2k | that has to be done manually though | 14:57 |
blackburn | it makes sense for clustering and regression issues | 14:57 |
@sonney2k | ok | 14:57 |
@sonney2k | currently we have | 14:57 |
@sonney2k | CMachine | 14:57 |
@sonney2k | CLinearMachine | 14:57 |
@sonney2k | CDistanceMachine | 14:57 |
@sonney2k | CKernelMachine | 14:57 |
blackburn | about CDistanceMachine | 14:57 |
blackburn | it have nice thread based distance calculation routines | 14:58 |
blackburn | why we have not ones in distance? | 14:58 |
@sonney2k | blackburn, IIRC distance has those already | 14:58 |
blackburn | sonney2k: for example get_distance_matrix do it without threads | 14:59 |
@sonney2k | blackburn, but I would say you only comment on the structure of shogun and do the remaining things afterwards | 14:59 |
@sonney2k | blackburn, i think it does with threads | 14:59 |
@sonney2k | I mean you have exams which are more important for now | 14:59 |
blackburn | no problem with exams, will study it this evening :) | 15:00 |
@sonney2k | ok | 15:00 |
blackburn | sonney2k: classifier, clustering might be subdirs of machine | 15:00 |
@sonney2k | if distance matrix is not yet pthreaded - submit patches sure | 15:00 |
@sonney2k | blackburn, yeah - thought so too | 15:01 |
@sonney2k | regression too | 15:01 |
blackburn | sonney2k: I am not very familiar with threads used here, will be think about just after finishing some important steps in my dimreduction | 15:02 |
blackburn | some of algos should be parallelized for sure | 15:02 |
@sonney2k | blackburn, yeah | 15:02 |
@sonney2k | very welcome... | 15:02 |
blackburn | and I would implement kd-tree or balltree | 15:02 |
blackburn | seems working with instance-learning (or neighborhood-based, etc) algos is my fate :D | 15:03 |
@sonney2k | blackburn, there is a lightning fast kdtree implementation available already | 15:03 |
blackburn | because I started shogun developing with kNN and my project uses it too | 15:03 |
@sonney2k | by john langford | 15:03 |
@sonney2k | so we could borrow his code :) | 15:04 |
blackburn | aha | 15:04 |
blackburn | well it simplifies work :) | 15:04 |
@sonney2k | but structure first | 15:04 |
blackburn | just adapt it to shogun | 15:04 |
@sonney2k | so what do you think should I move the machine derived things into machine ? | 15:04 |
blackburn | yeah, of course | 15:05 |
@sonney2k | and should I make subdirs there or not | 15:05 |
@sonney2k | probably or? | 15:05 |
blackburn | subdirs sounds nice | 15:05 |
@sonney2k | I mean regression -> machine/regression | 15:05 |
blackburn | btw, may be some more namespaces should be nice too | 15:05 |
@sonney2k | blackburn, but how do we reflect that change in e.g. python_modular? | 15:05 |
blackburn | what do you mean? | 15:06 |
blackburn | ah | 15:06 |
@sonney2k | currently it is from shogun.Classifier import * | 15:06 |
blackburn | shogun.Machine.Classifier or shogun.Classifier? | 15:06 |
@sonney2k | we don't want shogun.Machine.Classifier I think | 15:06 |
blackburn | yeah sounds cumbersome | 15:06 |
@sonney2k | so I am not sure if we should actually move things already | 15:07 |
@sonney2k | shogun isn't that big yet... | 15:07 |
blackburn | is it possible to make shogun.Classifier just a shorthand name for libshogun/machine/classifier? | 15:07 |
@sonney2k | if we were numpy then it makes sense | 15:07 |
@sonney2k | blackburn, sure but it is not consistent then | 15:07 |
@sonney2k | I would prefer the same structure in C++ as in *_modular | 15:07 |
@sonney2k | otherwise it will be confusing | 15:07 |
blackburn | sounds reasonable | 15:07 |
blackburn | okay so let it be the way it is now | 15:08 |
@sonney2k | I would then add a shogun.Machine for the modular interfaces | 15:08 |
CIA-32 | shogun: Baozeng Ding master * r6688b5c / (4 files in 2 dirs): use lua_objlen to count table size, improve error handing, and add lua vector/matrix test - http://bit.ly/klNC7w | 15:09 |
blackburn | the only issue - looks confusing then classes in some 'package' are inherited from the other one | 15:10 |
blackburn | but no other way now | 15:10 |
blackburn | sonney2k: btw 'make -j4' rocks, it makes shogun compile fast! | 15:10 |
@sonney2k | blackburn, I use that all the time of course | 15:11 |
@sonney2k | (I have it set in MAKEFLAGS='-j4') | 15:11 |
@sonney2k | so I don't have to specify it | 15:11 |
blackburn | where I can set it? | 15:11 |
@sonney2k | bashrc] | 15:12 |
blackburn | ah. i see | 15:12 |
@sonney2k | i have my son now on my left arm... | 15:12 |
@sonney2k | slight handicap | 15:12 |
blackburn | sonney2k: btw PreProc was wrong indeed | 15:13 |
blackburn | looks like wrong camel-case | 15:13 |
blackburn | cause word is Preprocessor not pre processor and so on | 15:13 |
blackburn | so I like it more :) | 15:13 |
@sonney2k | me too | 15:14 |
@sonney2k | more readable | 15:14 |
blackburn | just adapted LLE for new naming | 15:15 |
@sonney2k | and we avoid unneeded shortcuts anyway | 15:15 |
@sonney2k | LLE should also have a proper name :) | 15:15 |
blackburn | anyway it is not in trunk so I have much time to think about how to name it | 15:16 |
blackburn | but LocallyLinearEmbedding is bad too | 15:16 |
@sonney2k | it says more than LLE I think | 15:16 |
blackburn | sonney2k: I have a very simple idea about codestyle | 15:17 |
blackburn | just modify it http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml | 15:18 |
@sonney2k | which link exactly? | 15:21 |
blackburn | I just mean if we will have an 'official' codestyle | 15:21 |
blackburn | new developers should not make some not-shogun-style code | 15:21 |
blackburn | it could simplify your work | 15:21 |
@sonney2k | we have that though not as erfect | 15:23 |
@sonney2k | p | 15:23 |
@sonney2k | cookie time | 15:23 |
@sonney2k | l8r | 15:23 |
blackburn | well then I will have some game theory time :D | 15:26 |
-!- blackburn [~qdrgsm@188.168.3.22] has left #shogun [] | 15:58 | |
-!- blackburn [~qdrgsm@188.168.3.22] has joined #shogun | 20:13 | |
serialhex | OOH!!!! I WANNA POKE SOMEONE IN THE EYE!!!! | 21:29 |
serialhex | sonney2k: so i keep getting this error when i compile shogun, i have the configure string i'm using & the last little bit of the output. if you have any ideas of things you want me to look at let me know, i've got a few things i'm doing and will get back to you asap! | 21:37 |
@sonney2k | serialhex, look in the mirror ;-) | 21:38 |
serialhex | in the mirror?? | 21:38 |
@sonney2k | which error? | 21:38 |
serialhex | DUHH!!! | 21:38 |
@sonney2k | ^^eye poking :D | 21:38 |
serialhex | one sec :P | 21:38 |
serialhex | https://gist.github.com/9b28bde8718703fe1b66 | 21:38 |
@sonney2k | but only the left eye please ;-) | 21:38 |
serialhex | why? left eye wonky or somethin?? can you see better out of your right eye? | 21:39 |
@sonney2k | serialhex, do a git clean -dfx | 21:39 |
serialhex | kk | 21:39 |
serialhex | anything else before i try the make? | 21:40 |
* serialhex is configurin & makin! | 21:41 | |
serialhex | i've got some ppl coming over in a minute sonney2k so i've got to handle that & i'll let you know how things go, all right? | 21:43 |
serialhex | (and besides, the compiling takes FOR FREAKING EVAR!!!) | 21:43 |
@sonney2k | serialhex, heh | 21:43 |
@sonney2k | deal with them - let them choose the weapons ;-) | 21:44 |
serialhex | they're here! i'll bbl!! | 21:44 |
@bettyboo | 8) | 21:44 |
serialhex | EXACTLY!!! | 21:44 |
blackburn | damn stochastic game with shity bellman equations :E | 21:51 |
@sonney2k | blackburn, what do you think should I *add* a apply() and apply_to_example() function to all the classifiers and make that one call the classify() / classify_example() one that already exists in classifiers or should I rename the classify() etc functions in classifier's? | 22:44 |
blackburn | sonney2k: to _add_ sounds easily :) | 23:18 |
@sonney2k | blackburn, I did the other thing but now I am not convinced that this was the right deision | 23:19 |
@sonney2k | diaper time... | 23:19 |
blackburn | you renamed it? | 23:19 |
blackburn | not bad too | 23:19 |
@sonney2k | blackburn, I don't know... it will break all scripts.. | 23:26 |
blackburn | yeah a little revolution | 23:27 |
@sonney2k | CMachine / CClassifier rename is not intrusive for the interface side | 23:27 |
@sonney2k | so I don't like it | 23:27 |
blackburn | well time for some sleep | 23:30 |
blackburn | three days - three exams to go :D | 23:30 |
blackburn | sonney2k: see you | 23:31 |
@sonney2k | I tend to revert the changes ... | 23:31 |
blackburn | which changes have you done? | 23:31 |
@sonney2k | and only add the apply function | 23:31 |
@sonney2k | blackburn, all the replacement classify -> apply | 23:31 |
blackburn | ah | 23:32 |
@sonney2k | classify_example -> apply_example | 23:32 |
blackburn | apply_to_example looks better | 23:32 |
@sonney2k | but for classifiers I think we should keep these functions | 23:32 |
@sonney2k | blackburn, yeah sure but that is not the problem | 23:32 |
blackburn | sonney2k: btw what about no apply_to*? apply(features) & apply(vector)? | 23:33 |
@sonney2k | and apply(idx) ? | 23:34 |
blackburn | yeap | 23:34 |
blackburn | some kind of polymorphism :) | 23:35 |
@bettyboo | 8) | 23:35 |
blackburn | well, time to bed :) now really | 23:37 |
blackburn | see you | 23:37 |
-!- blackburn [~qdrgsm@188.168.3.22] has quit [Quit: Leaving.] | 23:37 | |
--- Log closed Mon May 30 00:00:44 2011 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!