| --- Log opened Sun Nov 24 00:00:38 2013 | ||
| shogun-buildbot_ | build #305 of osx1 - libshogun is complete: Failure [failed git] Build details are at http://buildbot.shogun-toolbox.org/builders/osx1%20-%20libshogun/builds/305 blamelist: Viktor Gal <viktor.gal@maeth.com> | 01:29 |
|---|---|---|
| -!- zxtx [~zv@ool-2f110054.dyn.optonline.net] has quit [Ping timeout: 246 seconds] | 02:48 | |
| -!- zxtx [~zv@ool-2f110054.dyn.optonline.net] has joined #shogun | 02:58 | |
| -!- thoralf [~thoralf@91-66-33-4-dynip.superkabel.de] has joined #shogun | 03:14 | |
| thoralf | Hello everybody. | 03:14 |
| -!- zxtx [~zv@ool-2f110054.dyn.optonline.net] has quit [Ping timeout: 252 seconds] | 03:27 | |
| -!- thoralf [~thoralf@91-66-33-4-dynip.superkabel.de] has quit [Quit: Konversation terminated!] | 03:41 | |
| -!- zxtx [~zv@ool-2f110054.dyn.optonline.net] has joined #shogun | 03:42 | |
| shogun-buildbot_ | build #627 of nightly_default is complete: Success [build successful] Build details are at http://buildbot.shogun-toolbox.org/builders/nightly_default/builds/627 | 04:14 |
| -!- iglesiasg [~iglesias@s83-179-44-135.cust.tele2.se] has joined #shogun | 11:24 | |
| -!- mode/#shogun [+o iglesiasg] by ChanServ | 11:24 | |
| -!- thoralf [~thoralf@91-66-33-4-dynip.superkabel.de] has joined #shogun | 12:21 | |
| thoralf | Heyhey. | 12:21 |
| @iglesiasg | thoralf, hello hello | 12:31 |
| @iglesiasg | sonney2k, around? | 12:32 |
| @iglesiasg | or someone with some Django experience around? | 12:32 |
| @iglesiasg | ok, no problem. I found what I needed :) | 12:36 |
| thoralf | iglesiasg: Trying ony stackoverflow code snippet after another? ;) | 12:37 |
| thoralf | http://xkcd.com/1185/ | 12:37 |
| @iglesiasg | hehe not really, I found in the doc actually! | 12:37 |
| thoralf | (don't forget to check the mouse-over of the xkcd strip) | 12:38 |
| -!- iglesiasg [~iglesias@s83-179-44-135.cust.tele2.se] has quit [Ping timeout: 245 seconds] | 13:24 | |
| -!- zxtx [~zv@ool-2f110054.dyn.optonline.net] has quit [Ping timeout: 245 seconds] | 14:28 | |
| @sonney2k | thoralf, around? | 15:57 |
| thoralf | sonney2k: Yes. | 16:00 |
| @sonney2k | thoralf, I am just wondering why you didn't make SGRefObject not a base class of CSGObject? | 16:01 |
| @sonney2k | but really only the minimal thing in SGRefObject | 16:02 |
| thoralf | sonney2k: I first wanted some feedback before spending more time on this. | 16:02 |
| thoralf | CSGObject does a lot of things. Which should be put into SGRefObject and which should stay? How does this relate to SGReferencedData/ReferencedObject, etc.? | 16:05 |
| @sonney2k | thoralf, just the refcounting no more should go into SGRefObject - as I said my biggest Q would be if we can use SGReferencedData (and just have one base class for referenced stuff) | 16:06 |
| @sonney2k | but maybe not at this stage | 16:06 |
| @sonney2k | thoralf, then maybe the CDynamicObjectArray should get another parent CDynamicRefObjectArray | 16:07 |
| @sonney2k | which contains all the stuff but the serialization | 16:07 |
| thoralf | I knew I'm triggering lots of ideas. ;) | 16:08 |
| thoralf | But for now, making CSGObject subclass of SGRefObject would do? | 16:08 |
| @sonney2k | thoralf, look the easy (and reasonable change) is SGReferencedObject <- CSGObject | 16:09 |
| @sonney2k | so that should be done in one patch | 16:09 |
| thoralf | Yes, I just didn't know if you will approve the way I chose and how much of the functionality should be outsourced. | 16:31 |
| thoralf | It just happend a few times that I did something you rejected. | 16:32 |
| @sonney2k | thoralf, the absolute minimum | 16:32 |
| thoralf | I'm on the way. | 16:32 |
| @sonney2k | thoralf, you already did too much in one PR... | 16:32 |
| thoralf | For example? | 16:33 |
| @sonney2k | thoralf, I am not sure how if you should use DynArray later - I mean it does not ref/unref there so it might be leaky | 16:35 |
| thoralf | Yes, but it was the easiest way of get it working, since DynamicObjectArray only accepts CSGObjects. | 16:36 |
| @sonney2k | thoralf, it might make sense to have DynamicRefObjectArray for automagic ref/unref'ing | 16:37 |
| thoralf | I totally know that. But I cannot spend more time on this issue -- the waste of memory has been reduced, so that my stuff runs. | 16:40 |
| thoralf | What I now do is just a favour for you guys. ;) | 16:40 |
| thoralf | sonney2k, I'm now having a problem with examples/undocumented/libshogun/library_gc_array.cpp: I'm getting a segfault in "return 0". | 16:54 |
| thoralf | The problem seems to be that the destructor is called *after* shogun_exit(). | 16:54 |
| thoralf | Putting a scope around, ending before shogun_exit() solves the problem. | 16:56 |
| thoralf | Obviously we shouldn't call shogun_exit() if we're having automatic (shogun) variables in the same scope. | 16:58 |
| * sonney2k is just doing this https://www.youtube.com/watch?v=mkZp851aOnE#t=201 | 17:00 | |
| thoralf | This video is currently unavailable. | 17:05 |
| thoralf | But the title tells a lot. | 17:05 |
| @sonney2k | thoralf, the simple refactoring shouldn't break anything | 17:13 |
| thoralf | sonney2k: Yes, but the problem existed before. | 17:14 |
| thoralf | calling shogun_exit() in a scope, where variables exist, is problematic: In my case only changing SG_GCDEBUG to SG_SGCDEBUG triggered the problem. | 17:16 |
| @sonney2k | thoralf, yes of course makes sense | 17:22 |
| @sonney2k | everything has to be freed before that | 17:23 |
| -!- zxtx [~zv@ool-2f110054.dyn.optonline.net] has joined #shogun | 17:27 | |
| thoralf | sonney2k: The pull request has been updated. I'm happy to announce: All refcount code from CSGObjects has been put into its new superclass SGRefObject. | 17:35 |
| thoralf | :D | 17:35 |
| @sonney2k | thoralf, errm dont' see the PR! | 17:42 |
| thoralf | It's still this one: https://github.com/shogun-toolbox/shogun/pull/1770 | 17:42 |
| thoralf | push --force | 17:42 |
| thoralf | I did not create a new class DynamicRefObjectArray, btw. | 17:44 |
| @sonney2k | thoralf, ohh please3 a PR with just the SGRefObject no more | 17:46 |
| thoralf | What about the StructuredData stuff? | 17:46 |
| @sonney2k | thoralf, not yet | 17:48 |
| thoralf | I don't understand. | 17:50 |
| -!- thoralf [~thoralf@91-66-33-4-dynip.superkabel.de] has quit [Quit: Konversation terminated!] | 18:19 | |
| @wiking | morning | 18:46 |
| @wiking | lisitsyn: ping | 18:46 |
| -!- sonne|osx [~sonne@f053044029.adsl.alicedsl.de] has joined #shogun | 19:23 | |
| sonne|osx | argh thorsten left | 19:24 |
| sonne|osx | hey wiking | 19:24 |
| lisitsyn | wiking: pong | 19:33 |
| lisitsyn | wiking: what kind of morning it is? :D | 19:34 |
| lisitsyn | are you in the us or what? ;) | 19:34 |
| -!- thoralf [~thoralf@91-66-33-4-dynip.superkabel.de] has joined #shogun | 19:38 | |
| thoralf | Hey. | 19:38 |
| -!- sonne|osx [~sonne@f053044029.adsl.alicedsl.de] has quit [Quit: sonne|osx] | 19:42 | |
| -!- sonne|osx [~sonne@f053044029.adsl.alicedsl.de] has joined #shogun | 20:52 | |
| -!- lisitsyn [~lisitsyn@80.252.20.67] has quit [Ping timeout: 264 seconds] | 20:53 | |
| -!- lisitsyn [~lisitsyn@80.252.20.67] has joined #shogun | 20:54 | |
| sonne|osx | thoralf: what I meant is that we should for now just do the SGRefObject refactoring in one PR not the other stuff you are doing | 21:11 |
| sonne|osx | thoralf: and really minimal please - no other functions like get_name etc - these should really all stay in SGObject | 21:11 |
| sonne|osx | (to the extent possible...) | 21:11 |
| thoralf | sonne|osx: No problem, I'll send another PR. But remember how it started: You said we need this StructuredData refactoring. | 21:14 |
| thoralf | That's why I'm confused. | 21:14 |
| sonne|osx | thoralf: yeah but that was before you realized that you need refcounting | 21:15 |
| thoralf | sonne|osx: Btw. I found method stubs deep_copy() and a shallow_copy() in CSGObject. | 21:20 |
| thoralf | They are not used. | 21:20 |
| thoralf | Remove them? | 21:20 |
| sonne|osx | thoralf: not used at all? then remove them. | 21:21 |
| thoralf | The stubs are SG_NOTIMPLEMENTED, not nowhere overridden. | 21:21 |
| thoralf | https://github.com/shogun-toolbox/shogun/pull/1771 | 21:24 |
| thoralf | SG_SGCDEBUG("unref() refcount %ld obj %s (%p) decreased\n", count, this->get_name(), this) | 21:26 |
| thoralf | sonne|osx: | 21:26 |
| thoralf | get_name() is required in SGRefObject ;) | 21:26 |
| sonne|osx | thoralf: that was only for debugging :/ | 21:43 |
| sonne|osx | but hmmh don't see any better option | 21:43 |
| thoralf | No, I found shallow_copy() implemented in RelaxedTree. | 21:44 |
| thoralf | and GaussianKernel | 21:44 |
| sonne|osx | thoralf: but this can be in CSGObject | 21:46 |
| -!- sonne|osx [~sonne@f053044029.adsl.alicedsl.de] has quit [Quit: sonne|osx] | 22:01 | |
| -!- thoralf [~thoralf@91-66-33-4-dynip.superkabel.de] has quit [Quit: Konversation terminated!] | 23:11 | |
| -!- thoralf [~thoralf@91-66-33-4-dynip.superkabel.de] has joined #shogun | 23:25 | |
| -!- pickle27 [~kevin@24-212-221-132.cable.teksavvy.com] has joined #shogun | 23:39 | |
| -!- pickle27 [~kevin@24-212-221-132.cable.teksavvy.com] has left #shogun [] | 23:39 | |
| --- Log closed Mon Nov 25 00:00:39 2013 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!