| --- Log opened Sat Dec 07 00:00:56 2013 | ||
| -!- new_lido [~walid@41.218.175.183] has quit [Ping timeout: 246 seconds] | 00:45 | |
| -!- new_lido [~walid@41.218.175.164] has joined #shogun | 00:58 | |
| -!- thoralf [~thoralf@91-65-142-97-dynip.superkabel.de] has left #shogun ["Konversation terminated!"] | 01:16 | |
| -!- FSCV [~FSCV@50.7.50.60] has quit [Quit: Leaving] | 01:17 | |
| -!- lisitsyn [~lisitsyn@188-122-234-71.clients.tlt.100megabit.ru] has joined #shogun | 02:17 | |
| -!- lisitsyn [~lisitsyn@188-122-234-71.clients.tlt.100megabit.ru] has quit [Ping timeout: 250 seconds] | 06:53 | |
| -!- new_lido [~walid@41.218.175.164] has quit [Quit: Leaving] | 07:55 | |
| -!- zxtx [~zv@129-79-241-148.dhcp-bl.indiana.edu] has quit [Ping timeout: 265 seconds] | 08:57 | |
| -!- zxtx [~zv@c-98-223-204-102.hsd1.in.comcast.net] has joined #shogun | 10:12 | |
| -!- lisitsyn [~lisitsyn@188-122-234-71.clients.tlt.100megabit.ru] has joined #shogun | 10:54 | |
| -!- iglesiasg [~iglesiasg@211.Red-83-40-129.dynamicIP.rima-tde.net] has joined #shogun | 12:17 | |
| -!- mode/#shogun [+o iglesiasg] by ChanServ | 12:17 | |
| @iglesiasg | sonney2k, hey! | 12:35 |
|---|---|---|
| @iglesiasg | sonney2k, I have seen that the urls for the md files accept e.g. README, README.md, but also pretty much any string after the point like README.aasdf | 12:36 |
| @iglesiasg | can that arise any issue? | 12:36 |
| -!- iglesiasg [~iglesiasg@211.Red-83-40-129.dynamicIP.rima-tde.net] has quit [Quit: Leaving] | 14:43 | |
| -!- shogun-notifier- [~irker@7nn.de] has joined #shogun | 15:18 | |
| shogun-notifier- | shogun: Thoralf Klein :develop * 329778b / src/shogun/ (8 files): https://github.com/shogun-toolbox/shogun/commit/329778b3c7b7afabaf8f14ad24f02c04927d77d3 | 15:18 |
| shogun-notifier- | shogun: Added StructuredModel::structured_labels_factory() to create the right SO labels class. | 15:18 |
| shogun-notifier- | shogun: Thoralf Klein :develop * 66edadb / src/shogun/labels/StructuredLabels.h: https://github.com/shogun-toolbox/shogun/commit/66edadbb7866f383f5ce734bf377bc2ada7b3d0c | 15:18 |
| shogun-notifier- | shogun: Prepared StructuredLabels' methods for overloading. | 15:18 |
| shogun-notifier- | shogun: Thoralf Klein :develop * 5ef2f20 / src/shogun/structure/ (2 files): https://github.com/shogun-toolbox/shogun/commit/5ef2f207e5ddd205982802189d17d9bbad6dfd54 | 15:18 |
| shogun-notifier- | shogun: Overloading add_label, set_label, get_label, get_num_elements in MulticlassSOLabels. | 15:18 |
| shogun-notifier- | shogun: Added own storage object for real labels. | 15:18 |
| shogun-notifier- | shogun: Temporarily disabled ensure_valid calls. | 15:18 |
| shogun-notifier- | shogun: Thoralf Klein :develop * 9761a93 / src/shogun/structure/MulticlassSOLabels.cpp: https://github.com/shogun-toolbox/shogun/commit/9761a9362be7b79a54165150c971ac6e2906ebe5 | 15:18 |
| shogun-notifier- | shogun: Fixed memory leak (forgot freeing of new CRealNumber labels). | 15:18 |
| shogun-notifier- | shogun: Fernando Iglesias :develop * 157bbb2 / src/shogun/ (9 files): https://github.com/shogun-toolbox/shogun/commit/157bbb2395c96305663c7011e56b45dee1ac9666 | 15:18 |
| shogun-notifier- | shogun: Merge pull request #1774 from tklein23/solabels_factory_in_somodel | 15:18 |
| -!- thoralf [~thoralf@91-65-142-97-dynip.superkabel.de] has joined #shogun | 15:20 | |
| thoralf | Hey. | 15:21 |
| thoralf | There are interferences between the unit tests. | 15:24 |
| thoralf | these tests break if running the whole test suite: CSVFileTest.vector_int32, SerializationHDF5.Random, SerializationXML.Random | 15:25 |
| thoralf | But not if you run them with --gtest_filter=CSVFileTest.* | 15:25 |
| thoralf | --gtest_filter=SerializationXML.* | 15:25 |
| thoralf | etc | 15:25 |
| thoralf | unknown file: Failure | 15:29 |
| thoralf | Unknown C++ exception thrown in the test body. | 15:29 |
| shogun-buildbot | build #2521 of deb1 - libshogun is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/deb1%20-%20libshogun/builds/2521 blamelist: Thoralf Klein <thoralf.klein@zib.de> | 15:30 |
| shogun-buildbot | build #2522 of deb1 - libshogun is complete: Success [build successful] Build details are at http://buildbot.shogun-toolbox.org/builders/deb1%20-%20libshogun/builds/2522 | 15:34 |
| shogun-buildbot | build #379 of FC19 - libshogun is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/FC19%20-%20libshogun/builds/379 blamelist: Thoralf Klein <thoralf.klein@zib.de> | 15:48 |
| shogun-buildbot | build #380 of FC19 - libshogun is complete: Success [build successful] Build details are at http://buildbot.shogun-toolbox.org/builders/FC19%20-%20libshogun/builds/380 | 15:53 |
| -!- travis-ci [~travis-ci@ec2-54-204-161-28.compute-1.amazonaws.com] has joined #shogun | 16:06 | |
| travis-ci | [travis-ci] it's Fernando Iglesias's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: http://travis-ci.org/shogun-toolbox/shogun/builds/15087061 | 16:06 |
| -!- travis-ci [~travis-ci@ec2-54-204-161-28.compute-1.amazonaws.com] has left #shogun [] | 16:06 | |
| shogun-buildbot | build #2080 of deb3 - modular_interfaces is complete: Failure [failed test csharp modular] Build details are at http://buildbot.shogun-toolbox.org/builders/deb3%20-%20modular_interfaces/builds/2080 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com>, Thoralf Klein <thoralf.klein@zib.de> | 16:30 |
| -!- thoralf [~thoralf@91-65-142-97-dynip.superkabel.de] has quit [Quit: Konversation terminated!] | 16:56 | |
| -!- thoralf [~thoralf@91-65-142-97-dynip.superkabel.de] has joined #shogun | 17:56 | |
| thoralf | Heyho! | 17:56 |
| thoralf | wiking? I've got work for you. ;) | 17:58 |
| -!- shogun-notifier- [~irker@7nn.de] has quit [Quit: transmission timeout] | 18:18 | |
| @wiking | thoralf: oh i just saw | 19:58 |
| @wiking | replied | 19:59 |
| thoralf | wiking: Sorry, 3.0.0 was not affected. | 20:31 |
| thoralf | Don't know what I was doing in parallel when I wrote this. ;) | 20:32 |
| thoralf | wiking: The last gdb instruction was "next" instead of "step". "new" returned successfully. | 20:55 |
| thoralf | As the gdb output shows. | 20:55 |
| thoralf | Can this statement fail? | 20:56 |
| thoralf | ssize_t actual_read = | 20:57 |
| thoralf | read(fd, reinterpret_cast<char*>(&seed), sizeof(seed)); | 20:57 |
| @wiking | mmm | 20:58 |
| @wiking | the assert should filter out problems | 20:59 |
| @wiking | ASSERT(fd > 0); | 20:59 |
| thoralf | Oh, the assertion failed. | 21:03 |
| thoralf | It's so simple. | 21:03 |
| @wiking | lol | 21:09 |
| @wiking | assertion failed | 21:09 |
| @wiking | ? | 21:09 |
| @wiking | which? :D | 21:09 |
| thoralf | ASSERT(fd > 0); | 21:13 |
| thoralf | errno 34, "Numerical result out of range" | 21:15 |
| @wiking | mmm | 21:22 |
| @wiking | do u actually have /dev/[u]random? | 21:22 |
| @wiking | i suppose so :P | 21:22 |
| @wiking | but that's the error | 21:23 |
| @wiking | for some reason fd <= 0 | 21:23 |
| @wiking | which stands for 'error opening file' | 21:23 |
| thoralf | crw-rw-rw- 1 root root 1, 9 Nov 25 10:11 /dev/urandom | 21:23 |
| thoralf | errno is 34 | 21:23 |
| @wiking | hehehe | 21:23 |
| thoralf | "Numerical result out of range" | 21:23 |
| @wiking | wtf? :) | 21:24 |
| thoralf | It's only three tests - other tests are running well. | 21:24 |
| thoralf | Isolated test execution works well, too. | 21:24 |
| thoralf | Hmm. Seems that open() does not set errno. | 21:25 |
| thoralf | So 34 is wrong. | 21:25 |
| @wiking | #define ERANGE 34 /* Result too large (possibly too small) */ | 21:26 |
| @wiking | yeah as that really doesn't make too much sense :P | 21:27 |
| @wiking | If successful, open() returns a non-negative integer, termed a file | 21:27 |
| @wiking | descriptor. It returns -1 on failure, and sets errno to indicate the | 21:27 |
| @wiking | error. | 21:27 |
| thoralf | I'm just getting paranoid. | 21:27 |
| thoralf | Maybe fd=0 is a valid descriptor? | 21:27 |
| thoralf | You're checking for fd>0. | 21:28 |
| @wiking | 0 is stdin | 21:28 |
| @wiking | so actually it should be | 21:28 |
| @wiking | fd >= 2 | 21:28 |
| @wiking | or fd 1 | 21:28 |
| @wiking | no fd > 2 | 21:28 |
| @wiking | can u try maybe fd >= 0 | 21:29 |
| thoralf | I'm just recompiling. ;) | 21:29 |
| @wiking | since maaaaaybe somebody closes stdin/stdout/stderr | 21:29 |
| @wiking | and then u can get fd = 0 | 21:29 |
| @wiking | but i can hardly believe that there's 0 fd open on the whole system :) | 21:29 |
| thoralf | When errno is not set, then there was not error. But fd>0 fails... so fd=0 might be okay. | 21:30 |
| @wiking | that's usually stdin | 21:30 |
| @wiking | so that would be reeeeallly strange that u get 0 | 21:30 |
| thoralf | HAHA. | 21:31 |
| thoralf | Works well. | 21:31 |
| thoralf | open(/dev/urandom) returned 0 | 21:32 |
| @wiking | lol | 21:33 |
| thoralf | The error seems trivial... but so many epic fails while debugging. ;) | 21:34 |
| thoralf | But as the "man 2 open" tells that only -1 is an error, we should remember to always ASSERT(fd >= 0) | 21:35 |
| thoralf | wiking: Could you fix it please? It's not critical to me, so take your time... but I guess you did this assertion in many places? | 21:36 |
| thoralf | wiking: Ah! fopen returns a pointer, so fd==NULL is a valid check. While open returns an integer, so 0 is valid as well. | 21:46 |
| -!- sonne|osx [~sonne@e179141158.adsl.alicedsl.de] has joined #shogun | 21:47 | |
| thoralf | Hey sonne|osx | 21:48 |
| sonne|osx | thoralf: hey there | 21:49 |
| thoralf | wiking: I checked all other uses of open(), but they all check for -1 or <0. Only CRandom is wrong. | 21:52 |
| sonne|osx | thoralf: so who is fixing it now? | 22:23 |
| thoralf | sonne|osx: I just sent a PR. | 22:24 |
| thoralf | https://github.com/shogun-toolbox/shogun/pull/1782 | 22:24 |
| sonne|osx | thoralf: kthx | 22:25 |
| sonne|osx | merged | 22:25 |
| -!- shogun-notifier- [~irker@7nn.de] has joined #shogun | 22:25 | |
| shogun-notifier- | shogun: Thoralf Klein :develop * 96654e6 / src/shogun/mathematics/Random.cpp: https://github.com/shogun-toolbox/shogun/commit/96654e62253aa92ee9258d83e6a3861b59b8dad5 | 22:25 |
| shogun-notifier- | shogun: Fix assertion - open() can return "0", which is a valid file descriptor. | 22:25 |
| shogun-notifier- | shogun: Soeren Sonnenburg :develop * e276096 / src/shogun/mathematics/Random.cpp: https://github.com/shogun-toolbox/shogun/commit/e276096b2fab2711d39b36b65a038237866d8418 | 22:25 |
| shogun-notifier- | shogun: Merge pull request #1782 from tklein23/develop | 22:25 |
| shogun-notifier- | shogun: | 22:25 |
| shogun-notifier- | shogun: Fix assertion - open() can return "0", which is a valid file descriptor. | 22:25 |
| shogun-buildbot | build #329 of osx1 - libshogun is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/osx1%20-%20libshogun/builds/329 blamelist: Thoralf Klein <thoralf.klein@zib.de> | 22:35 |
| shogun-buildbot | build #330 of osx1 - libshogun is complete: Success [build successful] Build details are at http://buildbot.shogun-toolbox.org/builders/osx1%20-%20libshogun/builds/330 | 22:42 |
| shogun-buildbot | build #2081 of deb3 - modular_interfaces is complete: Failure [failed test csharp modular] Build details are at http://buildbot.shogun-toolbox.org/builders/deb3%20-%20modular_interfaces/builds/2081 blamelist: Thoralf Klein <thoralf.klein@zib.de> | 23:04 |
| -!- travis-ci [~travis-ci@ec2-54-204-161-28.compute-1.amazonaws.com] has joined #shogun | 23:22 | |
| travis-ci | [travis-ci] it's Soeren Sonnenburg's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: http://travis-ci.org/shogun-toolbox/shogun/builds/15100276 | 23:22 |
| -!- travis-ci [~travis-ci@ec2-54-204-161-28.compute-1.amazonaws.com] has left #shogun [] | 23:22 | |
| -!- lisitsyn [~lisitsyn@188-122-234-71.clients.tlt.100megabit.ru] has quit [Ping timeout: 246 seconds] | 23:27 | |
| shogun-buildbot | build #2082 of deb3 - modular_interfaces is complete: Failure [failed test csharp modular] Build details are at http://buildbot.shogun-toolbox.org/builders/deb3%20-%20modular_interfaces/builds/2082 blamelist: Soeren Sonnenburg <sonne@debian.org> | 23:29 |
| --- Log closed Sun Dec 08 00:00:57 2013 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!