| --- Log opened Fri Jan 03 00:00:35 2014 | ||
| @iglesiasg | sonney2k, yep, in case you use apply_structured that is true | 00:00 |
|---|---|---|
| @sonney2k | iglesiasg, even with apply() ! | 00:01 |
| @sonney2k | iglesiasg, try it | 00:01 |
| @iglesiasg | oh really!? let mesee | 00:01 |
| @iglesiasg | sonney2k, true, indeed | 00:02 |
| @iglesiasg | sonney2k, well, the fix here then is not to use to_structured I guess | 00:02 |
| @iglesiasg | sonney2k, where is that handled though? | 00:02 |
| @iglesiasg | sonney2k, that the return value is casted to structured labels | 00:03 |
| @iglesiasg | sonney2k, SWIG code? | 00:03 |
| @sonney2k | iglesiasg, in Machine.i - yes swig code | 00:03 |
| @sonney2k | pretty cool uh? | 00:04 |
| @iglesiasg | sonney2k, yep | 00:04 |
| @iglesiasg | haha yeah | 00:04 |
| @sonney2k | iglesiasg, so please commit the fix that doesn't use this conversion | 00:04 |
| @sonney2k | I will nevertheless | 00:04 |
| @sonney2k | add %newobject to all methods in CLabelsFactory | 00:04 |
| @iglesiasg | why so? | 00:04 |
| @iglesiasg | sonney2k, don't we get a leak then? | 00:05 |
| @sonney2k | no | 00:07 |
| @sonney2k | it will return the object but ref'd | 00:07 |
| @sonney2k | so if the refcount was 0 before it will be 1 now | 00:08 |
| @iglesiasg | sonney2k, but that is right when doing to_structured(apply()) | 00:09 |
| @iglesiasg | what if doing? | 00:09 |
| @iglesiasg | var = apply() | 00:09 |
| @sonney2k | also then | 00:09 |
| @iglesiasg | to_structured(var) | 00:09 |
| @sonney2k | var.ref_count() should be 1 right? | 00:09 |
| @sonney2k | and then | 00:09 |
| @sonney2k | var2= to_structured(var) | 00:09 |
| @sonney2k | var2's refcount should be 2 | 00:09 |
| @sonney2k | because you have 2 references | 00:09 |
| @iglesiasg | yep, right | 00:10 |
| @iglesiasg | out of curiosity | 00:10 |
| @iglesiasg | var = to_structured(var) | 00:10 |
| @iglesiasg | what would it happen there? mmm | 00:10 |
| @sonney2k | var would just be converted to type CStructuredLabels | 00:11 |
| @sonney2k | and refcount would be 1 | 00:11 |
| @iglesiasg | about var2's refcount being 2, and var's refcount 1 in the setting before | 00:12 |
| @sonney2k | iglesiasg, but now you know why we always do SG_REF when returning some object (except for new ones...) | 00:12 |
| -!- shogun-notifier- [~irker@7nn.de] has joined #shogun | 00:15 | |
| shogun-notifier- | shogun: Fernando Iglesias :develop * 991e3cd / doc/ipython-notebooks/structure/FGM.ipynb: https://github.com/shogun-toolbox/shogun/commit/991e3cdd904a99776518ac7e711a5849bf26da49 | 00:15 |
| shogun-notifier- | shogun: Fix FGM notebook | 00:15 |
| shogun-notifier- | shogun: Do not use LabelsFactory in Python for apply's output, the cast is already | 00:15 |
| shogun-notifier- | shogun: handled by SWIG code in Machine.i | 00:15 |
| shogun-notifier- | shogun: Fernando Iglesias :develop * 2451111 / doc/ipython-notebooks/structure/FGM.ipynb: https://github.com/shogun-toolbox/shogun/commit/2451111d21c830053d23f91b86a3064820d4625d | 00:15 |
| shogun-notifier- | shogun: Merge pull request #1806 from iglesias/develop | 00:15 |
| shogun-notifier- | shogun: | 00:15 |
| shogun-notifier- | shogun: Fix FGM notebook | 00:15 |
| shogun-notifier- | shogun: Soeren Sonnenburg :develop * 39842ca / src/interfaces/modular/Features.i: https://github.com/shogun-toolbox/shogun/commit/39842ca8fb6aae4e9619c9dd10a809f62fccd69c | 00:20 |
| shogun-notifier- | shogun: use %newobject on label factory functions to fix premature memory freeing | 00:20 |
| @sonney2k | iglesiasg, alright nice teamwork nailing this down :D | 00:20 |
| @iglesiasg | sonney2k, well it feels I didn't actually help much :D | 00:21 |
| @sonney2k | iglesiasg, if you have time - scan the code for similar scary patterns... | 00:21 |
| @sonney2k | iglesiasg, finding the exact line is half of the work! | 00:21 |
| @iglesiasg | sonney2k, I just see one to_* in python_modular examples | 00:22 |
| @iglesiasg | in one factor graph example from Shell too | 00:23 |
| @iglesiasg | this is done in two steps so the crash did not pop up | 00:23 |
| @iglesiasg | but I guess it is nicer without the cast so I will take it out | 00:23 |
| @sonney2k | iglesiasg, yes | 00:23 |
| @sonney2k | iglesiasg, but there might be more in the C++ code ... functions that take some object as input and return it without the ref increased or functions returning object w/o increasing the refcount | 00:24 |
| @sonney2k | that is more subtle to find... so in case you have time have a look | 00:25 |
| @iglesiasg | sonney2k, I am not sure why the first case should increase the ref count though :S | 00:25 |
| @sonney2k | iglesiasg, and please update the NEWS about this bug | 00:26 |
| @sonney2k | so we are now in release shape | 00:26 |
| @iglesiasg | sonney2k, I mean, a function takes an object in the input, why should it do SG_REF of this? | 00:26 |
| @sonney2k | iglesiasg, it should not only if it returns it and then only in the modular interfaces | 00:26 |
| @iglesiasg | okok | 00:27 |
| @iglesiasg | so | 00:27 |
| @sonney2k | I am overdue with going to bed so be quick | 00:27 |
| @iglesiasg | p* f(p*) | 00:27 |
| @iglesiasg | should use this %newobject thing | 00:27 |
| @iglesiasg | that's it | 00:27 |
| shogun-notifier- | shogun: Fernando Iglesias :develop * 3038519 / examples/undocumented/python_modular/structure_factor_graph_model.py: https://github.com/shogun-toolbox/shogun/commit/30385190862550f63beffe69bc79e0b2b2da7614 | 00:31 |
| shogun-notifier- | shogun: Remove LabelsFactory.to_structured in python modular example | 00:31 |
| shogun-notifier- | shogun: NO need to use this method to do the cast since it is already handled | 00:31 |
| shogun-notifier- | shogun: in Machine.i | 00:31 |
| shogun-notifier- | shogun: Fernando Iglesias :develop * a22dd82 / examples/undocumented/python_modular/structure_factor_graph_model.py: https://github.com/shogun-toolbox/shogun/commit/a22dd82bf954a7acb3dc7c244694956ff7ef33a2 | 00:31 |
| shogun-notifier- | shogun: Merge pull request #1807 from iglesias/develop | 00:31 |
| shogun-notifier- | shogun: | 00:31 |
| shogun-notifier- | shogun: Remove LabelsFactory.to_structured in python modular example | 00:31 |
| shogun-buildbot | build #424 of FC19 - libshogun is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/FC19%20-%20libshogun/builds/424 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 00:32 |
| @sonney2k | iglesiasg, yes and also things doing | 00:32 |
| @sonney2k | p* f() | 00:32 |
| @sonney2k | returning a new object | 00:32 |
| @iglesiasg | unit-SGVectorTest failed?! | 00:33 |
| @sonney2k | and the others that return a reference should do SG_REF() | 00:33 |
| @iglesiasg | we lost Fedora :D | 00:33 |
| @sonney2k | iglesiasg, some numerical thing only though | 00:33 |
| shogun-buildbot | build #425 of FC19 - libshogun is complete: Success [build successful] Build details are at http://buildbot.shogun-toolbox.org/builders/FC19%20-%20libshogun/builds/425 | 00:36 |
| @sonney2k | iglesiasg, btw did you get my email about this? I am just wondering... | 00:36 |
| @iglesiasg | sonney2k, about the buildbot fail? No, I didn't | 00:37 |
| @sonney2k | iglesiasg, no the reply to your mail today | 00:38 |
| @iglesiasg | sonney2k, got it today about three hours ago | 00:40 |
| @iglesiasg | 2 hours actually, 21:55, just checked it | 00:40 |
| @iglesiasg | sonney2k, why do you wonder about it? Did you send it before that today? | 00:40 |
| @iglesiasg | sonney2k, just added a line in NEWS https://github.com/shogun-toolbox/shogun/pull/1808/files | 00:43 |
| @iglesiasg | just merge it please if that's how you wanted it | 00:43 |
| @sonney2k | iglesiasg, I had some issue recently so I was just wondering | 00:44 |
| * iglesiasg afk | 00:49 | |
| * iglesiasg back | 01:04 | |
| shogun-buildbot | build #162 of clang34 - undefined behaviour analysis is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20undefined%20behaviour%20analysis/builds/162 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 01:20 |
| -!- iglesiasg [~iglesiasg@211.Red-83-40-129.dynamicIP.rima-tde.net] has quit [Quit: Leaving] | 01:32 | |
| shogun-buildbot | build #158 of clang34 - thread analysis is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20thread%20analysis/builds/158 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 01:36 |
| -!- travis-ci [~travis-ci@ec2-54-211-35-213.compute-1.amazonaws.com] has joined #shogun | 01:38 | |
| travis-ci | [travis-ci] it's Fernando Iglesias's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: http://travis-ci.org/shogun-toolbox/shogun/builds/16287958 | 01:38 |
| -!- travis-ci [~travis-ci@ec2-54-211-35-213.compute-1.amazonaws.com] has left #shogun [] | 01:38 | |
| shogun-buildbot | build #173 of clang34 - static analysis is complete: Failure [failed analyse] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20static%20analysis/builds/173 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 02:21 |
| shogun-buildbot | build #163 of clang34 - undefined behaviour analysis is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20undefined%20behaviour%20analysis/builds/163 blamelist: Soeren Sonnenburg <sonne@debian.org> | 02:34 |
| shogun-buildbot | build #159 of clang34 - thread analysis is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20thread%20analysis/builds/159 blamelist: Soeren Sonnenburg <sonne@debian.org> | 02:51 |
| -!- shogun-notifier- [~irker@7nn.de] has quit [Quit: transmission timeout] | 03:31 | |
| shogun-buildbot | build #174 of clang34 - static analysis is complete: Failure [failed analyse] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20static%20analysis/builds/174 blamelist: Soeren Sonnenburg <sonne@debian.org> | 03:34 |
| -!- travis-ci [~travis-ci@ec2-54-227-186-41.compute-1.amazonaws.com] has joined #shogun | 03:40 | |
| travis-ci | [travis-ci] it's Fernando Iglesias's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: http://travis-ci.org/shogun-toolbox/shogun/builds/16288893 | 03:40 |
| -!- travis-ci [~travis-ci@ec2-54-227-186-41.compute-1.amazonaws.com] has left #shogun [] | 03:40 | |
| shogun-buildbot | build #164 of clang34 - undefined behaviour analysis is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20undefined%20behaviour%20analysis/builds/164 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 03:45 |
| shogun-buildbot | build #160 of clang34 - thread analysis is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20thread%20analysis/builds/160 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 04:02 |
| shogun-buildbot | build #669 of nightly_default is complete: Success [build successful] Build details are at http://buildbot.shogun-toolbox.org/builders/nightly_default/builds/669 | 04:41 |
| shogun-buildbot | build #175 of clang34 - static analysis is complete: Failure [failed analyse] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20static%20analysis/builds/175 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 04:44 |
| -!- lambday [67157f36@gateway/web/freenode/ip.103.21.127.54] has joined #shogun | 06:27 | |
| -!- wiking [~wiking@huwico/staff/wiking] has quit [Ping timeout: 245 seconds] | 06:31 | |
| -!- wiking [~wiking@info2k1.hu] has joined #shogun | 06:32 | |
| -!- lambday [67157f36@gateway/web/freenode/ip.103.21.127.54] has quit [Ping timeout: 272 seconds] | 07:53 | |
| -!- wiking [~wiking@info2k1.hu] has quit [Changing host] | 08:06 | |
| -!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 08:06 | |
| -!- mode/#shogun [+o wiking] by ChanServ | 08:07 | |
| sonne|work | heya all good morning! | 08:53 |
| sonne|work | wiking, besser82 ^ | 08:54 |
| -!- shogun-notifier- [~irker@7nn.de] has joined #shogun | 10:07 | |
| shogun-notifier- | shogun: Fernando Iglesias :develop * 7dccde8 / NEWS: https://github.com/shogun-toolbox/shogun/commit/7dccde870407ccf04be17b61f588d7e6ea78c691 | 10:07 |
| shogun-notifier- | shogun: Update bugfix NEWS for latest release | 10:07 |
| shogun-notifier- | shogun: Fernando Iglesias :develop * 609dcad / NEWS: https://github.com/shogun-toolbox/shogun/commit/609dcad8bd098bdb63c2449ac70d01521671f63c | 10:07 |
| shogun-notifier- | shogun: Merge pull request #1808 from iglesias/develop | 10:07 |
| shogun-notifier- | shogun: | 10:07 |
| shogun-notifier- | shogun: Update bugfix NEWS for latest release | 10:07 |
| besser82 | sonne|work, wiking, lisitsyn: G' Morning!!! | 10:36 |
| @wiking | mornin | 10:44 |
| shogun-buildbot | build #165 of clang34 - undefined behaviour analysis is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20undefined%20behaviour%20analysis/builds/165 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 11:12 |
| shogun-buildbot | build #161 of clang34 - thread analysis is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20thread%20analysis/builds/161 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 11:29 |
| shogun-buildbot | build #176 of clang34 - static analysis is complete: Failure [failed analyse] Build details are at http://buildbot.shogun-toolbox.org/builders/clang34%20-%20static%20analysis/builds/176 blamelist: Fernando Iglesias <fernando.iglesiasg@gmail.com> | 12:12 |
| -!- new_lido [~walid@41.218.176.150] has joined #shogun | 12:32 | |
| -!- new_lido [~walid@41.218.176.150] has quit [Ping timeout: 246 seconds] | 12:46 | |
| -!- iglesiasg [~fircuser@213.143.60.190] has joined #shogun | 12:47 | |
| iglesiasg | sonne|work: hey | 12:50 |
| iglesiasg | maybe you remember I asked you a few days past about using Baum-Welch with real valued features | 12:51 |
| iglesiasg | I am not sure if that is currently possible sonce I just saw StringFeatures there | 12:52 |
| iglesiasg | err, StringFeatures<uint16_t> actually | 13:03 |
| -!- shogun-notifier- [~irker@7nn.de] has quit [Quit: transmission timeout] | 13:07 | |
| -!- iglesiasg [~fircuser@213.143.60.190] has quit [Read error: Connection reset by peer] | 13:10 | |
| sonne|work | iglesias - yes I remember - unfortunately not yet in shogun - I can mentor you though how to do it... | 13:53 |
| -!- iglesiasg [~iglesiasg@211.Red-83-40-129.dynamicIP.rima-tde.net] has joined #shogun | 14:06 | |
| -!- mode/#shogun [+o iglesiasg] by ChanServ | 14:06 | |
| @iglesiasg | sonne|work, I need a couple of extensions to that | 14:07 |
| @iglesiasg | sonne|work, handle real values as well as vector observations | 14:07 |
| @iglesiasg | I have some Matlab code that is able to handle that, so I think I will try first with it | 14:08 |
| -!- iglesiasg [~iglesiasg@211.Red-83-40-129.dynamicIP.rima-tde.net] has quit [Ping timeout: 264 seconds] | 14:21 | |
| -!- iglesiasg [~iglesiasg@211.Red-83-40-129.dynamicIP.rima-tde.net] has joined #shogun | 14:23 | |
| -!- mode/#shogun [+o iglesiasg] by ChanServ | 14:23 | |
| sonne|work | iglesiasg: yeah sure - you would need to write a new HMM class for that if you would want to do that in shogun... | 15:00 |
| -!- lambday [67157f36@gateway/web/freenode/ip.103.21.127.54] has joined #shogun | 15:14 | |
| -!- besser82 [quassel@fedora/besser82] has quit [Remote host closed the connection] | 15:21 | |
| -!- besser82 [quassel@fedora/besser82] has joined #shogun | 15:40 | |
| -!- zxtx_ [~zv@c-98-223-196-32.hsd1.in.comcast.net] has quit [Ping timeout: 264 seconds] | 16:00 | |
| -!- zxtx_ [~zv@129-79-241-148.dhcp-bl.indiana.edu] has joined #shogun | 16:51 | |
| -!- pickle27 [d8bfe7da@gateway/web/freenode/ip.216.191.231.218] has joined #shogun | 17:34 | |
| pickle27 | sonney2k: what irc client do you use on osx? | 17:35 |
| -!- iglesiasg [~iglesiasg@211.Red-83-40-129.dynamicIP.rima-tde.net] has quit [Quit: Leaving] | 17:36 | |
| -!- bb_ [458fc8de@gateway/web/freenode/ip.69.143.200.222] has joined #shogun | 17:43 | |
| @wiking | pickle27: colloquy is quite ok | 17:51 |
| pickle27 | @wiking, alight I saw that one | 17:52 |
| pickle27 | osx has too many choices but I find it harder to make up my mind compared to linux | 17:52 |
| pickle27 | anyways figure I should get irc on my work machine so I can at least idle in here even though I don't have much time to do any development atm | 17:53 |
| @wiking | pickle27: no worries most of us is busy as well with other stuff but still we idle here :P | 18:13 |
| @sonney2k | wiking, pickle27 but we will do a rlease this weekend :) | 18:48 |
| * sonney2k afk | 18:48 | |
| pickle27 | awesome! | 18:48 |
| lisitsyn | sonney2k: okay I am speeding up to get notebook ready before release ;) | 18:50 |
| -!- bb_ [458fc8de@gateway/web/freenode/ip.69.143.200.222] has quit [Ping timeout: 272 seconds] | 19:39 | |
| -!- bb_ [458fc8de@gateway/web/freenode/ip.69.143.200.222] has joined #shogun | 20:05 | |
| -!- travis-ci [~travis-ci@ec2-54-205-49-151.compute-1.amazonaws.com] has joined #shogun | 20:39 | |
| travis-ci | [travis-ci] it's Fernando Iglesias's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: http://travis-ci.org/shogun-toolbox/shogun/builds/16305671 | 20:39 |
| -!- travis-ci [~travis-ci@ec2-54-205-49-151.compute-1.amazonaws.com] has left #shogun [] | 20:39 | |
| -!- pickle27 [d8bfe7da@gateway/web/freenode/ip.216.191.231.218] has quit [Ping timeout: 272 seconds] | 20:40 | |
| @wiking | sonney2k: great! :) | 21:56 |
| @wiking | besser82: ping | 21:57 |
| bb_ | quit | 22:30 |
| -!- bb_ [458fc8de@gateway/web/freenode/ip.69.143.200.222] has quit [] | 22:30 | |
| -!- lambday [67157f36@gateway/web/freenode/ip.103.21.127.54] has quit [Ping timeout: 272 seconds] | 22:35 | |
| -!- wiking_ [~wiking@info2k1.hu] has joined #shogun | 22:57 | |
| -!- wiking [~wiking@huwico/staff/wiking] has quit [Read error: Connection reset by peer] | 22:57 | |
| -!- wiking_ is now known as wiking | 23:07 | |
| -!- wiking [~wiking@info2k1.hu] has quit [Changing host] | 23:07 | |
| -!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 23:07 | |
| -!- mode/#shogun [+o wiking] by ChanServ | 23:07 | |
| besser82 | wiking: pong | 23:55 |
| --- Log closed Sat Jan 04 00:00:36 2014 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!