| --- Log opened Sat Apr 26 00:00:22 2014 | ||
| -!- khalednasr [~k.nasr92@41.69.161.127] has quit [Ping timeout: 265 seconds] | 00:04 | |
| -!- HeikoS [~heiko@85-220-3-15.dsl.dynamic.simnet.is] has joined #shogun | 01:47 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 01:47 | |
| -!- HeikoS [~heiko@85-220-3-15.dsl.dynamic.simnet.is] has quit [Quit: Leaving.] | 02:01 | |
| -!- soumyaC [uid15286@gateway/web/irccloud.com/x-elyfhdzmbepbvhul] has quit [Quit: Connection closed for inactivity] | 03:46 | |
| -!- PirosB3 [~pirosb3@cpc4-newt31-2-0-cust631.newt.cable.virginm.net] has joined #shogun | 04:10 | |
| -!- PirosB3 [~pirosb3@cpc4-newt31-2-0-cust631.newt.cable.virginm.net] has quit [Quit: PirosB3] | 04:42 | |
| -!- kislay [~Abhijeet@14.139.41.150] has joined #shogun | 08:56 | |
| -!- kislay [~Abhijeet@14.139.41.150] has quit [Read error: Connection reset by peer] | 09:00 | |
| -!- kislay [~Abhijeet@117.239.94.112] has joined #shogun | 09:46 | |
| -!- kislay [~Abhijeet@117.239.94.112] has quit [Ping timeout: 252 seconds] | 10:04 | |
| -!- kislay [~Abhijeet@117.239.94.112] has joined #shogun | 10:04 | |
| -!- khalednasr [~k.nasr92@41.69.130.181] has joined #shogun | 10:58 | |
| -!- khalednasr [~k.nasr92@41.69.130.181] has quit [Client Quit] | 11:01 | |
| -!- kislay [~Abhijeet@117.239.94.112] has quit [Ping timeout: 252 seconds] | 11:38 | |
| -!- kislay [~Abhijeet@117.239.94.112] has joined #shogun | 11:57 | |
| -!- kislay [~Abhijeet@117.239.94.112] has quit [Ping timeout: 240 seconds] | 12:16 | |
| -!- kislay [~Abhijeet@220.227.97.99] has joined #shogun | 12:17 | |
| -!- PirosB3 [~pirosb3@cpc4-newt31-2-0-cust631.newt.cable.virginm.net] has joined #shogun | 13:31 | |
| -!- kislay [~Abhijeet@220.227.97.99] has quit [Quit: Leaving] | 13:34 | |
| -!- lambday [67157f4f@gateway/web/freenode/ip.103.21.127.79] has joined #shogun | 13:39 | |
| -!- lambday [67157f4f@gateway/web/freenode/ip.103.21.127.79] has quit [Quit: Page closed] | 14:31 | |
| -!- thor|alf [~thoralf@91-65-140-50-dynip.superkabel.de] has joined #shogun | 14:46 | |
| thor|alf | Heyho. | 14:46 |
|---|---|---|
| thor|alf | lisitsyn: Ping? | 14:46 |
| thor|alf | lisitsyn: I don't understand your last comment to https://github.com/shogun-toolbox/shogun/issues/2185 | 14:47 |
| lisitsyn | thor|alf: | 14:57 |
| -!- PirosB3 [~pirosb3@cpc4-newt31-2-0-cust631.newt.cable.virginm.net] has quit [Quit: PirosB3] | 14:57 | |
| lisitsyn | well I mean if you want to restrict copies | 14:57 |
| lisitsyn | you do it this way | 14:57 |
| lisitsyn | = delete | 14:57 |
| lisitsyn | so that it is explicitly deleted | 14:58 |
| thor|alf | I feel totally lost. Do you mean adding a " = delete" to the header like " = 0" sometimes? | 14:58 |
| lisitsyn | thor|alf: exactly | 14:59 |
| lisitsyn | this means you won't provide implementation of this method anywhere | 14:59 |
| lisitsyn | thor|alf: when it is used you will be errored with quite meaningful message that the constructor you use is explicitly deleted | 15:00 |
| lisitsyn | instead of 'undefined reference to ...' | 15:00 |
| thor|alf | Ah, cool! | 15:00 |
| thor|alf | Now I understand. | 15:00 |
| thor|alf | Deleting the implementation, but keeping (a modified) declaration. | 15:01 |
| thor|alf | Is it part of the c++ standard or something gcc-ish or GNU-ish? | 15:02 |
| thor|alf | Never seen this. | 15:02 |
| thor|alf | stackoverflow.com/questions/5513881/c-meaning-of-delete-after-function-declaration | 15:03 |
| thor|alf | C++11 | 15:03 |
| thor|alf | Is declaring "delete" for operator= needed as well? Wouldn't it mean that we cannot copy using "=" any more? | 15:06 |
| thor|alf | I only want to restrict new CSGObject(*other_object), but not "CSGObject foo = other_object;". | 15:07 |
| thor|alf | lisitsyn: Or are they tied in a way I don't see yet? | 15:08 |
| lisitsyn | thor|alf: sorry was afk | 15:11 |
| lisitsyn | thor|alf: yeah it is C++11 | 15:12 |
| lisitsyn | well operator= is quite similar | 15:12 |
| thor|alf | Do you mean "=" has got the same bug? | 15:12 |
| lisitsyn | thor|alf: no not really | 15:12 |
| lisitsyn | thor|alf: I mean usually they come along | 15:12 |
| lisitsyn | thor|alf: so e.g. if you don't allow copying you usually don't allow assignment as well | 15:13 |
| thor|alf | Okay, but if I forbit assignment, this will break shogun. | 15:13 |
| thor|alf | We will force everybody to use only references, because "normal" instances cannot be assigned any more. | 15:14 |
| lisitsyn | thor|alf: yeah | 15:15 |
| lisitsyn | thor|alf: then it is not the case :) | 15:15 |
| lisitsyn | thor|alf: though it looks pretty ok to use only references | 15:25 |
| -!- lisitsyn1 [~qdrgsm@109-226-124-25.clients.tlt.100megabit.ru] has joined #shogun | 15:26 | |
| -!- lisitsyn [~qdrgsm@109-226-124-25.clients.tlt.100megabit.ru] has quit [Ping timeout: 240 seconds] | 15:29 | |
| thor|alf | lisitsyn1: I'll check what happens. Thanks for pointing this out | 15:31 |
| -!- soumyaC [uid15286@gateway/web/irccloud.com/x-hxhehllyggnkhmzh] has joined #shogun | 16:02 | |
| -!- lambday [67157f4f@gateway/web/freenode/ip.103.21.127.79] has joined #shogun | 17:02 | |
| lisitsyn1 | thor|alf: http://www.flightradar24.com/RSD47/3327545 :D | 17:26 |
| thor|alf | lol | 17:26 |
| lisitsyn1 | thor|alf: the boss is out of house | 17:26 |
| lisitsyn1 | thor|alf: we need more security facing the threats of space invaders :D | 17:27 |
| lisitsyn1 | that's actually putiphone | 17:27 |
| thor|alf | :D | 17:30 |
| thor|alf | Still looping. | 17:30 |
| lambday | thor|alf: could you please stop my travis build? | 17:32 |
| lambday | thor|alf: silly overlooking :( | 17:32 |
| thor|alf | lol | 17:33 |
| thor|alf | I can't. | 17:33 |
| lambday | errr | 17:33 |
| thor|alf | lambday: It's only you and me. | 17:40 |
| thor|alf | I just decided to do my laundry while waiting for Travis, so really no worries. | 17:41 |
| thor|alf | :D | 17:41 |
| lambday | thor|alf: both on travis and on this chatroom? :P | 17:41 |
| thor|alf | lambday: Hmm. Let me check. | 17:41 |
| thor|alf | lisitsyn1: You're listening or not? | 17:41 |
| lambday | he's out! | 17:42 |
| lisitsyn1 | thor|alf: hmm not really :) | 17:42 |
| lambday | oh he's in! :D | 17:42 |
| thor|alf | Haha. :D | 17:42 |
| lisitsyn1 | highlight me | 17:42 |
| lisitsyn1 | if I am not here after highlight then I am out :) | 17:42 |
| lambday | lisitsyn1: how? <i>lisitsyn1</i> | 17:42 |
| lambday | or you prefer to be bold? | 17:42 |
| lisitsyn1 | lambday: nickname ;) | 17:43 |
| -!- lisitsyn1 is now known as lisitsyn | 17:43 | |
| lisitsyn | I am already bold and I don't like it :D | 17:43 |
| lambday | lol | 17:43 |
| lambday | lisitsyn: run forest run | 17:43 |
| lisitsyn | thor|alf: so what's up? | 17:43 |
| thor|alf | lisitsyn: Nothing. lambday asked if we're alone in the channel or not... | 17:44 |
| lisitsyn | ah | 17:44 |
| thor|alf | :) | 17:44 |
| lambday | iirc last year this time we were pouring words like rain in this chatroom | 17:45 |
| thor|alf | lisitsyn: Sorry for waking you up, but I thought you're always happy to chat. | 17:45 |
| lisitsyn | thor|alf: sure ;) | 17:45 |
| thor|alf | (Disclaimer: Unable to smalltalk about music. ;)) | 17:45 |
| lisitsyn | that's pretty clear ;) | 17:46 |
| lambday | thor|alf: ah finally that errorneus build finished! now I can die in peace! | 17:46 |
| thor|alf | :) | 17:49 |
| -!- HeikoS [~heiko@130.208.244.119] has joined #shogun | 17:56 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 17:56 | |
| lambday | HeikoS: hey! | 18:00 |
| @HeikoS | lambday: hey! | 18:00 |
| @HeikoS | how are things? | 18:00 |
| lambday | HeikoS: good. sent the symmetry related patch first | 18:01 |
| lambday | HeikoS: modified QuadraticTimeMMD - but not fully finished | 18:01 |
| lambday | thinking of having a setter for depricated implementation and new implementation | 18:02 |
| @HeikoS | lambday: what about just having various different enums for the null approximation? | 18:02 |
| lambday | HeikoS: how's Iceland? | 18:02 |
| @HeikoS | lambday: quite cool, climbed a mountain yesterday | 18:02 |
| lambday | HeikoS: ah nice! :D | 18:03 |
| @HeikoS | with snow and stuff, really cool | 18:03 |
| lambday | HeikoS: yeah enums would be there | 18:03 |
| @HeikoS | lambday: then no need to change htings, just add some new private methods | 18:03 |
| lambday | HeikoS: no I mean, the statistic returned is also different - so its not just MMD2_SPECTRUM/MMD2_SPECTRUM_DEPRECATED but we should have deprecated methods as well | 18:04 |
| lambday | because compute_biased_statistic/compute_unbiased_statistic would return different values | 18:05 |
| @HeikoS | but thats also possible wiht enums right? | 18:05 |
| @HeikoS | lambday: in fact the deprecated impl should not be exposed to bright | 18:05 |
| @HeikoS | should not be used | 18:05 |
| @HeikoS | so only need constructor for other one | 18:05 |
| @HeikoS | and then have some setter to change enum internally (well documented etc) | 18:05 |
| lambday | HeikoS: I am not fully getting how this would work - I mean, for setting null_approximation methods we can use the enums | 18:07 |
| @HeikoS | there already is the MMD_biased and unbiased, cant we just extend that? | 18:07 |
| lambday | but those would internally use compute_statistic methods which would be having two different impl.... one for new one that returns mn/(m+n)*MMD^2 and previous ones which returned (m+n)*MMD^2 | 18:08 |
| lambday | HeikoS: umm yeah - then we'd have to set quite a lot of enums | 18:08 |
| @HeikoS | lambday: ok whats you suggestion? | 18:09 |
| lambday | HeikoS: what I was thinking is to have two copies of pvt methods - compute_unbiased_statistic_DEPRECATED() and compute_unbiased_statistic() .... then by using just one flag use_deprecated, we can switch which method to use - for null approximation method we'll have to set enum anyway | 18:11 |
| lambday | but since statistic returned is also changed, so to compare we gotta keep both, right | 18:12 |
| @HeikoS | lambday: ok thats fine, as long as all this deprecated stuff is hidden to the outside | 18:12 |
| @HeikoS | lambday: I would just use a setter for that, not constructor, people should not really use that | 18:12 |
| lambday | HeikoS: yeah definitely a setter | 18:13 |
| @HeikoS | just put good documentation, i.e. reference to papers, etc | 18:13 |
| lambday | HeikoS: yeah - modified the documentation already | 18:13 |
| -!- thor|alf [~thoralf@91-65-140-50-dynip.superkabel.de] has quit [Quit: Konversation terminated!] | 18:14 | |
| lambday | HeikoS: btw computing variance can be done on the fly when computing statistic - so should I add a method compute_statistic_and_variance() or have two separate methods for that? because, say, we're using PERMUTATION and then computing asymptotic variance for every single iteration isn't really needed | 18:15 |
| @HeikoS | lambday: yes I think thats a good idea | 18:17 |
| @HeikoS | lambday: though again, document why you do this | 18:17 |
| lambday | HeikoS: which one is good idea? having two separate methods? | 18:17 |
| @HeikoS | lambday: we want to keep the design as clean as possible, not corrupt just due to old buggy papers ;) | 18:17 |
| lambday | hehe :D | 18:17 |
| lambday | HeikoS: yeah trying to keep things well documented.. | 18:18 |
| @HeikoS | lambday: how much overhead is it to compute the variance always?`Also, streaming version should only use data once | 18:21 |
| lambday | HeikoS: yeah for streaming version its done in one go - for computing var alongwith statistic we need to compute sums/squared-sums row-wise - so overhead isn't the kernel calls but extra arithmatic to compute stuff.. | 18:24 |
| @HeikoS | that shouldnt be too much right? | 18:24 |
| lambday | HeikoS: I guess so - unless we use permuation test | 18:24 |
| lambday | HeikoS: having separate methods would require to recompute kernel values as well | 18:25 |
| @HeikoS | lambday: well thats bad | 18:25 |
| @HeikoS | we dont want this | 18:25 |
| @HeikoS | rather have some neglectible overhead for the variance | 18:25 |
| lambday | HeikoS: how about we add both - I mean, sometimes we just want to estimate the statistic and not the asympotic var - so one compute_statistic would do that and another compute_statistic_and_variance would compute both | 18:26 |
| @HeikoS | lambday: ok thats also fine | 18:29 |
| @HeikoS | lambday: but maybe only internally? | 18:29 |
| @HeikoS | or do we need this from the outside? | 18:29 |
| lambday | HeikoS: I think internally it can be done - just need to make sure which are the things we need from outside | 18:30 |
| lambday | HeikoS: we need var under null and alternative, right? | 18:31 |
| lambday | so, instead of exposing the compute_statistic_and_variance() to outside, we can have compute_variance() returning both var estimations under null and alternative | 18:32 |
| lambday | which is exposed | 18:32 |
| lambday | and compute_statistic() is exposed | 18:32 |
| @HeikoS | yep nice! | 18:34 |
| -!- lambday [67157f4f@gateway/web/freenode/ip.103.21.127.79] has quit [Ping timeout: 240 seconds] | 18:46 | |
| -!- lambday [67157f4f@gateway/web/freenode/ip.103.21.127.79] has joined #shogun | 18:47 | |
| lambday | HeikoS: hey! | 18:49 |
| lambday | HeikoS: sorry I got dc | 18:49 |
| lambday | HeikoS: Integration test is failing due to fixed lhs_equals_rhs flag in data | 18:50 |
| @HeikoS | lambday: yep thats expected | 18:50 |
| lambday | HeikoS: how do I fix this? | 18:50 |
| @HeikoS | lambday: update the test using generator.py in integration test dir | 18:54 |
| @HeikoS | lambday: update the test using generator.py in integration test dir | 18:54 |
| lambday | HeikoS: okay | 18:54 |
| lambday | HeikoS: you mean generate_testdata.py | 18:56 |
| @HeikoS | no | 18:56 |
| @HeikoS | shogun/tests/integration/python_modular/generator.py | 18:56 |
| lambday | HeikoS: yeah got it | 18:56 |
| lambday | :D | 18:56 |
| @HeikoS | lambday: you need to commit this to shogun-data, then update the data version of your PR | 18:59 |
| @HeikoS | I merge first, then travis will work again | 18:59 |
| lambday | HeikoS: okay.. thanks | 18:59 |
| -!- HeikoS [~heiko@130.208.244.119] has quit [Quit: Leaving.] | 19:00 | |
| -!- HeikoS [~heiko@130.208.244.119] has joined #shogun | 19:08 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 19:08 | |
| -!- HeikoS [~heiko@130.208.244.119] has quit [Quit: Leaving.] | 19:28 | |
| -!- lambday [67157f4f@gateway/web/freenode/ip.103.21.127.79] has quit [Ping timeout: 240 seconds] | 19:36 | |
| -!- khalednasr [~k.nasr92@41.69.243.188] has joined #shogun | 20:09 | |
| -!- khalednasr [~k.nasr92@41.69.243.188] has quit [Quit: Leaving] | 21:15 | |
| -!- HeikoS [~heiko@85-220-3-15.dsl.dynamic.simnet.is] has joined #shogun | 22:55 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 22:55 | |
| -!- HeikoS [~heiko@85-220-3-15.dsl.dynamic.simnet.is] has quit [Quit: Leaving.] | 23:02 | |
| -!- HeikoS [~heiko@85-220-3-15.dsl.dynamic.simnet.is] has joined #shogun | 23:03 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 23:03 | |
| -!- iglesiasg [~iglesiasg@136.Red-95-122-3.staticIP.rima-tde.net] has joined #shogun | 23:50 | |
| -!- mode/#shogun [+o iglesiasg] by ChanServ | 23:50 | |
| -!- HeikoS [~heiko@85-220-3-15.dsl.dynamic.simnet.is] has quit [Quit: Leaving.] | 23:55 | |
| --- Log closed Sun Apr 27 00:00:23 2014 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!