--- Log opened Sun Jun 05 00:00:26 2016 | ||
-!- sonne|osx [~sonne@x5ce25ef2.dyn.telefonica.de] has quit [Quit: sonne|osx] | 00:43 | |
-!- mizari [~mizari@95-174-213-100.nts.su] has joined #shogun | 03:00 | |
-!- lambday [56a397da@gateway/web/freenode/ip.86.163.151.218] has quit [Ping timeout: 250 seconds] | 03:09 | |
-!- sanuj [~sanuj@117.203.4.251] has joined #shogun | 05:22 | |
-!- sanuj [~sanuj@117.203.4.251] has quit [Ping timeout: 260 seconds] | 05:38 | |
-!- sanuj [~sanuj@117.203.4.251] has joined #shogun | 06:08 | |
sanuj | wiking, there? | 06:08 |
---|---|---|
-!- sanuj [~sanuj@117.203.4.251] has quit [Ping timeout: 258 seconds] | 07:06 | |
-!- sanuj [~sanuj@117.203.4.251] has joined #shogun | 07:44 | |
-!- lambday [56a397da@gateway/web/freenode/ip.86.163.151.218] has joined #shogun | 10:44 | |
-!- mode/#shogun [+o lambday] by ChanServ | 10:44 | |
-!- besser82 [~besser82@fedora/besser82] has joined #shogun | 10:51 | |
-!- mode/#shogun [+o besser82] by ChanServ | 10:51 | |
-!- sanuj [~sanuj@117.203.4.251] has quit [Ping timeout: 264 seconds] | 11:15 | |
-!- sanuj [~sanuj@117.203.4.251] has joined #shogun | 11:39 | |
sanuj | lisitsyn, hey, got time? | 11:39 |
lisitsyn | yeap | 11:39 |
lisitsyn | sup | 11:39 |
sanuj | i pushed some commits | 11:39 |
sanuj | https://github.com/shogun-toolbox/shogun/pull/3221 | 11:39 |
sanuj | lisitsyn, can you review? | 11:39 |
lisitsyn | sure | 11:39 |
sanuj | :) | 11:39 |
sanuj | lambday, there? | 11:40 |
lisitsyn | sanuj: I think we should merge soon | 11:42 |
lisitsyn | just a few things more | 11:42 |
sanuj | oh really | 11:42 |
sanuj | i need to write swig bindings | 11:42 |
-!- besser82 [~besser82@fedora/besser82] has quit [Ping timeout: 264 seconds] | 11:43 | |
lisitsyn | sanuj: it makes sense to me to just merge C++ part then go on with swig one | 11:43 |
sanuj | lisitsyn, okay | 11:43 |
lisitsyn | sanuj: https://github.com/shogun-toolbox/shogun/pull/3221/files#diff-9c3599c0d2090e493be261b079e9b63eR48 | 11:43 |
lisitsyn | this thing confuses me a bit | 11:44 |
sanuj | lisitsyn, this is because i want to use get_name() of SGObject | 11:44 |
sanuj | if i dont take SGObject ptr as an argument then it doesn't work | 11:44 |
lisitsyn | sanuj: yeah I understand why you did that but there is strange loop | 11:45 |
sanuj | okay | 11:46 |
lisitsyn | sanuj: what about moving this error handling | 11:46 |
lisitsyn | to SGObject | 11:46 |
lisitsyn | so you don't have to pass this pointer | 11:46 |
sanuj | lisitsyn, what "any" should i return if there is none corresponding to a key | 11:46 |
lisitsyn | sanuj: just return empty any | 11:47 |
lisitsyn | then you can check | 11:47 |
lisitsyn | empty() | 11:48 |
lisitsyn | like T value = self->get(...); | 11:48 |
lisitsyn | if (value.empty()) { get mad } | 11:48 |
sanuj | lisitsyn, haha, okay | 11:49 |
sanuj | but how to make an empty any object? | 11:49 |
sanuj | lisitsyn, Any::Empty()? | 11:50 |
lisitsyn | Any() | 11:50 |
lisitsyn | no parameter ctor produces empty value | 11:50 |
sanuj | lisitsyn, isn't this a function call | 11:50 |
sanuj | i did something like this earlier and got error | 11:51 |
sanuj | lisitsyn, or new Any(); | 11:51 |
lisitsyn | no should be legal | 11:51 |
lisitsyn | no, no new | 11:51 |
sanuj | okay | 11:51 |
sanuj | return Any(); | 11:51 |
lisitsyn | sanuj: you can actually | 11:51 |
lisitsyn | just use [] of map | 11:51 |
lisitsyn | ah no it is not a good idea | 11:52 |
sanuj | lisitsyn, okay | 11:52 |
lisitsyn | just return Any(); | 11:52 |
sanuj | okay | 11:52 |
sanuj | and i need to implement std::hash | 11:52 |
lisitsyn | sanuj: yeah it is usual way to make something hashable | 11:53 |
sanuj | lisitsyn, use SGVector instead of std::vec in all_parameters()? | 11:54 |
lisitsyn | sanuj: actually it would make sense due to swig | 11:54 |
lisitsyn | we have maps for SGVector | 11:54 |
lisitsyn | typemaps | 11:54 |
sanuj | okay | 11:55 |
lisitsyn | sanuj: I have one more thing | 11:55 |
lisitsyn | https://github.com/shogun-toolbox/shogun/pull/3221/files#diff-8cfacc7a0d1355252c12528031d690b5R399 | 11:55 |
lisitsyn | here you rely on the order of parameters | 11:55 |
sanuj | yeah | 11:55 |
sanuj | that's bad | 11:55 |
lisitsyn | it seems possible that the order would be defined by the implementation | 11:56 |
lisitsyn | I mean if we use other map | 11:56 |
lisitsyn | it could fail | 11:56 |
sanuj | how to test it otherwise? | 11:56 |
lisitsyn | sanuj: convert it to std::set | 11:56 |
lisitsyn | then check all of these three are in the set | 11:56 |
sanuj | lisitsyn, cool | 11:56 |
sanuj | lisitsyn, so these changes and document the new functions | 11:58 |
lisitsyn | sanuj: and finally we would need to add some doc for publich methods | 11:58 |
sanuj | then we are merge ready? | 11:59 |
sanuj | yeah | 11:59 |
lisitsyn | oh you seem to predict my thoughts :D | 11:59 |
lisitsyn | yes | 11:59 |
lisitsyn | then I think we merge and then make it work with swig | 11:59 |
sanuj | cool | 11:59 |
@lambday | sanuj: hey there | 12:16 |
@lambday | how's it going? | 12:16 |
sanuj | lambday, everything is great :D | 12:17 |
sanuj | lambday, you remember me and heiko were discussing about some build problems a few days back when you told me to increase ccache size to 10 gigs? | 12:18 |
@lambday | yeah | 12:19 |
@lambday | it didn't help? | 12:19 |
@lambday | it didn't help? | 12:21 |
sanuj | lambday, it helped :) | 12:21 |
sanuj | thanks | 12:21 |
sanuj | but i was also talking about python modular tests failing | 12:21 |
sanuj | lambday, i think that is due to python 3 | 12:22 |
sanuj | do you know how to fix it | 12:22 |
sanuj | i concluded this because the tests that pass, also pass if run by python3 | 12:23 |
sanuj | and the tests that fail, also fail if run by python3 | 12:23 |
sanuj | :P | 12:23 |
sanuj | lisitsyn, rename all_parameters() to params()? | 12:26 |
lisitsyn | sanuj: nono I mean variable name | 12:27 |
sanuj | cool | 12:27 |
lisitsyn | sanuj: it is just about vec in the name ;) | 12:27 |
sanuj | yeah :) | 12:27 |
@lambday | sanuj: what do you mean? you have some failing tests that fails for both python2 and python3? | 12:37 |
sanuj | oh sorry | 12:38 |
sanuj | lambday, i have some failing python modular tests that fail because of python3 | 12:38 |
sanuj | all of them pass if python2 is used | 12:39 |
sanuj | but when i do "make test", it automatically uses python 3 and not python2 | 12:39 |
@lambday | sanuj: I usually just run make and then run ctest | 12:39 |
@lambday | that doesn't work for you? | 12:40 |
@lambday | umm we had this thing where we used to specify whether to use python2 or 3.. but not sure how we set that now.. | 12:41 |
@lambday | I can check a bit | 12:41 |
Saurabh7 | hello guys | 12:41 |
@lambday | Saurabh7: hey how's it going? | 12:41 |
sanuj | lambday, ctest is working | 12:41 |
sanuj | i always used to do make test | 12:42 |
Saurabh7 | lambday: good good | 12:42 |
@lambday | sanuj: does that use python2? | 12:42 |
Saurabh7 | sanuj: set python ussing ccmake ? | 12:42 |
@lambday | I think that's possible ^ | 12:42 |
sanuj | lambday, well the tests are passing, so it must use python2 | 12:42 |
@lambday | I see | 12:42 |
@lambday | I vaguely remember some set option when we had configure;make .. | 12:43 |
Saurabh7 | when iwant to switch form py 2 to 3 i just change in ccmake, toggle advanced options | 12:43 |
Saurabh7 | sanuj: ^ | 12:43 |
@lambday | sanuj: there you go ^ | 12:43 |
sanuj | okay, let me try | 12:44 |
sanuj | i think ccmake reads stuff from cmakecache.txt | 12:48 |
sanuj | it already has PYTHON_PACKAGES_PATH=lib/python2.7/dist-packages | 12:49 |
-!- Saurabh7 [Saurabh7@gateway/shell/panicbnc/x-zjbrorlyietxjdsm] has quit [Ping timeout: 260 seconds] | 12:55 | |
-!- lambday [56a397da@gateway/web/freenode/ip.86.163.151.218] has quit [Ping timeout: 250 seconds] | 13:03 | |
-!- lambday [56a397da@gateway/web/freenode/ip.86.163.151.218] has joined #shogun | 13:17 | |
-!- mode/#shogun [+o lambday] by ChanServ | 13:17 | |
-!- Saurabh7 [Saurabh7@gateway/shell/panicbnc/x-aizjrbmwcdgxpctw] has joined #shogun | 13:46 | |
sanuj | lisitsyn, there? | 14:23 |
lisitsyn | sanuj: ye | 14:23 |
sanuj | lisitsyn, i'm getting this error | 14:24 |
sanuj | libshogun.so.17.2: undefined reference to `shogun::SGVector<std::string>::SGVector(int, bool)' | 14:24 |
sanuj | not able to locate the source | 14:24 |
lisitsyn | probably you need to use SGVector<SGString> | 14:26 |
sanuj | lisitsyn, why do we want to implement std::hash? | 14:28 |
sanuj | let me try SGString | 14:28 |
lisitsyn | sanuj: this way yuo don't have to put anything to your map | 14:30 |
lisitsyn | like BaseTageHasher | 14:30 |
sanuj | lisitsyn, how? i don't understand | 14:33 |
sanuj | do you have a link that explains this | 14:33 |
sanuj | lisitsyn, oh i think i understood | 14:34 |
sanuj | okay | 14:34 |
sanuj | don't bother | 14:34 |
lisitsyn | sanuj: by default it uses std::hash | 14:36 |
sanuj | lisitsyn, yes | 14:36 |
lisitsyn | so it tries to call std::hash<BaseTag>() | 14:36 |
lisitsyn | it is not implemented | 14:37 |
sanuj | okay | 14:37 |
sanuj | i got it | 14:37 |
sanuj | :) | 14:37 |
lisitsyn | ok cool | 14:37 |
-!- ptizoom [~christian@host-92-21-230-101.as13285.net] has quit [Ping timeout: 276 seconds] | 14:42 | |
sanuj | lisitsyn, SGString is a template | 14:49 |
sanuj | T=std::string? | 14:49 |
sanuj | okay, it should be char | 14:51 |
sanuj | lisitsyn, there? | 15:27 |
lisitsyn | sanuj: yes | 15:27 |
sanuj | params[i++] = SGVector<char>(str.c_str(), str.size()); | 15:27 |
sanuj | lisitsyn, i'm doing this ^ | 15:28 |
sanuj | but str.c_str() gives const char* | 15:28 |
lisitsyn | why SGVector? | 15:28 |
sanuj | oh sorry | 15:28 |
sanuj | its SGSVector | 15:29 |
sanuj | SGString | 15:29 |
sanuj | but it wants SGString(T*, index_t, bool) [with T = char; index_t = int] | 15:29 |
lisitsyn | ok I get it | 15:30 |
sanuj | lisitsyn, so const char* won't work | 15:30 |
sanuj | i will have to copy | 15:30 |
sanuj | using new | 15:30 |
sanuj | to convert const char* to char* | 15:30 |
lisitsyn | yes probably | 15:30 |
sanuj | lisitsyn, you cool with that? | 15:30 |
lisitsyn | yeah that's ok | 15:30 |
sanuj | cool | 15:31 |
lisitsyn | I just need to check | 15:31 |
lisitsyn | if SGVector<SGString> | 15:31 |
lisitsyn | is exported to swig | 15:31 |
lisitsyn | sanuj: ooh it seems it is not | 15:31 |
sanuj | lisitsyn, ohkay, what to do now? | 15:32 |
lisitsyn | sanuj: lets just keep it std::vector<std::String> | 15:32 |
lisitsyn | string* | 15:32 |
lisitsyn | we will change that later | 15:32 |
sanuj | cool | 15:32 |
sanuj | nice and easy :) | 15:32 |
lisitsyn | it could be tricky so lets just postpone | 15:33 |
sanuj | okay! | 15:34 |
sanuj | lisitsyn, but this needs to happen before swig interface gets merged | 15:34 |
sanuj | we will just use SGVector<std::string> then? | 15:35 |
lisitsyn | sanuj: not sure | 15:37 |
lisitsyn | may be its SGStringList | 15:37 |
lisitsyn | we will see | 15:37 |
-!- besser82 [~besser82@fedora/besser82] has joined #shogun | 15:50 | |
-!- mode/#shogun [+o besser82] by ChanServ | 15:50 | |
-!- besser82 [~besser82@fedora/besser82] has quit [Ping timeout: 260 seconds] | 16:16 | |
sanuj | lisitsyn, there? | 17:49 |
lisitsyn | sanuj: yes | 17:49 |
sanuj | lisitsyn, can you review https://github.com/shogun-toolbox/shogun/pull/3221 | 17:49 |
sanuj | lisitsyn, what's wrong with the indentation? | 17:54 |
lisitsyn | https://github.com/sanuj/shogun/blob/59e802a0f7036727faa18df63acf687050cc56a8/src/shogun/base/SGObject.cpp#L59 | 17:54 |
lisitsyn | :) | 17:54 |
sanuj | lisitsyn, oh i see, it looked okay on my sublime text | 17:57 |
lisitsyn | sanuj: ok I am done | 18:04 |
lisitsyn | a few more comments | 18:04 |
sanuj | yeah i saw | 18:04 |
-!- besser82 [~besser82@fedora/besser82] has joined #shogun | 18:04 | |
-!- mode/#shogun [+o besser82] by ChanServ | 18:04 | |
lisitsyn | sanuj: before we merge it we need someone else (HeikoS or wiking) to check | 18:04 |
sanuj | lisitsyn, sure | 18:05 |
sanuj | so it will happen tomorrow | 18:05 |
-!- besser82 [~besser82@fedora/besser82] has quit [Ping timeout: 260 seconds] | 18:14 | |
-!- sanuj [~sanuj@117.203.4.251] has quit [Ping timeout: 272 seconds] | 18:54 | |
-!- lambday [56a397da@gateway/web/freenode/ip.86.163.151.218] has quit [Ping timeout: 250 seconds] | 19:04 | |
-!- sonne|osx [~sonne@x4db3bf36.dyn.telefonica.de] has joined #shogun | 21:00 | |
-!- mizari [~mizari@95-174-213-100.nts.su] has quit [Quit: Leaving] | 21:08 | |
-!- lambday [56a397da@gateway/web/freenode/ip.86.163.151.218] has joined #shogun | 21:16 | |
-!- mode/#shogun [+o lambday] by ChanServ | 21:16 | |
-!- lambday [56a397da@gateway/web/freenode/ip.86.163.151.218] has quit [Ping timeout: 250 seconds] | 22:23 | |
-!- lambday [6d9941c0@gateway/web/freenode/ip.109.153.65.192] has joined #shogun | 23:49 | |
-!- mode/#shogun [+o lambday] by ChanServ | 23:49 | |
--- Log closed Mon Jun 06 00:00:28 2016 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!