--- Log opened Sat Jul 09 00:00:14 2016 | ||
-!- lambday [56a397c5@gateway/web/freenode/ip.86.163.151.197] has quit [Ping timeout: 250 seconds] | 01:39 | |
shogun-buildbot | build #28 of clang - thread analysis is complete: Failure [failed compile] Build details are at http://buildbot.shogun-toolbox.org/builders/clang%20-%20thread%20analysis/builds/28 blamelist: Heiko Strathmann <heiko.strathmann@gmail.com>, Saurabh7 <saurabh.mahindre@gmail.com> | 03:44 |
---|---|---|
shogun-buildbot | build #26 of clang - undefined behaviour analysis is complete: Failure [failed compile] Build details are at http://buildbot.shogun-toolbox.org/builders/clang%20-%20undefined%20behaviour%20analysis/builds/26 blamelist: Heiko Strathmann <heiko.strathmann@gmail.com>, Saurabh7 <saurabh.mahindre@gmail.com> | 03:48 |
shogun-buildbot | build #42 of memleak - valgrind is complete: Failure [failed memory check] Build details are at http://buildbot.shogun-toolbox.org/builders/memleak%20-%20valgrind/builds/42 blamelist: Heiko Strathmann <heiko.strathmann@gmail.com>, Saurabh7 <saurabh.mahindre@gmail.com> | 05:38 |
shogun-buildbot | build #1040 of nightly_none is complete: Failure [failed compile] Build details are at http://buildbot.shogun-toolbox.org/builders/nightly_none/builds/1040 blamelist: Heiko Strathmann <heiko.strathmann@gmail.com>, Saurabh7 <saurabh.mahindre@gmail.com> | 05:48 |
shogun-buildbot | build #1170 of nightly_default is complete: Failure [failed test notebooks] Build details are at http://buildbot.shogun-toolbox.org/builders/nightly_default/builds/1170 blamelist: Heiko Strathmann <heiko.strathmann@gmail.com>, Saurabh7 <saurabh.mahindre@gmail.com> | 06:35 |
-!- mizari [~mizari@95-174-213-100.nts.su] has joined #shogun | 07:34 | |
-!- mizari [~mizari@95-174-213-100.nts.su] has quit [Quit: Leaving] | 11:55 | |
-!- sanuj [~sanuj@59.97.245.51] has joined #shogun | 12:40 | |
sanuj | bzdmgz, there? | 12:40 |
-!- sanuj [~sanuj@59.97.245.51] has quit [Ping timeout: 264 seconds] | 13:26 | |
-!- sanuj [~sanuj@117.203.12.168] has joined #shogun | 13:39 | |
-!- sanuj [~sanuj@117.203.12.168] has quit [Quit: Leaving] | 14:13 | |
-!- sanuj [~sanuj@117.203.12.168] has joined #shogun | 14:13 | |
sanuj | bzdmgz, there? | 14:13 |
bzdmgz | sanuj: FINALLY yes | 14:15 |
bzdmgz | just fixed some crazy thing | 14:15 |
sanuj | :D | 14:15 |
sanuj | haha | 14:15 |
sanuj | bzdmgz, office work on weekend? | 14:15 |
bzdmgz | no but fixing it | 14:15 |
bzdmgz | crazily out of SLA | 14:15 |
sanuj | hmm | 14:15 |
bzdmgz | ok seen your mail | 14:16 |
bzdmgz | let me check | 14:16 |
sanuj | bzdmgz, https://github.com/shogun-toolbox/shogun/pull/3357#issuecomment-231361440 | 14:16 |
sanuj | cool | 14:16 |
bzdmgz | I agree with heiko but we need to separare those | 14:17 |
bzdmgz | I mean we need that list | 14:17 |
bzdmgz | but we can't combine list and create | 14:17 |
bzdmgz | SO | 14:17 |
bzdmgz | what about removing swig part YET | 14:17 |
sanuj | okay | 14:17 |
bzdmgz | we tried, it works | 14:17 |
bzdmgz | let me put that so heiko knows | 14:18 |
sanuj | bzdmgz, i'll remove swig from create() and update the PR | 14:18 |
bzdmgz | yeah tanks | 14:18 |
bzdmgz | thanks | 14:19 |
sanuj | bzdmgz, see the other PR also | 14:19 |
bzdmgz | sanuj: yeah | 14:19 |
bzdmgz | sanuj: actually creating | 14:19 |
bzdmgz | like clone | 14:19 |
bzdmgz | and equals | 14:19 |
bzdmgz | maybe it makes sense? | 14:19 |
sanuj | bzdmgz, are you talking about jinja? | 14:20 |
bzdmgz | yeah | 14:20 |
bzdmgz | sanuj: I tend to think it makes sense | 14:20 |
sanuj | i've done like the jinja generated unit-tests only | 14:20 |
bzdmgz | what do you think? | 14:20 |
sanuj | yes | 14:20 |
sanuj | jinja is good | 14:20 |
bzdmgz | no I mean | 14:20 |
bzdmgz | just copy what happens in | 14:20 |
bzdmgz | clone unit test | 14:20 |
bzdmgz | to test all the clasess are created | 14:21 |
sanuj | I see | 14:21 |
sanuj | bzdmgz, but we need to decide what classes to add | 14:21 |
bzdmgz | the only thing bothers me | 14:21 |
bzdmgz | is that you use | 14:21 |
bzdmgz | create<CKernel> | 14:21 |
bzdmgz | ok they all have base class | 14:21 |
bzdmgz | just use create<CSGObject> | 14:22 |
sanuj | bzdmgz, see my updated MockObject | 14:22 |
sanuj | i have created a pointer of CKernel* there | 14:22 |
bzdmgz | where where | 14:22 |
sanuj | in the jinja pr | 14:22 |
bzdmgz | ok let me check | 14:23 |
bzdmgz | sanuj: oh that looks cool | 14:26 |
sanuj | bzdmgz, the PR? | 14:26 |
bzdmgz | yeah | 14:26 |
sanuj | thanks | 14:26 |
bzdmgz | jinja thing look fancy | 14:26 |
sanuj | haha | 14:27 |
sanuj | bzdmgz, R is failing | 14:27 |
bzdmgz | yeah | 14:27 |
sanuj | did you see my last comment | 14:27 |
bzdmgz | not sure | 14:27 |
bzdmgz | I think it just doesn't support overloading? | 14:27 |
bzdmgz | or? | 14:27 |
bzdmgz | sanuj: we need a patch to disable it for R then | 14:27 |
sanuj | bzdmgz, does anyone use shogun in R? | 14:28 |
bzdmgz | does anyone use shogun | 14:28 |
bzdmgz | :D :D JK | 14:28 |
sanuj | :D | 14:28 |
bzdmgz | sanuj: no idea | 14:28 |
bzdmgz | we do not track that | 14:28 |
bzdmgz | should intergrate some spyware | 14:28 |
bzdmgz | ! | 14:28 |
bzdmgz | sanuj: just ignore it do not let it stop you :D | 14:29 |
bzdmgz | I mean some #ifdef maybe | 14:29 |
sanuj | i see | 14:29 |
bzdmgz | you can find some examples actually | 14:29 |
bzdmgz | in our .i files | 14:29 |
sanuj | the error happens because of this line in modshogun.R | 14:29 |
sanuj | vaccessors = c('io', 'parallel', 'version', 'm_parameters', 'm_model_selection_parameters', 'm_gradient_parameters', 'm_hash', 'get''get''get''get''get''get''get''get'); | 14:29 |
sanuj | the 'get' madness | 14:29 |
sanuj | bzdmgz, some similar issues were reported by | 14:30 |
sanuj | https://sourceforge.net/p/swig/mailman/message/35071142/ | 14:30 |
sanuj | https://github.com/swig/swig/issues/697 | 14:30 |
bzdmgz | yeah I've seen | 14:31 |
sanuj | cool | 14:31 |
bzdmgz | shit happens so we have to avoid that | 14:31 |
sanuj | okay | 14:31 |
sanuj | bzdmgz, so no tags-swig for R? | 14:31 |
sanuj | will use ifdef as you suggested | 14:31 |
bzdmgz | yeah | 14:31 |
bzdmgz | unless it is fixed in swig | 14:31 |
sanuj | bzdmgz, i think will take time | 14:31 |
sanuj | if they fix it | 14:32 |
bzdmgz | yes | 14:32 |
bzdmgz | lets just wait | 14:32 |
bzdmgz | once fixed we enable it for R | 14:32 |
sanuj | okay | 14:32 |
sanuj | bzdmgz, look at this https://github.com/shogun-toolbox/shogun/pull/3357/files#diff-5cdc2a59820a53342121f311fbbe4d51R26 | 14:32 |
sanuj | if i use CGaussianKernel* instead | 14:33 |
sanuj | it gives error from because the type are not same as i use setKernel() which expects a CKernel* | 14:34 |
bzdmgz | shouldnt be casted? | 14:35 |
sanuj | bzdmgz, will try casting | 14:35 |
bzdmgz | no I mean implicitly | 14:35 |
sanuj | no | 14:36 |
bzdmgz | why? | 14:36 |
sanuj | bzdmgz, well if it was implicitly casted, then it would have worked | 14:36 |
bzdmgz | yeahh | 14:37 |
bzdmgz | strange | 14:37 |
sanuj | bzdmgz, if we do this....is there a problem? | 14:37 |
bzdmgz | I am not sure what's the problem | 14:37 |
bzdmgz | :) | 14:37 |
sanuj | cool :D | 14:38 |
sanuj | i was just confirming | 14:38 |
sanuj | bzdmgz, i can't add classes till we decide what classes to add | 14:38 |
bzdmgz | yeah | 14:39 |
sanuj | bzdmgz, so what are the next steps for tags | 14:39 |
sanuj | and for plugins | 14:39 |
sanuj | i'll update the create PR | 14:39 |
bzdmgz | sanuj: ok it is hard to decide what classes | 14:40 |
sanuj | and the jinja PR to handle R error | 14:40 |
bzdmgz | sanuj: what about selecting just a few | 14:40 |
sanuj | bzdmgz, yes | 14:40 |
bzdmgz | just to make the simplest complete example work | 14:40 |
bzdmgz | classification with kernel svm | 14:40 |
sanuj | bzdmgz, okay | 14:40 |
bzdmgz | whole thing should be created by create | 14:40 |
bzdmgz | no `new` involved | 14:41 |
sanuj | bzdmgz, i will have to change internals of classes to support tag-parameters | 14:41 |
sanuj | bzdmgz, are you talking about using tag-parameters for kernel svm classification example? | 14:42 |
sanuj | or just create? | 14:42 |
bzdmgz | sanuj: I think tag is tougher | 14:45 |
bzdmgz | just create firt | 14:45 |
bzdmgz | first | 14:45 |
sanuj | bzdmgz, so i think the bottleneck is to decide what classes to add for tags | 14:45 |
sanuj | bzdmgz, and it is better if you and heiko do it | 14:46 |
bzdmgz | it is nearly impossible | 14:46 |
bzdmgz | we can start with something and iterate | 14:46 |
sanuj | bzdmgz, okay so what is the next step for the tags PR after i fix R issues | 14:47 |
bzdmgz | sanuj: I have to think about it | 14:47 |
bzdmgz | there are quite a few things to do | 14:47 |
bzdmgz | not sure how to decompose | 14:47 |
bzdmgz | but it is moving quite good | 14:48 |
bzdmgz | we will have something fancy quite soon | 14:48 |
sanuj | okay | 14:48 |
sanuj | bzdmgz, next thing for plugins, after i have the svm example ready with create() | 14:48 |
bzdmgz | sanuj: dlopen thing is due I guess | 14:49 |
sanuj | just asking this now.....because i don't know when you will be available on irc next :D | 14:49 |
bzdmgz | hahah | 14:49 |
bzdmgz | ok | 14:49 |
sanuj | bzdmgz, so migrate aer code in shogun | 14:49 |
bzdmgz | I will try to follow up next week | 14:49 |
bzdmgz | this week was crazy | 14:49 |
sanuj | haha i see | 14:49 |
bzdmgz | sanuj: so the basic idea | 14:50 |
bzdmgz | as you have create by string | 14:50 |
bzdmgz | make it able to call some library | 14:50 |
bzdmgz | to ask it to create this object | 14:50 |
sanuj | bzdmgz, so it is like using create with your aer plugin code | 14:51 |
sanuj | i'll have to modify create again then | 14:51 |
bzdmgz | yeah | 14:51 |
bzdmgz | but inside of create | 14:51 |
bzdmgz | no interface involved | 14:51 |
sanuj | bzdmgz, what interface? | 14:52 |
bzdmgz | of this 'create' function | 14:52 |
sanuj | abstract class | 14:52 |
bzdmgz | I mean from user experience it is still create | 14:52 |
bzdmgz | the only difference is how we load it | 14:52 |
sanuj | i see | 14:52 |
sanuj | so from user point of view, create() doesn't change | 14:52 |
bzdmgz | yeah | 14:52 |
sanuj | only it's internal implementation changes | 14:53 |
bzdmgz | yeap | 14:53 |
sanuj | bzdmgz, so i'll first make this create svm example work | 14:53 |
sanuj | bzdmgz, and migrate your aer plugin code on a different branch | 14:53 |
bzdmgz | yes makes sense | 14:53 |
sanuj | and make it work with create() | 14:53 |
bzdmgz | yeap | 14:54 |
sanuj | bzdmgz, but for this i think i would also need to write a plugin | 14:54 |
sanuj | dummy plugin | 14:54 |
bzdmgz | yes | 14:54 |
bzdmgz | :) | 14:54 |
bzdmgz | gaussian kerel | 14:54 |
bzdmgz | e.g. | 14:54 |
sanuj | bzdmgz, so what's the point of merging create in develop right now? | 14:55 |
bzdmgz | did I say that? | 14:56 |
bzdmgz | oops | 14:56 |
bzdmgz | :D | 14:56 |
sanuj | okay, not merging then? | 14:56 |
bzdmgz | I think it can go to tags | 14:56 |
sanuj | haha | 14:56 |
sanuj | yeah | 14:57 |
sanuj | bzdmgz, will send a pr to tags | 14:57 |
-!- sanuj [~sanuj@117.203.12.168] has quit [Ping timeout: 264 seconds] | 15:07 | |
-!- Saurabh7 [Saurabh7@gateway/shell/panicbnc/x-xohcuxorptqneppp] has quit [Ping timeout: 264 seconds] | 15:10 | |
-!- Saurabh7 [Saurabh7@gateway/shell/panicbnc/x-qqkcvttzzqzpgvhm] has joined #shogun | 15:31 | |
-!- HeikoS [~heiko@ppp-2-86-179-77.home.otenet.gr] has joined #shogun | 15:41 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 15:41 | |
-!- HeikoS [~heiko@ppp-2-86-179-77.home.otenet.gr] has quit [Quit: Leaving.] | 15:53 | |
-!- sanuj [~sanuj@117.203.12.168] has joined #shogun | 16:15 | |
-!- sanuj [~sanuj@117.203.12.168] has quit [Ping timeout: 272 seconds] | 16:53 | |
-!- sanuj [~sanuj@117.203.12.168] has joined #shogun | 17:43 | |
-!- HeikoS [~heiko@ppp-2-86-179-77.home.otenet.gr] has joined #shogun | 19:25 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 19:25 | |
-!- HeikoS [~heiko@ppp-2-86-179-77.home.otenet.gr] has quit [Quit: Leaving.] | 19:34 | |
sanuj | wiking, there? | 19:59 |
sanuj | ? | 19:59 |
sanuj | bzdmgz, there? | 20:18 |
bzdmgz | sanuj: yeap | 20:18 |
sanuj | bzdmgz, i have a cmake question | 20:18 |
sanuj | JINJA2_FOUND is not set | 20:18 |
bzdmgz | yes? | 20:19 |
sanuj | by FIND(Jinja2) | 20:19 |
sanuj | instead there is this variable | 20:19 |
sanuj | FIND_PACKAGE_MESSAGE_DETAILS_Jinja2=[1][v()] | 20:19 |
sanuj | i was trying to do this | 20:20 |
sanuj | IF(JINJA2_FOUND AND (NOT SWIGR)) | 20:20 |
sanuj | # Generate automatic shogun-base.i from jinja2 templates | 20:20 |
sanuj | ADD_CUSTOM_COMMAND(OUTPUT shogun-base.i | 20:20 |
sanuj | COMMAND ${PYTHON_EXECUTABLE} ${COMMON_MODULAR_SRC_DIR}shogun-base.i.py | 20:20 |
sanuj | ${COMMON_MODULAR_SRC_DIR}shogun-base.i.jinja2 | 20:20 |
sanuj | shogun-base.i | 20:20 |
sanuj | ${COMMON_MODULAR_SRC_DIR}shogun-base-list.txt | 20:20 |
sanuj | DEPENDS ${COMMON_MODULAR_SRC_DIR}shogun-base.i.py | 20:20 |
sanuj | ${COMMON_MODULAR_SRC_DIR}shogun-base.i.jinja2 | 20:20 |
sanuj | WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} | 20:20 |
sanuj | COMMENT "Generating shogun-base.i") | 20:20 |
sanuj | ENDIF() | 20:20 |
sanuj | bzdmgz, ^ | 20:20 |
bzdmgz | yeah it is not being set | 20:21 |
bzdmgz | you can find it in cmake/FindJinja2.cmake | 20:21 |
bzdmgz | sanuj: I think you can patch it | 20:21 |
bzdmgz | find_package_handle_standard_args(LibXslt FOUND_VAR LibXslt_FOUND | 20:21 |
bzdmgz | REQUIRED_VARS LibXslt_LIBRARIES LibXslt_INCLUDE_DIRS | 20:21 |
bzdmgz | VERSION_VAR LibXslt_VERSION_STRING) | 20:21 |
bzdmgz | from https://cmake.org/cmake/help/v3.0/module/FindPackageHandleStandardArgs.html | 20:21 |
bzdmgz | you can add FOUND_VAR | 20:21 |
bzdmgz | with JINJA2_FOUND | 20:22 |
bzdmgz | just like in this example | 20:22 |
bzdmgz | it should work | 20:22 |
sanuj | ohkay | 20:22 |
sanuj | bzdmgz, it is for this https://github.com/shogun-toolbox/shogun/pull/3357#discussion-diff-70074452R46 | 20:22 |
bzdmgz | yeah | 20:22 |
bzdmgz | good | 20:23 |
sanuj | bzdmgz, thanks | 20:23 |
sanuj | goingg to sleep | 20:23 |
sanuj | will do this tomorrow | 20:23 |
sanuj | goodnight | 20:23 |
bzdmgz | gnite | 20:24 |
-!- sanuj [~sanuj@117.203.12.168] has quit [Quit: Leaving] | 20:24 | |
-!- HeikoS [~heiko@80.106.205.93] has joined #shogun | 23:11 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 23:11 | |
-!- HeikoS [~heiko@80.106.205.93] has quit [Quit: Leaving.] | 23:52 | |
--- Log closed Sun Jul 10 00:00:16 2016 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!