| --- Log opened Tue Aug 02 00:00:48 2016 | ||
| @wiking | lisitsyn, what do you mean? bool operator==(const T& x, const T& y) is the declaration of the equals | 03:06 |
|---|---|---|
| @wiking | or? | 03:06 |
| @wiking | i mean it sounds stupid though :) | 03:07 |
| @wiking | ah you mean virtual bool equals(CSGObject* other, float64_t accuracy=0.0, bool tolerant=false); | 03:07 |
| @wiking | ? | 03:07 |
| @wiking | but then it should be fine :) | 03:07 |
| @wiking | ah but | 03:08 |
| @wiking | bool T::operator ==(const T2 &b) const; | 03:08 |
| @wiking | :) | 03:08 |
| @wiking | mmmm | 03:08 |
| @wiking | that's a fun one | 03:08 |
| @wiking | :> | 03:08 |
| @wiking | btw lisitsyn blame Heiko for that design decision: https://github.com/dhruv13J/shogun/commit/ff244613212122d54b3de609c7c4d95a45dd026e#diff-1689b0bd3ceb28355cc3c05ed7ffe4f0 | 03:14 |
| @wiking | rcurtin, sorry yesterday i've passed out | 03:52 |
| rcurtin | no worries, I am about to pass out myself | 04:39 |
| rcurtin | so maybe tomorrow :) | 04:39 |
| @wiking | :))) | 04:40 |
| @wiking | hahah ok | 04:40 |
| @wiking | just msg | 04:40 |
| @wiking | the problem is that i think we are in a 13 hours | 04:40 |
| @wiking | time diff | 04:40 |
| @wiking | you are east coast? | 04:40 |
| rcurtin | yeah, east coast | 04:51 |
| rcurtin | 13 hours... where are you? | 04:51 |
| @wiking | singapore | 04:58 |
| rcurtin | ah, okay | 04:59 |
| rcurtin | well I will be awake tomorrow morning around 1300 UTC, so maybe you will still be awake then :) | 04:59 |
| @wiking | :) | 05:02 |
| @wiking | just ping me | 05:02 |
| rcurtin | sure | 05:03 |
| rcurtin | 'night :) | 05:03 |
| @wiking | gnite | 05:03 |
| -!- sanuj [~sanuj@61.0.30.105] has joined #shogun | 05:15 | |
| sanuj | wiking, there? | 05:15 |
| @wiking | sanuj, yes | 05:19 |
| sanuj | wiking, so over here https://github.com/shogun-toolbox/shogun/pull/3357/files/b79c74445e90a3930003d5a4e35385ca31ecfa42..f768dbc9fa02e71ff155de5051ece64faa868208#diff-af3b638bc2a3e6c650974192a53c7291R962 | 05:19 |
| sanuj | i need to check FIND_PACKAGE(JINJA2) | 05:20 |
| sanuj | and then set ENABLE_TESTING or COMPILE_MODULAR_INTERFACE | 05:20 |
| sanuj | ? | 05:20 |
| @wiking | man | 05:20 |
| @wiking | i mean i dont understand | 05:20 |
| @wiking | check cmakelists.txt | 05:20 |
| sanuj | not sure what your second comment means | 05:20 |
| @wiking | https://github.com/sanuj/shogun/blob/f768dbc9fa02e71ff155de5051ece64faa868208/CMakeLists.txt#L89 | 05:21 |
| @wiking | why not check here the jinja2 | 05:21 |
| @wiking | ? | 05:21 |
| @wiking | i dont understand why do you need to create yet another branch | 05:21 |
| @wiking | that checks the same fucking thing | 05:22 |
| sanuj | wiking, jinja2 is also required in ENABLE_TESTING | 05:22 |
| @wiking | and | 05:22 |
| @wiking | you leave it there | 05:22 |
| @wiking | and check it | 05:22 |
| @wiking | i dont get what's the problem | 05:22 |
| @wiking | come on | 05:22 |
| @wiking | let's be a bit more like a developer | 05:22 |
| @wiking | instead of a random code generator | 05:22 |
| @wiking | anyhow | 05:23 |
| @wiking | just move the find pacakge there | 05:23 |
| @wiking | and you should be set | 05:23 |
| sanuj | wiking, in that case i'll have to put 2 checks for JINJA2 | 05:23 |
| @wiking | no just one | 05:23 |
| @wiking | you put one to the modular | 05:23 |
| @wiking | right? | 05:23 |
| @wiking | the other is already there | 05:23 |
| sanuj | if no modular interfaces are enabled then it won't be checked | 05:23 |
| @wiking | or? | 05:23 |
| sanuj | but we need to check for unit-tests also | 05:23 |
| @wiking | i'm sorry? | 05:24 |
| @wiking | https://github.com/sanuj/shogun/blob/f768dbc9fa02e71ff155de5051ece64faa868208/CMakeLists.txt#L960 | 05:24 |
| @wiking | this check is for | 05:24 |
| @wiking | modular | 05:24 |
| @wiking | the one for the unit test | 05:24 |
| @wiking | is *already* there | 05:24 |
| sanuj | yeah | 05:24 |
| @wiking | so? | 05:24 |
| sanuj | i meant there will be 2 checks for jinja2 in the resultant code | 05:25 |
| sanuj | if that's fine, then i'll do it | 05:25 |
| @wiking | and ? | 05:25 |
| @wiking | i mean in cmake taht check is actually cached | 05:25 |
| @wiking | if you do 2 times the same if in a codebase | 05:25 |
| @wiking | that wont work? | 05:25 |
| @wiking | or what? i mean i dont undestand here the concern | 05:25 |
| sanuj | i was worrying about the redundancy of 2 checks for the same thing | 05:26 |
| sanuj | i guess that's not a problem | 05:26 |
| sanuj | so i'll do what you are suggesting | 05:26 |
| sanuj | wiking, can you please rebase feature/tags with develop? | 05:42 |
| @wiking | sure | 05:43 |
| @wiking | gimem a sec | 05:43 |
| sanuj | wiking, actually no need | 05:43 |
| sanuj | lisitsyn pushed his commit on feature/tags | 05:44 |
| sanuj | i just checked | 05:44 |
| @wiking | k | 05:45 |
| -!- sanuj [~sanuj@61.0.30.105] has quit [Ping timeout: 252 seconds] | 05:55 | |
| -!- sanuj [~sanuj@61.0.30.105] has joined #shogun | 06:31 | |
| -!- c4goldsw [5da420e6@gateway/web/cgi-irc/kiwiirc.com/ip.93.164.32.230] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] | 08:44 | |
| -!- sanuj [~sanuj@61.0.30.105] has quit [Ping timeout: 265 seconds] | 09:45 | |
| -!- sanuj [~sanuj@61.0.30.105] has joined #shogun | 10:01 | |
| sanuj | lisitsyn, yo | 10:01 |
| sanuj | there is a problem | 10:01 |
| @wiking | what is the problem sanuj ? | 10:19 |
| sanuj | rebasing for that PR | 10:22 |
| lisitsyn | oh I am a bit stucked with SG_ADD | 10:22 |
| lisitsyn | I've implemented something working | 10:22 |
| lisitsyn | but it has some nasty bug | 10:22 |
| sanuj | lisitsyn, the problem is that sets() replaces Any object | 10:22 |
| sanuj | or does operator= | 10:22 |
| sanuj | ohkay | 10:22 |
| sanuj | lisitsyn, do we need a static method in Any that updates() the value | 10:23 |
| sanuj | will be good for updating value of member variables | 10:23 |
| lisitsyn | what for? | 10:23 |
| lisitsyn | ah | 10:23 |
| lisitsyn | yeah maybe | 10:23 |
| sanuj | lisitsyn, so sets() implementation should be changed i think | 10:24 |
| sanuj | since the current version won't work for member variables | 10:24 |
| sanuj | lisitsyn, we should just update the value of already existing Any object in the map | 10:24 |
| sanuj | what do you think? | 10:24 |
| lisitsyn | sanuj: what do you mean by won't work? | 10:25 |
| lisitsyn | what bug do you have? | 10:25 |
| sanuj | lisitsyn, i don't have any bug | 10:27 |
| sanuj | haven't tested it | 10:27 |
| sanuj | but i mean | 10:27 |
| sanuj | https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/base/SGObject.h#L333 | 10:27 |
| lisitsyn | ah you mean we can't use this external pointer thing there/ | 10:28 |
| lisitsyn | because it is going to be replaced? | 10:28 |
| sanuj | erase_type() makes a new Any object | 10:28 |
| sanuj | yeah | 10:28 |
| lisitsyn | oh well that's exactly what I am fighting with now | 10:28 |
| lisitsyn | the last thing before SG_ADD works | 10:28 |
| sanuj | lisitsyn, i think with this implementation the map object of Any will start pointing to new memory | 10:29 |
| sanuj | instead of the m_member's memory | 10:29 |
| sanuj | after it has been updated with sets() | 10:29 |
| lisitsyn | you're right | 10:29 |
| lisitsyn | lets try to fix it | 10:29 |
| lisitsyn | :) | 10:29 |
| sanuj | yeah | 10:30 |
| sanuj | wanted to discuss with you the possible solutions | 10:30 |
| sanuj | one way is to have an static update() in Any and use that | 10:30 |
| lisitsyn | not sure have to think about it | 10:30 |
| sanuj | okay | 10:33 |
| sanuj | lisitsyn, sets() is only used after register_param(). So there is always an Any object in map when sets() is used to modify it. Whatever we do, it's best to change value of same memory instead of making a new Any object and changing the memory. Unnecessary creation and deletion of Any objects. | 10:59 |
| -!- shogun-notifier- [~irker@7nn.de] has joined #shogun | 11:05 | |
| shogun-notifier- | shogun: Viktor Gal :feature/javascript * fad3659 / README.md,src/interfaces/javascript_modular/CMakeLists.txt,index.js,package.json: https://github.com/shogun-toolbox/shogun/commit/fad3659a65c70ca281a38462a327176965c4f048 | 11:05 |
| shogun-notifier- | shogun: Add node and npm build | 11:05 |
| shogun-notifier- | shogun: Viktor Gal :feature/javascript * 84cb0e4 / src/shogun/neuralnets/DeepBeliefNetwork.h: https://github.com/shogun-toolbox/shogun/commit/84cb0e4d78e8fed3677513ff7c2fdf7d189ac828 | 11:05 |
| shogun-notifier- | shogun: fix include path for SGMatrixList in DeepBeliefNetwork | 11:05 |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has joined #shogun | 11:07 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 11:07 | |
| @wiking | HeikoS, buya | 11:09 |
| @HeikoS | wiking: jo! | 11:09 |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has quit [Quit: Leaving.] | 11:17 | |
| -!- travis-ci [~travis-ci@ec2-54-163-63-103.compute-1.amazonaws.com] has joined #shogun | 11:48 | |
| travis-ci | it's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/149124483 | 11:48 |
| -!- travis-ci [~travis-ci@ec2-54-163-63-103.compute-1.amazonaws.com] has left #shogun [] | 11:48 | |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has joined #shogun | 11:56 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 11:56 | |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has quit [Quit: Leaving.] | 12:12 | |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has joined #shogun | 13:00 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 13:00 | |
| -!- sanuj [~sanuj@61.0.30.105] has quit [Ping timeout: 252 seconds] | 13:01 | |
| -!- sanuj [~sanuj@61.0.30.105] has joined #shogun | 13:14 | |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has quit [Quit: Leaving.] | 13:43 | |
| -!- sanuj [~sanuj@61.0.30.105] has quit [Ping timeout: 265 seconds] | 13:51 | |
| -!- shogun-notifier- [~irker@7nn.de] has quit [Quit: transmission timeout] | 14:05 | |
| -!- sanuj [~sanuj@59.91.132.116] has joined #shogun | 14:10 | |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has joined #shogun | 14:21 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 14:21 | |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has quit [Quit: Leaving.] | 14:28 | |
| -!- sanuj [~sanuj@59.91.132.116] has quit [Ping timeout: 240 seconds] | 14:29 | |
| rcurtin | wiking: I'm here now, but only for a few minutes... I overslept and have to leave soon... oops | 15:15 |
| @wiking | rcurtin, the trick is | 15:18 |
| @wiking | i have no idea what i wanted to ask | 15:19 |
| @wiking | :D | 15:19 |
| @wiking | i'll try to think about it | 15:19 |
| rcurtin | ok :) | 15:19 |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has joined #shogun | 15:31 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 15:31 | |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has quit [Quit: Leaving.] | 16:07 | |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has joined #shogun | 16:50 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 16:50 | |
| -!- OXPHOS [4441a916@gateway/web/freenode/ip.68.65.169.22] has joined #shogun | 16:54 | |
| @wiking | OXPHOS, back to usa? | 16:55 |
| OXPHOS | wiking: hey yep | 16:57 |
| @HeikoS | OXPHOS: jojo | 17:10 |
| @HeikoS | Saurabh7: hi! | 17:10 |
| -!- shogun-notifier- [~irker@7nn.de] has joined #shogun | 17:21 | |
| shogun-notifier- | shogun: OXPHOS :feature/linalg_refactor * 3e9ceac / / (7 files): https://github.com/shogun-toolbox/shogun/commit/3e9ceace0ecd572956060ff612b2de0aaf7124bf | 17:21 |
| shogun-notifier- | shogun: linalg-sum_no_diag | 17:21 |
| shogun-notifier- | shogun: Heiko Strathmann :feature/linalg_refactor * 3e3e8e0 / / (7 files): https://github.com/shogun-toolbox/shogun/commit/3e3e8e052b2c7a8c2c00a8caf7fb30601906e293 | 17:21 |
| shogun-notifier- | shogun: Merge pull request #3400 from OXPHOS/linalg_sum | 17:21 |
| shogun-notifier- | shogun: | 17:21 |
| shogun-notifier- | shogun: LinalgRefactor - no_diag sum | 17:21 |
| -!- leagoetz [~leagoetz@nat-206-249.internal.eduroam.ucl.ac.uk] has joined #shogun | 17:22 | |
| -!- leagoetz [~leagoetz@nat-206-249.internal.eduroam.ucl.ac.uk] has quit [Client Quit] | 17:22 | |
| -!- sanuj [~sanuj@59.91.130.234] has joined #shogun | 17:32 | |
| sanuj | HeikoS, yo | 17:33 |
| sanuj | the plan is to not replace TParamter | 17:33 |
| @HeikoS | sanuj: | 17:33 |
| sanuj | just add tags parameter also | 17:33 |
| @HeikoS | I see | 17:33 |
| @HeikoS | yeah thats ok | 17:33 |
| @HeikoS | sanuj: btw | 17:33 |
| sanuj | to add a layer of new API | 17:33 |
| @HeikoS | remember our meeting? | 17:33 |
| sanuj | yeah | 17:34 |
| @HeikoS | the last shogun gsoc meeting | 17:34 |
| @HeikoS | there were some dates | 17:34 |
| @HeikoS | so you guys should wrap up soon | 17:34 |
| @HeikoS | to spend the rest of the time writing docs and peer review | 17:34 |
| sanuj | HeikoS, yes, see my timeline | 17:34 |
| @HeikoS | try to stop coding very soon | 17:34 |
| @HeikoS | cool | 17:34 |
| @HeikoS | just wanted to remind :) | 17:34 |
| @HeikoS | I will leave for a trip soon | 17:34 |
| @HeikoS | and not be back before end of GSoC | 17:34 |
| @HeikoS | wiking: will merge things and handle the admin | 17:35 |
| @HeikoS | I will check back in September what was the result :) | 17:35 |
| @HeikoS | but yeah, as said in the meeting, the docs are really really important for us | 17:35 |
| sanuj | HeikoS, where are you going? | 17:35 |
| sanuj | https://docs.google.com/document/d/1ZVV9KsHxpoj2G3HYYp-8MNjDpHVL0RGvj5hD0r03lgg/edit?usp=sharing | 17:35 |
| sanuj | HeikoS, i'll write good docs | 17:35 |
| sanuj | don't worry :D | 17:35 |
| @HeikoS | good! :) | 17:36 |
| @HeikoS | I think you got the hang of it by now! | 17:36 |
| @HeikoS | Looking fowrad to read things when back | 17:36 |
| sanuj | HeikoS, cool | 17:36 |
| @HeikoS | Saurabh7: same for your stuff! | 17:36 |
| sanuj | when are you leaving? | 17:36 |
| @HeikoS | now | 17:36 |
| sanuj | oh | 17:36 |
| sanuj | HeikoS, enjoy your trip!!! | 17:36 |
| sanuj | :D | 17:36 |
| @HeikoS | thanks a lot! :) | 17:37 |
| sanuj | HeikoS, can you give me ideas about this: https://github.com/shogun-toolbox/shogun/pull/3390 | 17:38 |
| @HeikoS | sanuj: https://travis-ci.org/shogun-toolbox/shogun/jobs/147142817#L2744 | 17:40 |
| @HeikoS | you can run the listing by hand | 17:40 |
| @HeikoS | ctest -R "testname" | 17:40 |
| @HeikoS | ah it doesnt even compile | 17:40 |
| @HeikoS | well look at the java code listing and see whats wrong | 17:40 |
| sanuj | HeikoS, i need some ideas about enum | 17:41 |
| sanuj | how to structure the tests? | 17:41 |
| @HeikoS | I they work in the existing meta examples dont they? | 17:41 |
| sanuj | HeikoS, yes they work | 17:41 |
| @HeikoS | it is ok like this | 17:41 |
| @HeikoS | do something that makes sense | 17:41 |
| @HeikoS | it should be both illustrating the meta language, and also serve as systematic testing of the constructs | 17:42 |
| sanuj | HeikoS, okay | 17:42 |
| @HeikoS | try to ask esben sorig | 17:42 |
| @HeikoS | he know what to do there | 17:42 |
| @HeikoS | and he might help a bit | 17:42 |
| @HeikoS | wiking or lisitsyn need to merge for now | 17:42 |
| sanuj | HeikoS, sure sure | 17:43 |
| @HeikoS | sanuj: ok man, take care | 17:44 |
| @HeikoS | bye! | 17:44 |
| sanuj | HeikoS, nice working with you too! :D | 17:45 |
| sanuj | have fun | 17:45 |
| @HeikoS | sanuj: thanks! :) and see you soon ! | 17:45 |
| sanuj | yep :D | 17:45 |
| sanuj | (on irc :P) | 17:45 |
| -!- HeikoS [~heiko@host-92-0-178-129.as43234.net] has quit [Remote host closed the connection] | 17:51 | |
| -!- OXPHOS [4441a916@gateway/web/freenode/ip.68.65.169.22] has quit [Ping timeout: 250 seconds] | 18:06 | |
| -!- OXPHOS [4441a916@gateway/web/freenode/ip.68.65.169.22] has joined #shogun | 18:09 | |
| -!- travis-ci [~travis-ci@ec2-54-163-72-166.compute-1.amazonaws.com] has joined #shogun | 18:10 | |
| travis-ci | it's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/149218049 | 18:10 |
| -!- travis-ci [~travis-ci@ec2-54-163-72-166.compute-1.amazonaws.com] has left #shogun [] | 18:10 | |
| Saurabh7 | hm looks like heiko was "back" | 18:38 |
| Saurabh7 | :D | 18:43 |
| -!- sanuj [~sanuj@59.91.130.234] has quit [Remote host closed the connection] | 19:33 | |
| -!- lambday [6a3311c4@gateway/web/freenode/ip.106.51.17.196] has joined #shogun | 20:01 | |
| -!- mode/#shogun [+o lambday] by ChanServ | 20:01 | |
| -!- shogun-notifier- [~irker@7nn.de] has quit [Quit: transmission timeout] | 20:21 | |
| -!- OXPHOS [4441a916@gateway/web/freenode/ip.68.65.169.22] has quit [Ping timeout: 250 seconds] | 21:15 | |
| --- Log closed Wed Aug 03 00:00:49 2016 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!