--- Log opened Thu Aug 04 00:00:51 2016 | ||
-!- OXPHOS [4441a916@gateway/web/freenode/ip.68.65.169.22] has joined #shogun | 01:50 | |
@wiking | OXPHOS, ping | 01:54 |
---|---|---|
OXPHOS | wiking: hey sgvector serialization should be working now. I just squashed | 01:54 |
@wiking | yeah i know | 01:54 |
@wiking | but i just replied :) | 01:55 |
@wiking | read it and if you are open to talk a bit | 01:55 |
@wiking | lets talk :) | 01:55 |
OXPHOS | wiking: kk | 01:55 |
OXPHOS | wiking: also I had problem fetching from shogun. I thought it was the network but seems not.. | 01:55 |
@wiking | fetching what? | 01:55 |
OXPHOS | Mac148934:shogun zora$ git fetch upstream | 01:55 |
OXPHOS | fatal: unable to connect to github.com: | 01:55 |
OXPHOS | github.com[0: 192.30.253.112]: errno=Operation timed out | 01:55 |
@wiking | aaah | 01:56 |
OXPHOS | wiking ^ | 01:56 |
@wiking | check status.github.com | 01:56 |
@wiking | ``` All systems operational ``` | 01:56 |
@wiking | but who knows... | 01:56 |
OXPHOS | wiking: I can fetch shogun-data | 01:56 |
OXPHOS | wiking: and I was experiencing the same problem ~12h ago.. | 01:56 |
@wiking | ping github on twitter | 01:57 |
@wiking | i bet they'll answer in no time :) | 01:57 |
OXPHOS | wiking: so it's their problem : ) lemme try | 01:57 |
@wiking | yep i mean all our code is on github | 01:58 |
@wiking | so yeah i cannot help | 01:58 |
OXPHOS | wiking: kk thx | 01:58 |
-!- shogun-notifier- [~irker@7nn.de] has joined #shogun | 02:07 | |
shogun-notifier- | shogun: christopher :develop * ade10a6 / / (4 files): https://github.com/shogun-toolbox/shogun/commit/ade10a677daadb798087b912fffd666ae508c2a2 | 02:07 |
shogun-notifier- | shogun: LARS float32 / floatmax support clean up | 02:07 |
shogun-notifier- | shogun: | 02:07 |
shogun-notifier- | shogun: Replacing if-SGERROR sets with REQUIRE statements | 02:07 |
shogun-notifier- | shogun: | 02:07 |
shogun-notifier- | shogun: Fixing memory leaks / implicit type conversion warnings | 02:07 |
shogun-notifier- | shogun: Viktor Gal :develop * ed1c24e / / (4 files): https://github.com/shogun-toolbox/shogun/commit/ed1c24e8c46197a412d7a11ac346786b1eb7ead1 | 02:07 |
shogun-notifier- | shogun: Merge pull request #3401 from c4goldsw/develop | 02:07 |
shogun-notifier- | shogun: | 02:07 |
shogun-notifier- | shogun: LARS float support cleanup patch (for PR #3133) | 02:07 |
shogun-buildbot | build #1319 of precise - libshogun is complete: Failure [failed compile] Build details are at http://buildbot.shogun-toolbox.org/builders/precise%20-%20libshogun/builds/1319 blamelist: Viktor Gal <vigsterkr@gmail.com>, christopher <christopher.goldsworthy@outlook.com> | 02:21 |
shogun-buildbot | build #2961 of bsd1 - libshogun is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/bsd1%20-%20libshogun/builds/2961 blamelist: Viktor Gal <vigsterkr@gmail.com>, christopher <christopher.goldsworthy@outlook.com> | 02:30 |
shogun-buildbot | build #98 of xenial - libshogun is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/xenial%20-%20libshogun/builds/98 blamelist: Viktor Gal <vigsterkr@gmail.com>, christopher <christopher.goldsworthy@outlook.com> | 02:31 |
@wiking | OXPHOS, | 02:46 |
@wiking | so the problem is we just cannot include cereal headers | 02:46 |
@wiking | unless we make cereal dependency a STRONG dependency | 02:46 |
OXPHOS | wiking: like Eigen? | 02:49 |
@wiking | well no not really | 02:49 |
@wiking | because in eigen the problem is solved internally | 02:49 |
@wiking | meaning that although we download eigen for building shogun | 02:49 |
@wiking | but we dont distribute it | 02:49 |
@wiking | because we compile the header related stuff into shogun | 02:50 |
@wiking | but what you are doing now is actually making the cereal dependency outside of shogun | 02:50 |
@wiking | imagine that you compile and install libshogun | 02:50 |
@wiking | (without the cereal headers) | 02:50 |
@wiking | i mean without having cereal on the system | 02:50 |
@wiking | then you'll download cereal to build libshogun | 02:51 |
@wiking | and then ...? | 02:51 |
@wiking | if the user creates a new example | 02:51 |
@wiking | in c++ where he uses shogun | 02:51 |
@wiking | he will not be able to compile it at all | 02:51 |
@wiking | because a) he doesn't have cereal installed on the system | 02:51 |
@wiking | b) the headers you used for shogun to compile are long gone | 02:52 |
@wiking | do you get what i'm trying to say here? | 02:52 |
@wiking | in eigen case things are all wrapped into .cpp | 02:52 |
OXPHOS | wiking: not sure..so they have to be moved away from .h files in shogun? | 02:54 |
@wiking | so yeah | 02:55 |
@wiking | basically the idea is | 02:55 |
@wiking | that if we cannot solve | 02:55 |
@wiking | not to include cereal headers | 02:55 |
@wiking | in our headers | 02:55 |
@wiking | then we have to make cereal a strong dependency | 02:55 |
@wiking | note: not having some type defined is fine, because those can be forward declared in headers | 02:56 |
@wiking | see the trick about Eigen in SGVector | 02:56 |
@wiking | (SGVector.h) | 02:56 |
OXPHOS | wiking: you mean the namespace Eigen{} stuff? | 02:57 |
@wiking | yes | 02:58 |
@wiking | that is all because | 02:58 |
@wiking | we do not want to include eigen related headers in our headers | 02:58 |
@wiking | only in cpp | 02:58 |
OXPHOS | wiking: not checked closely yet - but there's include <Eigen/xx> in mathematics/eigen3.h | 02:59 |
@wiking | :) | 02:59 |
@wiking | and where do we include eigen3.h? ?:) | 02:59 |
@wiking | i mean trust me | 03:00 |
@wiking | i know what i'm talking about ehre | 03:00 |
@wiking | :) | 03:00 |
@wiking | no need to check things like this | 03:00 |
OXPHOS | wiking: yeah i believe you are :) ..trying to make myself clear. so the goal is to move cereal stuff to .cpp | 03:01 |
@wiking | (btw you do realise that mathematics/eigen3.h is just a wrapper around Eigen/xxxx headers ) | 03:01 |
@wiking | but yeah the idea is that | 03:01 |
@wiking | in headers | 03:01 |
@wiking | that exposed to the public | 03:01 |
@wiking | (say not linalg related headers) | 03:01 |
@wiking | you should not include cereal headrs | 03:02 |
@wiking | only in definition | 03:02 |
@wiking | meaning cpp | 03:02 |
@wiking | if that's not solveable | 03:03 |
@wiking | we'll have to default to the idea | 03:03 |
@wiking | that we gonna make cereal a strong dependency | 03:03 |
@wiking | but let's try to concentrate now on the | 03:03 |
OXPHOS | okay..I think I got it | 03:03 |
@wiking | part where we could solve this | 03:03 |
@wiking | and btw yeah it all makes sense | 03:03 |
@wiking | why it was working for you on your machine | 03:03 |
@wiking | as i believe you have cereal installed on your system | 03:04 |
@wiking | while on travis it was using the internal cereal (fetching as the part of cmake build...) | 03:04 |
OXPHOS | I tried removed it - and it also worked..I guess some settings are different | 03:04 |
@wiking | mmm | 03:04 |
@wiking | it should not | 03:04 |
@wiking | :) | 03:04 |
@wiking | but ok | 03:04 |
@wiking | the problem is this definitely atm | 03:05 |
@wiking | that we act like we have cereal headers installed globally | 03:05 |
OXPHOS | yeah | 03:05 |
@wiking | where we fake it sometimes... | 03:05 |
OXPHOS | haha | 03:05 |
OXPHOS | wiking | 03:06 |
OXPHOS | thanks! | 03:06 |
OXPHOS | lemme work on it | 03:06 |
@wiking | nw thnx for looking at it | 03:06 |
@wiking | can you do rebases on some of the prs? | 03:06 |
@wiking | or github is not working for you atm? | 03:07 |
OXPHOS | wiking: not working - only fetch upstream is not working | 03:07 |
@wiking | can you copy paste the exact error lines? | 03:07 |
OXPHOS | wiking: 1 sec. it takes a while to know it's failed :) | 03:09 |
OXPHOS | wiking: http://pastebin.com/4MEQb63Q | 03:09 |
@wiking | can you | 03:10 |
@wiking | ping github.com | 03:10 |
@wiking | ? | 03:10 |
OXPHOS | wiking: PING github.com (192.30.253.113): 56 data bytes 64 bytes from 192.30.253.113: icmp_seq=0 ttl=52 time=68.613 ms | 03:12 |
OXPHOS | and so on.. | 03:12 |
@wiking | mmm yeah | 03:12 |
@wiking | ok try | 03:13 |
@wiking | nc | 03:13 |
@wiking | ok not this | 03:13 |
@wiking | but | 03:13 |
@wiking | nc -vz github.com 443 | 03:14 |
@wiking | and then | 03:14 |
@wiking | nc -vz 192.30.253.112 443 | 03:14 |
OXPHOS | wiking: http://pastebin.com/Dg5FBJtQ | 03:15 |
OXPHOS | wiking: succeeded | 03:15 |
@wiking | haha | 03:16 |
@wiking | cat shogun/.git/config | 03:16 |
OXPHOS | wiking: I should do it in dir upstream shogun right? | 03:18 |
OXPHOS | Mac148934:Github zora$ cd shogun/.git/config -bash: cd: shogun/.git/config: Not a directory | 03:18 |
@wiking | i mean within your shogun just do | 03:18 |
@wiking | cat .git/config | 03:18 |
-!- OXPHOS_ [4441a916@gateway/web/freenode/ip.68.65.169.22] has joined #shogun | 03:21 | |
-!- OXPHOS [4441a916@gateway/web/freenode/ip.68.65.169.22] has quit [Ping timeout: 250 seconds] | 03:22 | |
OXPHOS_ | wiking: sry my irc somehow got stuck.. | 03:22 |
@wiking | k | 03:23 |
OXPHOS_ | wiking: http://pastebin.com/m6c8bf1P | 03:23 |
@wiking | mmm | 03:23 |
@wiking | when have you added the upstream to your config? | 03:23 |
@wiking | was it ever working? | 03:24 |
@wiking | as i believe you dont have access rights to the upstream repo | 03:24 |
@wiking | [remote "upstream"] | 03:24 |
@wiking | url = git://github.com/shogun-toolbox/shogun.git | 03:24 |
@wiking | and this would only work in that case | 03:24 |
@wiking | you should edit your config | 03:24 |
@wiking | and use https | 03:24 |
@wiking | url = https://github.com/shogun-toolbox/shogun.git | 03:24 |
@wiking | and yeah that git thign was toootaly weird | 03:25 |
OXPHOS_ | what..I never touched it can I used it pretty frequently.. | 03:25 |
@wiking | because if then it should have been | 03:25 |
@wiking | git@github.com... | 03:25 |
@wiking | so i dont really know how this got into this state | 03:25 |
@wiking | but no wonder it's not working | 03:25 |
OXPHOS_ | wiking: haha thanks! it must be hacked..or maybe wired : / | 03:26 |
OXPHOS_ | wiking: it's back to work! | 03:28 |
@wiking | yep | 03:29 |
@wiking | so rebase now plz | 03:29 |
@wiking | :) | 03:29 |
OXPHOS_ | wiking: i'm running(checking) it at local now. I'll push once it's done. | 03:38 |
@wiking | k | 03:38 |
@wiking | htn | 03:38 |
@wiking | *thnx | 03:38 |
shogun-buildbot | build #1181 of nightly_default is complete: Failure [failed test notebooks] Build details are at http://buildbot.shogun-toolbox.org/builders/nightly_default/builds/1181 blamelist: Viktor Gal <vigsterkr@gmail.com>, christopher <christopher.goldsworthy@outlook.com> | 03:57 |
-!- OXPHOS_ [4441a916@gateway/web/freenode/ip.68.65.169.22] has quit [Ping timeout: 250 seconds] | 04:24 | |
-!- OXPHOS [4441a916@gateway/web/freenode/ip.68.65.169.22] has joined #shogun | 05:03 | |
-!- shogun-notifier- [~irker@7nn.de] has quit [Quit: transmission timeout] | 05:07 | |
shogun-buildbot | build #47 of FC23 - libshogun - aarch64 is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/FC23%20-%20libshogun%20-%20aarch64/builds/47 blamelist: Viktor Gal <vigsterkr@gmail.com>, christopher <christopher.goldsworthy@outlook.com> | 05:36 |
shogun-buildbot | build #53 of memleak - valgrind is complete: Failure [failed memory check] Build details are at http://buildbot.shogun-toolbox.org/builders/memleak%20-%20valgrind/builds/53 blamelist: Viktor Gal <vigsterkr@gmail.com>, christopher <christopher.goldsworthy@outlook.com> | 06:37 |
shogun-buildbot | build #1052 of nightly_none is complete: Failure [failed compile] Build details are at http://buildbot.shogun-toolbox.org/builders/nightly_none/builds/1052 blamelist: Viktor Gal <vigsterkr@gmail.com>, christopher <christopher.goldsworthy@outlook.com> | 06:40 |
-!- OXPHOS [4441a916@gateway/web/freenode/ip.68.65.169.22] has quit [Ping timeout: 250 seconds] | 08:32 | |
-!- leagoetz [~leagoetz@host-92-0-178-129.as43234.net] has joined #shogun | 10:06 | |
-!- leagoetz [~leagoetz@host-92-0-178-129.as43234.net] has quit [Remote host closed the connection] | 10:17 | |
@wiking | Saurabh7, ping | 10:41 |
-!- sanuj [~sanuj@117.203.13.13] has joined #shogun | 10:54 | |
sanuj | lisitsyn, wiking yo\ | 10:54 |
sanuj | lisitsyn, are you working on SG_ADD? | 10:54 |
lisitsyn | sanuj: yeah will spend some time on that today | 10:54 |
lisitsyn | didn't get time yesterday tho | 10:55 |
sanuj | lisitsyn, okay, how to make swig interfaces for shogun templates like SGVector? | 10:55 |
lisitsyn | not get it | 10:55 |
lisitsyn | we specialize sgvector for specific types | 10:56 |
sanuj | lisitsyn, shogun-base.i looks like this: https://gist.github.com/sanuj/a85986fb35052de761ac251496e90e90 | 10:56 |
lisitsyn | once specialized it is just some time | 10:56 |
lisitsyn | type | 10:56 |
sanuj | we had left the templates since you wanted to discuss with HekioS and wiking | 10:56 |
sanuj | lisitsyn, so i just do SGVector<blah> | 10:56 |
sanuj | ? | 10:56 |
lisitsyn | yeah I think so | 10:56 |
sanuj | even i think there is no way | 10:57 |
sanuj | lisitsyn, so i'll just do SGVector with some primitive types, just for demonstration | 10:57 |
lisitsyn | ok | 10:57 |
@wiking | ? | 10:59 |
@wiking | RealVector | 10:59 |
@wiking | is SGVector<float64_t> | 10:59 |
@wiking | etc. | 10:59 |
@wiking | i dont really understand the swig interface for shogun templates like sgvector Saurabh7 | 10:59 |
@wiking | sanuj: | 10:59 |
sanuj | wiking, yes yes | 11:00 |
@wiking | meaning? :) | 11:16 |
@wiking | we dont use SGVector for other types than primitive types | 11:17 |
@wiking | for none primitive types there are other data structs | 11:17 |
sanuj | wiking, i mean i got it now :) | 11:17 |
sanuj | had forgotten about RealVector etc | 11:18 |
@wiking | k | 11:19 |
-!- sanuj [~sanuj@117.203.13.13] has quit [Ping timeout: 252 seconds] | 13:52 | |
-!- sanuj [~sanuj@117.203.13.13] has joined #shogun | 13:53 | |
sanuj | lisitsyn, there? | 15:36 |
lisitsyn | sanuj: yeap | 15:36 |
-!- sanuj [~sanuj@117.203.13.13] has quit [Ping timeout: 252 seconds] | 15:40 | |
@wiking | :) | 15:42 |
@wiking | that was fast | 15:42 |
-!- sanuj [~sanuj@117.203.22.232] has joined #shogun | 17:19 | |
sanuj | wiking, yo | 17:48 |
@wiking | what's happening | 17:48 |
@wiking | :) | 17:48 |
sanuj | wiking, can you review this: https://github.com/shogun-toolbox/shogun/pull/3357 | 17:48 |
sanuj | i think it's done | 17:48 |
@wiking | k | 17:49 |
@wiking | checking | 17:49 |
sanuj | wiking, MockObject is also used for integration testing | 17:58 |
@wiking | dont care | 17:59 |
@wiking | :) | 17:59 |
@wiking | if it's for testing | 17:59 |
@wiking | then it's no place | 17:59 |
@wiking | for that in code created for runtime | 17:59 |
sanuj | wiking, so where do i put it then? | 18:00 |
@wiking | for tests | 18:00 |
@wiking | where ever they need to be | 18:00 |
@wiking | but not into a runtime | 18:00 |
@wiking | where you possibly not going to be using it | 18:00 |
@wiking | if you think there's no way you can solve it | 18:01 |
@wiking | tests for macros are still possible | 18:01 |
@wiking | although again i dont understand that why does a mock object | 18:01 |
@wiking | has to be in runtime | 18:01 |
sanuj | wiking, i am not clear what you mean by runtime? | 18:01 |
@wiking | src/interfaces/modular/SGBase.i | 18:02 |
sanuj | and MockObject is in SGBase.i so that it is available in python for integration tests | 18:02 |
@wiking | is something that will be created | 18:02 |
@wiking | no matter | 18:02 |
@wiking | if you do ever an integration test | 18:02 |
@wiking | or not | 18:02 |
@wiking | right? | 18:02 |
@wiking | i mean src/interfaces/modular/SGBase.i -> modshogun.i -> modshogun<interface>_wrap.cxx | 18:02 |
@wiking | -> swig SO library | 18:03 |
sanuj | yeah | 18:03 |
sanuj | wiking, it has to be in modshogun.i, one way or another | 18:03 |
@wiking | ok so if i'm user HailMerry | 18:03 |
@wiking | who just wanna use shogun | 18:03 |
@wiking | from python | 18:03 |
@wiking | do i need that? | 18:03 |
@wiking | mockobject? | 18:03 |
sanuj | no | 18:04 |
@wiking | ok | 18:04 |
sanuj | wiking, so only make it available when enable_testing=on? | 18:04 |
@wiking | now you understand? | 18:14 |
@wiking | yeah | 18:14 |
sanuj | wiking, yeah, so i only need to add some MACRO checks? | 18:14 |
sanuj | just confirming | 18:14 |
@wiking | idk if there's actually a C level MACRO when we are running tests :) | 18:15 |
sanuj | okay | 18:24 |
sanuj | wiking, TagRealVector and RealVector are different because TagX is used to identify an object of X by a name | 18:28 |
sanuj | shall i put this in modshogun.i? | 18:30 |
sanuj | +#ifdef HAVE_JINJA2 | 18:30 |
sanuj | +%include "shogun-base.i" | 18:30 |
sanuj | +#endif | 18:30 |
sanuj | instead of SGBase.i | 18:30 |
sanuj | wiking, by doing this, i can write this as | 18:30 |
sanuj | https://github.com/shogun-toolbox/shogun/pull/3357/files#diff-9096c96ee0cb9b5463c3fc420ed96b0aR12 | 18:31 |
sanuj | RealVector, RealVector* | 18:31 |
-!- sanuj [~sanuj@117.203.22.232] has quit [Remote host closed the connection] | 20:36 | |
--- Log closed Fri Aug 05 00:00:52 2016 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!