IRC logs of #shogun for Thursday, 2017-06-01

« Wednesday, 2017-05-31 Index Friday, 2017-06-02 »
--- Log opened Thu Jun 01 00:00:54 2017
-!- olinguyen [81615ad9@gateway/web/freenode/ip.129.97.90.217] has quit [Ping timeout: 260 seconds]02:23
mikelingwiking: what's these two functions for?https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/lib/DynamicObjectArray.h#L136-L15803:50
mikelingit looks like do something like setter03:50
mikelingbut the comment says it will return something?03:50
mikelinglike a getter?03:50
-!- olinguyen [81615ad9@gateway/web/freenode/ip.129.97.90.217] has joined #shogun04:42
-!- olinguyen [81615ad9@gateway/web/freenode/ip.129.97.90.217] has quit [Client Quit]04:43
-!- olinguyen [81615ad9@gateway/web/freenode/ip.129.97.90.217] has joined #shogun04:51
-!- olinguyen [81615ad9@gateway/web/freenode/ip.129.97.90.217] has quit [Quit: Page closed]06:48
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has joined #shogun08:35
@sukeyPull Request #3745 "Add PRange class to replace old SG_PROGRESS (WIP)"  synchronized by geektoni - https://github.com/shogun-toolbox/shogun/pull/374510:10
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has quit [Quit: Leaving.]11:10
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has joined #shogun11:16
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has quit [Client Quit]11:17
-!- iglesiasg [~iglesiasg@217.119.234.214] has joined #shogun11:21
-!- mode/#shogun [+o iglesiasg] by ChanServ11:21
@wikingmikeling, how's the std::vector going?12:05
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has joined #shogun12:44
@wikinggeektoni, hi13:20
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has quit [Ping timeout: 240 seconds]13:21
mikelingwiking: mmm, not good, have some problem :/ I'm trying to fix it right now14:28
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has joined #shogun14:28
mikelingI will create gist if I failed14:28
geektonihi wiking, sorry I was afk14:30
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has quit [Read error: Connection reset by peer]14:40
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has joined #shogun14:40
@wikinggeektoni, no worries... see my commments on the pr15:05
@wikingmikeling, ok lemme know if you need anything15:06
mikelingwiking: BTW, what's these two functions for?https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/lib/DynamicObjectArray.h#L136-L15815:06
mikelingit looks like do something like setter but the comment says it will return something? like a getter?15:07
geektoniwiking: working on them right now15:07
geektonidoes anybody know what can cause the Shogun build process to take up *at least* 2 GB of RAM only to compile a class like CustomKernel???15:27
geektoniThis is happening to me with the "develop" branch15:27
geektoniwiking ^15:42
@wikinggeektoni, are you compiling any interface?15:44
geektoninope15:44
@wikingand what's your CMAKE_BUILD_TYPE?15:44
geektoniDebug15:44
@wikingmmmm15:44
geektoniI mean, it happened out of nowhere15:45
@wikingyou mean it wasn't like that before?15:46
@wikingor that you've just noticed15:46
geektoniyesterday building was fine15:46
@wikingsome ccache fun? :)15:47
geektoniI tried to disable it15:47
geektonibut it seems it doesn't work15:48
geektonithis huuge consumption of RAM happens only with some files15:49
geektoninot all of the codebase15:49
mikelingwiking: Do we have auto ref issue for CDynamicArray?15:54
@sukeyPull Request #3824 "Replace DynArray with std::vector"  synchronized by MikeLing - https://github.com/shogun-toolbox/shogun/pull/382415:58
mikelingwiking: ping16:23
@wikingjust a sec16:23
mikelingnp16:25
@wikingmikeling, no there does not seemed to be any SG_REF going on there16:26
@wikingok i can check the serialization issue16:27
mikelingwiking: ok, then I will create another pr for replacing CDynamicArray with std::vector(maybe)16:27
mikelingso maybe we could merge that first then back to the DynArray replacement16:27
mikelingso I don't need to change those DynArray related code in CDynamicArray16:28
mikelinganyway, I need to solve the serialization problem first :)16:28
@wikingmmm16:28
@wikingbut CDynamicArray is coupled with DynArray16:29
@wikingright?16:29
mikelingyep16:29
mikelingCDynamicArray take advantage of DynArray in a lot of places16:30
mikelingso16:30
mikelingif i do the CDynamicArray replacement first16:30
mikelingI don't need to care about how CDynamicArray use DynArray inside16:30
mikelingafter we get rid of CDynamicArray, then it will be much easier to replace DynArray16:31
mikelingDo you agree with it?16:31
@wikingmmm and you think we could drop CDynamicArray16:45
@wikingand replace it with std::vector directly16:45
@wiking?16:45
@wikingwe cannot do that because template <class T> class CDynamicArray :public CSGObject16:46
@wikingyou can only replace that with std::vector16:46
@wikingif you use Some<std::vector>16:46
@wikingright?16:47
mikelingmmm, I haven't think that far16:47
mikeling:/16:47
@wikingbecause a) CDynamicArray is using parameter framework (see all the SG_ADD); this is due to the fact of to be able to serialize CDynamicArray b) CDynamicArray has reference counting as it is derived from CSGObject16:48
mikelingmmmm, I see16:49
@sukeyPull Request #3745 "Add PRange class to replace old SG_PROGRESS (WIP)"  synchronized by geektoni - https://github.com/shogun-toolbox/shogun/pull/374516:54
@wikinggeektoni, do we need a fix for clang-fromat?16:55
@wiking*clang-format16:55
@wikingsee https://travis-ci.org/shogun-toolbox/shogun/jobs/238246972#L49316:55
geektonino idea actually16:55
geektoniI don't understand why it fails16:56
geektonilocally works16:56
@wikingsame error unfortunately https://travis-ci.org/shogun-toolbox/shogun/jobs/238374498#L49416:57
@wikingmaybe git version differences?16:58
@wikinghave you tried to run that within the shogun-sdk docker container?16:58
geektoniyeah, I saw16:59
geektoniI'll try to replicate it with docker16:59
-!- olinguyen [81615ad9@gateway/web/freenode/ip.129.97.90.217] has joined #shogun17:17
-!- iglesiasg [~iglesiasg@217.119.234.214] has quit [Quit: leaving]17:22
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has quit [Ping timeout: 255 seconds]17:22
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has joined #shogun17:24
geektoniwiking: ok, docker gives the exact Travis error.18:10
geektoniit seems that it doesn't know that there is a remote feature/progress branch18:10
geektoniso the git command fails miserably18:11
@sukeyPull Request #3826 "Remove duplicate code in LDA/FisherLDA (WIP)"  opened by micmn - https://github.com/shogun-toolbox/shogun/pull/382618:26
@sukeyPull Request #3827 "Fix check_format.sh script when the destination branch is not develop."  opened by geektoni - https://github.com/shogun-toolbox/shogun/pull/382719:08
@sukeyPull Request #3827 "Fix check_format.sh script when the destination branch is not develop."  merged by vigsterkr - https://github.com/shogun-toolbox/shogun/pull/382720:34
@sukeyNew Commit "Merge pull request #3827 from geektoni/fix_clang_format_not_existent_branches20:34
@sukeyFix check_format.sh script when the destination branch is not develop." to shogun-toolbox/shogun by vigsterkr: https://github.com/shogun-toolbox/shogun/commit/bfe45d510a66d54feafed2e89a11d76e45696fdc20:34
@wikinggeektoni, i'll merge then now https://github.com/shogun-toolbox/shogun/pull/374520:37
@wikingok?20:37
geektoniok20:37
@sukeyPull Request #3745 "Add PRange class to replace old SG_PROGRESS (WIP)"  merged by vigsterkr - https://github.com/shogun-toolbox/shogun/pull/374520:38
@sukeyNew Commit "Merge pull request #3745 from geektoni/feature/progress20:38
@sukeyAdd PRange class to replace old SG_PROGRESS (WIP)" to shogun-toolbox/shogun by vigsterkr: https://github.com/shogun-toolbox/shogun/commit/8de270ba1eef3e8932cb9652f3c4324251cd20ce20:38
@wikingboom20:38
@wiking:)20:38
geektoni8-)20:38
-!- mikeling [uid89706@gateway/web/irccloud.com/x-aehloslmslxbmvge] has quit [Quit: Connection closed for inactivity]21:31
@sukeyPull Request #3826 "Remove duplicate code in LDA/FisherLDA (WIP)" - https://github.com/shogun-toolbox/shogun/pull/382622:02
@sukeyPull Request #3828 "[ProgressBar] Add multi threaded progress bar."  opened by geektoni - https://github.com/shogun-toolbox/shogun/pull/382822:08
-!- geektoni [~geektoni@93-34-234-212.ip52.fastwebnet.it] has left #shogun []22:10
-!- travis-ci [~travis-ci@ec2-54-147-189-183.compute-1.amazonaws.com] has joined #shogun22:18
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/23845634822:18
-!- travis-ci [~travis-ci@ec2-54-147-189-183.compute-1.amazonaws.com] has left #shogun []22:18
--- Log closed Fri Jun 02 00:00:55 2017
« Wednesday, 2017-05-31 Index Friday, 2017-06-02 »

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!