| --- Log opened Sat Jun 24 00:00:26 2017 | ||
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3858 synchronized by geektoni | 00:24 |
|---|---|---|
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3751 synchronized by micmn | 00:49 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3750 closed by micmn | 00:50 |
| -!- TingMiao [uid229534@gateway/web/irccloud.com/x-bhbuvmdyizfzugrh] has quit [Quit: Connection closed for inactivity] | 00:53 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3860 vigsterkr added label: "entrance" | 05:28 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3860 vigsterkr added label: "memory problems" | 05:28 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3860 vigsterkr added label: "BUG" | 05:28 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3860 opened by vigsterkr | 05:28 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3860 vigsterkr added label: "bugfixing" | 05:28 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3861 opened by vigsterkr | 05:31 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3862 vigsterkr added label: "bugfixing" | 05:32 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3862 opened by vigsterkr | 05:32 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3862 vigsterkr added label: "BUG" | 05:32 |
| @wiking | lisitsyn, ping ping | 07:59 |
| -!- geektoni [~geektoni@93-34-128-38.ip49.fastwebnet.it] has joined #shogun | 09:45 | |
| @wiking | geektoni, hey | 09:45 |
| @wiking | geektoni, it's weeend :) | 09:45 |
| @wiking | *weekend | 09:45 |
| geektoni | hi wiking. yeah, I know ;) but I want to address your comments before next week. | 09:46 |
| @wiking | heheh | 09:46 |
| @wiking | ok | 09:46 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/cf1f846a210ed9da4aaafb5f4760f3fb69c43ace by vigsterkr | 10:52 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/c59e42de6e728e082c818569f4fa1a282c8e3cdb by vigsterkr | 10:58 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/2252d06e2a06dceeaa9528e3b772be34aa823034 by vigsterkr | 11:06 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3859 synchronized by MikeLing | 11:18 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3859 synchronized by MikeLing | 11:34 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3863 opened by micmn | 11:41 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/4854bd6370d8e505d6c8fba51894a9930309e38a by vigsterkr | 11:45 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3860 closed by vigsterkr | 11:47 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3863 merged by vigsterkr | 11:47 |
| @sukey | [https://github.com/shogun-toolbox/shogun] vigsterkr pushed 2 commits: | 11:47 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/1e8ab8f9656c5b2083a92ff049d013af0bbabe09 | 11:47 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/e87649f67698996bbd512b17c92edaefe5397860 | 11:47 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3751 synchronized by micmn | 13:07 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3858 synchronized by geektoni | 13:11 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/140a8eb77cfcd523711274789d4e5d6b5f30bd52 by vigsterkr | 13:30 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3843 synchronized by micmn | 13:33 |
| micmn | wiking: ping | 13:48 |
| @wiking | pong | 13:48 |
| micmn | what's the point of having a singleton with AddGlobalTestEnvironment? | 13:49 |
| micmn | https://github.com/micmn/shogun/blob/41f2ca4995d517c0729363e0f854bddb03af997c/tests/unit/base/main_unittest.cc#L74 | 13:49 |
| micmn | https://github.com/micmn/shogun/blob/41f2ca4995d517c0729363e0f854bddb03af997c/tests/unit/environments/LinearTestEnvironment.h#L52 | 13:49 |
| @wiking | eeeeeeeeeeeeeeeeeeeeeeee | 13:51 |
| @wiking | micmn, i wonder why it doesn't even follow | 13:55 |
| @wiking | the override of virtual void SetUp() and virtual void TearDown() | 13:55 |
| @wiking | :< | 13:55 |
| micmn | yep, I was writing the regression env and stumbled into this | 13:56 |
| @wiking | yeah plz fix it | 13:56 |
| micmn | it's a mix of singleton and gtest env | 13:56 |
| @wiking | and mea culpa for merging these :( | 13:56 |
| @wiking | yeah i can see that | 13:56 |
| @wiking | :((( | 13:56 |
| micmn | yeah you have too many to do :P | 13:58 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3858 synchronized by geektoni | 13:58 |
| @wiking | sukey, flip | 14:09 |
| @sukey | (/ .□.) ︵╰(゜Д゜)╯︵ /(.□. ) | 14:09 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3844 closed by vigsterkr | 14:22 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3844 reopened by vigsterkr | 14:25 |
| -!- geektoni [~geektoni@93-34-128-38.ip49.fastwebnet.it] has quit [Quit: Leaving.] | 14:34 | |
| -!- TingMiao [uid229534@gateway/web/irccloud.com/x-zmqavftcpyclebqv] has joined #shogun | 16:47 | |
| -!- mikeling [uid89706@gateway/web/irccloud.com/x-rjocwogybngdeeuj] has joined #shogun | 17:23 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3864 opened by micmn | 17:34 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3864 synchronized by micmn | 17:58 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/3864 merged by vigsterkr | 19:05 |
| @sukey | [https://github.com/shogun-toolbox/shogun] vigsterkr pushed 2 commits: | 19:05 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/ca5a503363a84493d51a0ef7b57ef3c97c49dc33 | 19:05 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/0d87fbd80a8f1c98ca652f2c21dad5f85218c513 | 19:05 |
| shogun-buildbot | build #249 of deb1 - libshogun is complete: Failure [failed test] Build details are at http://buildbot.shogun-toolbox.org/builders/deb1%20-%20libshogun/builds/249 blamelist: Michele Mazzoni <mic.mazzoni@gmail.com>, Viktor Gal <vigsterkr@gmail.com> | 19:08 |
| micmn | wiking, mikeling: SVMOcas fails :S | 19:13 |
| mikeling | micmn: mmm, you mean it will fails randomly or? | 19:16 |
| mikeling | because I found nothing shows up on co | 19:16 |
| mikeling | ci | 19:16 |
| micmn | buildbot | 19:16 |
| micmn | http://buildbot.shogun-toolbox.org/builders/deb1%20-%20libshogun/builds/249/steps/test/logs/stdio | 19:17 |
| mikeling | micmn: oh, I see. BTW, had you read this comment by Heikos in https://github.com/shogun-toolbox/shogun/pull/3812#pullrequestreview-45765041? | 19:19 |
| micmn | which one? | 19:20 |
| micmn | ah i see | 19:20 |
| mikeling | It about to restrict Gaussian output and make the data will be linearly separable every time | 19:20 |
| micmn | yeah | 19:21 |
| micmn | are you working on that? | 19:21 |
| mikeling | no, haven't yet | 19:22 |
| mikeling | BTW, I found this https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/features/DataGenerator.cpp#L32 in CDataGenerator | 19:22 |
| mikeling | isn't it the same thing we are going to use in the fixture? | 19:23 |
| mikeling | or? | 19:23 |
| mikeling | I'm not sure about that either :) | 19:23 |
| micmn | let me see | 19:23 |
| micmn | btw isn't a bit late over there? :P | 19:23 |
| mikeling | it's 1:30 am if you are talking about the time right now :) | 19:25 |
| micmn | yep :p | 19:26 |
| micmn | generate_checkboard_data seems useful | 19:26 |
| micmn | since you can control class overlap | 19:27 |
| mikeling | mmm, so maybe we could just use it directly :P | 19:27 |
| mikeling | wiking Herikos^ | 19:28 |
| -!- travis-ci [~travis-ci@ec2-50-16-14-196.compute-1.amazonaws.com] has joined #shogun | 19:29 | |
| travis-ci | it's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/246590421 | 19:29 |
| -!- travis-ci [~travis-ci@ec2-50-16-14-196.compute-1.amazonaws.com] has left #shogun [] | 19:29 | |
| mikeling | micmn:I should read all the functions carefully before I start working on that issue. | 19:30 |
| mikeling | sorry for misleading you to the wrong direction in the beginning | 19:30 |
| micmn | oh don't worry I guess we learn both from these things | 19:31 |
| mikeling | micmn: ;) | 19:33 |
| mikeling | micmn So, actually I'm working on the CRandom issue. The things I do basically is going to remove the global random which is sg_rng | 19:35 |
| mikeling | wiking: micmn but really makes me headache thing is its usage in unittest like https://github.com/shogun-toolbox/shogun/blob/develop/tests/unit/neuralnets/DeepBeliefNetwork_unittest.cc#L44 | 19:36 |
| micmn | why? | 19:37 |
| mikeling | it will given a seed to random generator | 19:38 |
| mikeling | but the DeepBeliefNetwork won't actually use that random generator | 19:38 |
| micmn | https://github.com/shogun-toolbox/shogun/blob/develop/tests/unit/neuralnets/DeepBeliefNetwork_unittest.cc#L57 ? | 19:39 |
| mikeling | micmn: how about this https://github.com/shogun-toolbox/shogun/blob/develop/tests/unit/neuralnets/NeuralNetwork_unittest.cc#L312 | 19:40 |
| micmn | mmm isn't neural networks initialization random? | 19:41 |
| mikeling | yes, it is. mmm, maybe I should add a set_seed() function in neural networks | 19:44 |
| mikeling | ok, I found it. Thank you micmn :) | 19:46 |
| micmn | i.e. https://github.com/micmn/shogun/blob/7339764920061d35581287f2483c24cc6187901e/src/shogun/neuralnets/NeuralLinearLayer.cpp#L61-L61 | 19:46 |
| micmn | np | 19:46 |
| micmn | btw which is the reason to remove these CRandom::seed() in unit tests? | 19:47 |
| mikeling | micmn: mmm, you mean CMath::init_random()? | 19:54 |
| mikeling | because we are going to remove the global random in https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/mathematics/Math.h#L127 | 19:56 |
| mikeling | s/in/like | 19:56 |
| mikeling | so we no longer need random functions in CMath | 19:57 |
| micmn | ah! | 19:59 |
| micmn | and how you'll generate random numbers then? | 20:00 |
| mikeling | we will introduce an variable named m_rng in SGObject | 20:02 |
| mikeling | and then use it inside | 20:02 |
| mikeling | it's a CRandom object | 20:02 |
| micmn | so each object has its rng? | 20:03 |
| micmn | and you'll do i.e. m_rng->random(0,1) | 20:04 |
| mikeling | the only problem is the CRandom is inherited from SGObject, so basically it will be a pointer like CRandom* | 20:04 |
| mikeling | yep | 20:04 |
| micmn | ok got it thx :) | 20:04 |
| mikeling | np ;) | 20:05 |
| -!- mikeling [uid89706@gateway/web/irccloud.com/x-rjocwogybngdeeuj] has quit [Quit: Connection closed for inactivity] | 22:58 | |
| --- Log closed Sun Jun 25 00:00:28 2017 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!