--- Log opened Tue Aug 01 00:00:20 2017 | ||
-!- olinguyen [81615ad9@gateway/web/freenode/ip.129.97.90.217] has quit [Quit: Page closed] | 04:14 | |
-!- https_GK1wmSU [~deep-book@77.234.42.183] has joined #shogun | 05:23 | |
-!- https_GK1wmSU [~deep-book@77.234.42.183] has left #shogun [] | 05:25 | |
-!- HeikoS [~heiko@host81-156-3-58.range81-156.btcentralplus.com] has joined #shogun | 11:27 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 11:27 | |
-!- HeikoS [~heiko@host81-156-3-58.range81-156.btcentralplus.com] has quit [Ping timeout: 260 seconds] | 11:36 | |
-!- HeikoS [~heiko@host81-156-3-58.range81-156.btcentralplus.com] has joined #shogun | 11:51 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 11:51 | |
-!- HeikoS [~heiko@host81-156-3-58.range81-156.btcentralplus.com] has quit [Ping timeout: 260 seconds] | 12:18 | |
-!- HeikoS [~heiko@host81-156-3-58.range81-156.btcentralplus.com] has joined #shogun | 12:32 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 12:32 | |
-!- HeikoS [~heiko@host81-156-3-58.range81-156.btcentralplus.com] has quit [Ping timeout: 255 seconds] | 12:38 | |
-!- HeikoS [~heiko@host81-156-3-58.range81-156.btcentralplus.com] has joined #shogun | 12:53 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 12:53 | |
-!- HeikoS [~heiko@host81-156-3-58.range81-156.btcentralplus.com] has quit [Ping timeout: 260 seconds] | 13:18 | |
-!- HeikoS [~heiko@host81-158-94-210.range81-158.btcentralplus.com] has joined #shogun | 13:33 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 13:33 | |
-!- HeikoS [~heiko@host81-158-94-210.range81-158.btcentralplus.com] has quit [Ping timeout: 248 seconds] | 13:57 | |
-!- HeikoS [~heiko@82-132-222-116.dab.02.net] has joined #shogun | 15:19 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 15:19 | |
-!- HeikoS [~heiko@82-132-222-116.dab.02.net] has quit [Ping timeout: 240 seconds] | 15:37 | |
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has joined #shogun | 16:17 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 16:17 | |
@HeikoS | micmn: hey | 16:28 |
---|---|---|
micmn | HeikoS: hey | 16:54 |
@HeikoS | micmn: I dont understand the "some" vs "Some" | 17:29 |
@HeikoS | can you enlighten me there? :D | 17:29 |
micmn | did you see this? https://github.com/shogun-toolbox/shogun/pull/3942#discussion_r130633442 | 17:30 |
@HeikoS | yeah saw your comment re wrap | 17:30 |
@HeikoS | wrap is to do reference counting on returned SGObject | 17:30 |
@HeikoS | but yeah maybe I am not on the latest state with that stuff | 17:30 |
@HeikoS | if Some work and doenst leak | 17:30 |
@HeikoS | it is fine :) | 17:30 |
@HeikoS | micmn: shall I merge that PR? | 17:30 |
micmn | wrap works too | 17:31 |
micmn | I'll address your latest comments | 17:31 |
micmn | then you can merge :P | 17:31 |
micmn | some creates an instance of the class | 17:32 |
micmn | but in this case the instance is returned from apply() | 17:33 |
micmn | (I mean the instance is created inside apply and the pointer returned) | 17:33 |
micmn | so wrap seems more appropriate | 17:33 |
@HeikoS | cool! | 17:54 |
@HeikoS | ping me when I shall merge | 17:54 |
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has quit [Ping timeout: 258 seconds] | 19:46 | |
-!- olinguyen [81615ad9@gateway/web/freenode/ip.129.97.90.217] has joined #shogun | 22:11 | |
--- Log closed Wed Aug 02 00:00:21 2017 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!