IRC logs of #shogun for Sunday, 2018-01-07

« Saturday, 2018-01-06 Index Monday, 2018-01-08 »
--- Log opened Sun Jan 07 00:00:09 2018
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun00:52
-!- mode/#shogun [+o HeikoS] by ChanServ00:52
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 240 seconds]01:23
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun01:26
-!- mode/#shogun [+o HeikoS] by ChanServ01:26
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 252 seconds]01:32
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4055 synchronized by dgkim536006:29
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4055 synchronized by dgkim536006:35
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4055 synchronized by dgkim536006:38
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun11:15
-!- mode/#shogun [+o HeikoS] by ChanServ11:15
@HeikoSlisitsyn:  jo11:20
lisitsynHeikoS: hey11:21
@HeikoSlisitsyn: have a question11:21
@HeikoSabout this equals stuff11:21
lisitsynyeah11:21
@HeikoSI ran into the implementation for sparse vector11:21
lisitsyngood stuff :)11:21
lisitsynaha11:21
@HeikoS"comparison not implemented for sparse vectors"11:21
lisitsynah11:21
lisitsynyeah I put it there11:22
@HeikoSand I noticed that equals method takes two arguments11:22
@HeikoSoperator==(const SGSparseVector<T>& lhs, const SGSparseVector<T>& rhs)11:22
lisitsynyes11:22
@HeikoSwhereas the ones for SGMatrix take only one since it is a class method11:22
lisitsynyeah11:22
@HeikoSwhy?11:22
lisitsynfirst one is a global function11:22
@HeikoSdoes it have to do with the order in which available methods are checked?11:22
@HeikoSokok11:23
lisitsynyeah global function is first11:23
lisitsynI think11:23
@HeikoSbut I can make it a member function as well right?11:23
lisitsynyeah sure11:23
@HeikoSlisitsyn: and I also will need an equals method11:23
@HeikoSand then this is tried first I guess11:23
lisitsyn->equals then .equals then ==11:24
@HeikoSok11:24
@HeikoSthats what I figured11:25
@HeikoSI almost got things working11:25
@HeikoSman11:25
@HeikoSso much deleted code you have no idea :D11:25
lisitsyndid you find a way with add_vector thing?11:25
lisitsynHeikoS: almost is like a few tests or? :)11:27
@HeikoSlisitsyn: yes few tests11:27
@HeikoSadd vector thing is tricly11:27
@HeikoSneed to think a bit11:27
@HeikoSbut can fix that11:27
@HeikoSfor now I disabled tests11:27
@HeikoSwhich means that everything where SG_ADD is not used is not serializable11:27
@HeikoSbut that is fine11:27
@HeikoSas long as the trained model serialization tests work11:27
lisitsynwell you can just put watch_param right next to add_vector11:27
lisitsyncan't you?11:28
@HeikoSI dont care if our DynamicObjectArray is not serializable11:28
@HeikoSlisitsyn: the thing there is that11:28
@HeikoSnot all of the array is registered11:28
@HeikoSonly the parts that are used11:28
@HeikoSso need another member variable11:28
lisitsynah yeah so you need a wrapper11:28
@HeikoSyep11:28
@HeikoSbut the type is not basic11:28
@HeikoSso SGVector wont really do it11:28
@HeikoSmaybe it does11:28
lisitsynyeah you need some MemoryArea11:28
@HeikoSI will check this later11:28
@HeikoSexactly11:28
lisitsynHeikoS: I think we need a base class for SGVector<T>, SGMatrix<T> blabla11:29
lisitsynwhich is untyped11:29
@HeikoSyep11:30
lisitsynruntime-typed I mean11:30
@HeikoSthat would solve this problem11:30
@HeikoSbut maybe it is not needed11:30
@HeikoSsince this DynArray stuff goes anyways11:30
lisitsynah no it's a different story11:30
@HeikoSand we dont reall yhave vectors of complex things in many places11:30
lisitsynin that AnyVisitor11:30
lisitsynwe have to implement for <int8> blabla11:30
lisitsynwe could avoid that if we had 'Tensor'11:30
@HeikoSah11:31
@HeikoSok11:31
@HeikoSI have to run now, but will be back later11:31
lisitsynsee you11:31
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 248 seconds]11:36
-!- gaurav_ [0e8bc409@gateway/web/freenode/ip.14.139.196.9] has joined #shogun14:59
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun16:48
-!- mode/#shogun [+o HeikoS] by ChanServ16:48
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 248 seconds]17:10
-!- gaurav_ [0e8bc409@gateway/web/freenode/ip.14.139.196.9] has quit [Ping timeout: 260 seconds]17:19
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun17:21
-!- mode/#shogun [+o HeikoS] by ChanServ17:21
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 265 seconds]17:28
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun17:33
-!- mode/#shogun [+o HeikoS] by ChanServ17:33
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 240 seconds]17:57
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun18:01
-!- mode/#shogun [+o HeikoS] by ChanServ18:01
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Quit: Leaving.]18:06
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun18:07
-!- mode/#shogun [+o HeikoS] by ChanServ18:07
-!- travis-ci [~travis-ci@ec2-54-196-25-80.compute-1.amazonaws.com] has joined #shogun18:13
travis-ciit's salonirk11's turn to pay the next round of drinks for the massacre he caused in salonirk11/shogun: https://travis-ci.org/salonirk11/shogun/builds/32607581018:13
-!- travis-ci [~travis-ci@ec2-54-196-25-80.compute-1.amazonaws.com] has left #shogun []18:13
@HeikoSlisitsyn:  jo18:47
lisitsynhey18:48
@HeikoSauto obj = some<CMockObject>();18:48
@HeikoSSome<CMockObject> other_obj = some<CMockObject>();18:48
@HeikoSEXPECT_EQ(other_obj->ref_count(), 1);18:48
@HeikoSobj->put("watched_object", dynamic_cast<CSGObject*>(other_obj.get()));18:48
@HeikoSEXPECT_EQ(other_obj->ref_count(), 2);18:48
@HeikoSEXPECT_TRUE(other_obj->equals(obj));18:48
@HeikoSobj = nullptr;18:48
@HeikoSEXPECT_EQ(other_obj->ref_count(), 1);18:48
@HeikoSdoesnt make sense to me18:48
lisitsynwhy so?18:48
@HeikoShere is the debug output18:48
@HeikoS[DEBUG] Comparing parameter MockObject::float of type double.18:49
@HeikoS[DEBUG] Comparing using lhs==rhs.18:49
@HeikoS[DEBUG] Comparing parameter MockObject::int of type int.18:49
@HeikoS[DEBUG] Comparing using lhs==rhs.18:49
@HeikoS[DEBUG] Comparing parameter MockObject::vector of type shogun::SGVector<double>.18:49
@HeikoS[DEBUG] Comparing using lhs.equals(rhs).18:49
@HeikoS[DEBUG] Comparing parameter MockObject::watched_int of type int.18:49
@HeikoS[DEBUG] Comparing using lhs==rhs.18:49
@HeikoS[DEBUG] Comparing parameter MockObject::watched_object of type shogun::CSGObject*.18:49
@HeikoS[DEBUG] Comparing using lhs->equals(rhs).18:49
@HeikoS[DEBUG] Own parameter MockObject::watched_object=null different from provided=MockObject::watched_object=MockObject(...)18:49
-!- travis-ci [~travis-ci@ec2-54-196-25-80.compute-1.amazonaws.com] has joined #shogun18:49
travis-ciit's salonirk11's turn to pay the next round of drinks for the massacre he caused in salonirk11/shogun: https://travis-ci.org/salonirk11/shogun/builds/32607581018:49
-!- travis-ci [~travis-ci@ec2-54-196-25-80.compute-1.amazonaws.com] has left #shogun []18:49
@HeikoSso you see there that other_obj::watched_object is null18:49
@HeikoSwhich kinda makes sense to me from the code18:49
@HeikoSi.e. equals fails where it is asserted true18:50
lisitsynah so you're talking about equals18:50
lisitsynit should not be true18:50
@HeikoSok18:51
@HeikoSI will change the test then18:51
lisitsynyeah sure18:51
@HeikoS(it used to be true)18:51
lisitsynHeikoS: what I wanted to test is refcounts18:52
@HeikoSi see18:52
@HeikoSthat was the last test18:52
@HeikoSupdating PR18:52
lisitsynno idea about equals why I put it here18:52
lisitsynyikes!18:52
lisitsynthat was fast18:52
lisitsyn:)18:52
lisitsynHeikoS: we have terrible segfault on mac I have no idea how to fix :D18:52
lisitsynimport shogun -> kaboom18:53
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4069 synchronized by karlnapf18:53
@HeikoSlisitsyn: check out the amount of deleted code :D18:54
lisitsynchecking18:54
@HeikoSlisitsyn: that is usually a version mispatch of python lib18:54
lisitsynHeikoS: not in my case18:54
lisitsynI compiled against conda18:54
lisitsynhttps://github.com/shogun-toolbox/shogun/issues/406818:55
@HeikoSi have had weird issues when compiling against conda myself18:55
@HeikoSlocally I mean18:55
@HeikoSonly could make it work when using a docker image with only conda18:56
@HeikoSsome weird ld conflicts18:56
@HeikoSbut didnt dive into it18:56
lisitsynHeikoS: I think it used to work but something changed18:57
@HeikoSok wow18:57
lisitsynHeikoS: huge pr :)18:57
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4070 opened by Sahil33318:59
sukey1[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4071 opened by karlnapf19:00
sukey1[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4071 karlnapf added label: "development tasks"19:00
sukey1[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4071 karlnapf added label: "good first issue"19:00
@HeikoSlisitsyn: yep :)19:00
@HeikoScheck the SGObject.cpp19:00
@HeikoSthat is the main thing, the rest is some clean up stuff19:00
@HeikoSI can remove the "removing code" parts19:00
lisitsynHeikoS: what next?19:02
@HeikoSclone19:02
@HeikoScereal19:02
lisitsynok clone19:02
@HeikoSand remiving more code19:02
@HeikoSclone will be a very similar story to equals in fact19:02
@HeikoSneed to make any clonable (if it is not yet)19:02
@HeikoSand therefore the SG* types as well19:02
lisitsynit is19:03
@HeikoSand for primitives we can use =19:03
@HeikoSlisitsyn: then implementing clone should be a quick one19:03
lisitsynyeah just iterate over map and assign19:03
@HeikoSyep19:03
@HeikoSwanna do it=?19:03
lisitsynno, wanted to add vector/matrix to swig19:03
lisitsyn:)19:03
lisitsynbut why not19:04
lisitsynlet me try19:04
@HeikoSno the ndo that19:04
@HeikoSI can do clone19:04
@HeikoSI am in there already19:04
lisitsynok19:04
@HeikoSlisitsyn: question19:05
@HeikoSwe had this "accuracy" parameter in equals19:05
@HeikoSsince xml serialization is lossy19:05
@HeikoSI removed it now19:05
@HeikoSsince otherwise need to pass it downstream to your any19:05
@HeikoSwhich would be annoying, or?19:06
lisitsynwhy xml is lossy?19:06
@HeikoSSerializationXML_unittest.junja219:06
@HeikoSour implementation only does 1e-1419:06
@HeikoSdont ask me why19:06
lisitsynI'd better fix xml then19:06
@HeikoSsame for ascii19:07
lisitsynmeh19:07
@HeikoSok ill kill that accuracy guy19:07
@HeikoSpointless in my eyes19:07
lisitsynyeah it is like a hack19:07
lisitsynHeikoS: git clang-format-3.8 --commit 6f1fd162892988e212b5ddfc6de15db3a8bf1026 --binary /usr/bin/clang-format-3.819:09
lisitsyn:)19:09
@HeikoSyeah Ill do that19:09
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4069 synchronized by karlnapf19:10
@HeikoShow to do it now?19:10
@HeikoSafter having updated19:10
lisitsyn?19:10
lisitsyndo what?19:10
@HeikoSsame thing? reformat19:11
lisitsynif you run the command it changes the files19:11
lisitsynand you commit19:11
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4069 synchronized by karlnapf19:12
@HeikoSdone19:12
@HeikoSok I am off now19:12
@HeikoSthanks!19:12
lisitsynok I will kill the builds19:12
@HeikoSlisitsyn: let's see how travis likes it19:12
lisitsynso that only latest runs19:12
@HeikoSfeel free to merge if it works19:12
lisitsynokie19:12
@HeikoSI changed the "trained models" tests as well19:12
@HeikoSthey had accuracy 1e-719:12
@HeikoSgnaaaa19:12
@HeikoSmight have to disable until we fix cereal and have reliable serialization ....19:13
@HeikoSanyways...signing off19:13
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 265 seconds]19:18
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun19:37
-!- mode/#shogun [+o HeikoS] by ChanServ19:37
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 240 seconds]19:43
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun19:47
-!- mode/#shogun [+o HeikoS] by ChanServ19:47
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4069 synchronized by karlnapf19:50
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 256 seconds]19:56
sukey1[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4072 opened by lisitsyn20:09
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun23:19
-!- mode/#shogun [+o HeikoS] by ChanServ23:19
@HeikoSlisitsyn: still there23:21
@HeikoS?23:21
@HeikoShttps://travis-ci.org/shogun-toolbox/shogun/jobs/326113679#L933523:21
lisitsynHeikoS: yeah23:22
lisitsynhaving sexy time with segfault23:22
@HeikoSI was wondering23:22
@HeikoSwhat if we gave every SGObject an epsilon?23:22
@HeikoSthat is used for equals23:22
@HeikoSlike get_global_io()23:22
@HeikoSthen the accuracy is not a parameter in all the comparison calls, but rather a state of the object23:22
@HeikoS(not registered state)23:23
@HeikoSjust has a default parameter, and one can change that if accuracy should change23:23
lisitsynHeikoS: yeah but I'd go with a global constant23:23
@HeikoSobj->set_equal_accuracy(1e-7);23:23
@HeikoSobj->equals(other);23:23
@HeikoSor that23:23
@HeikoSall floating point equals then have to respect that23:24
@HeikoSSG* and SGObject...23:24
lisitsyndo we really need to customize it often?23:24
@HeikoSthe thing https://github.com/shogun-toolbox/shogun/pull/4069/commits/d9e377d5ef55f46b27273ff19b877bb918ae6edb23:24
@HeikoSthese were the places23:25
@HeikoSall of these were set because tests were failing23:25
@HeikoSi think travis just doesnt catch all of them23:25
@HeikoSIll make a global constant for that23:25
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Ping timeout: 248 seconds]23:33
--- Log closed Mon Jan 08 00:00:10 2018
« Saturday, 2018-01-06 Index Monday, 2018-01-08 »

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!