--- Log opened Sun Jan 14 00:00:18 2018 | ||
-shogun-buildbot:#shogun- Build coverity analysis #22 is complete: Failure [failed update shogun (failure)] - http://buildbot.shogun-toolbox.org:8080/#builders/7/builds/22 | 08:00 | |
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun | 10:29 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 10:30 | |
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Quit: Leaving.] | 11:51 | |
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun | 11:53 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 11:53 | |
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Client Quit] | 11:54 | |
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has joined #shogun | 11:58 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 11:59 | |
-!- HeikoS [~heiko@host213-122-246-7.range213-122.btcentralplus.com] has quit [Client Quit] | 12:01 | |
-!- travis-ci [~travis-ci@ec2-54-221-113-180.compute-1.amazonaws.com] has joined #shogun | 13:47 | |
travis-ci | it's Sergey Lisitsyn's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/328688045 | 13:47 |
---|---|---|
-!- travis-ci [~travis-ci@ec2-54-221-113-180.compute-1.amazonaws.com] has left #shogun [] | 13:47 | |
-!- travis-ci [~travis-ci@ec2-54-235-17-100.compute-1.amazonaws.com] has joined #shogun | 14:43 | |
travis-ci | it's Sergey Lisitsyn's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/328688045 | 14:43 |
-!- travis-ci [~travis-ci@ec2-54-235-17-100.compute-1.amazonaws.com] has left #shogun [] | 14:43 | |
lisitsyn | fsck you travis | 14:43 |
lisitsyn | :P | 14:43 |
lisitsyn | I can restart you all night long | 14:44 |
-!- saurabh7 [~saurabh@106.51.19.168] has joined #shogun | 15:26 | |
-!- saurabh7 [~saurabh@106.51.19.168] has quit [Ping timeout: 256 seconds] | 15:50 | |
-!- HeikoS [~heiko@host86-129-231-92.range86-129.btcentralplus.com] has joined #shogun | 16:38 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 16:38 | |
-!- HeikoS [~heiko@host86-129-231-92.range86-129.btcentralplus.com] has quit [Client Quit] | 16:38 | |
-!- HeikoS [~heiko@host86-129-231-92.range86-129.btcentralplus.com] has joined #shogun | 18:16 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 18:16 | |
@HeikoS | lisitsyn: see comments in my latest PR | 19:33 |
@HeikoS | I can fix it, unless you want to go ahead | 19:33 |
lisitsyn | HeikoS: hey | 19:55 |
lisitsyn | I think I got disconnected so not sure messages got you :D | 19:56 |
lisitsyn | ok so we need .clone() | 19:56 |
@HeikoS | lisitsyn: whats the return type of the clone impl for that? | 20:48 |
@HeikoS | template <class T> | 20:48 |
@HeikoS | inline auto clone_impl(more_important, const T& value) | 20:48 |
@HeikoS | -> decltype(static_cast<void*>(value.clone())) | 20:48 |
@HeikoS | { | 20:48 |
@HeikoS | return static_cast<void*>(value.clone()); | 20:48 |
@HeikoS | } | 20:48 |
@HeikoS | ? | 20:48 |
lisitsyn | void* | 20:48 |
@HeikoS | ok trying this thing above | 20:48 |
lisitsyn | ah | 20:48 |
lisitsyn | why you cast? | 20:48 |
lisitsyn | HeikoS: the void* cast trick is not needed here | 20:48 |
lisitsyn | just return T | 20:49 |
@HeikoS | template <class T> | 20:49 |
@HeikoS | inline auto clone_impl(more_important, const T& value) | 20:49 |
@HeikoS | -> decltype(value.clone()) | 20:49 |
@HeikoS | { | 20:49 |
@HeikoS | return value.clone(); | 20:49 |
@HeikoS | } | 20:49 |
@HeikoS | or do I need to specify return type in decltype? | 20:49 |
@HeikoS | lisitsyn: ? | 20:49 |
lisitsyn | no that's fine ^ | 20:49 |
lisitsyn | does it work? | 20:50 |
@HeikoS | compiling .... | 20:50 |
@HeikoS | zzzz | 20:50 |
lisitsyn | should work | 20:50 |
@HeikoS | should probably add explcit unit tests to any... | 20:50 |
@HeikoS | but the ones I have in that PR should cover many cases | 20:50 |
@HeikoS | will let you know | 20:50 |
@HeikoS | talk later | 20:50 |
lisitsyn | ok | 20:50 |
@HeikoS | workw | 21:01 |
@HeikoS | worked | 21:01 |
lisitsyn | HeikoS: yay! | 21:11 |
lisitsyn | HeikoS: any other requests for any from you? ;) | 21:11 |
lisitsyn | my cv has a line 'senior any developer' :P | 21:13 |
--- Log closed Mon Jan 15 00:00:20 2018 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!