IRC logs of #shogun for Friday, 2018-01-19

« Thursday, 2018-01-18 Index Saturday, 2018-01-20 »
--- Log opened Fri Jan 19 00:00:25 2018
-!- HeikoS [~heiko@host86-129-231-92.range86-129.btcentralplus.com] has quit [Ping timeout: 248 seconds]00:16
-!- calvin [76bd2b0e@gateway/web/freenode/ip.118.189.43.14] has joined #shogun08:02
-!- calvin is now known as Guest1830308:02
Guest18303hi08:03
-!- Guest18303 [76bd2b0e@gateway/web/freenode/ip.118.189.43.14] has quit [Quit: Page closed]08:07
-!- HeikoS [~heiko@host86-129-231-92.range86-129.btcentralplus.com] has joined #shogun10:27
-!- mode/#shogun [+o HeikoS] by ChanServ10:27
@wikingmmm where's sukey10:46
-!- shogitter [~nodebot@ks312251.kimsufi.com] has quit [Remote host closed the connection]10:47
-!- shogitter [~nodebot@ks312251.kimsufi.com] has joined #shogun10:47
-!- sukey [~nodebot@ks312251.kimsufi.com] has joined #shogun10:47
-!- mode/#shogun [+o sukey] by ChanServ10:47
@sukey[https://github.com/shogun-toolbox/shogun] vigsterkr pushed 8 commits:10:48
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/92a5999f23f1f084222b0f36a21cab605af3f5e210:48
@wikingsukey, flip10:48
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/0507ff73955fff82884e4681789003b11ec5646d10:48
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/2a300794c1f10e527be625d2cc529bd652bb19eb10:48
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/080ec4a134a9bf5af6f7b5b10c2eb254a632b77210:48
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/9d2e76e0a33419548d90ee1ba4df2edd47be71b810:48
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/a4c84ee839dce1a25d5de3277ec5e3e81816601710:48
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/558da6bee73c8dcaf842355c36e17a557803471110:48
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/8bff18bc218b2d7884bd16b627b558b34c3c8f0a10:48
@sukey(/ .?.) ??(???)?? /(.?. )10:48
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf10:51
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: _Sidebar edited by karlnapf10:53
@HeikoSlisitsyn: whazzup?10:53
lisitsynHeikoS: hey10:53
@HeikoSlisitsyn: I am writing a usability project description now10:55
@HeikoSwiking: whats up with the R meta example? :)10:55
lisitsynHeikoS: I am implementing clone for 'ArrayWrapper'10:55
@wikingHeikoS, fixing10:55
@HeikoShttps://github.com/shogun-toolbox/shogun/compare/feature/meta_example_r_fix#diff-9713dcedd8b822026b94f290640534a9R12  .. might want to update that one :)10:56
@HeikoSwiking: cool!10:56
lisitsynsounds like daily standup we have here lol10:56
@HeikoSlisitsyn: cool! where is it?10:56
@wikinglisitsyn, arraywrapper?10:56
@HeikoShehehe10:56
lisitsynwiking: yes helper class for any10:56
lisitsynto store arrays10:56
@wikinglisitsyn, how does it wrap?10:56
lisitsynT** ptr, size_t* length10:56
@wikingHeikoS, to what? i mean feel free to update10:56
@HeikoSlisitsyn: it is good to have a standup for core devs as well :)10:56
@wikinglisitsyn, yeye but into what?10:57
@HeikoSwiking: the readme description, this is the super old one10:57
@HeikoSyeah I will10:57
lisitsynwiking: struct { T** ptr, size_t* length }10:57
@wikingHeikoS, sure it's a feature branch you can update whenever10:57
@wikingu feel like10:57
@wikinglisitsyn, so i added this into develop10:57
lisitsynwiking: added what10:57
@wikinghttps://github.com/shogun-toolbox/shogun/commit/1b55e385bb2326f54394e7a6cabab1f37624744810:57
lisitsynah10:58
lisitsynI now understand10:58
@wikingso Wrapped* is gone10:58
lisitsynwhy you get triggered by Wrapper10:58
lisitsyn:)10:58
@wikingyes10:58
lisitsynno it is a different thing10:58
@wiking:)10:58
@wikinggotcha10:58
@HeikoSwiking: oh are the meta examples useing the DynamicObjectArray?10:58
lisitsynwiking: it is to store refs to arrays in any10:58
@wikingHeikoS, yes10:58
@HeikoSohoh10:58
@wikinglisitsyn, mmmm yeah i mean maybe we should merge these? :)10:58
@HeikoSdamn10:58
@HeikoSI mean great, that's better10:59
@HeikoSbut then10:59
@HeikoScurrently our integration tests are disabled10:59
@wikingi mean on the end of the day they are in a way doing the same for differenrt purposes10:59
@HeikoSas the thing returns true on ::equals10:59
@HeikoSlisitsyn, more incentives for the array wrapper :)10:59
lisitsynHeikoS: is it true that we gonna use that arraywrapped thing11:00
lisitsynonly for clone and equals11:00
@HeikoSand serialization11:00
lisitsynwe won't 'get' it11:00
lisitsynah yes11:00
lisitsynand serialization11:00
@HeikoSyeah no get11:00
lisitsynsuper11:00
@HeikoSbecause that is outdated11:00
lisitsynthen I know how do that11:01
@HeikoSthere is sep. API for modification and reading11:01
@HeikoSlisitsyn: cool11:01
@HeikoSah bad bad11:01
@HeikoSi merged some changes that were supposed to be covered by integration tests11:01
@HeikoSsuch a subtle little fuck11:01
@HeikoSlisitsyn: https://github.com/shogun-toolbox/shogun/pull/403211:04
@HeikoSlet's merge this!11:04
@HeikoSthen we can go bsd11:04
lisitsynah11:04
lisitsynyeah wanted to push the button11:04
lisitsynkawabanga11:04
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4032 merged by lisitsyn11:04
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/c0cb4a765a3dc99fb3324d3e064049a2232ced85 by lisitsyn11:04
@wikingguys11:04
@wikingwhy is EVERYTHING11:05
@wikingread11:05
@wiking:)11:05
@wikingin buildbot11:05
lisitsyneh?11:05
@wikinghttp://buildbot.shogun-toolbox.org:8080/#/console11:05
@wiking:D11:05
@HeikoSuh11:05
@HeikoSgood times :D11:05
@wikingFetched in submodule path 'data', but it did not contain 0bc7d73b2cdc29e6a71c12a3f88cf1f1e3e03cf5. Direct fetching of that commit failed.11:05
@wikingwtf?!11:05
lisitsynfml11:06
lisitsyn:)11:06
lisitsynwrong data submodule hash?11:06
@wikingyeah but i wonder how :)11:07
@wikingstarted with this11:07
@wikingHEAD is now at 5d1e93d3e Rename files for meta examples (#4055)11:07
@wikingcommit 5d1e93d3ec1fcd60580a352dc8b4f698e9d6305111:08
@wikingAuthor: Don <dgkimdev@gmail.com>11:08
@wikingDate:   Fri Jan 12 02:35:47 2018 +090011:08
@HeikoSim checking11:08
@wikingwho merged?11:08
@wikingi cannot see the merge commit somehow11:08
@wiking @karlnapf11:09
@wikingRename files for meta examples (#4055)11:09
@wikingdgkim5360 committed with karlnapf 8 days ago11:09
@HeikoSyep on it11:10
@HeikoSah crap11:10
@HeikoSmmmh travis passed11:11
@wikingit should have been linked to this11:11
@wikinghttps://github.com/shogun-toolbox/shogun-data/commit/1f5996c78ad957da1d3bc849b95054aef36139b911:11
@HeikoSyeah11:11
@HeikoSwhy did it work in travis?11:11
@wikingnot to 0bc7d73b2cdc29e6a71c12a3f88cf1f1e3e03cf511:11
@wikingcoz different way of checking out submodules11:12
@wikinghttps://github.com/shogun-toolbox/shogun-data/pull/140/commits/0bc7d73b2cdc29e6a71c12a3f88cf1f1e3e03cf511:12
@wikingis still there11:12
@HeikoSmmh I see11:12
@wikingbut yeah cna you push a fixer into develop plz11:12
@wikingjust fix it to current master HEAD of shogun-data11:12
@HeikoSon it11:13
@wikingthnx11:13
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/d57e19533b819009691e531180ed2976d231392b by karlnapf11:15
@wikingletse11:16
@HeikoSwiking: btw11:16
@HeikoSwait with merging the R fixes11:16
@HeikoSintegration tests are currently off11:16
@wikingHeikoS, afaik if you simply merge (ff) then this will not happen11:16
@wikingyeye i mean it's just i had to factor out the Wrapped* fix11:17
@wikingthat thing is not yet 100% anyways11:17
@HeikoSsure cool, just wanted to make double sure11:17
@wikingi'm still on cereal11:17
@HeikoSI see11:17
@wikingbut that thing was blocking me from many places11:17
@HeikoSi see11:17
@wikingi.e. wanted to have that serialization for cereal11:17
@wikingnow building but since headers are changed a lot11:17
@HeikoScool, ill get back to application writing11:17
@wikingit's spinning clock11:17
@wikinglisitsyn, the any.h is becoming a nonono11:18
@wiking:)11:18
@wiking1k LoC :)11:18
@HeikoS.cpp11:18
@wikingunfortunately not really11:18
@wikingcoz of the templates11:19
lisitsynwell11:19
lisitsynit is not really that big11:19
@wiking:>11:19
lisitsynour { } style multiplies LoC11:19
lisitsynand there is some doc11:19
@wiking../src/shogun/base/class_list.h:46:4: warning: deleting pointer to incomplete type 'shogun::CSGObject' may cause undefined behavior [-Wdelete-incomplete]11:20
@wiking                        delete object;11:20
@wikinglisitsyn, we wanna do delete or SG_UNREF :P11:20
lisitsynyeah know that11:20
lisitsyndelete11:20
@wiking:>11:20
lisitsynwiking: nevermind I'll fix that11:20
@wikingits ok11:20
@wikingbaaaahaaaa11:21
@wikingbtw did you deliberately did virtual void on(double*) = 0;?11:21
@wikingi.e. not float64_t ?11:21
lisitsynI do not remember exactly but I think I had some issues11:21
lisitsynbut yeah float6411:21
@HeikoSwiking: there is an issue with rxcpp if there is not internet connection i think11:26
@wikingHeikoS, yes11:27
@wikingHeikoS, it works if you copy it there11:27
@wikingwhere it needs to be11:27
@wiking:)11:27
@wikingsame story as eigen basically11:27
@HeikoSwhat about cmake ignoring it in that case?11:28
@wikingignoring what?11:28
@wikingyou cannot11:28
@wikingit's like eigen11:28
@HeikoSah11:29
@HeikoSit is not guarded11:29
@HeikoSHAVE_RXCPP11:29
@HeikoSisnt there11:29
@wikingmmm11:29
@wikingthere's no guard11:29
@wikingbecause it's required11:29
@HeikoSis that a good idea, to make it a hard dependency?11:29
@wikingit's like eigen11:30
@wikingheader only11:30
@wikingjust put it there11:30
@wikingIf you download the file by hand and exatract it into external, that should do it11:31
@wikingyou dont need to extract11:31
@wikingjust put the archive there11:31
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf11:31
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf11:33
-shogun-buildbot:#shogun- Build trusty - libshogun - viennacl #262 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/6/builds/26211:34
@wikinghuhu11:34
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf11:35
-shogun-buildbot:#shogun- Build deb1 - libshogun #243 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/10/builds/24311:50
@wiking\o/11:50
@wikingok so this will take the avalanche11:50
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf11:56
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf11:57
@wikinglisitsyn, mumumu11:58
@wikingbazdmeg11:58
@wikinghttps://github.com/shogun-toolbox/shogun/commit/521f2171f4b8aebfe667b65f39ec3fcc400c8b7211:58
@wiking:)11:58
@wiking#### set required C++ standard level of the compiler11:58
@wikingset(CMAKE_CXX_STANDARD 14)11:58
@wiking? :)11:58
@wikingfixing11:59
@wikingmmm12:00
@wikingwe need an appveyor fix for that's12:00
@wikingas msvc15 does not support is12:01
@wiking:S12:01
-!- travis-ci [~travis-ci@ec2-54-83-108-224.compute-1.amazonaws.com] has joined #shogun12:02
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/33073181812:02
-!- travis-ci [~travis-ci@ec2-54-83-108-224.compute-1.amazonaws.com] has left #shogun []12:02
@HeikoSlisitsyn, wiking what is again the name of the super popular black box optimization library?12:02
@wiking?12:02
@wikingwonders how the fuck appveyor compiled12:03
@wiking:)12:03
@wikinglisitsyn, make_any is std++17 no?12:03
@wikingmmm no comprende12:04
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf12:04
@wikingah ok12:04
@wikingi undestand now... i'm stupid :D12:04
@wikinggood12:04
@wikinglisitsyn, mea culpa12:04
@wiking:)12:04
@HeikoSwiking: btw I met the main sklearn guy two days ago12:07
-shogun-buildbot:#shogun- Build bsd1 - libshogun #226 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/31/builds/22612:10
-shogun-buildbot:#shogun- Build trusty - libshogun #243 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/33/builds/24312:11
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf12:12
-!- witness [uid10044@gateway/web/irccloud.com/x-myoashpplxbldarf] has quit [Quit: Connection closed for inactivity]12:12
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf12:13
-shogun-buildbot:#shogun- Build CentOS7 - libshogun #332 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/19/builds/33212:32
-shogun-buildbot:#shogun- Build FC23 - libshogun #331 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/27/builds/33112:33
-shogun-buildbot:#shogun- Build xenial - libshogun #329 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/16/builds/32912:34
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf12:36
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf12:37
-shogun-buildbot:#shogun- Build yakkety - libshogun #329 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/1/builds/32912:37
-shogun-buildbot:#shogun- Build zesty - libshogun #324 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/13/builds/32412:38
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf12:38
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf12:39
-!- travis-ci [~travis-ci@ec2-54-204-156-165.compute-1.amazonaws.com] has joined #shogun12:41
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/33073181812:41
-!- travis-ci [~travis-ci@ec2-54-204-156-165.compute-1.amazonaws.com] has left #shogun []12:41
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has joined #shogun12:43
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/33073271212:43
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has left #shogun []12:43
@wikingHeikoS, which, andreas?12:55
@HeikoSgael12:56
@wikingaaah12:56
@wikingmmm12:59
@wikingthose errors with modular interfaces are like :O13:00
@wikingahhaha13:00
@wiking[100%] Swig source13:00
@wikingshogun_doxygen.i:71612: Error: Syntax error in input(1).13:00
@wiking:)13:00
@wikingno doxygen in travis :)13:00
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has joined #shogun13:07
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/33073271213:07
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has left #shogun []13:07
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: GSoC_2018_deliverables created by karlnapf13:08
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: GSoC_2018_deliverables edited by karlnapf13:10
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: GSoC_2018_deliverables edited by karlnapf13:10
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: GSoC_2018_deliverables edited by karlnapf13:11
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: GSoC_2018_project_usability created by karlnapf13:20
@sukey[https://github.com/shogun-toolbox/shogun] Wiki page: Google-Summer-of-Code-2018-Projects edited by karlnapf13:23
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has joined #shogun13:41
travis-ciit's Esben S?rig's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/33073836113:41
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has left #shogun []13:41
-!- travis-ci [~travis-ci@ec2-54-204-156-165.compute-1.amazonaws.com] has joined #shogun14:01
travis-ciit's Esben S?rig's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/33073836114:01
-!- travis-ci [~travis-ci@ec2-54-204-156-165.compute-1.amazonaws.com] has left #shogun []14:01
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has joined #shogun14:23
travis-ciit's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/33074215014:23
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has left #shogun []14:23
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has joined #shogun14:50
travis-ciit's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/33074215014:50
-!- travis-ci [~travis-ci@ec2-54-92-193-87.compute-1.amazonaws.com] has left #shogun []14:50
-!- rahul [~rahul@49.206.127.43] has joined #shogun15:52
-!- rahul is now known as Guest9068015:52
@wikingboooo16:52
@wikingi've jsut witnessed a segfault on import shogun16:52
@wikingwith conda 6.1.316:52
@wiking:(16:52
@wikingand it's linux16:53
@wikingnot osx :(16:53
@wikingooooooo17:31
@wiking[ 54%] Generating trained_model_serialization_unittest.cc17:31
@wikingTraceback (most recent call last):17:31
@wiking  File "/cluster/home/galv/shogun/tests/unit/base/trained_model_serialization_unittest.cc.py", line 137, in <module>17:31
@wiking    outputText = entry(TEMPLATE_FILE, input_file, config_file)17:31
@wiking  File "/cluster/home/galv/shogun/tests/unit/base/trained_model_serialization_unittest.cc.py", line 116, in entry17:31
@wiking    and not is_guarded(header, guards)\17:31
@wiking  File "/cluster/home/galv/shogun/tests/unit/base/trained_model_serialization_unittest.cc.py", line 45, in is_guarded17:31
@wiking    guards = re.findall('#ifdef (\w+)', header.read().lower())17:31
@wiking  File "/cluster/home/galv/anaconda2/envs/shogun-mkl-35/lib/python3.5/encodings/ascii.py", line 26, in decode17:31
@wiking    return codecs.ascii_decode(input, self.errors)[0]17:32
@wikingUnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 290: ordinal not in range(128)17:32
@wikingtests/unit/CMakeFiles/shogun-serialization-unit-test.dir/build.make:82: recipe for target 'tests/unit/trained_model_serialization_unittest.cc' failed17:32
@wikingmake[2]: *** [tests/unit/trained_model_serialization_unittest.cc] Error 117:32
@wikingasdf17:32
@wikingpython ftw17:32
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4088 vigsterkr added label: "good first issue"17:43
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4088 vigsterkr added label: "BUG"17:43
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4088 opened by vigsterkr17:43
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4088 vigsterkr added label: "testing"17:43
-!- Guest90680 [~rahul@49.206.127.43] has quit [Read error: Connection reset by peer]18:09
-!- HeikoS [~heiko@host86-129-231-92.range86-129.btcentralplus.com] has quit [Quit: Leaving.]20:09
@wikinglisitsyn, around? :)20:12
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4089 opened by Red-devilz20:18
lisitsynwiking: hey20:27
@wikinginline T const* typed_pointer(const void* ptr)20:29
lisitsynyes20:29
@wikingconceptually i get it why it's const*20:29
@wikingbut the problem is20:29
@wikingthat then in visitor20:29
@wikingwe need to define20:29
@wikingT* and T const*20:29
@wiking:)20:29
@wikingfor example20:29
lisitsynoh20:29
lisitsynI think visitor should always be const20:29
@wikingok20:29
@wikingthen i fix it that way20:29
@wikingindeed20:29
@wikingyou ar eright20:29
lisitsynyeah sounds good20:29
@wikingvisitor is readonly20:29
@wiking:like:20:30
@wiking:+1:20:30
lisitsynotherwise20:30
lisitsynit would be messy20:30
lisitsynwiking: T from templates and consts get a bit crazy sometimes20:30
lisitsynso I might messed something20:30
lisitsynto solve that people usally do something like std::decay<std::fuck_my_life::20:30
lisitsynstd::help_me<std::drop_any_regulations<T>>20:31
@wiking:>20:33
@wikingmmm20:35
@wikingshou;ldn't it be const T*? :)20:35
@wikinghttp://demin.ws/blog/english/2009/09/30/const-t-t-const/20:35
@wiking:)20:35
@wikingok20:35
@wikinglisitsyn, should i do const T* rather than T const* in the function declaration20:36
@wikingvirtual void on(const bool*) = 0;20:37
@wikinglooks nicer to me than virtual void on(bool const*) = 0;20:37
@wikingbut i mean this is my personal pref20:37
lisitsynwiking: yes const bool*20:41
-!- rrahul [~rahul@49.206.127.43] has joined #shogun20:45
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4090 opened by shubham80821:01
-!- HeikoS [~heiko@host86-129-231-92.range86-129.btcentralplus.com] has joined #shogun21:05
-!- mode/#shogun [+o HeikoS] by ChanServ21:05
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4090 closed by shubham80821:13
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4091 opened by Red-devilz21:20
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/409121:23
-!- rrahul [~rahul@49.206.127.43] has quit [Ping timeout: 256 seconds]22:08
--- Log closed Sat Jan 20 00:00:27 2018
« Thursday, 2018-01-18 Index Saturday, 2018-01-20 »

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!