IRC logs of #shogun for Friday, 2018-02-16

« Thursday, 2018-02-15 Index Saturday, 2018-02-17 »
--- Log opened Fri Feb 16 00:00:04 2018
@wikinglisitsyn, https://github.com/facebookresearch/TensorComprehensions jit is everywher :)09:04
lisitsynwiking: ugly as shit!09:05
@wikingyeah09:05
@wikingi've looked into the code09:05
@wikingit looks pretty bad api09:05
@wikingThe memory layout implied by TC is row-major (C-like).09:05
@wikingwonder why09:05
lisitsynthey use halide but halide is so freaking nice09:06
@wiking:)09:06
@wikinghalide = llvm based?09:06
lisitsynFunc blur_3x3(Func input) {09:06
lisitsyn  Func blur_x, blur_y;09:06
lisitsyn  Var x, y, xi, yi;09:06
@wikingyep09:06
@wikingjust checking09:06
lisitsynmuch better huh09:07
@wikingthink we foudn a swig bug yesterday with Heiko :(09:07
@wikingfor ruby09:07
lisitsynseen some array stuff09:08
lisitsynvector/matrix/float something09:08
@wikingyeah09:08
@wikingthat was ok09:08
@wikingthat was fixable09:08
@wikingof course there was a bug in ruby typemap :)09:08
@wikingbut the problem is atm that when yo udo the dispatching with the generated swig09:09
@wikingif you pass an object but the same api (polymorphism) accepts a pointer09:09
@wikingthere's a :kaboom:09:09
@wikingWilliam Fulton's reaction was: try latest swig from trunk :)09:09
@wikinganyhow that's a blocker for ruby09:10
@wikingbut yeah i mean we should refactor ruby's typemaps09:11
@wikingsince09:11
@wikinghttp://ruby-doc.org/stdlib-2.0.0/libdoc/matrix/rdoc/Matrix.html09:11
lisitsynaha09:11
@wikingthere's native matrix for ruby09:11
lisitsynwiking: fulton!!!!!!!!!!09:11
@wikingsince 2.009:11
@wikinglisitsyn, heheh yeah swig guy :)09:11
lisitsynthis guy09:11
lisitsynargh09:11
@wikingheheh yeah he is not the easiest :)09:11
@wikinglisitsyn, btw do you have an idea why we have taken jblas or ujmp as a jdk typemap?09:23
@wikingi mean we could just have taken [] and [][]09:23
@wikingthat works in jdk09:23
lisitsynwiking: true09:23
lisitsynwiking: don't know09:23
lisitsynmore cool?09:23
lisitsyn:)09:23
@wikingbecause both jblas and ujmp09:23
@wikingare kind of not maintained anymore09:23
@wiking:(09:23
@wikingand i mean from [] and [][]09:24
@wikingyou could do *anything* in jvm09:24
lisitsynwell nobody calculates stuff in java09:24
lisitsyn:D09:24
@wikingyeah but you would use as well09:24
@wiking[][] and []09:24
@wikingand then maybe define wrappers09:24
@wikingaround09:24
lisitsynyeah that's true09:24
lisitsynalthough [][] is ineffective09:24
@wikingyeah09:24
@wikingi mean we can just say09:24
@wiking[]09:24
@wiking:)09:24
@wikingand that it's column oriented09:25
@wiking:p09:25
@wikingi guess even less people would use us then from JVM09:25
@wiking:DD09:25
lisitsynour matrices would be OBJECT oriented09:25
lisitsynbecause it is jvm09:25
@wiking:D09:25
@wikingi see you had woken up already :P09:25
@wikinganyhow we coudl change dthat09:26
@wikingujmp Jul 30, 201509:26
@wikingjblas May 12, 201509:26
@wikingthese are the release dates09:26
lisitsynuh09:27
lisitsynI guess we need to switch to either something else09:28
lisitsynor to []09:28
@wiking[]09:28
@wikingas that lives forever09:29
@wikingi dont see any other stuff09:29
@wikingmaybe commons math?09:29
lisitsynyeah apache something09:29
@wikingi mean that at least has even sparse support as well09:29
@wikinghttp://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/linear/SparseFieldMatrix.html09:29
lisitsynoh that sounds better09:30
lisitsynbecause commons is like everywhere09:30
@wikingyeah09:32
@wikingi mean it's ocmmons.math09:32
@wikingbu tyeah09:32
@wikingyaeh maybe that's the best09:32
@wikingbtw lisitsyn do you  think it makes sense to have a mapping for vector as well?09:37
lisitsynwiking: not sure it makes sense everywhere09:37
lisitsynI mean why not assume vector is 1xd09:37
@wikingi mean we can do the same as in ruby09:38
@wikingthere as i can see we both support09:38
@wikingruby array09:38
@wikingand nmatrix09:39
@wikingor what is that package09:39
@wiking(this is at least when it's a typemap(in)09:39
@wikingso we can support both [] and RealVector09:40
@wikingand then drop ujmp and jblas09:41
-!- HeikoS [~heiko@bmi-airport-1.inf.ethz.ch] has joined #shogun10:00
-!- mode/#shogun [+o HeikoS] by ChanServ10:00
lisitsynHeikoS: welcome to zurich?10:25
lisitsyn:)10:25
lisitsynwiking: HeikoS is visiting you? :)10:25
@HeikoSlisitsyn: yes10:25
@HeikoSI am leaving today10:25
@HeikoSwas here 3 days10:25
lisitsynoh I see10:25
-!- HeikoS [~heiko@bmi-airport-1.inf.ethz.ch] has quit [Ping timeout: 255 seconds]10:43
@wikingTrixis, here?11:24
@sukey[https://github.com/shogun-toolbox/shogun] vigsterkr pushed 9 commits:16:46
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/3a3983cedf572fa06765281c22dbfb3082366e1316:46
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/f474d37990f75a45f1d0c725ec8eb06f7aa3b55816:47
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/ab7f46630c1b4ed3d103d96d431c69e9d654e2e516:47
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/b0acbde82a7ead6b5e000ff9eebf678f5e38609e16:47
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/df6d3e4d9f8b953c701c45a958f26b5ecb48690616:47
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/f23601c0c7255d20a8b9429a13685ae60d072e5516:47
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/733289836748144ae437d70a30dda19a2624556716:47
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/c9dcbeb3d42fe349e847aed4a06884f4e6982a8b16:47
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/a65ae991155aead63e90828cc91d0867a1edb90516:47
-!- HeikoS [~heiko@p4FED5061.dip0.t-ipconnect.de] has joined #shogun17:00
-!- mode/#shogun [+o HeikoS] by ChanServ17:00
@sukey[https://github.com/shogun-toolbox/shogun] karlnapf pushed 2 commits:17:00
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/b1d3e0650e4e74a3d9613cf9fdf51152bebc6e8217:00
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/8f03a9dca3c8d620d8355720e4d3d0f4ca5c43e717:00
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/417717:01
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4178 opened by karlnapf17:04
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4178 karlnapf added label: "SWIG"17:04
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4178 karlnapf added label: "good first issue"17:04
@HeikoSlisitsyn: I think the build should now be green for "put"17:08
lisitsynHeikoS: wow you rock17:08
lisitsyn:)17:08
@HeikoSonly thing that doesnt work is ruby, which I blacklisted for now17:08
@HeikoS(only that example)17:08
@HeikoSIF it is green, I think we shoujld merge it back17:09
@HeikoSand then do another one for PUT17:09
@HeikoSehm17:09
@HeikoSGET17:09
@HeikoSlisitsyn: could you have a look at the diff of the feature branch to develop?17:09
lisitsynHeikoS: typedo?17:10
@HeikoSI would do a PR for that, but wiking doesnt like doing PRs from feature branches, so not sure what is the best way17:10
@HeikoSy17:10
lisitsynfunny name17:10
lisitsynlike tuxedo17:10
lisitsynbut typedo17:10
lisitsynHeikoS: why not PR from feature branch? seems reasonable to me17:10
@HeikoSit does to me too17:10
@HeikoStravis works twice17:11
@HeikoSbut one gets the nice discussion webinterface for all the changes17:11
@HeikoSIll wait for travis and then open one17:11
@HeikoSlisitsyn: or you wanna have a look now?17:11
lisitsynHeikoS: I checked the diff17:12
@HeikoSah ok17:12
lisitsynlooks quite good17:12
@HeikoSlets see whether it worked17:13
@HeikoSand then Ill merge it17:13
@HeikoSsee you later!17:13
shogitter(vikrant97) Hi, I am Vikrant Goyal and I am trying to setup the code in my PC but got some errors while doing "cmake .." in the build directory17:31
shogitter(vikrant97) Could NOT find Doxygen (missing:  DOXYGEN_EXECUTABLE) (Required is at least version "1.8.6")17:31
shogitter(vikrant97) -- Found PythonInterp: /usr/bin/python (found version "2.7.12")17:31
shogitter(vikrant97) CMake Error at src/shogun/CMakeLists.txt:49 (MESSAGE):17:31
shogitter(vikrant97) [full message: https://gitter.im/shogun-toolbox/shogun?at=5a87075f17b16a2377566ebf]17:31
shogitter(vikrant97) Can anyone please help?17:31
@wikingHeikoS, doesn't like? :D17:32
@wikingman what's the point of PR of a feature branch17:32
@wikingwhen that was already tested by all the CIs17:32
@HeikoSlisitsyn: ^ see :)17:33
@HeikoSwiking: sure ;)17:33
@HeikoSI guess only the nice summarising "changes" tab on github17:33
@HeikoSas a central base for discussion17:33
@wikingHeikoS, git squash?17:34
@wikingas this is anyways one thing17:34
@wikingand then you have one diff17:35
@HeikoSI know17:35
@wikingso i dont get it17:35
@wikingor kill the CIs for the PR17:35
@HeikoSyep I would do that17:35
@HeikoSbut I think we can merge without PR17:36
@HeikoSonce travis is fine17:36
@HeikoSwiking: I blacklisted the example btw in ruby17:36
@wikingHeikoS, mmm17:36
@wikingcould you not merge it plz17:36
@wikingand give me couple of hours17:36
@HeikoSsure17:37
@HeikoSI dont want to merge it NOW :)17:37
@wikingas at the moment i'm doing what will wants us to do17:37
@HeikoSwiking: but would be good if we did that some time soon17:37
@HeikoSsure sure17:37
Trixiswiking: ye17:37
@HeikoSwiking: no rush, just would like to get it in before I start working on "get"17:38
@wikingyou can have a branch from this to get branch17:38
@wikingand then you'll just merge that17:38
shogitter(vikrant97) can anyone please help?17:39
@wikingHeikoS, you still have code in .cpp17:39
@wikingregarding put17:39
@HeikoSyep17:39
@HeikoSwiking: think it should stay, as these methods will be extended soon17:40
@wikingand it's still put_scalar17:40
@wikingso i mean17:40
@HeikoSput_scalar is fine in fact17:40
@wikingthis is not mergable17:40
@wikingatm17:40
@wikingand void put_vector_or_matrix17:40
@wikingis still there17:40
@HeikoSyep17:40
@HeikoSwould you mind fixing that? I couldnt17:41
@wikingall?17:41
@HeikoSthe vector/matrix %extend17:41
@HeikoSand if you can rename put_scalar to put, do it17:41
@HeikoSoitherwise I think it doesnt matter17:41
@wikinghttps://github.com/shogun-toolbox/shogun/blob/8f03a9dca3c8d620d8355720e4d3d0f4ca5c43e7/src/shogun/base/SGObject.h#L40617:41
@wikingthi sis not good17:41
@wikingits not a good api17:42
@wikingwhen you have in swig a general put17:42
@HeikoSyep that as well17:42
@wikingbut in c++ is not good17:42
@wikingbecause of whatever reason17:42
@wikingbut that language supports polymorphism17:42
@wikingso i'm not so sure if there's a way to justify17:42
@wikingwhy in c++ of all apis17:42
@HeikoSah yes sure17:42
@HeikoSremove it17:42
@HeikoSor I can do17:42
@wikingput for scalar is put_scalar17:42
@wikingbut not in other langs17:42
@wikingand yeah that type trait17:43
@wikingis just not good17:43
@HeikoSchange it17:43
@wikingas you dont want to have Some<CSGObject*>17:43
@HeikoSI'm waiting for those fixes17:43
@wikingjust Some<CSGObject>17:43
@HeikoSyep17:43
@wikingso there's no need for typename std::remove_pointer<T>::type>::value17:43
@wikingand that type trait since it's not swiged17:44
@wikingit can be simply be17:44
@wiking, std::enable_if_t<std::is_convertible<T, CSGObject>::value>* = nullptr>17:45
@HeikoSwiking: would you mind fixing those in the branch?17:45
@HeikoSI spend some time changing stuff but always broke the compilation or the interface17:45
@wikingcould you push these obvious fixes17:45
@wikingthat i have just told you17:45
@HeikoSthis version now at least works17:45
@wikingbut say that thing is buggy17:45
@HeikoSif it is quick, pls just do it17:45
@wiking:40517:45
@wiking:40617:45
@wikingso even if it 'worksforme'17:46
@wikingit's just allowing something17:46
@wikingthat is prone to error17:46
@HeikoSit would be amazing if you could just push all this quickly in there17:46
@wiking?17:47
@wikingi've just given a review of the code17:47
@wiking:)17:47
@wikinga quick one17:47
@wikingimo this is just not ready for merge17:47
@HeikoSwiking: sure I get it, what I ask you, would you mind doing these 1 line changes?17:48
@HeikoSwould appreciate17:48
@wikingyes17:48
@wikingi would mind :)17:48
@wikingas tehre's other stuff in this branch17:48
@wikingthat needs fixing17:48
@wikingthat are not so straightforward17:48
@wikingsay the put_scalar17:48
@wikingso i rather look on that17:48
shogitter(geektoni) ping wiking18:01
@wikinggeektoni pong18:01
-!- travis-ci [~travis-ci@ec2-54-167-157-129.compute-1.amazonaws.com] has joined #shogun18:01
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/34239989218:01
-!- travis-ci [~travis-ci@ec2-54-167-157-129.compute-1.amazonaws.com] has left #shogun []18:01
@wikingTrixis, mmm i cannot recall why i pinged u18:01
@wiking:(18:01
shogitter(geektoni) wiking do you have a minute? ;)18:02
shogitter(geektoni) I need to talk you about something18:02
@wikingsure thing18:02
@wikingon gitter?18:02
-!- witness [uid10044@gateway/web/irccloud.com/x-qzkhqtvckgzfmerp] has joined #shogun18:02
shogitter(geektoni) yes yes18:02
@wikingust a sec18:03
-!- travis-ci [~travis-ci@ec2-54-166-192-148.compute-1.amazonaws.com] has joined #shogun18:12
travis-ciit's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/34240717618:12
-!- travis-ci [~travis-ci@ec2-54-166-192-148.compute-1.amazonaws.com] has left #shogun []18:12
-!- travis-ci [~travis-ci@ec2-54-166-192-148.compute-1.amazonaws.com] has joined #shogun18:17
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/34239989218:17
-!- travis-ci [~travis-ci@ec2-54-166-192-148.compute-1.amazonaws.com] has left #shogun []18:17
@HeikoSvikrant97, pls read the installation readme and the error msg18:17
-!- HeikoS [~heiko@p4FED5061.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds]18:30
-!- travis-ci [~travis-ci@ec2-54-224-67-202.compute-1.amazonaws.com] has joined #shogun18:53
travis-ciit's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/34240717618:53
-!- travis-ci [~travis-ci@ec2-54-224-67-202.compute-1.amazonaws.com] has left #shogun []18:53
-!- witness [uid10044@gateway/web/irccloud.com/x-qzkhqtvckgzfmerp] has quit [Quit: Connection closed for inactivity]20:21
--- Log closed Sat Feb 17 00:00:05 2018
« Thursday, 2018-02-15 Index Saturday, 2018-02-17 »

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!