| --- Log opened Tue Mar 27 00:00:58 2018 | ||
| @wiking | lisitsyn, no problem fixed in the meanwhile | 10:15 |
|---|---|---|
| @wiking | buuuut | 10:15 |
| @wiking | i have another question | 10:15 |
| @wiking | lemme know when u r around | 10:15 |
| @wiking | lisitsyn, ok i'll create a PR | 10:27 |
| @wiking | with a lot of comments | 10:27 |
| lisitsyn | hey | 10:27 |
| lisitsyn | here | 10:27 |
| @wiking | so question is here about BinaryLabels and DenseLabels | 10:41 |
| @wiking | we keep copying stuff | 10:41 |
| @wiking | which i dont see the point | 10:41 |
| @wiking | https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/labels/BinaryLabels.cpp#L26 | 10:41 |
| @wiking | so my question is the following | 10:42 |
| @wiking | say you have this codeline | 10:42 |
| @wiking | auto labels = new CDenseLabels({1.0, -1.0, 1.0, -1.0}; | 10:42 |
| @wiking | and then you want to convert that to be a BinaryLabels | 10:42 |
| @wiking | auto labels2 = binary_labels(labels); | 10:43 |
| @wiking | in this case | 10:43 |
| @wiking | would you expect to be labels still valid? | 10:43 |
| @wiking | i.e. would you scream as a user | 10:43 |
| @wiking | if we'd be using there a move? | 10:43 |
| @wiking | i.e. CBinaryLabels(CDenseLabels&& src); | 10:44 |
| @wiking | but i'll create a pr so you can comment | 10:46 |
| @wiking | maybe that'd be easier | 10:46 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4219 opened by fyoda | 11:24 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4219 | 11:26 |
| lisitsyn | wiking: I think the copy-nocopy decision should not be the move semantic or not | 13:23 |
| lisitsyn | because in python everything is treated as pointers anyway | 13:23 |
| lisitsyn | I'd say it is up to implementation of labels | 13:23 |
| lisitsyn | so it could be BinaryLabels(whatever) but it is copied or not in the implementation | 13:23 |
| lisitsyn | wiking: could you please highlight me once you answer :) I get distracted way too often and instantly forget | 13:26 |
| @wiking | yo | 14:13 |
| @wiking | lisitsyn, sure i cleared up some shit first | 14:13 |
| @wiking | now that thing is in stash | 14:13 |
| @wiking | will review someday | 14:13 |
| lisitsyn | okie | 14:28 |
| Trixis | wiking: not looking great. havent received a response. having to deal with personal things rn. | 14:29 |
| @wiking | Trixis, :( | 14:29 |
| Trixis | yep :\ | 14:31 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/5bb757dda195dde27a0c44b8ee0130714b6df1be by vigsterkr | 14:53 |
| @wiking | sukey, flip | 14:53 |
| @sukey | (????)??????/ | 14:53 |
| -!- 7GHAAGLE6 [~travis-ci@ec2-54-163-184-30.compute-1.amazonaws.com] has joined #shogun | 15:46 | |
| 7GHAAGLE6 | it's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/358872093 | 15:46 |
| -!- 7GHAAGLE6 [~travis-ci@ec2-54-163-184-30.compute-1.amazonaws.com] has left #shogun [] | 15:46 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4220 opened by sunalbert | 16:32 |
| -!- travis-ci [~travis-ci@ec2-54-160-228-235.compute-1.amazonaws.com] has joined #shogun | 16:45 | |
| travis-ci | it's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/358872093 | 16:45 |
| -!- travis-ci [~travis-ci@ec2-54-160-228-235.compute-1.amazonaws.com] has left #shogun [] | 16:45 | |
| -!- nikhilweee [~nikhilwee@128.199.66.195] has quit [Remote host closed the connection] | 17:31 | |
| --- Log closed Wed Mar 28 00:00:00 2018 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!