--- Log opened Wed Apr 04 00:00:09 2018 | ||
-!- witness [uid10044@gateway/web/irccloud.com/x-kznznfieqepqevbn] has joined #shogun | 07:07 | |
-!- witness [uid10044@gateway/web/irccloud.com/x-kznznfieqepqevbn] has quit [Quit: Connection closed for inactivity] | 09:17 | |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4227 synchronized by grig-guz | 09:50 |
---|---|---|
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4227 | 09:53 |
-!- HeikoS [~heiko@host86-171-158-155.range86-171.btcentralplus.com] has joined #shogun | 11:28 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 11:28 | |
@HeikoS | lisitsyn: jojo | 11:33 |
lisitsyn | HeikoS: hey | 11:33 |
@HeikoS | lisitsyn: long time no see | 11:33 |
@HeikoS | all good? | 11:33 |
lisitsyn | HeikoS: yeah but super busy | 11:33 |
lisitsyn | end of Q | 11:33 |
@HeikoS | I see | 11:34 |
@HeikoS | lisitsyn: I wanted to catch you back on that clone stuff | 11:34 |
@HeikoS | arrays of SGO | 11:34 |
lisitsyn | ahh yeah I am desperate to touch it as well | 11:34 |
lisitsyn | :D | 11:34 |
lisitsyn | I think I will have some time for that this saturday | 11:34 |
@HeikoS | cool | 11:34 |
@HeikoS | I have a bunch of local edits | 11:35 |
lisitsyn | HeikoS: will we plan our belgrade thing? | 11:35 |
@HeikoS | tests and stuff | 11:35 |
@HeikoS | lisitsyn: yeah we should I guess | 11:35 |
@HeikoS | lisitsyn: I mean I wrote the proposal, we can just orient ourselves on that | 11:35 |
lisitsyn | ah ok | 11:35 |
@HeikoS | lisitsyn: shall I send it again? | 11:37 |
lisitsyn | HeikoS: no I will find that | 11:38 |
lisitsyn | HeikoS: can you guide me what else is missed in the parameter thingy? | 11:43 |
lisitsyn | so clone of sgo arrays, what else? | 11:44 |
@HeikoS | lisitsyn: globally zou mean? | 11:44 |
@HeikoS | ah | 11:44 |
@HeikoS | I dont know of anything right now | 11:44 |
@HeikoS | clean up maybe | 11:44 |
lisitsyn | oh ok | 11:44 |
@HeikoS | once clone is in | 11:44 |
@HeikoS | then a lot of code can go | 11:44 |
@HeikoS | and then next we could look at model selection stuff | 11:44 |
@HeikoS | meta examples are ready to be transformed as well | 11:45 |
@HeikoS | so then we can look at some<> integration | 11:45 |
@HeikoS | but there is a bug in swig ruby right now | 11:45 |
@HeikoS | that blocks switching all examples to the new style | 11:45 |
@HeikoS | I can of course just disable the ruby examples, but would need to discuss that | 11:45 |
@sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4074 closed by karlnapf | 11:47 |
lisitsyn | HeikoS: what's the bug? | 11:48 |
@HeikoS | https://github.com/shogun-toolbox/shogun/issues/4177 | 11:49 |
-!- Jinquan [b7d32228@gateway/web/freenode/ip.183.211.34.40] has joined #shogun | 11:49 | |
@sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4177 | 11:50 |
@sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4177 | 11:50 |
@sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4177 | 11:51 |
@HeikoS | lisitsyn: I updated it a bit | 11:51 |
lisitsyn | HeikoS: ok something similar to what we had | 11:52 |
@HeikoS | lisitsyn: debugging inside the swig wrapper reveals that if you do | 11:52 |
@HeikoS | svm.set_kernel(matrix) | 11:52 |
lisitsyn | with all the stuff | 11:52 |
@HeikoS | then the wrapper thinks the passed parameter is sgobject, then tries to convert and fails | 11:52 |
@HeikoS | this is only ruby | 11:52 |
lisitsyn | is the wrapper generated only for sgobject? | 11:52 |
@HeikoS | no | 11:52 |
@HeikoS | the matrix wrapper is there as well | 11:52 |
lisitsyn | but it tries sgobject first? | 11:52 |
@HeikoS | yes | 11:53 |
lisitsyn | heh | 11:53 |
@HeikoS | it checks if parameter is sgobject (that is swig genereted code) | 11:53 |
lisitsyn | HeikoS: sed s/../.. as cmake step | 11:53 |
lisitsyn | :D | 11:53 |
@HeikoS | and then the answer is "yes" | 11:53 |
@HeikoS | and then it goes down the rabbithole | 11:53 |
lisitsyn | krazy | 11:53 |
@HeikoS | https://github.com/swig/swig/issues/1199 | 11:53 |
@HeikoS | I reported to swig | 11:53 |
@HeikoS | they asked for a minimal case | 11:53 |
lisitsyn | yeah it is always not easy | 11:54 |
@HeikoS | so the q is | 11:54 |
@HeikoS | shall we disable ruby examples in test and move on? | 11:54 |
@HeikoS | or shall we fix first :) | 11:54 |
lisitsyn | I don't know | 11:54 |
lisitsyn | I'd move on because | 11:54 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4228 merged by karlnapf | 11:55 |
@sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/8f8347a290ca932d2ea77e2b0155d9c977cbde18 by karlnapf | 11:55 |
lisitsyn | well ruby+shogun is used by negative amount of users | 11:55 |
@sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3889 closed by karlnapf | 11:55 |
@HeikoS | lisitsyn: yes | 11:55 |
@HeikoS | while the old api is still there, users could just use that | 11:55 |
@HeikoS | ... | 11:55 |
lisitsyn | users | 11:55 |
lisitsyn | :D | 11:55 |
@HeikoS | yeah | 11:55 |
@HeikoS | ok then | 11:55 |
lisitsyn | shogun+python is something >0 | 11:55 |
lisitsyn | but shogun and ruby | 11:55 |
@HeikoS | I can then refactor all meta examples to the new api | 11:56 |
@HeikoS | this would help with some<> right? | 11:56 |
lisitsyn | yes | 11:56 |
lisitsyn | we can get back to that PR | 11:56 |
lisitsyn | by toni | 11:56 |
@HeikoS | lisitsyn: you have a list of steps that we need to get some<> going? | 11:56 |
lisitsyn | HeikoS: I remember parametric ctors were the only blocker | 11:56 |
lisitsyn | but who knows | 11:56 |
@HeikoS | lisitsyn: in examples or everywhere? | 11:57 |
-!- Jinquan [b7d32228@gateway/web/freenode/ip.183.211.34.40] has quit [Quit: Page closed] | 11:57 | |
lisitsyn | HeikoS: we should stop using parameteric ctors IIRC | 11:57 |
@HeikoS | everywhere | 11:57 |
@HeikoS | ? | 11:58 |
lisitsyn | yes | 11:58 |
lisitsyn | because of renaming CLinearSVM to Some<CLInearSVM> | 11:58 |
@HeikoS | lisitsyn: wanna make an entrance task for that? | 11:59 |
@HeikoS | that is a huge refactoring task | 11:59 |
-!- shubham808 [0e8bf0fb@gateway/web/freenode/ip.14.139.240.251] has joined #shogun | 11:59 | |
@HeikoS | and we can ask the gsoc students do some of this every week :) | 11:59 |
lisitsyn | HeikoS: lets first check if it is the only thing left | 11:59 |
@HeikoS | kk | 11:59 |
@HeikoS | lisitsyn: I mean first thing is clone | 11:59 |
@HeikoS | for raw arrays | 11:59 |
lisitsyn | yeah | 11:59 |
lisitsyn | and then I will check | 11:59 |
@HeikoS | once that is in, I can do all sorts of new things | 11:59 |
lisitsyn | if that PR is mergeable | 11:59 |
shubham808 | @HeikoS there is a problem with #4229 | 12:04 |
@HeikoS | shubham808: hi | 12:04 |
@HeikoS | shubham808: what is the problem? | 12:05 |
-!- shubham808_ [2ff7812c@gateway/web/freenode/session] has joined #shogun | 12:06 | |
@HeikoS | shubham808_: what is the problem? | 12:06 |
shubham808_ | the code that generates the results needed by those tests in now combined with respective operator functions | 12:06 |
shubham808_ | since we decided to get rid of the job based structure | 12:07 |
@HeikoS | I see | 12:08 |
-!- shubham808 [0e8bf0fb@gateway/web/freenode/ip.14.139.240.251] has quit [Ping timeout: 260 seconds] | 12:08 | |
@HeikoS | as long as you test something downstream (some test that is based on the code), it should be ok then | 12:08 |
@HeikoS | shubham808_: is that the case? | 12:09 |
shubham808_ | in rational approximation unit test we are checking final results | 12:09 |
-!- tctara_ [~quassel@irc.redcorelinux.org] has joined #shogun | 12:09 | |
shubham808_ | so yeah | 12:09 |
shubham808_ | we are checking something based on the code | 12:10 |
shubham808_ | for all 3 operator functions | 12:10 |
@HeikoS | ok cool that is good | 12:11 |
@HeikoS | shubham808_: would there be a way of pulling out the functionality of those operator functions into separate functions, and then test those functions? | 12:11 |
@HeikoS | that would be best | 12:11 |
shubham808_ | that would also involve adding set/get methods for weights and shifts | 12:13 |
shubham808_ | okay lets try that | 12:14 |
-!- zxtx_ [~zxtx@sunnythinking.org] has joined #shogun | 12:14 | |
shubham808_ | but it will make the code uglier | 12:14 |
@HeikoS | shubham808_: really? | 12:14 |
@HeikoS | shubham808_: actually | 12:15 |
-!- Netsplit *.net <-> *.split quits: tctara, zxtx | 12:16 | |
@HeikoS | shubham808_: you know what, I think it is fine | 12:17 |
@HeikoS | as long as you test downstream, I think we are good | 12:18 |
@HeikoS | so I will merge this | 12:18 |
shubham808_ | yeah nice :) | 12:18 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4229 merged by karlnapf | 12:18 |
@sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/38a6489561968aa2b4fa391fd053fc583121304b by karlnapf | 12:18 |
@HeikoS | shubham808_: nice, that was a huge cleanup, thanks for that | 12:18 |
@HeikoS | shubham808_: whats next? :) | 12:19 |
shubham808_ | next is parallelization | 12:19 |
shubham808_ | then maybe i will deal with #4044 | 12:20 |
-!- shubham808_ [2ff7812c@gateway/web/freenode/session] has quit [Quit: Page closed] | 12:23 | |
-!- travis-ci [~travis-ci@ec2-54-159-25-82.compute-1.amazonaws.com] has joined #shogun | 12:45 | |
travis-ci | it's Albert's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/362054861 | 12:45 |
-!- travis-ci [~travis-ci@ec2-54-159-25-82.compute-1.amazonaws.com] has left #shogun [] | 12:45 | |
-!- travis-ci [~travis-ci@ec2-54-81-21-151.compute-1.amazonaws.com] has joined #shogun | 12:59 | |
travis-ci | it's Albert's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/362054861 | 12:59 |
-!- travis-ci [~travis-ci@ec2-54-81-21-151.compute-1.amazonaws.com] has left #shogun [] | 12:59 | |
-!- travis-ci [~travis-ci@ec2-54-92-167-44.compute-1.amazonaws.com] has joined #shogun | 13:09 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/362067352 | 13:09 |
-!- travis-ci [~travis-ci@ec2-54-92-167-44.compute-1.amazonaws.com] has left #shogun [] | 13:09 | |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4208 merged by karlnapf | 13:42 |
@sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/63594a456919492d35a799d26b5974e9f9d4fb60 by karlnapf | 13:42 |
-!- travis-ci [~travis-ci@ec2-54-81-21-151.compute-1.amazonaws.com] has joined #shogun | 13:45 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/362067352 | 13:45 |
-!- travis-ci [~travis-ci@ec2-54-81-21-151.compute-1.amazonaws.com] has left #shogun [] | 13:45 | |
-!- travis-ci [~travis-ci@ec2-54-92-167-44.compute-1.amazonaws.com] has joined #shogun | 14:40 | |
travis-ci | it's Elfarouk Yasser's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/362096716 | 14:40 |
-!- travis-ci [~travis-ci@ec2-54-92-167-44.compute-1.amazonaws.com] has left #shogun [] | 14:40 | |
-!- travis-ci [~travis-ci@ec2-54-159-25-82.compute-1.amazonaws.com] has joined #shogun | 14:45 | |
travis-ci | it's Elfarouk Yasser's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/362096716 | 14:45 |
-!- travis-ci [~travis-ci@ec2-54-159-25-82.compute-1.amazonaws.com] has left #shogun [] | 14:45 | |
-!- durovo [~durovo@cc.b7.2ea9.ip4.static.sl-reverse.com] has quit [Remote host closed the connection] | 15:42 | |
-!- durovo1 [~durovo@b1.aa.36a9.ip4.static.sl-reverse.com] has joined #shogun | 15:42 | |
-!- sukey [~nodebot@188.165.194.51] has quit [Remote host closed the connection] | 15:52 | |
-!- sukey [~nodebot@ks312251.kimsufi.com] has joined #shogun | 15:52 | |
-!- mode/#shogun [+o sukey] by ChanServ | 15:52 | |
@sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4226 closed by ypic | 17:15 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4230 opened by karlnapf | 19:17 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4230 synchronized by karlnapf | 19:51 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4230 synchronized by karlnapf | 19:52 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4230 | 19:53 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4230 | 21:03 |
-!- witness [uid10044@gateway/web/irccloud.com/x-tcmvrhvotlzspjtc] has joined #shogun | 21:57 | |
-!- HeikoS [~heiko@host86-171-158-155.range86-171.btcentralplus.com] has quit [Ping timeout: 255 seconds] | 22:13 | |
--- Log closed Thu Apr 05 00:00:11 2018 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!