IRC logs of #shogun for Wednesday, 2018-06-06

« Tuesday, 2018-06-05 Index Thursday, 2018-06-07 »
--- Log opened Wed Jun 06 00:00:38 2018
-!- HeikoS [~heiko@host86-128-122-106.range86-128.btcentralplus.com] has joined #shogun00:32
-!- mode/#shogun [+o HeikoS] by ChanServ00:32
-!- HeikoS [~heiko@host86-128-122-106.range86-128.btcentralplus.com] has quit [Ping timeout: 260 seconds]01:04
-!- HeikoS [~heiko@host86-128-122-106.range86-128.btcentralplus.com] has joined #shogun01:13
-!- mode/#shogun [+o HeikoS] by ChanServ01:13
-!- HeikoS [~heiko@host86-128-122-106.range86-128.btcentralplus.com] has quit [Read error: No route to host]01:16
-!- HeikoS [~heiko@host86-128-122-106.range86-128.btcentralplus.com] has joined #shogun01:16
-!- mode/#shogun [+o HeikoS] by ChanServ01:17
-!- HeikoS [~heiko@host86-128-122-106.range86-128.btcentralplus.com] has quit [Ping timeout: 240 seconds]01:21
-!- shogun-buildbot [~shogun-bu@7nn.de] has quit [Ping timeout: 260 seconds]03:07
-!- shogun-buildbot [~shogun-bu@7nn.de] has joined #shogun03:09
-!- witness_ [uid10044@gateway/web/irccloud.com/x-vszsnqvahaqacvsk] has quit [Quit: Connection closed for inactivity]03:44
-shogun-buildbot:#shogun- Build nightly stretch deb #125 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/38/builds/12504:57
wuweiwiking: hi08:05
wuweimorning :)08:05
@wikingwuwei, hello08:05
@wikingplz write down the issue08:06
@wikingi still need some time to boot up08:06
@wiking:)08:06
wuweisure08:06
wuweiso you know i'm doing some refactor on machine api08:07
wuweipreviously we features and labels are stored in the machine08:07
wuweione question is how we deal with things like train_locked08:08
wuweiand should we still store feature and labels otherwise we will have to pass them around internal helpers in that machine08:08
wuweisince that's realy a big refactor so i'm a bit unclear now :)08:10
wuweicheck the example https://github.com/shogun-toolbox/shogun/blob/94c093bf640ccc52a36f2cd59e9faeabdbfb0bd4/src/shogun/classifier/Perceptron.cpp#L55 , where features are implicitly stored08:13
@wikingk08:19
@wikingyeah that's a crazy refactor08:19
@wikingi might for a second08:19
@wikingjust hold on to this idea08:19
@wikingof refactoring this :)08:19
@wikingjust having a typical fit(f,l) kind of approach08:19
@wikingis already great!08:19
@wikingwe should have a clear goal for you for the next 2 weeks i believe :)08:19
@wikingas the pipeline transformer story is almost over08:19
wuweiyeah08:20
@wikingit'd be great if we could close up and merge the whole transformer branch08:20
wuweii've made fit as a wrapper of old api now08:20
@wikingbut that requires some minimum fixes/changes in the prs08:20
@wiking:)08:20
@wikingyeye i saw that08:20
@wikingthat is great08:20
@wikingso what i woudl actually concentrate08:21
wuweiare there sth to add/fix for the transformer branch08:21
@wikingis the story of exceptions :)08:22
@wikingthat i've mentioned in your pr08:22
@wikingas as you can see from the unit test with mocs08:22
@wiking*mocks08:22
@wikingyou dont really know08:22
@wikingunless you read the exception message08:22
@wikingwhy things failed08:22
wuweiyeah i've seen that08:22
@wikingwhich is bad08:22
@wikingif you are trying to use this within a bigger system08:22
@wikingbecause then you cannot automate really things08:22
@wikingor you need to start parsing the exception message :)08:23
@wikingwhich is not ideal08:23
wuweiagree08:23
wuweii checked REQUIRE, we need change SGIO a bit to allow throwing different exceptions08:24
@wikingyeah REQUIRE might need seomthing like08:24
@wikingexception type08:24
@wiking:)08:24
wuweimaking SGIO::message a template function?08:25
@wikingyeah something like that08:25
@wikingbuuuuuut08:25
@wikingthat reminds me!08:25
@wikingabout SGIO08:25
@wikingthat is a self brew-ed logger thingy08:26
@wikingnot the best :)08:26
@wikinghttps://github.com/gabime/spdlog is great and it's header only08:26
wuweiyeah i think better we could separate message formatting and throwing exceptions08:26
@wikingyeah08:26
@wikingexactly08:26
@wikingthat's another point08:26
@wiking:)08:26
wuweii will spend some time on SGIO now08:30
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun09:02
-!- witness_ [uid10044@gateway/web/irccloud.com/x-mvbobtignvtygctu] has joined #shogun09:08
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]09:10
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun09:12
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]09:31
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun09:31
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Client Quit]09:34
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun09:56
wuweiwiking: are we having the meeting now?11:08
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]11:15
@wikingwuwei,11:15
@wikingshould11:15
@wikinghow about 10 mins11:15
wuweiwiking: sure11:16
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun11:22
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Client Quit]11:23
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun11:49
@wikingdoh11:50
@wikinghere i am11:50
@wikingwuwei, around?11:50
@wiking:)11:50
wuweiwiking: hi11:51
@wikingok11:53
@wikingso11:53
@wikinglets see what you can do first on the remaining days this week11:54
@wikingand then maybe talk about what should we do in the next 2 weeks?11:54
wuweisure11:54
wuweiI'm working on SGIO right now to allow throw custom exceptions11:57
@wikingok12:04
@wikingand then lets go back to finish up with pipelines12:04
wuweiokay12:07
wuweiwiking: and then? what's next two weeks12:20
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has joined #shogun12:40
-!- mode/#shogun [+o HeikoS] by ChanServ12:40
@wikingwuwei, mmmm i would say what's with linalg? :)13:02
wuweistart working on new linalg?13:03
wuweiall right13:03
wuweiwiking: i'm implementing some new macro, like, REQUIRE(condition, std::invalid_argument, message...)13:06
wuweicould u suggest some name for this macro?13:06
@HeikoSshubham808: hi13:18
shubham808hey13:18
shubham808i did the macro refactor13:18
shubham808and a few other things :)13:19
lisitsynHeikoS: hey13:19
lisitsyncan we get back to that feature block thingy13:20
@HeikoSlisitsyn: hi13:20
@HeikoSshubham808: cool, can you send me link of things I should look at? :)13:20
@HeikoSlisitsyn: yes13:20
@HeikoSsorry had to leave yesterday13:20
shubham808progress bar: https://github.com/shogun-toolbox/shogun/pull/4305/commits/4a4e82237c59d9ec0283a5cf7f6e430767dd88d513:21
shubham808HeikoS: i did not understand ur comment about "all_model_tests"13:23
@HeikoSshubham808: it is currently called "trained_model_serialization" tests or something13:26
@HeikoSbut now you also test whether algorithms are stoppable13:26
@HeikoSso the name is not appropriate anymore13:26
@HeikoSand we need a new one13:27
shubham808ah i see13:27
@HeikoSsince we aim to test all models13:27
shubham808u mean a new file altogether13:27
@HeikoSI would call it something like "all_models_test"13:27
@HeikoSyes13:27
shubham808we might end up copying the test fixture13:27
@HeikoSshubham808: btw I dont understand your SG_SPROGRESS thing13:30
@HeikoSthat is supposed to be used from static contexts where there is no "this"13:30
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]13:30
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun13:30
@HeikoSbut you use "this" inside the definition and also use it from inside training methods13:30
@HeikoSlisitsyn: so any thoughts on changing that API?13:31
lisitsynHeikoS: it is a bit shitty so I am open to any suggestions actually13:32
lisitsyn:P13:32
@HeikoSlisitsyn: what about a simple index based thing13:36
@HeikoSrather than objects than contain the ranges13:36
@HeikoSso working with vectors13:36
@HeikoSshubham808: got my comment on SG_SPROGRESS?13:36
shubham808HeikoS: kinda13:37
shubham808what i did was13:37
shubham808not having to pass an io object anymore13:37
@HeikoSshubham808: so SG_SPRINT is supposed to be used from *outside* SGOBject context13:39
@HeikoSso in external library functions for example13:39
@HeikoSthere is no "this" available in that case13:39
@HeikoSso the global io has to be used13:39
@HeikoSfor the progress bar, we want to do the same13:39
@HeikoSeither user this->io13:39
@HeikoSor sg_io13:39
@HeikoSand the SG_PROGRESS can also use "this-get_name()"13:39
@HeikoSwhereas SG_SPROGRESS has to do something else, either accept a string, or put a default13:40
shubham808i see13:40
shubham808sg_io is to be used outside of scope13:42
@HeikoSshubham808: so SG_PRGRESS will be used in every ::train method13:42
@HeikoSand actually in any CSGObject:: method13:42
@HeikoSand SG_SPROGRESS will be used from external code13:43
shubham808i see13:43
shubham808yeah13:43
@HeikoSso you can just put SG_PROGRESS everywhere13:43
@HeikoSand where the compiler errors saying that "this" is not available, you put SG_SPROGRESS13:43
shubham808and they will always use this->io13:43
@HeikoSexactly13:43
shubham808makes sense13:43
@HeikoSyou will need to do something about the this->get_name()13:44
@HeikoSeither make the macro accept another string, or make it default13:44
shubham808we could just go 'PROGRESS :'13:44
shubham808again13:44
@HeikoSwell in SG_PRGORESS, we have13:44
@HeikoSthis->get_name()::__FUNCTION__13:44
@HeikoSin static we would want13:44
@HeikoSCALLER_STRING::__FUNCTION__13:44
@HeikoSor we can use the filename13:45
@HeikoSwhen you update13:45
@HeikoSpls first only do deploy it in a few places13:45
@HeikoSso you dont end up changing all those files over and over13:45
shubham808yeah13:45
shubham808so do we want file::function or caller_string13:46
shubham808file::function makes more sense since if user want a caller string he can directly use to constructors13:46
@HeikoSshubham808: yes13:48
@HeikoSthink that is ok13:48
@HeikoSor even just nothing13:48
@HeikoSactually13:48
@HeikoSjust __FUNCTION__13:49
@HeikoSmight be cleaner13:49
@HeikoSor the filename without suffix13:49
@HeikoSI'll leave it to you to figure out something nice13:49
shubham808alright13:49
shubham808also did u see the helper PR ?13:49
@HeikoSyes13:54
@HeikoSI think we should make this a bit more elaborate13:55
@HeikoSLet's give the StoppableObject a member that is a file13:55
@HeikoSand by default it will be ascii and the filename you made up13:55
@HeikoSbut then the user can change it13:55
@HeikoSshubham808: see what I mean?13:55
@HeikoSI dont like forcing filenames and formats in there13:55
@HeikoSshould be modular13:55
@HeikoSfor those who care13:56
shubham808yeah13:56
shubham808scalable13:56
@HeikoScool13:56
@HeikoSI gotta go somehwere now, but will be back later to discuss more13:56
shubham808okay13:56
shubham808see you later13:56
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]13:59
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun17:30
shubham808HeikoS: hey17:44
shubham808u remember we talked of a test to check if state is properly updated or not ?17:45
shubham808in the meeting ?17:45
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has quit [Ping timeout: 240 seconds]18:12
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]18:30
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun18:46
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]19:21
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun19:21
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]20:01
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun20:03
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]20:08
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun20:19
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Client Quit]20:21
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has joined #shogun21:49
-!- shubham808 [0e8bf0fb@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.240.251] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]22:33
-!- witness_ [uid10044@gateway/web/irccloud.com/x-mvbobtignvtygctu] has quit [Quit: Connection closed for inactivity]22:48
-!- HeikoS [~heiko@host86-128-122-106.range86-128.btcentralplus.com] has joined #shogun23:49
-!- mode/#shogun [+o HeikoS] by ChanServ23:49
--- Log closed Thu Jun 07 00:00:39 2018
« Tuesday, 2018-06-05 Index Thursday, 2018-06-07 »

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!