--- Log opened Fri Jul 06 00:00:56 2018 | ||
-!- HeikoS [~heiko@host86-172-81-177.range86-172.btcentralplus.com] has joined #shogun | 16:38 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 16:38 | |
-!- travis-ci [~travis-ci@ec2-54-163-84-24.compute-1.amazonaws.com] has joined #shogun | 17:01 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/400873455 | 17:01 |
---|---|---|
-!- travis-ci [~travis-ci@ec2-54-163-84-24.compute-1.amazonaws.com] has left #shogun [] | 17:01 | |
lisitsyn | HeikoS: he llo | 17:08 |
@HeikoS | lisitsyn: jojo | 17:08 |
lisitsyn | did you try watch_method yet? | 17:08 |
lisitsyn | HeikoS: the only thing I am worried about | 17:09 |
lisitsyn | is that we bind it with this | 17:09 |
lisitsyn | so if something wrong happens we might get something bad | 17:09 |
lisitsyn | HeikoS: oh I think we should explicitly disable put for these guys | 17:10 |
@HeikoS | like? | 17:13 |
@HeikoS | ah | 17:13 |
@HeikoS | yes we can just overload put | 17:13 |
@HeikoS | i mean, put a check in | 17:13 |
@HeikoS | lisitsyn: that would solve one problem or? | 17:13 |
lisitsyn | yeah let me check what happens | 17:13 |
lisitsyn | yes should work | 17:13 |
lisitsyn | HeikoS: apart from that this is it | 17:14 |
@HeikoS | kk | 17:22 |
@HeikoS | lisitsyn: great | 17:22 |
@HeikoS | I will check it out soon | 17:22 |
@HeikoS | to use it | 17:22 |
lisitsyn | uhmm | 17:22 |
lisitsyn | what do I do next | 17:22 |
lisitsyn | :) | 17:22 |
@HeikoS | lisitsyn: good q | 17:25 |
@HeikoS | there was more stuff or? | 17:26 |
@HeikoS | ah yes | 17:26 |
@HeikoS | plugins | 17:26 |
@HeikoS | there is your pr | 17:26 |
lisitsyn | https://github.com/shogun-toolbox/shogun/pull/4357 | 17:36 |
lisitsyn | HeikoS: ^ | 17:36 |
@HeikoS | i dont get the message but yes that should do it | 17:37 |
@HeikoS | /home/heiko/git/shogun/src/shogun/clustering/KMeansBase.cpp:367:67: error: no matching function for call to 'shogun::CKMeansBase::watch_method(const char [16], shogun::SGMatrix<double> (shogun::CKMeansBase::*)())' | 17:39 |
@HeikoS | lisitsyn: | 17:39 |
lisitsyn | HeikoS: yeah the parameter is immutable | 17:40 |
lisitsyn | why not? :) | 17:40 |
@HeikoS | lisitsyn: you get this error? | 17:40 |
lisitsyn | HeikoS: no, can you paste the whole error? | 17:40 |
@HeikoS | ah it is const stuff | 17:40 |
@HeikoS | https://pastebin.com/aZFBtGFc | 17:40 |
lisitsyn | argh | 17:41 |
lisitsyn | HeikoS: can you copy-paste the method for non-consts? | 17:41 |
lisitsyn | I don't see any prettier way unfortunately | 17:41 |
lisitsyn | I mean just another one of watch_method | 17:42 |
@HeikoS | lisitsyn: compiling | 17:42 |
lisitsyn | with non-const function | 17:42 |
lisitsyn | and dynamic_cast<T*> | 17:42 |
lisitsyn | HeikoS: ^ this one also | 17:42 |
lisitsyn | S* I mean | 17:42 |
lisitsyn | not const S* | 17:42 |
@HeikoS | yep compiling it | 17:43 |
lisitsyn | HeikoS: two random thoughts | 17:49 |
lisitsyn | don't we want to merge meta examples with their descriptions? | 17:49 |
lisitsyn | that's 1) | 17:49 |
lisitsyn | 2) do we want to generate ipynb? | 17:49 |
@HeikoS | lisitsyn: jo | 17:59 |
@HeikoS | lisitsyn: I would love to combine the doxzgen stuff with meta examples | 17:59 |
@HeikoS | not sure what exactly you mean by 1 | 17:59 |
@HeikoS | like have the docs inline? | 17:59 |
lisitsyn | HeikoS: yes | 17:59 |
@HeikoS | so we only need one file? | 17:59 |
lisitsyn | why do we keep .txt | 17:59 |
@HeikoS | generate ipynb maybe | 17:59 |
@HeikoS | probably later | 18:00 |
@HeikoS | lisitsyn: ah ok | 18:00 |
@HeikoS | lisitsyn: well we use sphinx | 18:00 |
@HeikoS | and that is based on rst | 18:00 |
@HeikoS | but we also want to have executable code | 18:00 |
@HeikoS | lisitsyn: I gotta cycle somewhere now | 18:00 |
@HeikoS | lisitsyn: if you wanna think about stuff | 18:00 |
lisitsyn | can't we write the text in [some] [things]? | 18:00 |
@HeikoS | think: how to sensibly combine doxzgen and cookbook (intro maybe?) | 18:00 |
@HeikoS | lisitsyn: we can probably | 18:00 |
@HeikoS | lisitsyn: really gotta run now, but will be back in a bit | 18:01 |
lisitsyn | kk | 18:01 |
@HeikoS | you thing compiled | 18:01 |
@HeikoS | add the non const | 18:01 |
@HeikoS | lisitsyn: will modify an example and see if itnegration test still works | 18:02 |
-!- HeikoS [~heiko@host86-172-81-177.range86-172.btcentralplus.com] has quit [Quit: Leaving.] | 18:02 | |
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has joined #shogun | 18:41 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 18:41 | |
@HeikoS | lisitsyn: ok back! | 18:41 |
@HeikoS | lisitsyn: think we should do something in the to_string method | 18:41 |
lisitsyn | HeikoS: this time I am leaving soonish | 18:41 |
lisitsyn | oops | 18:41 |
@HeikoS | like: lazy_methods | 18:41 |
lisitsyn | to_string crashes I guess | 18:41 |
lisitsyn | ah no | 18:42 |
lisitsyn | it should actually compute stuff | 18:42 |
@HeikoS | and also something to get a list of parmaeters names | 18:42 |
@HeikoS | and then have a list of lazy computed parameter names | 18:42 |
@HeikoS | what do you think? | 18:42 |
lisitsyn | well that's easy | 18:42 |
lisitsyn | just add these two lines :P | 18:42 |
@HeikoS | so this is well separated for the user | 18:42 |
lisitsyn | HeikoS: to_string is really easy to patch | 18:42 |
@HeikoS | lisitsyn: wanna do it? :D | 18:44 |
@HeikoS | lisitsyn: ok it works | 18:44 |
@HeikoS | ill send a PR | 18:44 |
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has quit [Ping timeout: 260 seconds] | 18:59 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-255.ucl.ac.uk] has joined #shogun | 19:15 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 19:15 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-255.ucl.ac.uk] has quit [Quit: Leaving.] | 19:40 | |
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has joined #shogun | 19:55 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 19:55 | |
-!- travis-ci [~travis-ci@ec2-54-227-1-238.compute-1.amazonaws.com] has joined #shogun | 20:08 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/400990236 | 20:08 |
-!- travis-ci [~travis-ci@ec2-54-227-1-238.compute-1.amazonaws.com] has left #shogun [] | 20:08 | |
-!- travis-ci [~travis-ci@ec2-54-227-1-238.compute-1.amazonaws.com] has joined #shogun | 21:07 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/400990236 | 21:07 |
-!- travis-ci [~travis-ci@ec2-54-227-1-238.compute-1.amazonaws.com] has left #shogun [] | 21:07 | |
@HeikoS | wuwei: check my pr | 21:24 |
@HeikoS | we have the lazy get now | 21:24 |
-!- HeikoS1 [~heiko@eduroam-int-pat-8-255.ucl.ac.uk] has joined #shogun | 21:27 | |
-!- HeikoS1 [~heiko@eduroam-int-pat-8-255.ucl.ac.uk] has quit [Client Quit] | 21:27 | |
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has quit [Ping timeout: 256 seconds] | 21:29 | |
--- Log closed Sat Jul 07 00:00:58 2018 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!