| --- Log opened Wed Jul 25 00:00:24 2018 | ||
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4352 synchronized by vinx13 | 08:43 |
|---|---|---|
| wuwei[m] | wiking: check https://github.com/vinx13/shogun/blob/5650d422f80dda1f950bb976b8adae5fef174d63/src/shogun/lib/View.h | 08:45 |
| wuwei[m] | ^ view as a template function | 08:45 |
| -!- HeikoS [~heiko@host86-146-49-234.range86-146.btcentralplus.com] has joined #shogun | 09:47 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 09:47 | |
| -!- HeikoS [~heiko@host86-146-49-234.range86-146.btcentralplus.com] has quit [Ping timeout: 265 seconds] | 09:54 | |
| @wiking | wuwei[m], just a sec | 11:00 |
| wuwei[m] | okay | 11:01 |
| @wiking | yep | 11:15 |
| @wiking | wuwei[m], this is much better | 11:15 |
| @wiking | i mean of course this currently makes it a way that you cannot do view via swig | 11:16 |
| @wiking | but worst case there we can introduce some extra swig related stuff | 11:16 |
| @wiking | but i like this better | 11:16 |
| @wiking | you can even introduce a using viewable = std::is_base_of<CFeatures, T>::value || | 11:17 |
| @wiking | std::is_base_of<CLabels, T>::value | 11:17 |
| @wiking | :) | 11:17 |
| @wiking | but yeah | 11:17 |
| @wiking | this is it | 11:17 |
| wuwei[m] | sure i'll update other part of that pr | 11:17 |
| @wiking | cool stuff | 11:17 |
| @wiking | i like this much better | 11:17 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4373 merged by karlnapf | 11:29 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/ca213d96e0d7c0b0aadacb92d09875e784a5d122 by karlnapf | 11:29 |
| -!- HeikoS [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has joined #shogun | 12:19 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 12:19 | |
| -!- HeikoS [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has quit [Client Quit] | 12:19 | |
| -!- HeikoS [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has joined #shogun | 12:23 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 12:23 | |
| -!- travis-ci [~travis-ci@ec2-54-147-133-39.compute-1.amazonaws.com] has joined #shogun | 12:28 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/407980086 | 12:28 |
| -!- travis-ci [~travis-ci@ec2-54-147-133-39.compute-1.amazonaws.com] has left #shogun [] | 12:28 | |
| -!- HeikoS [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has quit [Ping timeout: 240 seconds] | 12:28 | |
| -!- HeikoS [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has joined #shogun | 12:36 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 12:36 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4384 synchronized by karlnapf | 12:49 |
| -!- HeikoS [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has quit [Quit: Leaving.] | 12:49 | |
| -!- travis-ci [~travis-ci@ec2-54-147-133-39.compute-1.amazonaws.com] has joined #shogun | 12:50 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/407980086 | 12:50 |
| -!- travis-ci [~travis-ci@ec2-54-147-133-39.compute-1.amazonaws.com] has left #shogun [] | 12:50 | |
| @wiking | wuwei[m], are you gonna change the ->view to use this? | 13:36 |
| @wiking | in the PR i meant | 13:36 |
| @wiking | so for example feats->view(right_subset)->as<CDenseFeatures<float64_t>>()); to change it to view(...) | 13:38 |
| @wiking | ? | 13:38 |
| wuwei[m] | wiking: exactly | 14:05 |
| -!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has joined #shogun | 14:18 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 14:18 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] vigsterkr pushed 9 commits: | 15:03 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/d5557dc15feb2caa7949ec8dfef82edd02c9abce | 15:04 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/5f67d35fd4d333e321a3662adc60e5676879c5a2 | 15:04 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/5fe17728bf96818dd64ef71f89c40e373301204b | 15:04 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/15b4be1cad45b6c86bea9ea2d2aece86710548c0 | 15:04 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/488ebc5821aadd7ea891df11d89d4cbca3031692 | 15:04 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/bac1869c055548f3edbfea6be5bf867ee030635e | 15:04 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/e59d8a1c113a9837b8e062f78052fbec3d92dcf7 | 15:04 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/2f50c3f8d1b161bff2b6e641b603300dbffc6b95 | 15:04 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/0d4ba5b2325782dcfddbc63b9e98e53bf8b57d4e | 15:04 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4352 synchronized by vinx13 | 15:19 |
| -!- travis-ci [~travis-ci@ec2-23-20-169-236.compute-1.amazonaws.com] has joined #shogun | 15:26 | |
| travis-ci | it's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/408053460 | 15:26 |
| -!- travis-ci [~travis-ci@ec2-23-20-169-236.compute-1.amazonaws.com] has left #shogun [] | 15:26 | |
| -!- travis-ci [~travis-ci@ec2-54-147-133-39.compute-1.amazonaws.com] has joined #shogun | 15:27 | |
| travis-ci | it's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/408053460 | 15:27 |
| -!- travis-ci [~travis-ci@ec2-54-147-133-39.compute-1.amazonaws.com] has left #shogun [] | 15:27 | |
| -!- HeikoS1 [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has joined #shogun | 16:20 | |
| -!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has quit [Ping timeout: 268 seconds] | 16:21 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4352 synchronized by vinx13 | 16:36 |
| -!- HeikoS1 [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has quit [Ping timeout: 256 seconds] | 16:53 | |
| -!- HeikoS [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has joined #shogun | 17:02 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 17:02 | |
| -!- HeikoS [~heiko@eduroam-int-pat-8-246.ucl.ac.uk] has quit [Ping timeout: 268 seconds] | 17:07 | |
| -!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has joined #shogun | 17:19 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 17:19 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4385 opened by karlnapf | 19:04 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4385 karlnapf added label: "performance improvement" | 19:04 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4385 karlnapf added label: "Cleanups" | 19:04 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4385 karlnapf added label: "good first issue" | 19:05 |
| -!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has quit [Ping timeout: 256 seconds] | 20:08 | |
| --- Log closed Thu Jul 26 00:00:25 2018 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!