--- Log opened Tue Aug 14 00:00:52 2018 | ||
-!- Netsplit *.net <-> *.split quits: zxtx | 02:57 | |
-!- Netsplit over, joins: zxtx | 03:04 | |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4380 synchronized by vinx13 | 05:52 |
---|---|---|
-!- witness [uid10044@gateway/web/irccloud.com/x-afkkkmpwtmpehuik] has joined #shogun | 06:00 | |
-!- witness [uid10044@gateway/web/irccloud.com/x-afkkkmpwtmpehuik] has quit [Quit: Connection closed for inactivity] | 08:14 | |
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:3078:e3f2:a766:5a01] has joined #shogun | 11:16 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 11:16 | |
@wiking | wuwei[m], hey hey | 12:14 |
@wiking | here? | 12:14 |
wuwei[m] | wiking: hi | 12:14 |
@wiking | mmm so i guess the problem with the integration test of evaluation-cross_validation_pipeline | 12:14 |
@wiking | is serialization | 12:14 |
@wiking | or? | 12:14 |
@wiking | although there's already some other problems like | 12:14 |
@wiking | [DEBUG] Own parameter Serializable::value=0.98125 different from provided Serializable::value=0.50625 | 12:14 |
wuwei[m] | i'm not sure now | 12:16 |
@wiking | i've just checked the last travis job | 12:16 |
@wiking | https://api.travis-ci.org/v3/job/415749737/log.txt | 12:16 |
wuwei[m] | haven't check that | 12:17 |
wuwei[m] | but ica converter pr is ready | 12:17 |
wuwei[m] | yeah i've seen that | 12:17 |
wuwei[m] | it might be some problem about using factory methods | 12:18 |
wuwei[m] | because test data is generated before using factories | 12:19 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4390 merged by vigsterkr | 12:19 |
@sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/c89317eff908726ecb14bd6053f794e6a4320a72 by vigsterkr | 12:19 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4367 merged by vigsterkr | 12:21 |
@sukey | [https://github.com/shogun-toolbox/shogun] vigsterkr pushed 4 commits: | 12:21 |
@sukey | https://github.com/shogun-toolbox/shogun/commit/2fe8de3e33570c7fe9b3c99ed84f015cf3009b6f | 12:21 |
@sukey | https://github.com/shogun-toolbox/shogun/commit/ca6518e6ff043c0a85b71eb8f9bd65c3d31d06a9 | 12:21 |
@sukey | https://github.com/shogun-toolbox/shogun/commit/305f1c02e8e43f75b04545dd1fc720367c27b37a | 12:21 |
@sukey | https://github.com/shogun-toolbox/shogun/commit/2c3837471d470d5ab9c4084a803e93843b056f21 | 12:21 |
-!- travis-ci [~travis-ci@ec2-54-91-111-0.compute-1.amazonaws.com] has joined #shogun | 13:09 | |
travis-ci | it's Wuwei Lin's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/415854311 | 13:09 |
-!- travis-ci [~travis-ci@ec2-54-91-111-0.compute-1.amazonaws.com] has left #shogun [] | 13:09 | |
-!- travis-ci [~travis-ci@ec2-54-211-248-34.compute-1.amazonaws.com] has joined #shogun | 13:39 | |
travis-ci | it's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/415855208 | 13:39 |
-!- travis-ci [~travis-ci@ec2-54-211-248-34.compute-1.amazonaws.com] has left #shogun [] | 13:39 | |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4380 synchronized by vinx13 | 14:01 |
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:3078:e3f2:a766:5a01] has quit [Quit: Leaving.] | 14:11 | |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4380 synchronized by vinx13 | 14:41 |
@wiking | wuwei[m], ok so i guess i should merge the new data :) | 15:15 |
wuwei[m] | yeah thanks | 15:16 |
@wiking | b4 merging let me just check what happens with the clang job | 15:19 |
@wiking | wuwei[m], 100% tests passed, 0 tests failed out of 504 | 15:22 |
@wiking | yey | 15:22 |
@wiking | restarted all the other jobs | 15:24 |
@wiking | lets see | 15:24 |
@wiking | wuwei[m], https://travis-ci.org/shogun-toolbox/shogun/jobs/415901656#L2887 | 15:34 |
@wiking | C# | 15:34 |
@wiking | :< | 15:34 |
@wiking | pipeline.cs(34,29): error CS0266: Cannot implicitly convert type `Machine' to `Pipeline'. An explicit conversion exists (are you missing a cast?) | 15:34 |
wuwei[m] | let me check | 15:35 |
@wiking | and i guess the same happens in java | 15:35 |
@wiking | https://travis-ci.org/shogun-toolbox/shogun/jobs/415901655#L3356 | 15:35 |
@wiking | mmm there it's smoething else | 15:36 |
@wiking | import org.shogun.MachineEvaluation; | 15:36 |
@wiking | ^ | 15:36 |
@wiking | symbol: class MachineEvaluation | 15:36 |
@wiking | location: package org.shogun | 15:36 |
@wiking | /opt/shogun/build/examples/meta/java/evaluation/cross_validation_pipeline.java:55: error: cannot find symbol | 15:36 |
@wiking | MachineEvaluation cross = shogun.machine_evaluation("CrossValidation"); | 15:36 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4380 synchronized by vinx13 | 15:42 |
@wiking | wuwei[m], the same error persist in java | 15:56 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4380 synchronized by vinx13 | 15:57 |
wuwei[m] | should be fixed now, let's see | 15:58 |
@wiking | wuwei[m], k | 16:01 |
@wiking | wuwei[m], i can see you but not really hear anythign | 16:01 |
@wiking | maybe disable video? | 16:01 |
@wiking | wuwei[m], can u hear me? | 16:02 |
@wiking | wuwei[m], dunno if its my connection | 16:03 |
@wiking | or yours | 16:03 |
@wiking | but i only hear like every 10th word :) | 16:03 |
wuwei[m] | i can hear you | 16:04 |
@wiking | but not me :( | 16:04 |
@wiking | ok | 16:04 |
@wiking | lets see if anybody else shows up | 16:04 |
@wiking | if not then we can have a meeting here :))) | 16:04 |
@wiking | due to connection problems | 16:05 |
@wiking | :) | 16:05 |
wuwei[m] | sure | 16:05 |
@wiking | ok so anyhow | 16:05 |
@wiking | let's see how this PR goes | 16:05 |
@wiking | i mean the last patch | 16:05 |
@wiking | hopefully now all will be in place | 16:05 |
@wiking | i was just checking in the meanwhile this one https://github.com/shogun-toolbox/shogun/pull/4376 | 16:06 |
@wiking | currently that one is failing | 16:06 |
wuwei[m] | yeah | 16:06 |
@wiking | wuwei[m], have u seen this https://api.travis-ci.org/v3/job/412615243/log.txt | 16:09 |
@wiking | wuwei[m], [0m[1m/opt/shogun/build/src/interfaces/python/shogunPYTHON_wrap.cxx:10091:9: [0m[0;1;31merror: [0m[1mno matching member function for call to 'put'[0m | 16:10 |
@wiking | self->put("feature_matrix", new_feat_matrix); | 16:10 |
@wiking | wuwei[m], | 16:28 |
@wiking | mmm just realised | 16:28 |
@wiking | https://github.com/shogun-toolbox/shogun/pull/4380/files#diff-5782297405e0b7f12c2bd5d430f34d8fR46 | 16:28 |
@wiking | :( | 16:28 |
@wiking | i mean i understand why | 16:28 |
@wiking | but this is a problem because how do you get back the Pipeline | 16:28 |
@wiking | i think i've mentioned this couple of times in that PR | 16:29 |
@wiking | that as soon as well loose Pipeline type | 16:29 |
@wiking | we loose access to its internals | 16:29 |
@wiking | or? | 16:29 |
wuwei[m] | we can either use .as or pipeline(Machine*) | 16:29 |
@wiking | well .as only works in c++ right? :)( | 16:30 |
wuwei[m] | yeah | 16:30 |
@wiking | the pipeline(Machine*) thing just seems like a pain | 16:30 |
@wiking | to use | 16:30 |
wuwei[m] | yeah | 16:30 |
@wiking | this is 'just because' we dont want to add Pipeline as a base class? | 16:30 |
wuwei[m] | current problem is we can't put Pipeline* into Machine* | 16:31 |
@wiking | what do you mean by that? | 16:31 |
wuwei[m] | i didn't try making pipeline a base class, maybe that works, the problem now is that it throws an error that you can't put Some<Pipeline> to a parameter CMachine* | 16:34 |
@wiking | ah yeah | 16:34 |
@wiking | lemme just think a bit about that thing | 16:34 |
@wiking | since now the whole pipeline thing is great | 16:35 |
@wiking | just this little part is bugging me | 16:35 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4376 synchronized by vinx13 | 16:37 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4380 synchronized by vinx13 | 16:57 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4376 synchronized by vinx13 | 16:59 |
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:3078:e3f2:a766:5a01] has joined #shogun | 19:22 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 19:22 | |
--- Log closed Wed Aug 15 00:00:54 2018 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!