--- Log opened Sat Aug 18 00:00:58 2018 | ||
-!- HeikoS [~heiko@host86-144-26-233.range86-144.btcentralplus.com] has joined #shogun | 11:23 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 11:23 | |
-!- HeikoS [~heiko@host86-144-26-233.range86-144.btcentralplus.com] has quit [Quit: Leaving.] | 11:31 | |
-!- HeikoS [~heiko@host86-144-26-233.range86-144.btcentralplus.com] has joined #shogun | 11:32 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 11:32 | |
lisitsyn | HeikoS: hey | 12:42 |
---|---|---|
@HeikoS | hi | 12:43 |
@HeikoS | lisitsyn: whats up? | 12:43 |
lisitsyn | HeikoS: I was quite absent lately :P | 12:43 |
@HeikoS | I noticed :D | 12:43 |
lisitsyn | wanted to catch up | 12:43 |
@HeikoS | sure | 12:44 |
@HeikoS | I will be more absent from now on :) | 12:44 |
@HeikoS | whats up with you? | 12:44 |
lisitsyn | well nothing, I was on holidays | 12:44 |
lisitsyn | :) | 12:44 |
@HeikoS | hiaha ok | 12:44 |
@HeikoS | I remember asking you for something code wise | 12:44 |
@HeikoS | but I forgot what it was | 12:45 |
lisitsyn | I do | 12:45 |
@HeikoS | what was it? | 12:45 |
lisitsyn | it is that log regression | 12:45 |
lisitsyn | that's group regularized | 12:45 |
lisitsyn | aka featureblock | 12:45 |
@HeikoS | ah yes that as well | 12:45 |
@HeikoS | but that is quite minor | 12:45 |
lisitsyn | the whole thing is rather not ready for plugins/parameters | 12:45 |
@HeikoS | I have some other things | 12:45 |
@HeikoS | like | 12:45 |
@HeikoS | we need to be able to register std::vector | 12:45 |
lisitsyn | really? | 12:45 |
@HeikoS | and that needs to work with clone and equals | 12:45 |
@HeikoS | std::vector<SGVector<float64_t>> | 12:46 |
@HeikoS | for example | 12:46 |
lisitsyn | oh really? :D | 12:46 |
lisitsyn | ufff | 12:46 |
@HeikoS | because wiking wants to use this in more and more classes | 12:46 |
@HeikoS | so currently, nothing works with those | 12:46 |
@HeikoS | (old framework also couldnt do it) | 12:46 |
lisitsyn | yeah but it should work more or less seamlessly | 12:46 |
@HeikoS | registering works | 12:46 |
lisitsyn | what does not work? | 12:46 |
@HeikoS | but clone equals | 12:46 |
@HeikoS | that is tricky | 12:47 |
@HeikoS | as it needs to be recursive | 12:47 |
@HeikoS | i.e. the whole decltype checking of ->equals .equals == | 12:47 |
@HeikoS | needs to happen in the elements of the std::vector as well | 12:47 |
lisitsyn | ah you want deep clone and deep equals | 12:47 |
@HeikoS | the operator == on std>>vector | 12:47 |
@HeikoS | compares using ++ | 12:47 |
@HeikoS | == | 12:47 |
@HeikoS | yes | 12:47 |
@HeikoS | makes sense or> | 12:48 |
@HeikoS | ? | 12:48 |
@HeikoS | well does it? | 12:48 |
lisitsyn | yeah yeah why not | 12:48 |
@HeikoS | but also | 12:48 |
@HeikoS | we dont want to hand craft this for all std:: structures right? | 12:48 |
@HeikoS | so we need std::vector::equals | 12:48 |
@HeikoS | could overload the thing | 12:49 |
@HeikoS | but thats not nice | 12:49 |
lisitsyn | uhmm | 12:49 |
lisitsyn | we can't really specialize for templates | 12:49 |
lisitsyn | ah no we can | 12:50 |
@HeikoS | but we want to use the original type | 12:50 |
@HeikoS | or not | 12:50 |
@HeikoS | I dont know | 12:50 |
@HeikoS | swig should work | 12:50 |
@HeikoS | internally we can do whatever | 12:50 |
@HeikoS | some food for thought | 12:50 |
@HeikoS | feature block is another thing | 12:50 |
@HeikoS | and the third one is serialization | 12:50 |
@HeikoS | there is wikings feature branch | 12:51 |
@HeikoS | if you have some input on that | 12:51 |
@HeikoS | because it is a release blocker | 12:51 |
lisitsyn | ok we had something good in belgrade but it got stucked | 12:51 |
@HeikoS | yeah loading seems a fundamental problem | 12:51 |
@HeikoS | the recursiveness | 12:51 |
@HeikoS | and the fact that we dont want to implement our own json writer | 12:52 |
lisitsyn | I think we need that | 12:52 |
lisitsyn | not really thing emitting {"" whatever | 12:52 |
lisitsyn | but we do need to control the json layout | 12:52 |
@HeikoS | yep | 12:53 |
@HeikoS | this is more important | 12:53 |
@HeikoS | than std::vector | 12:53 |
@HeikoS | but std::vector is also really important actually | 12:53 |
lisitsyn | I just checked and it seems more or less possible | 12:53 |
@HeikoS | as once we have that deep clone equals (of all of the std::structures), then we can drop our own vectors | 12:53 |
lisitsyn | we just need a way to detect std vector | 12:53 |
lisitsyn | we already detect pointers and functions | 12:54 |
@HeikoS | lisitsyn: tbh if we detect std::vector inside the any equals, and then do it by hand in there I am fine | 12:54 |
@HeikoS | just we also want: | 12:54 |
@HeikoS | list and map | 12:54 |
@HeikoS | and maybe more | 12:54 |
@HeikoS | but a hacky addition for vector should be already a great step forward | 12:54 |
@HeikoS | lisitsyn: I have to leave now, will check back tomorrow | 12:54 |
@HeikoS | nice to catch up! :) | 12:54 |
@HeikoS | where was your holiday? | 12:54 |
lisitsyn | cyprus | 12:55 |
lisitsyn | oh well that's the most russian island out there I guess | 12:55 |
lisitsyn | apart from that it is nice | 12:55 |
@HeikoS | haha | 12:56 |
@HeikoS | nice | 12:56 |
@HeikoS | nice place | 12:56 |
@HeikoS | shall we start with the std::vector | 12:56 |
@HeikoS | if you send the skeleton, then I can integrate it, write tests and use it | 12:57 |
lisitsyn | yeah ok once I get spare time I'll patch to support std::vector (or collections in general) | 12:57 |
@HeikoS | cool thx | 12:57 |
@HeikoS | collection in general would be best | 12:57 |
@HeikoS | ah yeah of course | 12:57 |
@HeikoS | great! | 12:57 |
@HeikoS | talk later! | 12:57 |
lisitsyn | ttyl | 12:57 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4392 opened by lisitsyn | 14:03 |
@sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4392 | 14:03 |
-!- HeikoS [~heiko@host86-144-26-233.range86-144.btcentralplus.com] has quit [Ping timeout: 240 seconds] | 14:05 | |
-!- HeikoS [~heiko@host86-144-26-233.range86-144.btcentralplus.com] has joined #shogun | 14:47 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 14:47 | |
-!- HeikoS [~heiko@host86-144-26-233.range86-144.btcentralplus.com] has quit [Ping timeout: 240 seconds] | 17:21 | |
--- Log closed Sun Aug 19 00:00:59 2018 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!