--- Log opened Mon Sep 17 00:00:40 2018 | ||
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:adf4:8dac:e66a:2204] has joined #shogun | 12:50 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 12:51 | |
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:adf4:8dac:e66a:2204] has quit [Ping timeout: 252 seconds] | 12:58 | |
-!- HeikoS [~heiko@host86-151-43-178.range86-151.btcentralplus.com] has joined #shogun | 13:11 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 13:11 | |
-!- HeikoS [~heiko@host86-151-43-178.range86-151.btcentralplus.com] has quit [Ping timeout: 272 seconds] | 13:19 | |
-!- witness [uid10044@gateway/web/irccloud.com/x-nanwkyaenzlyxvpq] has joined #shogun | 13:53 | |
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:adf4:8dac:e66a:2204] has joined #shogun | 14:16 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 14:16 | |
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:adf4:8dac:e66a:2204] has quit [Ping timeout: 252 seconds] | 14:25 | |
@wiking | lisitsyn, man | 14:52 |
---|---|---|
@wiking | this sort of functions void CSGObject::build_gradient_parameter_dictionary(CMap<TParameter*, CSGObject*>* dict) | 14:52 |
@wiking | :) | 14:52 |
@wiking | lisitsyn, i have a q | 16:47 |
@wiking | since currently we store w and features and labels as a model param | 16:48 |
@wiking | the only way to actually get out the actual params of a model is to somehow manually do a gettype... i'm wondering whether build_gradient_parameter_dictionary is something that would cover all the model params that are actually the params of the model :) | 16:49 |
@wiking | lisitsyn, see https://pastebin.com/x4PyfYWf | 16:52 |
@wiking | data_locked, features, labels, store_model_features, w | 16:52 |
@wiking | are not the model params | 16:52 |
@wiking | that traditional ml paramers think/call model params | 16:53 |
@wiking | and since for example | 16:53 |
@wiking | SG_ADD( | 16:53 |
@wiking | &use_bias, "use_bias", "Indicates if bias is used.", MS_NOT_AVAILABLE); | 16:53 |
@wiking | SG_ADD(&epsilon, "epsilon", "Convergence precision.", MS_NOT_AVAILABLE); | 16:53 |
@wiking | the gradient thing would not fly as a good filter obviously | 16:53 |
@sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4398 opened by vigsterkr | 17:18 |
@wiking | lisitsyn, so? | 17:26 |
@wiking | :) | 17:26 |
lisitsyn | wiking: so you want to get all the parameters of the object? | 17:26 |
lisitsyn | trainable? | 17:26 |
@wiking | well see the pastebin | 17:26 |
@wiking | i mean some of those are not real ML parameters | 17:27 |
@wiking | right? ) | 17:27 |
lisitsyn | ah ok | 17:27 |
@wiking | data_locked, features, labels, store_model_features, w | 17:27 |
@wiking | these are 'shogun' related stuff | 17:27 |
@wiking | not much to do with the model itself | 17:27 |
lisitsyn | I think we should switch to _data_locked | 17:27 |
lisitsyn | :P | 17:27 |
lisitsyn | python! | 17:27 |
@wiking | hahahahahahha | 17:27 |
@wiking | serious? :) | 17:27 |
lisitsyn | I don't know | 17:27 |
@wiking | enum? | 17:27 |
lisitsyn | or add a few methods | 17:27 |
@wiking | with multimap? | 17:27 |
@wiking | :) | 17:27 |
lisitsyn | like trainable parameters | 17:27 |
lisitsyn | model_parameters, internal_parameters, etc | 17:28 |
lisitsyn | state_parameters | 17:28 |
@wiking | lisitsyn, we can use std::multinap | 17:28 |
@wiking | no? | 17:28 |
@wiking | :) | 17:28 |
lisitsyn | why? what for? | 17:28 |
@wiking | lisitsyn, basically i wanna tag the tag | 17:29 |
lisitsyn | wiking: where do we have multiple keys? | 17:29 |
@wiking | :) | 17:29 |
@wiking | if you see what i mean? :) | 17:29 |
lisitsyn | that's fine | 17:29 |
@wiking | but trying to avoid another hashmap | 17:29 |
@wiking | :) | 17:29 |
@wiking | but yeah the simplest way is to have those various hashmaps | 17:30 |
@wiking | :) | 17:30 |
@wiking | but it feels eeeeh | 17:30 |
@wiking | but i guess it's gonna be that | 17:30 |
@wiking | :) | 17:30 |
lisitsyn | wiking: anyway you don't need multimap | 17:31 |
@wiking | yeah i know | 17:31 |
@wiking | i mean i was trying to say that i'd like to index the tags | 17:31 |
@wiking | with multiple keys | 17:31 |
@wiking | :) | 17:31 |
lisitsyn | that's like 2-level map | 17:31 |
lisitsyn | wiking: but adding _ is a good hack | 17:32 |
lisitsyn | :) | 17:32 |
@wiking | you are note serious now right? :) | 17:32 |
@wiking | *not | 17:32 |
@wiking | i mean but what would you do | 17:32 |
@wiking | [i.startswith("_") for i parameters_list()] | 17:33 |
@wiking | ? | 17:33 |
@wiking | :D | 17:33 |
@wiking | or sophistication level ++ | 17:33 |
@wiking | that when you create a Tag you check for "_" prefix? | 17:33 |
@wiking | :D | 17:33 |
@wiking | and then insert it into different maps | 17:33 |
@wiking | there are some other issues here | 17:34 |
@wiking | like we currently set the default value of a parameter by code, but the only way to get that info is actually construct an obj and check the values of the model param | 17:34 |
@wiking | so i cannot just say | 17:35 |
@wiking | get_param("name?) | 17:35 |
@wiking | or something | 17:35 |
@wiking | and it will give me back | 17:35 |
@wiking | param value, documentation and default value | 17:35 |
@wiking | :) | 17:35 |
@wiking | we have this magic | 17:36 |
@wiking | char* get_modsel_param_descr(const char* param_name); | 17:36 |
@wiking | but i mean | 17:36 |
@wiking | :D | 17:36 |
lisitsyn | wiking: I just don't know if we really have good groups for parameters | 17:36 |
lisitsyn | like classification of parameters | 17:36 |
@wiking | yeah we currently have 2 | 17:37 |
@wiking | right? | 17:37 |
@wiking | i mean 2 gorups | 17:37 |
@wiking | MS_AVAILABLE vs MS_NOT_AVAILABLE | 17:37 |
@wiking | now i wanna add a new group | 17:37 |
@wiking | :) | 17:37 |
@wiking | basically this is the story | 17:37 |
@wiking | but i mean | 17:38 |
@wiking | we can hide this | 17:38 |
@wiking | into AnyParameterProperties | 17:38 |
@wiking | right? :) | 17:38 |
@wiking | i guess actually that would be a good place for this | 17:38 |
@wiking | lisitsyn, ^ | 17:38 |
lisitsyn | wiking: yeah lemme check | 17:39 |
lisitsyn | somewhere like that | 17:39 |
lisitsyn | wiking: yeah a good place probably | 17:42 |
@wiking | lisitsyn, hehe | 17:48 |
@wiking | lisitsyn, and then just expose these params | 17:48 |
@wiking | i mean AnyParameterProperties get_properties() const | 17:48 |
@wiking | is there | 17:48 |
lisitsyn | yeah | 17:48 |
lisitsyn | that's exactly for such things | 17:48 |
@wiking | only thing that AnyParameter is not exposed | 17:49 |
@wiking | and i guess we dont wanna expose it right? :) | 17:49 |
@wiking | (to swig) | 17:49 |
@wiking | so i mean in the c++ api i would do something like | 17:49 |
@wiking | std::vector<> get_parameters(std::vector<AnyParamTypes> anyParameterFilter) | 17:50 |
@wiking | and then do some dummy wrappers over this for SWIG? | 17:50 |
@wiking | or fully expose anyparameter? :) | 17:51 |
@wiking | see what i mean? | 17:51 |
-!- HeikoS [~heiko@host86-151-43-178.range86-151.btcentralplus.com] has joined #shogun | 18:14 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 18:14 | |
-!- HeikoS [~heiko@host86-151-43-178.range86-151.btcentralplus.com] has quit [Ping timeout: 245 seconds] | 18:39 | |
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:adf4:8dac:e66a:2204] has joined #shogun | 19:55 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 19:55 | |
-!- HeikoS [~heiko@2a00:23c5:e10a:5c00:adf4:8dac:e66a:2204] has quit [Ping timeout: 252 seconds] | 20:07 | |
--- Log closed Tue Sep 18 00:00:42 2018 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!