IRC logs of #shogun for Thursday, 2018-11-15

« Wednesday, 2018-11-14 Index Friday, 2018-11-16 »
--- Log opened Thu Nov 15 00:00:03 2018
-!- HeikoS [~heiko@p4FED5ABB.dip0.t-ipconnect.de] has joined #shogun00:17
-!- mode/#shogun [+o HeikoS] by ChanServ00:17
-!- HeikoS [~heiko@p4FED5ABB.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]00:35
-!- HeikoS [~heiko@p4FED5B4D.dip0.t-ipconnect.de] has joined #shogun10:48
-!- mode/#shogun [+o HeikoS] by ChanServ10:48
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4412 merged by karlnapf10:55
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/b45243cf5afadcea5dee1df21284c2442ee01e98 by karlnapf10:55
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4405 merged by karlnapf10:57
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/6e42c52da66d995ca057ac7148682b1d4d77eea8 by karlnapf10:57
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4413 closed by karlnapf11:07
-!- gf712 [c13cdcfd@gateway/web/freenode/ip.193.60.220.253] has joined #shogun11:45
@HeikoSgf712: yo!11:46
@HeikoSgf712: so now that we have the attributes ....11:46
@HeikoSwe should think about how to best use this from shogun classes11:47
@HeikoSI suggest we make a PR where we deploy this new masking idea to a few example classes11:47
gf712OK, would we still used the call from within the macro?11:47
@HeikoSand then we document the idea and how to change it in an entrance task issue11:47
@HeikoSyeah good question with the macro11:48
@HeikoSI wonder whether we can overload it nicely11:48
@HeikoSi.e.11:48
gf712OK, can give it a go with a simple example like Perceptron or LinearRegression11:48
@HeikoSSG_ADD(pointer, name, mask)?11:48
@HeikoSthat should actually work or?11:48
gf712so is that the same as now but without the description?11:49
@HeikoSah sorry11:49
@HeikoSdescription as well11:49
@HeikoSSG_ADD(pointer, name, description, mask)11:49
@HeikoSand then11:49
@HeikoSSG_ADD(pointer, name, description)11:49
@HeikoS(default mask)11:49
@HeikoSthose two should work11:49
@HeikoSand then yes, a few examples11:50
gf712OK, and that replaces the current SG_ADD4?11:50
@HeikoSyeah probably11:50
gf712and then a SG_ADD3 with the default?11:50
@HeikoSthe only thing is11:50
@HeikoSthat this will be hard to refactor11:50
@HeikoSas currently an enum is passed11:50
gf712maybe.. Can give it a go and see how many errors come out..11:50
@HeikoSok11:51
@HeikoSI mean11:51
@HeikoSit has to be done eventually11:51
gf712but the enums are binary so they are used usually in conditions no? So might just have to change the type in the declarations?11:51
@HeikoSwhat do you mean?11:51
@HeikoSi think most common are11:52
@HeikoSSG_ADD(...) without any modelselection mention11:52
@HeikoSand then SG_ADD(... MODEL_SELECTION_PARAMETER)11:52
gf712Oh right, that part, sorry11:52
@HeikoSSG_ADD(&m_log_width, "log_width", "Kernel width in log domain", MS_AVAILABLE, GRADIENT_AVAILABLE);11:52
@HeikoSGaussianKernel.cpp11:52
@HeikoSuses both11:52
@HeikoSSG_ADD(&properties, "properties", "Feature properties", MS_NOT_AVAILABLE);11:53
@HeikoSFeatures.cpp11:53
@HeikoSuses only one11:53
@HeikoSI think SG_ADD3 is not defined right?11:53
@HeikoSso omitting the properties completely wont compile11:53
gf712NO SG_ADD3 does not exist11:53
@HeikoSok11:53
@HeikoSthen you can let the compiler work for you11:53
@HeikoScompiler errors11:53
@HeikoSso SG_ADD5 is remove11:54
@HeikoSSG_ADD4 uses the mask11:54
@HeikoSand defaults to no property set11:54
@HeikoSand SG_ADD3 doesnt exist11:54
@HeikoSmakes sense?11:54
gf712OK, just thinking how to set to no property11:55
@HeikoSi think properties should always behave in a way that one explicitly has to add them11:55
@HeikoSi.e. everything zero is the default11:55
@HeikoSand that means11:55
gf712yes, I think that is what happens11:55
@HeikoSparameter that is accessible via put/get11:55
gf712as in when calling AnyProperties enum class should be zero when instantiating11:55
@HeikoSand thats all11:55
@HeikoSyes, although I would be even more explicit11:56
@HeikoSand AnyProperties doesnt have default ctor11:56
@HeikoSah sorry11:56
@HeikoSit does11:56
@HeikoSand then all zero11:56
@HeikoSand that is used like you say11:56
@HeikoSand then the author of the class can decide what is model parameter what has gradients etc11:56
@HeikoSoh btw11:56
gf712sorry I mean enum class ParameterProperties11:56
@HeikoSyes11:57
gf712what happens when it is instantiated?11:57
gf712is it all zero?11:57
@HeikoSnothing is set11:57
@HeikoSy11:57
gf712ok!11:57
@HeikoSmakes sense or?11:57
@HeikoSgf712: oh btw11:57
@HeikoSbefore you do that11:57
gf712yes, makes sense, I just wasn't sure if it was undefined behaviour11:57
@HeikoScould you make a test for the  getters11:57
gf712Yup, where would it make sense to put those?11:58
@HeikoSso that we know the old API still works .... get_modelselection()11:58
@HeikoSchecking11:58
gf712btw should I add getters called is_*?11:58
@HeikoSAny_unittest11:58
gf712if they return a boolean it makes more sense no?11:58
@HeikoSgf712: yes11:58
@HeikoSbut why not general purpose11:58
@HeikoSis(AnyParameterProperties)11:58
@HeikoSis(AnyParameterProperties::MODEL)11:59
@HeikoSsorry11:59
@HeikoSbool has_property(enum class AnyParameterProperties)11:59
@HeikoSand this one can be used for any property11:59
@HeikoSlike I call it as11:59
gf712true, that is more compact!12:00
@HeikoShas_propertyAnyParameterProperties::MODEL)12:00
@HeikoSor has_property(AnyParameterProperties::MODEL | AnyParameterProperties::GRADIENT)12:00
@HeikoSor has_property(AnyParameterProperties::MODEL & AnyParameterProperties::GRADIENT)12:00
@HeikoSall useful cases12:00
@HeikoSok cool12:00
@HeikoSso then we have12:00
@HeikoS1) test the old API12:01
@HeikoS2) refactor SG_ADD12:01
@HeikoS3) solve all compile errors12:01
@HeikoSi think 1) can be a separate PR12:01
@HeikoSand then 2/3 can be one12:01
gf712cool! sound like fun :D12:01
@HeikoSlol, well hopefully :D12:01
@HeikoSand then next step would be to observe parameters is put12:01
gf712alright, Ill get to it!12:01
@HeikoScool!12:01
@HeikoSIll keep an eye on my emails12:02
gf712yup, can then discuss that with Viktor?12:02
@HeikoSyeah the observe part we should discuss with him and Giovanni12:02
@HeikoSas I think we should change the design a bit ...12:02
@HeikoSbut we will discuss12:02
@HeikoSah12:02
@HeikoSanother thing12:02
@HeikoSah nevermind12:02
@HeikoSlater :)12:02
gf712haha ok!12:03
gf712ill keep you updated!12:03
@HeikoScool man thx!12:03
@HeikoSI am setting up the admin with the ATI btw12:03
@HeikoSshould be a contractor soon12:03
@HeikoSthen I can come visit London in December maybe12:03
@HeikoSor latest in Jan12:03
gf712ah cool! so they pay for travelling?12:04
@HeikoSoh and we wanna do a shogun workshop early next year, I think you should join as well! :)12:04
gf712yes, sounds good12:04
gf712where would it be?12:04
@HeikoSgf712: see you!12:04
gf712see you!12:05
@HeikoSgf712: maybe spain somewhere warm12:08
@HeikoSand I might be in spain that time anyways12:08
@HeikoSwe usually have some funding for meetings12:08
@HeikoSwould be cool to get the ATI pay for your attending12:08
@HeikoSI am sure we can ask :)12:08
gf712haha, yup that would be good!12:09
-!- travis-ci [~travis-ci@ec2-54-242-185-53.compute-1.amazonaws.com] has joined #shogun12:19
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/45541358512:19
-!- travis-ci [~travis-ci@ec2-54-242-185-53.compute-1.amazonaws.com] has left #shogun []12:19
-!- travis-ci [~travis-ci@ec2-54-146-188-98.compute-1.amazonaws.com] has joined #shogun12:33
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/45541358512:33
-!- travis-ci [~travis-ci@ec2-54-146-188-98.compute-1.amazonaws.com] has left #shogun []12:33
-!- travis-ci [~travis-ci@ec2-54-158-106-121.compute-1.amazonaws.com] has joined #shogun12:40
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/45541411912:40
-!- travis-ci [~travis-ci@ec2-54-158-106-121.compute-1.amazonaws.com] has left #shogun []12:40
-!- travis-ci [~travis-ci@ec2-54-158-106-121.compute-1.amazonaws.com] has joined #shogun13:21
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/45541411913:21
-!- travis-ci [~travis-ci@ec2-54-158-106-121.compute-1.amazonaws.com] has left #shogun []13:21
-!- HeikoS [~heiko@p4FED5B4D.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]13:42
-!- gf712 [c13cdcfd@gateway/web/freenode/ip.193.60.220.253] has quit [Ping timeout: 256 seconds]13:46
-!- travis-ci [~travis-ci@ec2-54-163-94-123.compute-1.amazonaws.com] has joined #shogun15:08
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in gf712/shogun: https://travis-ci.org/gf712/shogun/builds/45549454615:08
-!- travis-ci [~travis-ci@ec2-54-163-94-123.compute-1.amazonaws.com] has left #shogun []15:08
-!- travis-ci [~travis-ci@ec2-184-73-35-63.compute-1.amazonaws.com] has joined #shogun15:08
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in gf712/shogun: https://travis-ci.org/gf712/shogun/builds/45549454615:08
-!- travis-ci [~travis-ci@ec2-184-73-35-63.compute-1.amazonaws.com] has left #shogun []15:08
-!- travis-ci [~travis-ci@ec2-54-163-94-123.compute-1.amazonaws.com] has joined #shogun15:24
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in gf712/shogun: https://travis-ci.org/gf712/shogun/builds/45549401215:24
-!- travis-ci [~travis-ci@ec2-54-163-94-123.compute-1.amazonaws.com] has left #shogun []15:24
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4414 opened by gf71215:39
-!- travis-ci [~travis-ci@ec2-54-158-243-227.compute-1.amazonaws.com] has joined #shogun15:40
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in gf712/shogun: https://travis-ci.org/gf712/shogun/builds/45552078015:40
-!- travis-ci [~travis-ci@ec2-54-158-243-227.compute-1.amazonaws.com] has left #shogun []15:40
-!- travis-ci [~travis-ci@ec2-54-147-192-193.compute-1.amazonaws.com] has joined #shogun16:07
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in gf712/shogun: https://travis-ci.org/gf712/shogun/builds/45550517816:07
-!- travis-ci [~travis-ci@ec2-54-147-192-193.compute-1.amazonaws.com] has left #shogun []16:07
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4415 opened by gf71216:07
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4415 closed by gf71216:07
-!- gf712 [c13cdcfd@gateway/web/freenode/ip.193.60.220.253] has joined #shogun16:17
-!- rcurtin [~ryan@knife.lugatgt.org] has quit [Ping timeout: 252 seconds]16:34
-!- rcurtin [~ryan@knife.lugatgt.org] has joined #shogun16:40
-!- travis-ci [~travis-ci@ec2-54-147-192-193.compute-1.amazonaws.com] has joined #shogun17:13
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in gf712/shogun: https://travis-ci.org/gf712/shogun/builds/45552752617:13
-!- travis-ci [~travis-ci@ec2-54-147-192-193.compute-1.amazonaws.com] has left #shogun []17:13
-!- rcurtin [~ryan@knife.lugatgt.org] has quit [Ping timeout: 272 seconds]17:30
-!- rcurtin [~ryan@knife.lugatgt.org] has joined #shogun17:36
-!- gf712 [c13cdcfd@gateway/web/freenode/ip.193.60.220.253] has quit [Ping timeout: 256 seconds]17:40
-!- travis-ci [~travis-ci@ec2-54-242-185-53.compute-1.amazonaws.com] has joined #shogun17:49
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in gf712/shogun: https://travis-ci.org/gf712/shogun/builds/45552752617:49
-!- travis-ci [~travis-ci@ec2-54-242-185-53.compute-1.amazonaws.com] has left #shogun []17:49
-!- HeikoS [~heiko@p4FED5B4D.dip0.t-ipconnect.de] has joined #shogun19:05
-!- mode/#shogun [+o HeikoS] by ChanServ19:05
-!- travis-ci [~travis-ci@ec2-54-162-216-63.compute-1.amazonaws.com] has joined #shogun19:05
travis-ciit's Gil's turn to pay the next round of drinks for the massacre he caused in gf712/shogun: https://travis-ci.org/gf712/shogun/builds/45554190819:05
-!- travis-ci [~travis-ci@ec2-54-162-216-63.compute-1.amazonaws.com] has left #shogun []19:05
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4416 karlnapf added label: "good first issue"19:45
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4416 karlnapf added label: "memory problems"19:45
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4416 karlnapf added label: "bugfixing"19:45
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4416 opened by karlnapf19:45
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4416 karlnapf added label: "BUG"19:45
-!- HeikoS [~heiko@p4FED5B4D.dip0.t-ipconnect.de] has quit [Quit: Leaving.]19:56
--- Log closed Fri Nov 16 00:00:04 2018
« Wednesday, 2018-11-14 Index Friday, 2018-11-16 »

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!