| --- Log opened Tue Jan 08 00:00:18 2019 | ||
| -!- besser82 [~besser82@fedora/besser82] has quit [Quit: Freedom, Friends, Features, First [fedoraproject.org]] | 11:56 | |
| -!- besser82 [~besser82@fedora/besser82] has joined #shogun | 11:57 | |
| -!- mode/#shogun [+o besser82] by ChanServ | 11:57 | |
| -!- wiking [~wiking@bmi-airport-1.inf.ethz.ch] has joined #shogun | 11:57 | |
| wiking | lisitsyn: ping? | 15:29 |
|---|---|---|
| -!- gf712 [905208cc@gateway/web/freenode/ip.144.82.8.204] has joined #shogun | 15:29 | |
| wiking | gf712: hey there | 15:48 |
| gf712 | hey! | 15:48 |
| gf712 | I am not sure how to fix the msvc bug with the way the code is written right now. I can extract the return type of the lambda with some convoluted std::declval | 15:50 |
| gf712 | it might be better to disable the checks with msvc, since its more of a development tool, and assume development is mainly done with gcc and clang | 15:51 |
| wiking | mmmm | 15:51 |
| wiking | you reckon to guard it with macros? | 15:52 |
| wiking | i mean apparently this'll be fixed in 2019 version of visual studio | 15:52 |
| gf712 | something like that. just make the alias be std::true_type | 15:52 |
| wiking | ok i mean i'm fine with any temp fix for the time being, the question is whether we can sanely guard that part that fails | 15:53 |
| -!- rcurtin [~ryan@knife.lugatgt.org] has quit [Quit: Lost terminal] | 15:53 | |
| gf712 | I'll give it a go, it shouldn't be too difficult I think | 15:53 |
| -!- rcurtin [~ryan@knife.lugatgt.org] has joined #shogun | 15:53 | |
| wiking | https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/lib/type_case.h#L227 is killing it | 15:54 |
| wiking | and this as well https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/lib/type_case.h#L240 | 15:54 |
| gf712 | yup, msvc doesn't like that template there | 15:54 |
| gf712 | even if we fixed the first one | 15:54 |
| wiking | yep | 15:55 |
| wiking | i haven't managed to test with 2019 preview what are the remaining errors | 15:55 |
| wiking | and azure does not provide CI host for it | 15:55 |
| gf712 | is there a macro to get the msvc version? | 15:55 |
| wiking | yes | 15:55 |
| wiking | _MSC_VER | 15:56 |
| gf712 | I don't have a windows machine or vm at hand to try it out, but I can start a PR with a macro to disable the lambda tests on msvc | 15:57 |
| wiking | gimme the patch | 15:57 |
| wiking | and i can push it | 15:57 |
| wiking | coz for your pr you would need to fork my branch | 15:57 |
| gf712 | ah ok, shall I email it to you when its ready? | 15:57 |
| wiking | yes | 15:57 |
| wiking | thnx | 15:57 |
| gf712 | it'll just be a couple of lines | 15:57 |
| gf712 | cool! | 15:58 |
| wiking | #if _MSC_VER >= 1920 | 15:59 |
| wiking | that's 2019 | 15:59 |
| gf712 | ok, thanks! | 16:00 |
| -!- wiking [~wiking@bmi-airport-1.inf.ethz.ch] has quit [Ping timeout: 252 seconds] | 16:48 | |
| -!- wiking [~wiking@bmi-airport-1.inf.ethz.ch] has joined #shogun | 16:51 | |
| wiking | gf712: got it lemme test it | 16:52 |
| gf712 | ok, sent you an updated version, it should be _MSVC_VER < 1920 | 16:53 |
| wiking | gf712: yeah i realised did that change manually ;) | 16:56 |
| wiking | gf712: https://dev.azure.com/shogunml/shogun/_build/results?buildId=195 | 16:56 |
| wiking | it'll take a good hour to get it tested | 16:56 |
| gf712 | OK! hopefully it'll work.. | 16:59 |
| wiking | fingerz crossed | 16:59 |
| wiking | if it passes i'll merge that branch into develop | 16:59 |
| wiking | and then hopefully the compiler cache will work as well | 16:59 |
| wiking | ;) | 16:59 |
| gf712 | OK! lets see.. I'll try and find a better solution in the meantime | 17:06 |
| gf712 | I'm curious if it works with msvc 2019 | 17:07 |
| wiking | mmm yeah needs testing... i'll have access to a windows sometime next week.. | 17:14 |
| gf712 | it seems like msvc doesn't like 'not' and 'and' in the templates | 18:02 |
| wiking | gf712: yeah the patch reversed the fixes i had in that branch :Facepalm: | 18:05 |
| wiking | i had a fix for that separetely already | 18:05 |
| wiking | ok i've pushed again | 18:05 |
| wiking | lets see in 1h | 18:05 |
| wiking | :D | 18:05 |
| gf712 | sorry, I only noticed that after sending you the code! | 18:05 |
| wiking | no worries | 18:06 |
| wiking | i should have spotted it as well | 18:06 |
| wiking | ok i'm off to climb | 18:06 |
| wiking | will check on it once i'm back | 18:07 |
| wiking | ttyl | 18:07 |
| -!- gf712 [905208cc@gateway/web/freenode/ip.144.82.8.204] has quit [Ping timeout: 256 seconds] | 18:10 | |
| -!- wiking [~wiking@bmi-airport-1.inf.ethz.ch] has quit [Ping timeout: 250 seconds] | 18:19 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 18:42 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Ping timeout: 245 seconds] | 19:03 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 19:18 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Ping timeout: 250 seconds] | 21:01 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 21:02 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Ping timeout: 258 seconds] | 21:13 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 21:20 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Ping timeout: 258 seconds] | 23:27 | |
| -!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 23:35 | |
| --- Log closed Wed Jan 09 00:00:20 2019 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!