| --- Log opened Mon Jan 14 00:00:27 2019 | ||
| -!- Prateek [0e8bc403@gateway/web/freenode/ip.14.139.196.3] has quit [Ping timeout: 256 seconds] | 00:02 | |
| -!- durovo [~durovo@be.cd.3ea9.ip4.static.sl-reverse.com] has joined #shogun | 04:25 | |
| -!- durovo2 [~durovo@c4.65.2ea9.ip4.static.sl-reverse.com] has quit [Remote host closed the connection] | 04:25 | |
| -!- gf712 [8028b333@gateway/web/freenode/ip.128.40.179.51] has joined #shogun | 09:21 | |
| -!- witness [uid10044@gateway/web/irccloud.com/x-hckzlkfqrjbxpmcq] has quit [Quit: Connection closed for inactivity] | 10:24 | |
| -!- Lefteris [836fb90d@gateway/web/freenode/ip.131.111.185.13] has joined #shogun | 13:08 | |
| -!- HeikoS48 [5aae046b@gateway/web/cgi-irc/kiwiirc.com/ip.90.174.4.107] has joined #shogun | 15:24 | |
| HeikoS48 | gf712 so Ill go ahead and merge | 15:24 |
|---|---|---|
| HeikoS48 | ? | 15:24 |
| HeikoS48 | Lefteris btw these feature things are much less important than say translating an example where string features are used for a kernel classifier or so | 15:24 |
| gf712 | I can stil change the docstring | 15:25 |
| gf712 | Just need to know where it is | 15:25 |
| Lefteris | ok, then. Let's keep this feature example simple and merge it as it is now? | 15:25 |
| gf712 | But other than that it's fine to merge! | 15:25 |
| Lefteris | I will need to rebase first...will do than later at night | 15:26 |
| Lefteris | I am not sure if something changed | 15:27 |
| HeikoS48 | Lefteris maybe have something to extract data from the object? | 15:28 |
| HeikoS48 | string list stuff? | 15:28 |
| HeikoS48 | gf712 not sure where the factory docstring is you mean? | 15:28 |
| Lefteris | HeikoS48: Will do | 15:30 |
| HeikoS48 | gf712 I realised it is not set | 15:30 |
| HeikoS48 | made a comment | 15:30 |
| HeikoS48 | but generally, it would be good if we could forward something from factory.h | 15:30 |
| HeikoS48 | actually | 15:30 |
| HeikoS48 | Let's just leave it as it is for now | 15:30 |
| gf712 | ah OK! | 15:30 |
| HeikoS48 | as none of the factories have set docstrings | 15:31 |
| gf712 | OK, I can have a look in another PR | 15:31 |
| gf712 | Can merge now this and see if your PR works with it? | 15:31 |
| HeikoS48 | Sure let's do that | 15:31 |
| HeikoS48 | ok merged, I will rebase my PR now | 15:32 |
| gf712 | OK, hopefully it'll work.. | 15:33 |
| HeikoS48 | just compiling | 15:34 |
| HeikoS48 | Ill need to update the data as the CI build stops before building the interfaces if there is a test in the cpp meta example integration tests | 15:34 |
| HeikoS48 | ah | 15:35 |
| HeikoS48 | actually, we also need to change the meta examples to actually forward the kwargs | 15:35 |
| HeikoS48 | currently it is asll put | 15:35 |
| gf712 | Yes, true | 15:37 |
| gf712 | need to change python.json? | 15:37 |
| HeikoS48 | yes, but maybe need to do some deeper changes as well | 15:38 |
| HeikoS48 | not sure we can get the intended with python.json changes | 15:38 |
| HeikoS48 | just looking at it | 15:38 |
| HeikoS48 | gf712 so | 15:39 |
| HeikoS48 | "KeywordArguments": { "List": "$elements", "Element": "$keyword=$expr", "Separator": ", ", "InitialSeperatorWhenArgs>0": false }, | 15:39 |
| HeikoS48 | this leads to | 15:40 |
| HeikoS48 | svm = machine("LibSVM")C1=1.1, kernel=k | 15:40 |
| HeikoS48 | so need to change the generator a bit | 15:40 |
| HeikoS48 | I can have a look at this later. Need to go somewhere now | 15:40 |
| HeikoS48 | If you feel inspired, feel free to try to hack this, otherwise I'll take care of it | 15:41 |
| gf712 | OK! I can have a quick look | 15:41 |
| HeikoS48 | the notebooks work | 15:41 |
| HeikoS48 | Ie my PR | 15:41 |
| HeikoS48 | thx for the patch! | 15:41 |
| HeikoS48 | kinda cool actually this stuff | 15:41 |
| gf712 | no problem! | 15:41 |
| HeikoS48 | shogun feels very pythonic with this all of a sudden | 15:42 |
| HeikoS48 | sergey was talking about autogenerating | 15:42 |
| gf712 | can do the same with other factories | 15:42 |
| HeikoS48 | sg.Kernel.GaussianKernel as well, so we might see a PR here | 15:42 |
| HeikoS48 | gf712 yeah go ahead pls | 15:42 |
| HeikoS48 | see you later! | 15:42 |
| gf712 | see you later! | 15:42 |
| -!- HeikoS48 [5aae046b@gateway/web/cgi-irc/kiwiirc.com/ip.90.174.4.107] has quit [Ping timeout: 272 seconds] | 15:47 | |
| -!- Lefteris [836fb90d@gateway/web/freenode/ip.131.111.185.13] has quit [Quit: Page closed] | 16:10 | |
| -!- gf712 [8028b333@gateway/web/freenode/ip.128.40.179.51] has quit [Quit: Page closed] | 16:34 | |
| -!- HeikoS48 [5aae043e@gateway/web/cgi-irc/kiwiirc.com/ip.90.174.4.62] has joined #shogun | 21:15 | |
| -!- HeikoS48 [5aae043e@gateway/web/cgi-irc/kiwiirc.com/ip.90.174.4.62] has quit [Remote host closed the connection] | 21:22 | |
| -!- HeikoS [5aae043e@gateway/web/cgi-irc/kiwiirc.com/ip.90.174.4.62] has joined #shogun | 21:23 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 21:24 | |
| --- Log closed Tue Jan 15 00:00:28 2019 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!