--- Log opened Mon Apr 08 00:00:27 2019 | ||
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 00:29 | |
-!- mode/#shogun [+o wiking] by ChanServ | 00:29 | |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Remote host closed the connection] | 00:36 | |
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 00:45 | |
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Changing host] | 00:45 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 00:45 | |
-!- mode/#shogun [+o wiking] by ChanServ | 00:45 | |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Remote host closed the connection] | 02:48 | |
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 03:56 | |
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Changing host] | 03:56 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 03:56 | |
-!- mode/#shogun [+o wiking] by ChanServ | 03:56 | |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Ping timeout: 252 seconds] | 04:00 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 07:18 | |
-!- mode/#shogun [+o wiking] by ChanServ | 07:19 | |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Remote host closed the connection] | 07:36 | |
-!- Moatman [~Moatman@pool-96-255-151-151.washdc.fios.verizon.net] has quit [Remote host closed the connection] | 07:43 | |
-!- wiking_ [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 07:58 | |
-!- wiking_ [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Remote host closed the connection] | 08:45 | |
-!- wiking [~wiking@ict-networks-195-176-113-034.fwd-v4.ethz.ch] has joined #shogun | 09:49 | |
-!- wiking [~wiking@ict-networks-195-176-113-034.fwd-v4.ethz.ch] has quit [Changing host] | 09:49 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 09:49 | |
-!- mode/#shogun [+o wiking] by ChanServ | 09:49 | |
-!- gf712 [90520840@gateway/web/freenode/ip.144.82.8.64] has joined #shogun | 10:14 | |
@wiking | hah gf712 we have a slight problem https://github.com/openml/openml-python/pull/647 | 11:11 |
---|---|---|
@wiking | :) | 11:11 |
@wiking | this is instead of my pr :))) | 11:11 |
@wiking | but at least there's a way now and that can be directly added to this repo... one would hope | 11:13 |
-!- geektoni [c1cdd24a@gateway/web/freenode/ip.193.205.210.74] has joined #shogun | 11:14 | |
gf712 | wiking: let me have a look at the new master branch | 11:21 |
@wiking | k | 11:21 |
gf712 | they added stubs and everything :p | 11:21 |
gf712 | wiking: it does look pretty similar | 11:23 |
@wiking | yeah | 11:23 |
gf712 | should be able to get something working with that today | 11:23 |
@wiking | and its pretty annoying | 11:23 |
@wiking | that all the commits are not taken from me | 11:23 |
@wiking | so it's kind of like | 11:23 |
@wiking | fu | 11:23 |
@wiking | :) | 11:23 |
gf712 | yea.. | 11:23 |
@wiking | but whatever | 11:24 |
gf712 | we can always just write a shogun version and connect directly to the rest api :p | 11:24 |
gf712 | there is an issue with running regressors btw | 11:25 |
gf712 | as in, it doesn't support it | 11:25 |
gf712 | so I had to add some checks for shogun, need to checks if they fixed it | 11:25 |
@wiking | :>> | 11:28 |
@wiking | dunno if i should comment anything on this | 11:28 |
@wiking | but this is pretty lame imo | 11:28 |
gf712 | yup, very lame... | 11:39 |
gf712 | wiking: need some help with memory management with swig btw | 11:40 |
@wiking | sup sup | 11:40 |
gf712 | I don't understand an error I am getting, where swig is calling the destructor of an object | 11:40 |
gf712 | but then get a a bad access error | 11:40 |
gf712 | I think me using unique ptr in class members might be messing up something | 11:41 |
gf712 | have you had any issues with that? | 11:41 |
@wiking | mmmm | 11:44 |
@wiking | not really | 11:44 |
@wiking | but i mean if you dont expose unique_ptr to swig | 11:45 |
@wiking | it shouldn't be a problem or? | 11:45 |
gf712 | no, it shouldn't... | 11:45 |
gf712 | the destructor seems to be called properly | 11:45 |
@wiking | you can lldb the swig | 11:45 |
@wiking | interface cxx as well | 11:45 |
gf712 | but then in the swig wrapper | 11:45 |
@wiking | what happens there | 11:45 |
gf712 | delete arg1; | 11:45 |
@wiking | ? | 11:45 |
gf712 | causes an error | 11:45 |
@wiking | arg1 is nullptr? | 11:46 |
gf712 | no | 11:46 |
@wiking | invalid mem? | 11:46 |
gf712 | it points to the object | 11:46 |
gf712 | but it seems like the object is in protected memory? | 11:46 |
gf712 | p arg1 | 11:47 |
gf712 | (shogun::GridParameters *) $0 = 0x0000000100694c50 | 11:47 |
gf712 | it's clearly there | 11:47 |
@wiking | p *arg1 ? | 11:47 |
@wiking | so i mean when you try to reference that mem region | 11:47 |
gf712 | yea I can get it too | 11:47 |
@wiking | mmmm | 11:47 |
@wiking | that is even weirder | 11:48 |
gf712 | but the size of the maps is huge | 11:48 |
@wiking | coz then there should be no problems | 11:48 |
@wiking | ah | 11:48 |
@wiking | mmmmm | 11:48 |
gf712 | which makes no sense | 11:48 |
@wiking | maybe then the problem is actually somewhere else :))) | 11:48 |
gf712 | it seems like it is pointing at the wrong thing | 11:48 |
@wiking | maybe there was a buffer overflow somewhere and that messed up your mem | 11:48 |
gf712 | but from the debug messages everything is fine... | 11:48 |
@wiking | but you actually see the error here | 11:49 |
gf712 | hmmm | 11:49 |
@wiking | i've head this b4 | 11:49 |
gf712 | let me print out the map sizes | 11:49 |
@wiking | *had | 11:49 |
gf712 | you think there might be some recursion going on? | 11:49 |
@wiking | that actually some memory corruption caused a total different bug | 11:49 |
gf712 | and that causes an overflow? | 11:49 |
gf712 | ah ok | 11:49 |
@wiking | but the memory fuckup | 11:49 |
@wiking | happened somewhere else | 11:49 |
@wiking | :) | 11:49 |
@wiking | so first | 11:50 |
@wiking | can you run the same code | 11:50 |
@wiking | i mean essentially the same thing in c++ | 11:50 |
@wiking | and run valgrind on it | 11:50 |
@wiking | just to see if everything is ok on the c codebase | 11:50 |
@wiking | (you can do the printf story as well, but this is more pragmatic) | 11:50 |
@wiking | ;) | 11:50 |
@wiking | :> | 11:50 |
gf712 | yea, let me check valgrind | 11:51 |
@wiking | ah fuck | 11:51 |
gf712 | talking about that | 11:51 |
@wiking | go on donbot | 11:51 |
@wiking | as macaos will not work | 11:51 |
@wiking | :) | 11:51 |
@wiking | or idk | 11:52 |
@wiking | maybe it is fixed | 11:52 |
gf712 | valgrind in latest macOS don't work | 11:52 |
@wiking | yeah | 11:52 |
@wiking | go to donbot | 11:52 |
gf712 | ah | 11:52 |
@wiking | i haven't tried valgrind like 5 years now on macos | 11:52 |
@wiking | :D | 11:52 |
@wiking | as for me it's default that it doesn't work | 11:52 |
@wiking | you can use instruments though | 11:52 |
@wiking | it has memleak and stuff | 11:52 |
@wiking | uses dtrace | 11:52 |
@wiking | pretty awesome | 11:52 |
@wiking | :) | 11:52 |
gf712 | ah ok, I only ever use memcheck | 11:54 |
@wiking | memcheck? | 11:54 |
@wiking | instruments is part of Xcode | 11:54 |
gf712 | oh right | 11:54 |
@wiking | you should have it as you can compile stuff | 11:54 |
@wiking | :D | 11:54 |
gf712 | I got it the other day for CoreML stuff :p | 11:54 |
@wiking | :DDDDD | 11:54 |
gf712 | got this 6gb beast | 11:54 |
gf712 | which of course wants to update again | 11:55 |
gf712 | wiking: just ran Valgrind on a local linux machine and there is an issue with unique_ptr and CSGObject | 11:56 |
gf712 | :( | 11:56 |
@wiking | que? | 12:02 |
@wiking | what? | 12:02 |
@wiking | can you pastebin it plz | 12:02 |
-!- gf712_ [8028b351@gateway/web/freenode/ip.128.40.179.81] has joined #shogun | 12:08 | |
gf712_ | wiking: https://pastebin.com/m3bvz7cu | 12:08 |
@wiking | its about sqrtdiag_lhs and sqrtdiag_rhs i guess | 12:12 |
@wiking | mmm does this happen with develop as is ? | 12:13 |
@wiking | i guess so | 12:15 |
gf712 | need to check | 12:16 |
gf712 | but I am not sure if it could be an issue with wrapping it in a unique_ptr? | 12:16 |
gf712 | I think using the raw pointer working fine | 12:16 |
gf712 | worked | 12:16 |
@wiking | what's wrapped in unique_ptr? | 12:18 |
gf712 | the CSGObject | 12:20 |
gf712 | basically I clone it | 12:20 |
gf712 | and keep it a unique_ptr | 12:20 |
gf712 | maybe should just stick to raw pointers.. | 12:20 |
gf712 | wiking: m_parent = std::unique_ptr<CSGObject>(model->clone()); | 12:23 |
@wiking | mmmm | 12:25 |
@wiking | and you clone that? :) | 12:25 |
gf712 | yea, I mean I could move | 12:25 |
gf712 | the r value | 12:25 |
gf712 | but I don't want to take over ownership | 12:26 |
gf712 | because I don't want the user to do something funky | 12:26 |
gf712 | and then gridsearch gets confused :/ | 12:26 |
@wiking | yeah | 12:27 |
@wiking | ok wait | 12:27 |
@wiking | the obj that contains m_parent | 12:28 |
@wiking | is not an SGObject or? | 12:28 |
gf712 | no | 12:28 |
gf712 | it doesn't inherit from anything | 12:28 |
gf712 | ah I think I found an issue | 12:29 |
gf712 | when the ptr is destroyed it seems to call the SGObject destructor, which is virtual? | 12:30 |
gf712 | ah no | 12:30 |
gf712 | nvm | 12:30 |
gf712 | ok, I get it now | 12:32 |
gf712 | shouldn't clone it | 12:32 |
gf712 | because that creates a CSGObject | 12:33 |
gf712 | and not the derived class | 12:33 |
gf712 | when I tried to debug I noticed that I was calling pure virtual functions from CSGObject | 12:34 |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Remote host closed the connection] | 13:14 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 13:23 | |
-!- mode/#shogun [+o wiking] by ChanServ | 13:23 | |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Ping timeout: 244 seconds] | 13:28 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 13:42 | |
-!- mode/#shogun [+o wiking] by ChanServ | 13:42 | |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Remote host closed the connection] | 13:45 | |
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 13:49 | |
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Changing host] | 13:49 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 13:49 | |
-!- mode/#shogun [+o wiking] by ChanServ | 13:49 | |
-!- amarisch [c3b0705b@gateway/web/freenode/ip.195.176.112.91] has joined #shogun | 13:58 | |
-!- amarisch [c3b0705b@gateway/web/freenode/ip.195.176.112.91] has quit [Client Quit] | 13:59 | |
-!- amarisch [c3b0705b@gateway/web/freenode/ip.195.176.112.91] has joined #shogun | 14:03 | |
-!- geektoni [c1cdd24a@gateway/web/freenode/ip.193.205.210.74] has quit [Quit: Page closed] | 14:19 | |
gf712 | wiking: how are %newobject instances garbage collected? how does it differ between sgobject and non sgobject? | 14:20 |
gf712 | I think the issue I am having is there | 14:20 |
-!- amarisch [c3b0705b@gateway/web/freenode/ip.195.176.112.91] has quit [Ping timeout: 256 seconds] | 14:26 | |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Remote host closed the connection] | 16:24 | |
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun | 16:27 | |
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Changing host] | 16:27 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 16:27 | |
-!- mode/#shogun [+o wiking] by ChanServ | 16:27 | |
-!- wiking [~wiking@huwico/staff/wiking] has quit [Ping timeout: 250 seconds] | 16:34 | |
-!- gf712_ [8028b351@gateway/web/freenode/ip.128.40.179.81] has quit [Quit: Page closed] | 16:58 | |
-!- gf712 [90520840@gateway/web/freenode/ip.144.82.8.64] has quit [Ping timeout: 256 seconds] | 17:04 | |
-!- wiking [~wiking@huwico/staff/wiking] has joined #shogun | 18:18 | |
-!- mode/#shogun [+o wiking] by ChanServ | 18:18 | |
-!- besser82 [~besser82@fedora/besser82] has quit [Ping timeout: 268 seconds] | 21:14 | |
-!- besser82 [~besser82@fedora/besser82] has joined #shogun | 21:23 | |
-!- mode/#shogun [+o besser82] by ChanServ | 21:23 | |
-!- durovo [~durovo@99.b3.3da9.ip4.static.sl-reverse.com] has quit [Read error: Connection reset by peer] | 21:57 | |
-!- durovo2 [~durovo@99.b3.3da9.ip4.static.sl-reverse.com] has joined #shogun | 21:57 | |
--- Log closed Tue Apr 09 00:00:28 2019 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!