IRC logs of #shogun for Wednesday, 2019-04-24

--- Log opened Wed Apr 24 00:00:46 2019
-!- wiking_ [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun01:23
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Read error: Connection reset by peer]01:23
-!- wiking_ [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Remote host closed the connection]05:19
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun05:40
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Ping timeout: 255 seconds]05:44
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun06:54
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Remote host closed the connection]06:58
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun07:21
-!- braceletboy [67157d53@gateway/web/cgi-irc/kiwiirc.com/ip.103.21.125.83] has joined #shogun07:34
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Remote host closed the connection]07:35
-!- geektoni [5d2045c3@gateway/web/freenode/ip.93.32.69.195] has joined #shogun09:12
-!- braceletboy [67157d53@gateway/web/cgi-irc/kiwiirc.com/ip.103.21.125.83] has quit [Remote host closed the connection]10:01
-!- wiking_ [~wiking@2001:67c:10ec:5784:8000::3ff] has joined #shogun10:15
-!- braceletboy [d408f9b1@gateway/web/cgi-irc/kiwiirc.com/ip.212.8.249.177] has joined #shogun11:48
-!- braceletboy [d408f9b1@gateway/web/cgi-irc/kiwiirc.com/ip.212.8.249.177] has quit [Remote host closed the connection]12:00
-!- braceletboy [9f41c0ec@gateway/web/cgi-irc/kiwiirc.com/ip.159.65.192.236] has joined #shogun13:02
-!- braceletboy [9f41c0ec@gateway/web/cgi-irc/kiwiirc.com/ip.159.65.192.236] has quit [Remote host closed the connection]13:17
-!- geektoni [5d2045c3@gateway/web/freenode/ip.93.32.69.195] has quit [Quit: Page closed]14:01
-!- HeikoS [~heiko@203.pool85-48-187.static.orange.es] has joined #shogun14:10
-!- mode/#shogun [+o HeikoS] by ChanServ14:10
-!- braceletboy [67157d53@gateway/web/cgi-irc/kiwiirc.com/ip.103.21.125.83] has joined #shogun14:38
wiking_aaaand!14:44
wiking_lalalal14:44
-!- gf712 [905208d2@gateway/web/freenode/ip.144.82.8.210] has joined #shogun15:16
wiking_gf712: \o/15:17
wiking_success :D15:17
wiking_i mean ish15:17
wiking_228 files changed, 5424 insertions(+), 6031 deletions(-)15:17
wiking_1004 files changed, 10182 insertions(+), 10880 deletions(-)15:17
wiking_some of the unit tests runs out of box :)15:17
wiking_now i'm trying to see15:17
wiking_how can we add shared_ptr to tags fw15:18
gf712wiking_: haha15:20
wiking_this library is a mess15:20
gf712btw yesterday when you had issues with .get maybe you wanted release?15:21
-!- HeikoS [~heiko@203.pool85-48-187.static.orange.es] has quit [Quit: Leaving.]15:21
-!- HeikoS [~heiko@203.pool85-48-187.static.orange.es] has joined #shogun15:21
-!- mode/#shogun [+o HeikoS] by ChanServ15:21
wiking_dunno15:21
wiking_i have currently no clue15:21
wiking_about this shared_ptr story with tags15:22
wiking_:)15:22
gf712wiking_: so what do you need for tags fw15:22
wiking_now all the params15:22
wiking_that are CSGO15:22
wiking_are actually shared_ptr<CSGO>15:22
gf712but what is the issue?15:23
wiking_everything is being tied to SGO*15:23
wiking_see all that crazy getter/setter story15:24
gf712you meant the add?15:25
wiking_put/get15:25
wiking_i mean as said15:26
wiking_everything is around sgo*15:26
wiking_so here it's gonna b a domino eeffect15:26
wiking_get this merged15:26
wiking_then deadbeef15:26
wiking_then _export15:26
wiking_:)15:26
wiking_i will own every fucking line of code15:27
wiking_:D15:27
gf712haha15:27
gf712do you have a branch for the shared_ptr stuff>15:27
gf712?15:27
gf712I have been quite busy with phd stuff15:27
wiking_yeah havent' pushed15:27
wiking_lemme push15:27
gf712hate writing papers :D15:27
wiking_i haven't had time to deal with GPL15:28
gf712ok, ill have a look at it might be able to help15:28
wiking_so it only works with BSD code15:28
gf712btw do you need access to ati Monday to wednesday?15:28
wiking_https://github.com/shogun-toolbox/shogun/pull/461915:30
wiking_gf712: indeed15:30
wiking_i should writ to marc15:30
gf712its ok, I can get you a badge15:31
gf712at least a visitor pass15:31
wiking_\o/15:31
wiking_great15:31
wiking_thnx heaps15:31
gf712nw15:32
wiking_hehehe15:34
wiking_managed to break lldb15:34
wiking_!!!!15:34
gf712why do you have things like `io=sg_io.get();`15:34
wiking_hahahah15:34
gf712why not have std::shared_ptr<..> io ?15:34
wiking_gf712: because i had no time to deal with that shit15:34
gf712do you not end up with some weird stuff15:34
wiking_that whole io should be15:34
wiking_THROWN OUT15:34
wiking_:)15:34
gf712ah o ok15:35
gf712just wondering15:35
gf712so how did you break lldb /15:35
gf712?15:35
gf712macOS or linux version?15:35
wiking_(lldb) p orig_array15:35
wiking_(std::__1::shared_ptr<shogun::CDynamicObjectArray>) $0 = std::__1::shared_ptr<shogun::CDynamicObjectArray>::element_type @ 0x0000000111e20448 strong=1 weak=2 {15:35
wiking_  __ptr_ = 0x0000000111e2044815:35
wiking_}15:35
wiking_(lldb) p *orig_array15:35
wiking_and BOOM15:36
wiking_i get lldb stacktrace and lldb quits15:36
wiking_:D15:36
wiking_yes osx15:36
gf712that's quite impressive15:36
wiking_unlocked next level15:36
wiking_!15:36
wiking_:)15:36
gf712does po do the same?15:36
gf712as opposed to p15:36
gf712wiking_: btw should shared_ptr be passed by reference or value?15:37
wiking_to whom? :)15:37
wiking_(lldb) po *orig_array15:37
wiking_but it doesn't die at least15:37
wiking_:)))15:37
wiking_i mean as you can see15:37
wiking_many parts i just did15:38
wiking_#if 015:38
wiking_because i couldn't be bothered to fix15:38
wiking_but liblinear15:38
wiking_and shit like this works15:38
wiking_:)15:38
wiking_the whole init.h would be nice to throw out15:38
wiking_as that's another one15:38
wiking_:))))15:38
* wiking_ realised that if we dont refactor this in the next 6 months this project is dead15:38
gf712wiking_: to functions that do not take ownership15:39
gf712haha dead?15:39
wiking_yeah i mean15:39
wiking_our userbase is crazy low15:39
wiking_;)15:39
wiking_anyhow15:39
wiking_mmm good q15:39
wiking_i mean here i just did things with libtooling and didn't care too much of the logic15:39
gf712yea, I guess its all about the nets for now15:40
wiking_yep15:40
wiking_anyhow15:40
wiking_so now i wanna have clone work15:40
wiking_:))))15:40
wiking_which is not atm since as you can see15:40
wiking_all the SG_ADD is commented out15:41
wiking_:)))15:41
gf712tbh a shared_ptr<..> is a simple object15:41
gf712the compiler should optimise15:41
gf712the pointer won't copy15:41
wiking_i've added for now for dynamicobjarra15:41
wiking_and boom15:41
wiking_that's the crazy shit15:41
wiking_so there's now the time to look into any15:41
wiking_:))))15:41
gf712you mean support std::shared_ptr with any>?15:43
wiking_yes15:43
wiking_to be able to watch_param15:43
wiking_:)15:43
wiking_yey https://www.youtube.com/watch?v=NlnqUjP-SvE15:44
wiking_and fuck all15:44
wiking_;()15:44
gf712I think shared_ptr<Any> is fine15:44
wiking_que?15:44
wiking_i mean about this15:44
wiking_for example15:44
wiking_DynArray<std::shared_ptr<CSGObject>> m_array;15:45
wiking_i mean actually15:45
wiking_this is not yet crazy15:45
wiking_:()15:45
wiking_but yeah15:45
wiking_watch_param("array", &m_array.array, &m_array.current_num_elements);15:45
wiking_and then comes crazy shit like15:45
wiking_std::shared_ptr<CKernel> m_kernel;15:46
wiking_and watch_param for that m_kernel15:46
wiking_i mean the first one got crazy as well15:46
wiking_:)))15:46
wiking_i wish i would have the any where i already handled this with std::vector15:47
wiking_but HONESTLY15:47
wiking_the whole fucking DynamicObjectArray could go down to drain15:47
wiking_since essentially it's std::vector<shared_ptr<CSGObject>>15:47
wiking_:P15:47
wiking_hahahahah15:49
wiking_GITHUB15:49
wiking_The table of contents is too big for display.15:49
wiking_for jump to file15:49
wiking_:)15:49
gf712what happens when you do watch_param with m_kernel?15:52
wiking_i haven't tried that15:53
wiking_should actually15:53
wiking_:)15:53
wiking_ah fuck15:54
wiking_i have to turn off the old15:54
wiking_param fw15:54
gf712watch_param("kernel", &m_kernel) would that work?15:54
wiking_as that keaps complaining15:54
gf712?15:54
wiking_you know15:54
wiking_m_param15:54
gf712right right15:54
gf712as in remove from sgobject ?15:55
wiking_ok trying15:55
wiking_compiled15:55
wiking_:DDD15:55
gf712what's the ref to when you ref a std:shared_ptr?15:55
gf712i.e. &m_kernel15:55
wiking_good q15:55
gf712is that &(*m_kernel.get()) ?15:56
wiking_mmm but we dont wanna ref the pointer it contians15:56
wiking_as that could change right15:56
wiking_:P15:56
wiking_we actually wanna ref the shared_ptr15:56
wiking_ok so how the heck to i test this now15:56
gf712ah yes15:56
wiking_:)))15:56
gf712ok, so thats what's happening15:56
wiking_dunno15:57
gf712I think it15:57
wiking_need a kernel machine15:57
gf712is15:57
gf712if you go to cpp ref15:57
wiking_ok i'll test clone15:57
gf712there is no operator  overloading for &15:57
gf712so should be ref to shared_ptr15:57
gf712otherwise ill be confused15:57
wiking_argh15:58
wiking_where the hell is a kernel machine unit test15:58
wiking_:)))15:58
wiking_we dont have15:58
wiking_just linear machine15:58
wiking_:D15:58
wiking_lol15:58
gf712for cpp?15:59
gf712do meta examples not work>15:59
gf712?15:59
wiking_ah no15:59
wiking_that i didn't even touch15:59
wiking_coz that needs so much work15:59
wiking_for the sgobject interface16:00
gf712true16:00
wiking_see the enable_if stories16:00
wiking_ok gotta run16:00
wiking_brb16:00
wiking_i'll figure something soon16:00
gf712aight!16:00
-!- wiking_ [~wiking@2001:67c:10ec:5784:8000::3ff] has quit [Remote host closed the connection]16:00
-!- wiking [~wiking@2001:67c:10ec:5784:8000::3ff] has joined #shogun16:01
-!- wiking_ [~wiking@inf-ise-etx-dock-1-111.ethz.ch] has joined #shogun16:06
-!- wiking [~wiking@2001:67c:10ec:5784:8000::3ff] has quit [Ping timeout: 264 seconds]16:06
wiking_wanna have a repl for shogun c++16:06
wiking_ah ok16:08
wiking_linearmachine has dotfeatures sharedptr16:08
wiking_gf712: watch_param("features", (std::shared_ptr<CFeatures>*)&features);16:09
wiking_:D16:09
gf712why don't you get a c++ repl?16:13
gf712I use xeus cling16:13
wiking_yeah16:13
gf712in Jupiter notebook16:13
wiking_but setting up the header paths is crazy16:13
gf712pretty neat, but crashes sometimes16:13
gf712meh, its a one time thing really16:13
gf712so for watch param16:13
wiking_testing16:14
wiking_:)16:14
gf712you cast to a std::shared_ptr16:14
gf712pointer16:14
gf712not sure...16:14
wiking_but need to16:14
wiking_seems to b working16:14
wiking_but lemme check16:14
gf712hmm, actually I guess it makes sense it works16:15
gf712its just weird16:15
wiking_ok idk how to check equals16:16
wiking_:D16:16
gf712why the casting though?16:16
wiking_i mean lldb seems to be shitting me16:16
gf712well you have to get the pointer?16:16
wiking_coz features is DotFeatures16:16
wiking_as soon as i do that16:16
wiking_booom16:16
wiking_(lldb) p *ocas.get()16:17
wiking_kills lldb16:17
gf712*(ocas.get()) ?16:18
gf712ah no16:18
gf712. has precedence16:18
wiking_Value of: pred->equals(cloned)16:19
wiking_  Actual: false16:19
wiking_Expected: true16:19
wiking_:D16:19
-!- HeikoS [~heiko@203.pool85-48-187.static.orange.es] has quit [Ping timeout: 244 seconds]16:20
wiking_ok this is asdf16:21
wiking_:D16:21
wiking_as lldb dies on me16:22
wiking_to_string is currently not functional16:22
wiking_:D16:22
wiking_i should step the clone function16:22
wiking_:)))16:22
gf712haha16:24
gf712but equals will be different16:24
gf712because of refcount no?16:24
gf712you are comparing shared_ptr right?16:24
gf712rhs != lhs16:24
-!- geektoni [5d22ef24@gateway/web/freenode/ip.93.34.239.36] has joined #shogun16:24
gf712because they will have different counters as you observe right?16:25
gf712what does equal do exactly?16:25
gf712ah nvm16:26
gf712== is overloaded16:26
wiking_lol16:26
wiking_if (strcmp(this->get_name(), other->get_name()))16:26
wiking_:)16:26
wiking_this fails in equals16:26
gf712lhs.get() == rhs.get()16:26
gf712wat?16:27
gf712what does lldb say?16:27
wiking_i'll try to rerun16:27
gf712as in what are those value16:27
gf712ok16:27
wiking_argh16:27
wiking_(lldb) p this->get_name()16:27
wiking_(const char *) $10 = 0xa000000023000000 <no value available>16:27
gf712but this16:28
gf712p this16:28
gf712ah no16:28
gf712because there is no member16:28
wiking_that's a sharedptr16:28
wiking_:)16:28
-!- wiking_ [~wiking@inf-ise-etx-dock-1-111.ethz.ch] has quit [Remote host closed the connection]16:29
-!- wiking [~wiking@195.176.113.68] has joined #shogun16:39
-!- wiking [~wiking@195.176.113.68] has quit [Ping timeout: 245 seconds]16:43
-!- wiking [~wiking@2001:67c:10ec:5784:8000::3ff] has joined #shogun16:48
wikingasdf16:49
wikingi'm a bit tired i guess16:50
wiking:D16:50
wikingbut16:50
wiking[DEBUG] Own parameter SVMOcas::features= different from provided SVMOcas::features=16:50
gf712so there are issues with deep copies?16:55
gf712or deep clones16:55
wikingyeah but imo it's about16:56
wikingany16:56
wiking:)16:56
gf712hmm why do you think that?16:58
wikingcoz that's where shit can go bad16:58
wiking;)16:58
wikingi mean we use any to clone16:58
wiking:)16:58
wikingand imo16:58
wikingthe thing is that there's nowhere a new shared_ptr is being created16:58
wikingand then set with a new obj16:59
wikingcurrently whatever happens17:00
wikingi'm pretty sure that in best case we would have a shared_ptr that shares ownership17:00
wikingof the same ptr17:00
gf712I agree, in the case of shallow copy17:01
gf712but then deep copy you would want a new ptr no?17:01
wikingyeah17:01
wikingbut that needs to be added into any17:01
wikingto handle this stuff17:01
wikingthis is what happens with the shared_ptr imo17:02
wikingtemplate <class T, std::enable_if_t<std::is_copy_constructible<T>::value>* = nullptr>17:02
wikinginline T clone_impl(general, T& value)17:02
wiking{17:02
wikingreturn T(value);17:02
wiking}17:02
wikingbut i can check17:02
gf712well it is copy constructible17:02
gf712so yea17:02
wikingbut this is not deep copy:)17:03
gf712yea, so need to add a check17:03
gf712but then in sgobject.h there are methods for that need implementation17:04
gf712but you think it should go to any?17:04
wikingyep17:05
wiking(lldb) p cloned17:05
wiking(std::__1::shared_ptr<shogun::CFeatures>) $4 = std::__1::shared_ptr<shogun::CFeatures>::element_type @ 0x0000000113806398 strong=4 weak=2 {17:05
wiking  __ptr_ = 0x000000011380639817:05
wiking}17:05
wiking(lldb) p value17:05
wiking(const std::__1::shared_ptr<shogun::CFeatures>) $5 = std::__1::shared_ptr<shogun::CFeatures>::element_type @ 0x0000000113806398 strong=4 weak=2 {17:05
wiking  __ptr_ = 0x000000011380639817:05
wiking}17:05
wikingthis is sharing ownershuip17:05
wikingthis part should go to any17:06
wikingcoz this is already in any17:06
wikingthe crazy stuff in sgo17:06
wikingthat's another haxor time17:06
wikingbasically needs a way to make_any for std::shared_ptr<T>17:06
wikingthat properly does the cloning17:06
gf712and then move constructor for shallow, or?17:08
gf712hmm actually no17:08
wikingyeah17:08
gf712then you lose ownership?17:08
wikingbut we are not in shallow copy business yet :)17:09
wikingyeah std::move(sharedptr) moves ownership17:09
wikingok gonna have a smoke now and think about this17:11
gf712aight17:11
gf712I have got cudnn code to write :p17:11
-!- wiking [~wiking@2001:67c:10ec:5784:8000::3ff] has quit [Remote host closed the connection]17:11
-!- wiking_ [~wiking@ict-networks-195-176-113-068.fwd-v4.ethz.ch] has joined #shogun17:15
-!- wiking_ [~wiking@ict-networks-195-176-113-068.fwd-v4.ethz.ch] has quit [Ping timeout: 258 seconds]17:20
-!- gf712 [905208d2@gateway/web/freenode/ip.144.82.8.210] has quit [Quit: Page closed]17:46
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun18:17
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Ping timeout: 244 seconds]18:21
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun18:37
-!- geektoni [5d22ef24@gateway/web/freenode/ip.93.34.239.36] has quit [Quit: Page closed]18:47
-!- braceletboy [67157d53@gateway/web/cgi-irc/kiwiirc.com/ip.103.21.125.83] has quit [Remote host closed the connection]19:44
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Remote host closed the connection]20:10
-!- durovo1 [~durovo@68.73.2ea9.ip4.static.sl-reverse.com] has joined #shogun20:21
-!- durovo [~durovo@3a.6c.2ea9.ip4.static.sl-reverse.com] has quit [Remote host closed the connection]20:21
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun20:26
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Ping timeout: 258 seconds]20:34
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun20:38
-!- braceletboy [67157d53@gateway/web/cgi-irc/kiwiirc.com/ip.103.21.125.83] has joined #shogun20:40
-!- durovo [~durovo@35.6c.2ea9.ip4.static.sl-reverse.com] has joined #shogun21:17
-!- durovo1 [~durovo@68.73.2ea9.ip4.static.sl-reverse.com] has quit [Remote host closed the connection]21:18
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Remote host closed the connection]21:27
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun22:13
-!- braceletboy [67157d53@gateway/web/cgi-irc/kiwiirc.com/ip.103.21.125.83] has quit [Remote host closed the connection]23:04
-!- besser82 [~besser82@fedora/besser82] has quit [Read error: Connection reset by peer]23:08
-!- besser82 [~besser82@fedora/besser82] has joined #shogun23:12
-!- mode/#shogun [+o besser82] by ChanServ23:12
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has quit [Remote host closed the connection]23:19
-!- wiking [~wiking@c-185-45-237-122.customer.ggaweb.ch] has joined #shogun23:22
--- Log closed Thu Apr 25 00:00:48 2019

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!