| --- Log opened Wed Aug 19 00:00:42 2015 | ||
| -!- PirosB3 [~pirosb3@host227-133-dynamic.33-79-r.retail.telecomitalia.it] has joined #shogun | 01:47 | |
| -!- PirosB3 [~pirosb3@host227-133-dynamic.33-79-r.retail.telecomitalia.it] has quit [Quit: PirosB3] | 02:16 | |
| shogun-buildbot | build #1035 of nightly_default is complete: Failure [failed test notebooks] Build details are at http://buildbot.shogun-toolbox.org/builders/nightly_default/builds/1035 blamelist: Wu Lin <yorker.lin@gmail.com> | 05:57 |
|---|---|---|
| -!- witness [uid10044@gateway/web/irccloud.com/x-vrlfiqmevxpdahmk] has joined #shogun | 06:27 | |
| -!- witness [uid10044@gateway/web/irccloud.com/x-vrlfiqmevxpdahmk] has quit [Quit: Connection closed for inactivity] | 10:04 | |
| -!- PirosB3 [~pirosb3@host227-133-dynamic.33-79-r.retail.telecomitalia.it] has joined #shogun | 10:22 | |
| -!- PirosB3 [~pirosb3@host227-133-dynamic.33-79-r.retail.telecomitalia.it] has quit [Quit: PirosB3] | 12:04 | |
| -!- PirosB3 [~pirosb3@host227-133-dynamic.33-79-r.retail.telecomitalia.it] has joined #shogun | 15:33 | |
| -!- PirosB3 [~pirosb3@host227-133-dynamic.33-79-r.retail.telecomitalia.it] has quit [Quit: PirosB3] | 15:54 | |
| @besser82 | lisitsyn, yo? | 17:18 |
| lisitsyn | besser82: hey | 17:18 |
| @besser82 | lisitsyn, You have a constructive idea, how to avoid ptr when instanciating classes from plugins? | 17:19 |
| lisitsyn | well just shared_ptr :D | 17:20 |
| @besser82 | I mean in shogun with plugins it'd be like this: CSVM* my_svm = whateverpluginstuff.instance('libsvm') ; | 17:20 |
| lisitsyn | yes | 17:21 |
| @besser82 | That's ugly, because not all PhD can work with ptr | 17:21 |
| lisitsyn | shared_ptr<CSVM> my_svm = shogun.instance('libsvm'); | 17:21 |
| @besser82 | So I'd prefer real object... | 17:21 |
| lisitsyn | yes shared_ptr :) | 17:22 |
| @besser82 | like: CSVM = some_magick_here_to_get.instace('libsvm'); :P | 17:22 |
| @besser82 | shared_ptr / unique_ptr will be the same mess... | 17:23 |
| lisitsyn | ok we can make all our objects shared_ptrs inside | 17:23 |
| lisitsyn | so these object are lightweight and we can copy them | 17:23 |
| @besser82 | lisitsyn, like: | 17:24 |
| @besser82 | class CSVM { | 17:24 |
| @besser82 | public: | 17:24 |
| @besser82 | fancy_types params; | 17:25 |
| @besser82 | private: | 17:25 |
| @besser82 | shared_ptr<CSVMpriv> dptr; | 17:25 |
| @besser82 | } | 17:25 |
| @besser82 | ? | 17:25 |
| @besser82 | Would be an idea... So wrapper class should work it | 17:26 |
| @besser82 | lisitsyn, ^ | 17:27 |
| lisitsyn | yes | 17:28 |
| lisitsyn | besser82: CSVM is just a really light wrapper | 17:28 |
| @besser82 | lisitsyn, sounds good ^^ | 17:33 |
| @besser82 | lisitsyn, lemme try around with that a bit... | 17:33 |
| @besser82 | It think stuff should be ready for first experiments within the next days | 17:34 |
| @besser82 | but we need to expose the header of CSVM_impl for the plugin then ;) | 17:34 |
| lisitsyn | no | 19:29 |
| lisitsyn | use forward declaration | 19:29 |
| lisitsyn | you don't need full declaration for shared_ptr | 19:29 |
| @besser82 | lisitsyn, but the plugin-class needs to inherit from CSVM_impl... ;) | 19:43 |
| -!- PirosB3 [~pirosb3@host227-133-dynamic.33-79-r.retail.telecomitalia.it] has joined #shogun | 19:55 | |
| lisitsyn | besser82: hmm yeah | 19:56 |
| lisitsyn | but that's ok | 19:57 |
| lisitsyn | it could be in .cpp | 19:57 |
| @besser82 | lisitsyn, yes, but then we'd have to dup it in to a kazillion different svm-plugz | 20:20 |
| lisitsyn | why? | 20:20 |
| lisitsyn | svm.h forward declares SVMImpl | 20:20 |
| lisitsyn | svm_impl.h declares SVMImpl | 20:20 |
| lisitsyn | svm.h *doesn't* include svm_impl.h | 20:20 |
| lisitsyn | fancy_svm.h *does* include svm_impl.h | 20:21 |
| @besser82 | ahhh... now it's clearer :P | 20:21 |
| @besser82 | I though of like directly written in cpp :P | 20:21 |
| lisitsyn | I think this should work | 20:21 |
| @besser82 | lisitsyn, ^ | 20:21 |
| @besser82 | yes, it will | 20:21 |
| @besser82 | afaik | 20:21 |
| -!- PirosB3 [~pirosb3@host227-133-dynamic.33-79-r.retail.telecomitalia.it] has quit [Quit: PirosB3] | 22:50 | |
| --- Log closed Thu Aug 20 00:00:44 2015 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!