| --- Log opened Mon Apr 16 00:00:26 2018 | ||
| -!- HeikoS [~heiko@37.19.108.89] has quit [Quit: Leaving.] | 01:47 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 03:05 |
|---|---|---|
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 04:12 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 04:16 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #shogun | 04:23 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/366951239 | 04:24 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #shogun [] | 04:24 | |
| -!- travis-ci [~travis-ci@ec2-54-196-23-115.compute-1.amazonaws.com] has joined #shogun | 04:45 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/366951239 | 04:45 |
| -!- travis-ci [~travis-ci@ec2-54-196-23-115.compute-1.amazonaws.com] has left #shogun [] | 04:45 | |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has joined #shogun | 05:02 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/366963449 | 05:02 |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has left #shogun [] | 05:02 | |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has joined #shogun | 05:13 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/366964233 | 05:13 |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has left #shogun [] | 05:13 | |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has joined #shogun | 05:37 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/366964233 | 05:37 |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has left #shogun [] | 05:37 | |
| -shogun-buildbot:#shogun- Build nightly_bsd_license #136 is complete: Failure [test (failure)] - http://buildbot.shogun-toolbox.org:8080/#builders/4/builds/136 | 06:52 | |
| -shogun-buildbot:#shogun- Build nightly_default #124 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/17/builds/124 | 08:24 | |
| -!- HeikoS [~heiko@77.243.26.231] has joined #shogun | 08:53 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 08:53 | |
| -!- HeikoS [~heiko@77.243.26.231] has quit [Quit: Leaving.] | 08:59 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4216 synchronized by FaroukY | 09:33 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4206 synchronized by FaroukY | 10:12 |
| -!- HeikoS [~heiko@77.243.26.231] has joined #shogun | 10:17 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 10:17 | |
| lisitsyn | ../../src/shogun/libshogun.so.18.0: error: undefined reference to 'shogun::CCoverTreeKNNSolver::CCoverTreeKNNSolver(int, double, int, int, shogun::SGVector<int>)' | 10:29 |
| lisitsyn | HeikoS: ^ I have something like that | 10:29 |
| @HeikoS | lisitsyn: mmmh | 10:29 |
| @HeikoS | so it is linked against | 10:29 |
| @HeikoS | some gpl guard problem | 10:30 |
| @HeikoS | where does the linking error happen? | 10:30 |
| @HeikoS | git submodule udpate | 10:30 |
| @HeikoS | lisitsyn: | 10:30 |
| lisitsyn | ah | 10:30 |
| lisitsyn | sorry | 10:30 |
| @HeikoS | also you broke the build :D | 10:30 |
| @HeikoS | lisitsyn: btw | 10:30 |
| @HeikoS | I will make features immutable from API, via overloading put and throwing an error | 10:30 |
| @HeikoS | OK with that? | 10:30 |
| lisitsyn | yeah it seems I did | 10:30 |
| lisitsyn | ok | 10:30 |
| lisitsyn | HeikoS: what did I broke? | 10:31 |
| lisitsyn | I've seen some java example | 10:31 |
| lisitsyn | but python and libshogun works | 10:31 |
| @HeikoS | yes | 10:31 |
| @HeikoS | you forgot to update the variable type | 10:31 |
| lisitsyn | I see | 10:31 |
| @HeikoS | CrossValidationResult = evaluate() | 10:31 |
| @HeikoS | but evaluate returns base type | 10:31 |
| @HeikoS | so in ajva and c# this breaks | 10:31 |
| @HeikoS | see what I mean? | 10:32 |
| lisitsyn | yes | 10:32 |
| @HeikoS | lisitsyn: easy to fix | 10:32 |
| lisitsyn | there was obtain from generic | 10:32 |
| lisitsyn | so I get rid of them but added back only 2 of them | 10:32 |
| lisitsyn | and missed third | 10:32 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/351a9a389acee1aa20da518f9065622c19a583fb by lisitsyn | 10:36 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4250 synchronized by lisitsyn | 10:36 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4257 synchronized by iglesias | 10:50 |
| @HeikoS | lisitsyn: want me to check stuff? | 10:57 |
| @HeikoS | which one first? | 10:57 |
| lisitsyn | HeikoS: if you fix the multiplekernel thing it would be nice | 10:59 |
| @HeikoS | lisitsyn: where is that? | 10:59 |
| lisitsyn | I am soon to leave, won't make it before tonight | 10:59 |
| @HeikoS | the meta example in the develop? | 10:59 |
| lisitsyn | the bug I introduced | 10:59 |
| lisitsyn | yes | 10:59 |
| @HeikoS | ok I will look into that | 10:59 |
| @HeikoS | wiking: REQUIRE("Number of feature vectors (%d) must be equal to number of samples (%d))" | 11:12 |
| @HeikoS | Number of feature vectors (%d) must be equal to number of samples (%d) | 11:12 |
| @HeikoS | SG_REQUIRE_EQ(a, "number of feature vectors", b, "number of samples") | 11:13 |
| @HeikoS | SG_REQUIRE_MEMBER(get<CInferenceMetho>("method").value()) | 11:45 |
| @HeikoS | "Member method is not provided" | 11:45 |
| @HeikoS | SG_REQUIRE_PARAM(data) | 11:45 |
| @HeikoS | "Parameter data needs to be provided" | 11:45 |
| @HeikoS | 11:45 | |
| @HeikoS | SG_REQUIRE_EQ(foo, "foo", data->-get_num_classes(), "bar") | 11:45 |
| @HeikoS | "Provided foo (%d) must be equal to bar (%d)" | 11:45 |
| @HeikoS | lisitsyn: | 11:45 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #shogun | 11:55 | |
| travis-ci | it's Sergey Lisitsyn's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367047117 | 11:55 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #shogun [] | 11:55 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4258 karlnapf added label: "Documentation" | 12:01 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4258 karlnapf added label: "good first issue" | 12:01 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4258 opened by karlnapf | 12:01 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4258 | 12:01 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4258 | 12:02 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4258 | 12:02 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4259 karlnapf added label: "development tasks" | 12:09 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4259 opened by karlnapf | 12:09 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4259 karlnapf added label: "Cleanups" | 12:09 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4259 karlnapf added label: "good first issue" | 12:09 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4206 synchronized by FaroukY | 12:10 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4259 | 12:10 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4259 | 12:10 |
| lisitsyn | HeikoS: yes? | 12:12 |
| @HeikoS | lisitsyn: ? | 12:12 |
| lisitsyn | HeikoS: you hilited me | 12:13 |
| @HeikoS | lisitsyn: ah yes, see the error msg and give your thoughts | 12:13 |
| lisitsyn | lack some context | 12:13 |
| lisitsyn | HeikoS: what's that? :) | 12:19 |
| @HeikoS | lisitsyn: nevermind actually :) | 12:19 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #shogun | 12:25 | |
| travis-ci | it's Sergey Lisitsyn's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367047117 | 12:25 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #shogun [] | 12:25 | |
| @wiking | lisitsyn, here? | 12:37 |
| @wiking | lisitsyn, there's no way we can some an object that has unique_ptr as a ctor arg... :< | 13:02 |
| lisitsyn | wiking: example? | 13:19 |
| @wiking | FileOutputStream(std::unique_ptr<File> file) | 13:21 |
| @wiking | but since i have to do JsonSerilizer.attach(Some<OutputStream>...) | 13:22 |
| @wiking | i have to wrap FileOutputStream with some | 13:22 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4257 synchronized by iglesias | 13:24 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4257 merged by karlnapf | 13:25 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/ebd45aee101347a4ef91e9253806f14a7fb486ca by karlnapf | 13:25 |
| -shogun-buildbot:#shogun- Build trusty - libshogun - viennacl #410 is complete: Failure [failed test (failure)] - http://buildbot.shogun-toolbox.org:8080/#builders/6/builds/410 | 13:27 | |
| lisitsyn | wiking: yes, why unique? | 13:32 |
| lisitsyn | unique is not going to be good for swig | 13:32 |
| lisitsyn | it can't handle that gracefully | 13:32 |
| lisitsyn | I'd say swig means everything is shared | 13:32 |
| @wiking | nono | 13:32 |
| @wiking | this is never exposed to swig | 13:33 |
| @wiking | thats the point | 13:33 |
| lisitsyn | wiking: just wrap everything into Some, that's our swig thing | 13:37 |
| @wiking | yes | 13:38 |
| @wiking | but i dont want swig-ed this | 13:38 |
| @wiking | nor i want it to be SGobject | 13:38 |
| -!- witness [uid10044@gateway/web/irccloud.com/x-yrffbwfyzhzcshgf] has joined #shogun | 13:40 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 13:52 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 13:56 |
| -!- dseiko [027d0f4f@gateway/web/freenode/ip.2.125.15.79] has joined #shogun | 14:01 | |
| dseiko | Hey! for GSoC, results cannot be announced yet right? | 14:02 |
| -!- HeikoS [~heiko@77.243.26.231] has quit [Read error: Connection reset by peer] | 14:12 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 14:26 |
| -!- HeikoS [~heiko@77.243.19.33] has joined #shogun | 14:29 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 14:29 | |
| -!- dseiko [027d0f4f@gateway/web/freenode/ip.2.125.15.79] has quit [Quit: Page closed] | 14:37 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 14:42 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #shogun | 14:42 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/367116611 | 14:42 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #shogun [] | 14:42 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 14:43 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 14:44 |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has joined #shogun | 14:51 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/367117783 | 14:51 |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has left #shogun [] | 14:51 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham808 | 15:09 |
| -!- travis-ci [~travis-ci@ec2-54-163-50-118.compute-1.amazonaws.com] has joined #shogun | 15:17 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/367128479 | 15:17 |
| -!- travis-ci [~travis-ci@ec2-54-163-50-118.compute-1.amazonaws.com] has left #shogun [] | 15:17 | |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #shogun | 15:37 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/367135137 | 15:37 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #shogun [] | 15:37 | |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has joined #shogun | 15:43 | |
| travis-ci | it's Fernando J. Iglesias Garc?a's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367107213 | 15:43 |
| -!- travis-ci [~travis-ci@ec2-23-20-242-232.compute-1.amazonaws.com] has left #shogun [] | 15:43 | |
| -!- witness [uid10044@gateway/web/irccloud.com/x-yrffbwfyzhzcshgf] has quit [Quit: Connection closed for inactivity] | 15:54 | |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #shogun | 16:17 | |
| travis-ci | it's Fernando Iglesias's turn to pay the next round of drinks for the massacre he caused in iglesias/shogun: https://travis-ci.org/iglesias/shogun/builds/367173417 | 16:17 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #shogun [] | 16:17 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4234 synchronized by sunalbert | 16:28 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #shogun | 16:31 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/367145882 | 16:31 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #shogun [] | 16:31 | |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has joined #shogun | 16:51 | |
| travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/367145882 | 16:51 |
| -!- travis-ci [~travis-ci@ec2-54-221-131-22.compute-1.amazonaws.com] has left #shogun [] | 16:51 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] Wiki page: Hackhaton-TODOs edited by iglesias | 17:06 |
| @wiking | lisitsyn, ok now i have a fileoutputstream finally that is unittested :) | 17:33 |
| @wiking | bufferedoutputstream is still missing :( | 17:34 |
| @wiking | but lemme now build from the other side... visitor | 17:34 |
| @wiking | lisitsyn, lemme know when you are here | 18:14 |
| @wiking | coz there's a conceptual problem :) | 18:15 |
| @wiking | afaik you dont want CSerializer::write(Some<CSGObject> object) ... unless we make CSerializer friend of SGObject i cannot have reverence on Self.map | 18:15 |
| @wiking | that contains the tags which i can visit | 18:15 |
| @wiking | because otherwise i cannot do visitors on SGObject | 18:16 |
| lisitsyn | wiking: I think we should add a method "visit" | 18:17 |
| lisitsyn | that accepts Visitor* | 18:17 |
| lisitsyn | that visits all the parameters | 18:17 |
| @wiking | mmm | 18:17 |
| lisitsyn | in the SGObject | 18:17 |
| @wiking | i see | 18:17 |
| @wiking | yeah that's anther way :) | 18:17 |
| lisitsyn | so SGObject visits itself | 18:17 |
| @wiking | yeye after that its easy | 18:17 |
| @wiking | but with the current setup this aint' working | 18:17 |
| @wiking | btw on the end of the day | 18:17 |
| @wiking | to save an object | 18:18 |
| @wiking | you want this pseudo code: | 18:18 |
| @wiking | JsonSerializer js; | 18:18 |
| @wiking | js.attach(OutputStream); | 18:18 |
| @wiking | js.write(myObj) | 18:19 |
| @wiking | ? | 18:19 |
| @wiking | as this could simply be: myObject.serialize(some<JsonSerializer>(outputStream)) | 18:19 |
| @wiking | right? :) | 18:19 |
| lisitsyn | wiking: why not let serializer call some method of sgobject? | 18:22 |
| lisitsyn | sgobject.visit(serializingVisitor) | 18:22 |
| @wiking | lisitsyn, yeah i mean that's another story | 18:22 |
| @wiking | now i meant that once we are done | 18:22 |
| @wiking | with the serialization | 18:23 |
| @wiking | the first example is how you would serialize an obj | 18:23 |
| @wiking | which is a bit clunky | 18:23 |
| @wiking | compared to the other one | 18:23 |
| @wiking | imo | 18:23 |
| lisitsyn | we can make a helper method for that | 18:23 |
| @wiking | i mean if we take java is the same: void writeObject(java.io.ObjectOutputStream out) | 18:24 |
| @wiking | right? | 18:24 |
| @wiking | :) | 18:24 |
| @wiking | so that later you can say | 18:24 |
| lisitsyn | yes | 18:25 |
| @wiking | sgobjec.writeObject(out) | 18:25 |
| @wiking | but not | 18:25 |
| @wiking | out.writeObject(object) | 18:25 |
| @wiking | :) | 18:25 |
| @wiking | anyhow | 18:25 |
| @wiking | because now in writeObject this way | 18:25 |
| @wiking | i would do this back and forth and have a .visitor etc | 18:25 |
| @wiking | whereas if i do this the other way round | 18:26 |
| lisitsyn | you still have to have visitor | 18:26 |
| @wiking | i can keep everything inside sgobject | 18:26 |
| @wiking | yeey | 18:26 |
| @wiking | but everything is inside no? :) | 18:26 |
| lisitsyn | otherwise you put json into sgobject | 18:26 |
| @wiking | ah but you can past that as a template param :P | 18:26 |
| lisitsyn | in java it is so because there is just one way to serialize | 18:26 |
| lisitsyn | but we have at least 3 | 18:27 |
| @wiking | template<JSonSerializer> SGObject::serializer(outputsream) | 18:27 |
| @wiking | and whatever you pass as template arg you know there's a visitor etc | 18:28 |
| @wiking | so you still dont ahve to make all that part of sgobject | 18:28 |
| @wiking | ? | 18:28 |
| @wiking | wouldn't that work? | 18:28 |
| @wiking | arg | 18:48 |
| @wiking | btw | 18:49 |
| @wiking | lisitsyn, it's even worse with serialvisitor... as we need a sort of | 18:49 |
| @wiking | anyvisitor | 18:49 |
| @wiking | buut acutally it's more like | 18:49 |
| @wiking | on(string key, T v) | 18:49 |
| @wiking | :) | 18:49 |
| @wiking | so basically SerialVisitor is class SerialVisitor ( on(k,v) <- all typed and then it actually holds an implementation on AnyVisitor imoplementation so that one can pass that in SGobject to visit the map | 18:51 |
| @wiking | :) | 18:51 |
| @wiking | argh | 18:51 |
| @wiking | this looks rather !@#$ | 18:51 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4260 opened by iglesias | 18:57 |
| -!- HeikoS [~heiko@77.243.19.33] has quit [Quit: Leaving.] | 19:02 | |
| -!- HeikoS [~heiko@77.243.19.33] has joined #shogun | 19:04 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 19:04 | |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/617e1714f6e859f056025747a8aec9fb6c003121 by iglesias | 19:08 |
| @sukey | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/a45d28355b537960537308ba12bede265763d368 by iglesias | 19:09 |
| -!- HeikoS [~heiko@77.243.19.33] has quit [Quit: Leaving.] | 19:30 | |
| -!- HeikoS [~heiko@77.243.19.33] has joined #shogun | 19:30 | |
| -!- mode/#shogun [+o HeikoS] by ChanServ | 19:30 | |
| -!- HeikoS [~heiko@77.243.19.33] has quit [Ping timeout: 260 seconds] | 19:43 | |
| -!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has joined #shogun | 20:02 | |
| travis-ci | it's Fernando J. Iglesias Garc?a's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367264065 | 20:02 |
| -!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has left #shogun [] | 20:02 | |
| @wiking | lisitsyn, pingu | 20:37 |
| -!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has joined #shogun | 20:37 | |
| travis-ci | it's Fernando J. Iglesias Garc?a's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367264065 | 20:37 |
| -!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has left #shogun [] | 20:37 | |
| -!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has joined #shogun | 20:41 | |
| travis-ci | it's Fernando J. Iglesias Garc?a's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367264323 | 20:41 |
| -!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has left #shogun [] | 20:41 | |
| -!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has joined #shogun | 21:06 | |
| travis-ci | it's Fernando J. Iglesias Garc?a's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367264323 | 21:06 |
| -!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has left #shogun [] | 21:06 | |
| lisitsyn | wiking: hey | 21:34 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4168 synchronized by syashakash | 21:39 |
| @wiking | lisitsyn, hoy | 21:54 |
| lisitsyn | wiking: ok | 21:55 |
| lisitsyn | catched | 21:55 |
| lisitsyn | :) | 21:55 |
| lisitsyn | so what's up | 21:55 |
| @wiking | kk | 21:55 |
| @wiking | finally | 21:55 |
| @wiking | so have you seen my comments above | 21:55 |
| @wiking | about SerialVisitor that holds a specific AnyVisitor | 21:56 |
| lisitsyn | I think I missed what's SerialVisitor | 21:57 |
| @wiking | ok | 22:03 |
| @wiking | so the idea is that in need to store in the json the (key, value) tuple right? that is coming from Self->map | 22:04 |
| lisitsyn | yes | 22:04 |
| @wiking | basically the only way i can store in a json or any kv store | 22:04 |
| @wiking | that i need | 22:04 |
| lisitsyn | visit(string, any) { write(key); any.visit(writer); } | 22:05 |
| lisitsyn | something like that? | 22:05 |
| @wiking | .add(key, value); | 22:05 |
| @wiking | yeah basiucally | 22:05 |
| @wiking | that should be it righT? :) | 22:05 |
| lisitsyn | yes so key value visitor | 22:05 |
| lisitsyn | wiking: but that's fine? | 22:06 |
| lisitsyn | I mean the interface is simple | 22:06 |
| @wiking | yeah i know | 22:07 |
| @wiking | but its just clunky :P | 22:07 |
| lisitsyn | class ParameterVisitor { void visit(string key, any value); } | 22:07 |
| lisitsyn | wiking: I don't see anything clunky :P | 22:08 |
| lisitsyn | what's wrong? | 22:08 |
| @wiking | i mean it adds another abstraction | 22:08 |
| @wiking | over AnyVisitor | 22:08 |
| lisitsyn | not really | 22:09 |
| @wiking | i mean on the concept | 22:09 |
| lisitsyn | ParameterVisitor may not even use AnyVisitor | 22:09 |
| lisitsyn | they are quite separated | 22:09 |
| @wiking | mmm so you want to add support to any for ParameterVisitor? | 22:10 |
| @wiking | i mean because you need to access any | 22:10 |
| lisitsyn | yeah just accept any | 22:10 |
| lisitsyn | and then you can do anything you want with any | 22:10 |
| lisitsyn | I mean parameter visitor visits parameter and then it can use anyvisitor to print the value | 22:12 |
| lisitsyn | they're like composing on top of each other | 22:12 |
| @wiking | yeah | 22:12 |
| @wiking | hence my sentence about another abstraction over anyvisitor | 22:12 |
| @wiking | :P | 22:12 |
| @wiking | i.e. on any | 22:12 |
| @wiking | :D | 22:12 |
| lisitsyn | wiking: other way is that | 22:12 |
| lisitsyn | you just provide necessary methods | 22:12 |
| lisitsyn | to introspect the object | 22:12 |
| lisitsyn | this might work as well | 22:13 |
| @sukey | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4260 merged by iglesias | 22:13 |
| @sukey | [https://github.com/shogun-toolbox/shogun] iglesias pushed 2 commits: | 22:13 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/9ac2c55a2063d9835193e10091c5283718d59939 | 22:13 |
| @sukey | https://github.com/shogun-toolbox/shogun/commit/8da4063178562011ae82686bab6e96ca5b1e1e58 | 22:13 |
| lisitsyn | parameteriterator or something would work as well | 22:14 |
| -shogun-buildbot:#shogun- Build trusty - libshogun - viennacl #413 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/6/builds/413 | 22:14 | |
| lisitsyn | I don't know what way is better | 22:14 |
| -!- travis-ci [~travis-ci@ec2-54-221-31-242.compute-1.amazonaws.com] has joined #shogun | 22:29 | |
| travis-ci | it's syashakash's turn to pay the next round of drinks for the massacre he caused in syashakash/shogun: https://travis-ci.org/syashakash/shogun/builds/367327130 | 22:29 |
| -!- travis-ci [~travis-ci@ec2-54-221-31-242.compute-1.amazonaws.com] has left #shogun [] | 22:29 | |
| -!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has joined #shogun | 22:43 | |
| travis-ci | it's syashakash's turn to pay the next round of drinks for the massacre he caused in syashakash/shogun: https://travis-ci.org/syashakash/shogun/builds/367327130 | 22:43 |
| -!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has left #shogun [] | 22:43 | |
| -!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has joined #shogun | 23:03 | |
| travis-ci | it's Fernando J. Iglesias Garcia's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367342741 | 23:03 |
| -!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has left #shogun [] | 23:03 | |
| -!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has joined #shogun | 23:14 | |
| travis-ci | it's Fernando J. Iglesias Garcia's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/367342741 | 23:14 |
| -!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has left #shogun [] | 23:14 | |
| --- Log closed Tue Apr 17 00:00:28 2018 | ||
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!