IRC logs of #shogun for Tuesday, 2018-04-17

« Monday, 2018-04-16 Index Wednesday, 2018-04-18 »
--- Log opened Tue Apr 17 00:00:28 2018
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4168 synchronized by syashakash03:07
-!- travis-ci [~travis-ci@ec2-54-221-31-242.compute-1.amazonaws.com] has joined #shogun04:35
travis-ciit's syashakash's turn to pay the next round of drinks for the massacre he caused in syashakash/shogun: https://travis-ci.org/syashakash/shogun/builds/36744302404:35
-!- travis-ci [~travis-ci@ec2-54-221-31-242.compute-1.amazonaws.com] has left #shogun []04:35
-shogun-buildbot:#shogun- Build nightly_bsd_license #137 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/4/builds/13706:03
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham80806:23
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4236 synchronized by shubham80806:25
-shogun-buildbot:#shogun- Build nightly_default #125 is complete: Failure [failed test (failure)] - http://buildbot.shogun-toolbox.org:8080/#builders/17/builds/12507:09
-!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has joined #shogun07:13
travis-ciit's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/36748053307:14
-!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has left #shogun []07:14
-!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has joined #shogun07:26
travis-ciit's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/36748053307:26
-!- travis-ci [~travis-ci@ec2-107-21-150-51.compute-1.amazonaws.com] has left #shogun []07:26
-!- iglesias [~iglesias@77.243.24.142] has joined #shogun09:01
-!- HeikoS [~heiko@77.243.24.142] has joined #shogun09:11
-!- mode/#shogun [+o HeikoS] by ChanServ09:11
@wikinglisitsyn, yo09:43
@wikinglisitsyn, one question that i still dont get... how do you get the type for a tag?09:44
@wikingsay i have LibSVM and have its tags09:46
@wikingand the promise for me was that if i traverse the tags i know exactly what type i'm gonna be reading in :)09:48
lisitsynwiking: no but Any can inject its value into visitor09:53
lisitsynthat's the whole point of visitors09:53
lisitsynbut you can't know outside09:53
@wikingyeye09:53
@wikingi'm talking now reversing09:53
@wikingi.e reading into any09:54
@wikingthe visitor i have and that works nicely09:54
@wikingthe problemm is the other way around09:54
@wikingsame as in case of cereal09:54
@wiking:)09:54
lisitsynaah09:54
lisitsynwiking: uh :)09:55
@wikingi mean the problem is that09:55
lisitsynwiking: you may obtain type_info09:55
lisitsynfrom any09:55
@wikingthis is where i've got stuck09:55
lisitsynand then switch over it09:55
@wikingyeye09:55
@wikingbut then we are where we were with cereal :))))09:55
lisitsynno, why?09:56
@wikingafaik type_info is not consistent09:56
@wikingover machines09:56
@wikingor libstdc++09:56
lisitsynnot sure09:56
-!- HeikoS [~heiko@77.243.24.142] has quit [Ping timeout: 260 seconds]09:56
lisitsynwiking: ok better solution then09:56
lisitsynwiking: visitor but that provides reference09:56
@wikingThere is no guarantee that the same std::type_info instance will be referred to by all evaluations of the typeid expression on the same type, although std::type_info::hash_code of those type_info objects would be identical, as would be their std::type_index.09:56
@wikingThere is no guarantee that the same std::type_info instance will be referred to by all evaluations of the typeid expression on the same type, although std::type_info::hash_code of those type_info objects would be identical, as would be their std::type_index.09:56
@wikingsorry for the double copy09:56
lisitsynlike visit(T& value) { value = read(..) }09:57
@wikingaha09:57
lisitsynsee what I mean?09:57
@wikingcompiling09:57
@wikingjust a sec09:57
@wiking:)09:57
@wikingok so then we have 2 type of visitor?09:57
@wikingone with const T09:57
@wikingand one with T& ?09:58
lisitsynor just merge them into one09:58
lisitsynwhich is also fine to me09:58
lisitsynI mean T& always is as good09:58
@wikingi mean actually09:58
@wikingvirtual void on(const bool*) = 0;09:58
@wikingvirtual void on(const int32_t*) = 0;09:58
@wikingso if we'd drop const09:58
@wikingit would work no?09:58
@wikingi mean because it's a pointer09:58
lisitsynwiking: exactly09:59
lisitsynyeah we already using pointers09:59
lisitsynso just drop the const and that's it09:59
@wikingkkk but lemme think09:59
lisitsynwiking: in the implementation you will be calling appropriate methods to read bools, read vectors, etc10:00
@wikingyeye10:00
@wikingmmm ok so i have VisitorReader10:00
@wikingand VisitorWriter10:00
lisitsynor ReadVisitor WriteVisitor10:01
-!- iglesias [~iglesias@77.243.24.142] has quit [Ping timeout: 256 seconds]10:14
-!- ricklly_ [~ricklly@2001:cc0:2020:4017:cde3:b86a:f647:f008] has joined #shogun10:24
-!- HeikoS [~heiko@77.243.24.142] has joined #shogun11:22
-!- mode/#shogun [+o HeikoS] by ChanServ11:22
-!- iglesias [~iglesias@77.243.24.142] has joined #shogun11:25
-!- ricklly_ [~ricklly@2001:cc0:2020:4017:cde3:b86a:f647:f008] has quit [Remote host closed the connection]11:56
@sukey[https://github.com/shogun-toolbox/shogun] vigsterkr pushed 2 commits:12:04
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/7bbf0977daa1e8af6f4a01a40234f3351739a41e12:04
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/67bf8100ce7567921c0ac1c2f91a5a5fb218baf112:04
-!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has joined #shogun12:12
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/36757642112:12
-!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has left #shogun []12:12
lisitsynwiking: O_o :)12:28
lisitsynso you go with cereal and visitors?12:28
@wikingit's just a quick check12:31
@wikingif that'd work12:31
@wikingas i had the same problem there12:32
@wikingthat we have here12:32
@wikinglisitsyn, and there i had the saving working nicely already12:32
@wikingso now i just test it on hedonism12:32
lisitsynwiking: I think this is going to work12:32
@wikingwould that work the other way round12:32
lisitsynwith that we don't need to write json/xml/etc things12:33
@wikingyeah lets see12:33
@wikingjust trying to get it to worj12:33
@wikingwork12:33
lisitsynwiking: one thing I am not sure12:42
lisitsynis that Archive is templated thing12:42
lisitsynit is not going to work directly with swig12:42
lisitsynso we still wrap it12:42
@wikingah yeah12:42
@wikingbut we do a trick there12:42
lisitsynwiking: it might make sense to implement CerealSerializer, CerealDeserializer12:42
@wikingwe extend sgobj12:42
@wikingto have those12:43
lisitsynso that Cereaal is not the dependency but just one way of doing that12:43
@wikingic12:43
@wikingyeah we can mix that12:43
@wikingjust i'm still testing this whole idea12:43
@wiking(compiling)12:43
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/d0d526d76d96a7939b6cd2e558a80a2ddebc9ae9 by vigsterkr12:58
@wikingstill far from the good :(12:58
@wikinglisitsyn, we have aw problem13:23
@wiking:))))13:23
lisitsynhouston13:23
lisitsynyeah?13:23
-!- travis-ci [~travis-ci@ec2-54-221-31-242.compute-1.amazonaws.com] has joined #shogun13:23
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/36759720013:23
-!- travis-ci [~travis-ci@ec2-54-221-31-242.compute-1.amazonaws.com] has left #shogun []13:23
@wikinglisitsyn, i think when i do ReadVisitor13:24
@wikingi go to the on(Empty<>()13:24
@wikingof the visitor13:24
@wikingbecause the object is empty... it only has been created with default ctor13:24
@wikingbut i'm not 100513:24
@wiking100%13:24
@wikingjust debugging13:24
-!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has joined #shogun13:27
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/36759720013:27
-!- travis-ci [~travis-ci@ec2-54-144-195-124.compute-1.amazonaws.com] has left #shogun []13:27
@wikingcoz any visitor has void on(Empty*)13:27
@wiking{13:27
@wiking}13:27
@wikingvoid on(...)13:27
@wiking{13:27
@wiking}13:27
@wikingaaah nooo fuck13:29
@wikingi have a hunch13:29
@wikingthat somewhere i left in the const13:29
@wikingargh13:31
@wikingtemplate <class T>13:31
@wikinginline T const* typed_pointer(const void* ptr)13:31
@wiking{13:31
@wikingreturn static_cast<T const*>(ptr);13:31
@wiking}13:31
@wikinglisitsyn, basically because our visitor is not on(T* v)13:32
@wikingwe need const removal :)13:33
lisitsynah13:33
lisitsynok13:33
lisitsynwell fixable13:33
@wikinglisitsyn, visitor->on(const_cast<T>(typed_pointer<T>(storage)));13:33
@wikingor rather have a different typed_pointer wrapper?13:33
@wikingjust testing with the above fix13:34
@wikingif that's the case13:34
lisitsynconst cast is fine13:34
@wikingtesting13:36
@wikingman i compiled like 10 times13:36
@wikingthe whole lib13:36
@wikinglisitsyn, ok it matched all the serialization part13:43
@wikingbut when i do visit on an empty class13:44
@wikingas if no visitor is being called13:45
lisitsynwiking: empty sgobject?13:46
lisitsynor?13:47
@wikingi mean it's a default ctored object13:47
@wikingbut i'm still debugging13:49
@wikingi might know wtf13:53
-!- iglesiasg [~iglesias@77.243.26.98] has joined #shogun14:13
-!- HeikoS [~heiko@77.243.24.142] has quit [Read error: Connection reset by peer]14:13
-!- iglesias [~iglesias@77.243.24.142] has quit [Read error: Connection reset by peer]14:13
@wikingmmm ok i have no clue why that doesn't work lisitsyn ... but basically SGObject's serialization method is being called good and it actually does a serizalization properly14:19
@wikingthe other way round doesn't work14:19
lisitsynwiking: what exactly fails?14:21
@wikingSGObject's cereal functions not being called14:21
lisitsynwiking: can you point me to the code?14:21
@wikingsave works good14:21
@wikingyeah sure14:21
@wikingthis is called https://github.com/shogun-toolbox/shogun/blob/feature/cereal/src/shogun/base/SGObject.h#L14914:22
@wikingthis is not https://github.com/shogun-toolbox/shogun/blob/feature/cereal/src/shogun/base/SGObject.h#L16714:22
@wikingand the unit test14:22
@wikinghttps://github.com/shogun-toolbox/shogun/blob/feature/cereal/tests/unit/io/Cereal_unittest.cc#L17614:22
lisitsynhmm14:24
@wikingand the json has this14:24
@wikinghttps://pastebin.com/kDvAdTbu14:25
-!- ricklly_ [~ricklly@2001:cc0:2020:4017:cde3:b86a:f647:f008] has joined #shogun14:25
-!- HeikoS [~heiko@77.243.26.98] has joined #shogun14:29
-!- mode/#shogun [+o HeikoS] by ChanServ14:29
-!- ricklly_ [~ricklly@2001:cc0:2020:4017:cde3:b86a:f647:f008] has quit [Remote host closed the connection]14:54
-!- iglesiasg [~iglesias@77.243.26.98] has quit [Ping timeout: 264 seconds]15:39
@wikinglisitsyn, there's no way i can match a template with the return value one expects right? so say template<typename T> T asdf() {...} and then i have  a = asdf() where a has a type17:08
@wikingof X or whatever17:08
-!- iglesiasg [~iglesias@77.243.26.98] has joined #shogun17:22
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/4f2d50669800e5b3f375497413f76508343bc8d3 by vigsterkr17:57
@wikinglisitsyn, ^ this almost works...have some problem with class_list.h inclusion17:57
@wikingother than that it should work17:57
-!- travis-ci [~travis-ci@ec2-54-147-20-153.compute-1.amazonaws.com] has joined #shogun18:06
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/36772387018:06
-!- travis-ci [~travis-ci@ec2-54-147-20-153.compute-1.amazonaws.com] has left #shogun []18:06
lisitsynwiking: cool18:15
@wikingok works18:17
@wikingok now i do the last test18:17
@wikingand then i push18:17
@wikinglisitsyn, here?19:39
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4261 opened by karlnapf19:57
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4261 synchronized by karlnapf20:04
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4262 opened by iglesias20:13
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/426220:13
-!- iglesiasg [~iglesias@77.243.26.98] has quit [Remote host closed the connection]20:17
-!- iglesiasg [~iglesias@77.243.26.98] has joined #shogun20:17
@sukey[https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/3975 closed by iglesias20:27
-!- travis-ci [~travis-ci@ec2-54-147-20-153.compute-1.amazonaws.com] has joined #shogun20:27
travis-ciit's syashakash's turn to pay the next round of drinks for the massacre he caused in syashakash/shogun: https://travis-ci.org/syashakash/shogun/builds/36775670420:27
-!- travis-ci [~travis-ci@ec2-54-147-20-153.compute-1.amazonaws.com] has left #shogun []20:27
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4261 synchronized by karlnapf20:27
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/ca0f19cd0c3db7d3ca36ed9ee6201ef317ae89f8 by vigsterkr20:33
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4235 synchronized by shubham80820:37
-!- travis-ci [~travis-ci@ec2-54-92-178-164.compute-1.amazonaws.com] has joined #shogun20:42
travis-ciit's syashakash's turn to pay the next round of drinks for the massacre he caused in syashakash/shogun: https://travis-ci.org/syashakash/shogun/builds/36775670420:42
-!- travis-ci [~travis-ci@ec2-54-92-178-164.compute-1.amazonaws.com] has left #shogun []20:42
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4261 synchronized by karlnapf20:45
@sukey[https://github.com/shogun-toolbox/shogun] New branch feature/prune_swig created20:47
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/6475cf9956bc7e920e40b71836398161ec71ff5f by karlnapf20:47
-!- iglesiasg [~iglesias@77.243.26.98] has quit [Ping timeout: 240 seconds]21:46
-!- travis-ci [~travis-ci@ec2-54-147-20-153.compute-1.amazonaws.com] has joined #shogun21:55
travis-ciit's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/36779614421:55
-!- travis-ci [~travis-ci@ec2-54-147-20-153.compute-1.amazonaws.com] has left #shogun []21:55
-!- travis-ci [~travis-ci@ec2-54-92-178-164.compute-1.amazonaws.com] has joined #shogun22:18
travis-ciit's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/36779614422:18
-!- travis-ci [~travis-ci@ec2-54-92-178-164.compute-1.amazonaws.com] has left #shogun []22:18
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/2373affaa3806b9023e87d5479a7e3c5366d944c by vigsterkr22:24
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/2c04e597035d7d24b35240020a6240a827170495 by vigsterkr22:26
-!- travis-ci [~travis-ci@ec2-54-92-178-164.compute-1.amazonaws.com] has joined #shogun22:41
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/36779403222:41
-!- travis-ci [~travis-ci@ec2-54-92-178-164.compute-1.amazonaws.com] has left #shogun []22:41
-!- iglesiasg [~iglesias@77.243.26.98] has joined #shogun22:42
-!- iglesiasg [~iglesias@77.243.26.98] has quit [Ping timeout: 268 seconds]22:50
-!- iglesiasg [~iglesias@77.243.26.98] has joined #shogun22:52
-!- iglesiasg [~iglesias@77.243.26.98] has quit [Ping timeout: 256 seconds]23:01
-!- iglesiasg [~iglesias@77.243.26.98] has joined #shogun23:12
@sukey[https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4262 synchronized by iglesias23:14
-!- iglesiasg [~iglesias@77.243.26.98] has quit [Client Quit]23:15
-!- iglesiasg [~iglesias@77.243.26.98] has joined #shogun23:15
@sukey[https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/41dabf91db36ddccfeb4ac9f6004ba5c168c8618 by vigsterkr23:20
-!- iglesiasg [~iglesias@77.243.26.98] has quit [Remote host closed the connection]23:26
-!- iglesiasg [~iglesias@77.243.26.98] has joined #shogun23:26
@sukey[https://github.com/shogun-toolbox/shogun] New branch w/streams-serialization created23:32
@sukey[https://github.com/shogun-toolbox/shogun] vigsterkr pushed 8 commits:23:32
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/fac2fef3ec600b8b4ec7f899dd3bb66257c09cdb23:32
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/1c6256fd3c76ea6a37b414f65c8e6aeefbad3b5623:32
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/d71bda8b01014c96030fc060d6640720c91605fb23:32
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/a6ed4bd9b7d2285625a02d2b94adc9cf40608b4123:32
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/e1c3ffe691c18dd5aa9c36e2fceba5a2dbe0172523:32
@sukeyhttps://github.com/shogun-toolbox/shogun/commit/9dabacaeab7e24455cd42aec59dda8489e51873823:32
-!- sukey [~nodebot@ks312251.kimsufi.com] has quit [Remote host closed the connection]23:32
--- Log closed Wed Apr 18 00:00:29 2018
« Monday, 2018-04-16 Index Wednesday, 2018-04-18 »

Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!