--- Log opened Tue May 08 00:00:50 2018 | ||
--- Day changed Tue May 08 2018 | ||
-!- iglesiasg [~iglesias@f119189.upc-f.chello.nl] has quit [Quit: Leaving] | 00:00 | |
-shogun-buildbot:#shogun- Build nightly_bsd_license #149 is complete: Failure [failed update shogun (failure)] - http://buildbot.shogun-toolbox.org:8080/#builders/4/builds/149 | 03:00 | |
-shogun-buildbot:#shogun- Build clang - static analysis #135 is complete: Exception [exception update shogun (failure) uploading static_analysis (exception)] - http://buildbot.shogun-toolbox.org:8080/#builders/29/builds/135 | 03:00 | |
-shogun-buildbot:#shogun- Build cookbook - nightly #137 is complete: Failure [failed update shogun (failure)] - http://buildbot.shogun-toolbox.org:8080/#builders/14/builds/137 | 03:00 | |
-shogun-buildbot:#shogun- Build doxygen - nightly #135 is complete: Failure [failed update shogun (failure)] - http://buildbot.shogun-toolbox.org:8080/#builders/12/builds/135 | 03:00 | |
-!- HeikoS [~heiko@bmi-airport-1.inf.ethz.ch] has joined #shogun | 10:43 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 10:43 | |
-!- witness [uid10044@gateway/web/irccloud.com/x-mcszsykrhrjmoqoy] has quit [Quit: Connection closed for inactivity] | 10:50 | |
@wiking | geektoni here? | 11:15 |
---|---|---|
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4275 synchronized by karlnapf | 11:18 |
@HeikoS | wuwei: hi | 11:21 |
@HeikoS | wuwei: you still have that problem with the unsigned parameter? | 11:21 |
wuwei | yeah I still don't get a way | 11:22 |
wuwei | Besides some parameters are registered as CSGObject*, which also causes errors in python, for example in random forests | 11:24 |
@HeikoS | wuwei: yes | 11:28 |
@HeikoS | wuwei: so for sgobject | 11:28 |
@HeikoS | see my recent patches. We dont register as SGObject anymore | 11:29 |
@HeikoS | you want to register by the base type | 11:29 |
@HeikoS | CMachine* | 11:29 |
@HeikoS | CKernel* etc | 11:29 |
@HeikoS | then you can put the object | 11:29 |
@HeikoS | for the unsigned parameter, you will have to give me an example | 11:29 |
@HeikoS | wuwei: but generally, we have to dispatch the numeric types (i.e. try-error) | 11:29 |
@HeikoS | wuwei: check shogun.i | 11:29 |
@HeikoS | there we dispatch ints to floats and things like this | 11:30 |
@HeikoS | if you write obj.put("number", 4) | 11:30 |
@HeikoS | it will try to set it as float32,float64,int32,int64, etc | 11:30 |
wuwei | For the unsigned, see notebook for LMNN | 11:30 |
@HeikoS | so might have to add the unsigned dispatcher there | 11:30 |
@HeikoS | which parameter of LMNN? | 11:30 |
wuwei | Let me check | 11:31 |
wuwei | max iter , IIRC | 11:32 |
@HeikoS | wuwei: so for features | 11:33 |
@HeikoS | SG_ADD((CSGObject**) &m_features, "features", "Training features", | 11:33 |
@HeikoS | MS_NOT_AVAILABLE) | 11:33 |
@HeikoS | you have to remove the cast to CSGObject | 11:34 |
@HeikoS | for the unsigned int | 11:35 |
@HeikoS | mmmh | 11:35 |
@HeikoS | wiking: you think we should support uint as type? | 11:35 |
@HeikoS | I tend to say no | 11:35 |
@wiking | heheh | 11:35 |
@HeikoS | wiking: what do you think? | 11:35 |
@wiking | where is it unit? | 11:36 |
@HeikoS | I mean there is very few places where this is used anyways | 11:36 |
@wiking | which param? | 11:36 |
@HeikoS | LMNN::m_maxiter | 11:36 |
@HeikoS | maxiter is just an int in most algorithms | 11:36 |
@HeikoS | just fernando decided to use uint | 11:36 |
@wiking | ehhe | 11:36 |
@wiking | fernando makes things correct :P | 11:36 |
@wiking | yeah i mean | 11:36 |
@wiking | if this is the only usecase | 11:36 |
@wiking | then lets just convert it to int64 :) | 11:37 |
@wiking | and tada done | 11:37 |
@HeikoS | yep | 11:37 |
@HeikoS | wuwei: so you can just change the type of that parameter | 11:37 |
wuwei | okay I see | 11:38 |
@HeikoS | wuwei: also check out the bottom of shogun.i | 11:38 |
@HeikoS | there are the dispatchers | 11:39 |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4275 merged by karlnapf | 11:39 |
sukey1 | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/bce30238faf0bd5afb3cf9df9ab9d08076ad5bca by karlnapf | 11:39 |
-shogun-buildbot:#shogun- Build deb1 - libshogun #405 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/10/builds/405 | 11:43 | |
lisitsyn | HeikoS: the latest patches are like converging to something nice | 11:48 |
@HeikoS | lisitsyn: yeah it is getting there | 11:54 |
@HeikoS | lisitsyn: I managed to get rid of the dispatching in put/add as well | 11:54 |
@HeikoS | just cleaning up another PR | 11:55 |
@HeikoS | lisitsyn: gotta run, be back in half an hour | 11:55 |
lisitsyn | alright :) | 11:56 |
@HeikoS | lisitsyn: back | 12:20 |
@HeikoS | lisitsyn: any news on your side? | 12:21 |
@HeikoS | lisitsyn: there was this thing | 12:21 |
@HeikoS | register callback with get | 12:21 |
lisitsyn | not yet sorry | 12:21 |
@HeikoS | and what else? there was another thingi | 12:21 |
lisitsyn | prototype of callback | 12:21 |
lisitsyn | and merge plugins | 12:21 |
@HeikoS | ah yeah | 12:21 |
@HeikoS | You might specialize is_sg_base for specific T. | 12:23 |
@HeikoS | lisitsyn: can you give me a hint on that? | 12:23 |
lisitsyn | HeikoS: ah yeah sure | 12:24 |
lisitsyn | declare template<class T> struct is_sg_base | 12:24 |
lisitsyn | and then declare | 12:24 |
lisitsyn | struct is_sg_base<CMacihine> { ... } | 12:24 |
@HeikoS | I see | 12:24 |
lisitsyn | I don't know if it is better | 12:24 |
@HeikoS | so we then just define more template specialisations | 12:24 |
@HeikoS | mmh | 12:25 |
@HeikoS | and you know about the constexpr? | 12:25 |
lisitsyn | inside the is_sg_base you can declare static constexpr something | 12:25 |
lisitsyn | well I don't think constexpr is very important in here | 12:25 |
@HeikoS | ok | 12:27 |
@HeikoS | I think i will just leave it for now | 12:27 |
@HeikoS | we can always improve this | 12:27 |
@HeikoS | just wanted to avoid the dispatching code escalating | 12:27 |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4276 synchronized by karlnapf | 12:34 |
@HeikoS | lisitsyn: ^ | 12:35 |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4276 synchronized by karlnapf | 12:35 |
sukey1 | [https://github.com/shogun-toolbox/shogun] karlnapf pushed 2 commits: | 12:56 |
sukey1 | https://github.com/shogun-toolbox/shogun/commit/e70c6d6010a77e6269b9e2a565acfe45411bcd9d | 12:56 |
sukey1 | https://github.com/shogun-toolbox/shogun/commit/5bede6e8603fe1d895649c19ce0fc56299282dda | 12:56 |
-!- durovo2 [~durovo@37.8f.559e.ip4.static.sl-reverse.com] has quit [Remote host closed the connection] | 12:59 | |
-!- durovo [~durovo@37.8f.559e.ip4.static.sl-reverse.com] has joined #shogun | 12:59 | |
@HeikoS | wuwei: yo | 13:18 |
@HeikoS | wuwei: about your notebook PR | 13:18 |
@HeikoS | did you run all notebooks with the changes you made? | 13:18 |
wuwei | hi heiko | 13:18 |
wuwei | yes i did | 13:18 |
@HeikoS | great | 13:18 |
@HeikoS | great patch! :) | 13:19 |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4269 merged by karlnapf | 13:19 |
sukey1 | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/cceeb315e9f75b41364eddd53a5b7e874acf9d88 by karlnapf | 13:19 |
@HeikoS | wuwei: I guess there are still some left? | 13:19 |
wuwei | yeah i'm still woking on it | 13:19 |
@HeikoS | wuwei: cool! | 13:19 |
@HeikoS | wuwei: I sent out an email saying that you are working on the notebooks, so nobody starts working on the same thing | 13:23 |
@HeikoS | wuwei: next step is to port all the legacy python examples to meta examples | 13:23 |
wuwei | python in undocumented? | 13:25 |
wuwei | all right! | 13:25 |
-!- HeikoS [~heiko@bmi-airport-1.inf.ethz.ch] has quit [Ping timeout: 264 seconds] | 13:28 | |
-!- HeikoS [~heiko@inf-ise-etx-dock-1-111.ethz.ch] has joined #shogun | 13:48 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 13:48 | |
-!- HeikoS [~heiko@inf-ise-etx-dock-1-111.ethz.ch] has quit [Read error: Connection reset by peer] | 13:51 | |
-!- HeikoS [~heiko@inf-ise-etx-dock-1-111.ethz.ch] has joined #shogun | 13:51 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 13:51 | |
-!- HeikoS [~heiko@inf-ise-etx-dock-1-111.ethz.ch] has quit [Client Quit] | 13:51 | |
-!- HeikoS [~heiko@inf-ise-etx-dock-1-111.ethz.ch] has joined #shogun | 13:59 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 13:59 | |
-!- HeikoS [~heiko@inf-ise-etx-dock-1-111.ethz.ch] has quit [Ping timeout: 256 seconds] | 14:04 | |
-!- HeikoS [~heiko@inf-ise-etx-dock-1-111.ethz.ch] has joined #shogun | 14:21 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 14:21 | |
-!- HeikoS [~heiko@inf-ise-etx-dock-1-111.ethz.ch] has quit [Ping timeout: 260 seconds] | 14:34 | |
-!- travis-ci [~travis-ci@ec2-54-160-194-98.compute-1.amazonaws.com] has joined #shogun | 14:40 | |
travis-ci | it's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/376310596 | 14:40 |
-!- travis-ci [~travis-ci@ec2-54-160-194-98.compute-1.amazonaws.com] has left #shogun [] | 14:40 | |
sukey1 | [https://github.com/shogun-toolbox/shogun] Issue https://github.com/shogun-toolbox/shogun/issues/4267 closed by vigsterkr | 14:42 |
@wiking | wuwei, we have our video conference at 1500 UTC right? | 14:46 |
@wiking | that's 10pm beijing time? | 14:47 |
wuwei | 1500 UTC, 11pm in beijing :) | 14:47 |
@wiking | aaah | 14:47 |
@wiking | okok i've got it | 14:47 |
@wiking | it's 5pm CET | 14:47 |
-!- travis-ci [~travis-ci@ec2-54-211-20-75.compute-1.amazonaws.com] has joined #shogun | 15:29 | |
travis-ci | it's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/376310596 | 15:29 |
-!- travis-ci [~travis-ci@ec2-54-211-20-75.compute-1.amazonaws.com] has left #shogun [] | 15:29 | |
@wiking | lisitsyn, https://stackoverflow.com/questions/4131091/dynamic-cast-from-void | 15:45 |
@wiking | ideas? :) | 15:45 |
@wiking | coz storage is void* | 15:45 |
lisitsyn | wiking: I guess you need reinterpret_cast<SGObject*> then dynamic_cast<T> | 16:01 |
shogitter | (vigsterkr) lisitsyn craaaaazyyyyzuzi | 16:01 |
shogitter | (vigsterkr) :) | 16:02 |
@wiking | mmm | 16:02 |
lisitsyn | ?\_(?)_/? | 16:02 |
lisitsyn | yolo | 16:02 |
shogitter | (vigsterkr) YOL0! | 16:02 |
@wiking | mmm shogitter is one way :) | 16:04 |
@wiking | lisitsyn, http://matthias.vallentin.net/slides/berkeley-cpp-summit-caf.pdf | 16:04 |
@wiking | lisitsyn, check page 37 | 16:06 |
@wiking | better than erlang :O | 16:06 |
lisitsyn | ah yeah | 16:07 |
lisitsyn | erlang is not fast indeed | 16:07 |
@wiking | if we ever wanna do distrib shit :) | 16:08 |
@wiking | lisitsyn, ok so do you know why would clone fail on an obj where i dynamically add a param that is owned :) | 16:16 |
@wiking | meaning it's not a member var :) | 16:16 |
lisitsyn | wiking: what is 'fail'? | 16:17 |
@wiking | C++ exception with description "[ERROR] In file ../src/shogun/base/SGObject.cpp line 730: There is no parameter called "seed" in RandomCARTree | 16:17 |
@wiking | so i dynamically add the seed tag to the RandomCARTree | 16:17 |
lisitsyn | oh | 16:17 |
@wiking | with create_param | 16:17 |
lisitsyn | where do you add it? | 16:17 |
@wiking | basically it's a c->create_parameter(kSeedTag, AnyParameter(make_any(seed))); | 16:17 |
@wiking | it's totally dynamic :) i.e. not registered or anythign | 16:18 |
lisitsyn | clone creates empty object | 16:18 |
@wiking | that's fine :) | 16:18 |
@wiking | but i mean shouldn't it fill up the parameters map | 16:19 |
@wiking | from src? | 16:19 |
lisitsyn | no, it tries to access the parameter on an empty object | 16:19 |
lisitsyn | because we call clone_from | 16:19 |
@wiking | miju | 16:20 |
@wiking | yeah just checked SGO::clone | 16:20 |
@wiking | so we actually do not support these type of runtime crazyness :) | 16:21 |
@wiking | we need std::optional :) | 16:22 |
@wiking | maybe? :> | 16:22 |
@wiking | would Any(Maybe<int>) work? | 16:24 |
@wiking | ok lets try... :) | 16:24 |
lisitsyn | haha | 16:27 |
lisitsyn | wiking: I think maybe is to be dropped | 16:35 |
lisitsyn | C++14 has optional already | 16:35 |
lisitsyn | ah sorry it is 17 | 16:35 |
lisitsyn | do we use 17 already? | 16:36 |
@wiking | noup | 16:36 |
@wiking | :( | 16:36 |
@wiking | yeah i've checked | 16:36 |
@wiking | 17 is not really supported yet | 16:36 |
@wiking | so we do maybe for the time being | 16:36 |
lisitsyn | yeah jsut year more | 16:36 |
@wiking | :> | 16:45 |
@wiking | lisitsyn, btw since seed is part of self->map... essentially we could just do .put("seed", Maybe<int32_t>) | 16:46 |
@wiking | do we want to have a specialized set_seed in sgo? | 16:47 |
@wiking | that wraps the whole story of maybe<int32_t> ? | 16:47 |
@wiking | (maybe only in swig?) | 16:47 |
@wiking | i mean there has to be a specially handler for put("seed",...) because of traversing the children... | 16:47 |
@wiking | so unfortunately i'll have to do a shitty type traited catch for the put("seed") | 16:48 |
@wiking | :( | 16:48 |
@wiking | or should we just check if you do a put | 16:48 |
@wiking | "seed" then throw an exception that you should set that via | 16:49 |
@wiking | .set_seed ? :) | 16:49 |
@wiking | shitty | 16:49 |
@wiking | no matter how we do it | 16:49 |
@wiking | or? | 16:49 |
-!- travis-ci [~travis-ci@ec2-54-91-120-31.compute-1.amazonaws.com] has joined #shogun | 20:00 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/376460175 | 20:00 |
-!- travis-ci [~travis-ci@ec2-54-91-120-31.compute-1.amazonaws.com] has left #shogun [] | 20:00 | |
-!- travis-ci [~travis-ci@ec2-54-81-80-255.compute-1.amazonaws.com] has joined #shogun | 20:20 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/376485619 | 20:20 |
-!- travis-ci [~travis-ci@ec2-54-81-80-255.compute-1.amazonaws.com] has left #shogun [] | 20:20 | |
-!- travis-ci [~travis-ci@ec2-54-198-47-146.compute-1.amazonaws.com] has joined #shogun | 20:46 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/376464404 | 20:46 |
-!- travis-ci [~travis-ci@ec2-54-198-47-146.compute-1.amazonaws.com] has left #shogun [] | 20:46 | |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4277 opened by shubham808 | 21:17 |
-!- travis-ci [~travis-ci@ec2-54-81-80-255.compute-1.amazonaws.com] has joined #shogun | 22:11 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/376533183 | 22:11 |
-!- travis-ci [~travis-ci@ec2-54-81-80-255.compute-1.amazonaws.com] has left #shogun [] | 22:11 | |
-!- travis-ci [~travis-ci@ec2-54-91-120-31.compute-1.amazonaws.com] has joined #shogun | 22:20 | |
travis-ci | it's Shubham Shukla's turn to pay the next round of drinks for the massacre he caused in shubham808/shogun: https://travis-ci.org/shubham808/shogun/builds/376536124 | 22:20 |
-!- travis-ci [~travis-ci@ec2-54-91-120-31.compute-1.amazonaws.com] has left #shogun [] | 22:20 | |
--- Log closed Wed May 09 00:00:58 2018 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!