--- Log opened Wed May 09 00:00:58 2018 | ||
-shogun-buildbot:#shogun- Build cookbook - nightly #138 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/14/builds/138 | 03:01 | |
-shogun-buildbot:#shogun- Build clang - static analysis #136 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/29/builds/136 | 03:12 | |
-shogun-buildbot:#shogun- Build doxygen - nightly #136 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/12/builds/136 | 05:57 | |
-shogun-buildbot:#shogun- Build nightly_all #136 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/22/builds/136 | 06:15 | |
-shogun-buildbot:#shogun- Build nightly_bsd_license #150 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/4/builds/150 | 06:30 | |
-shogun-buildbot:#shogun- Build nightly_default #138 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/17/builds/138 | 07:39 | |
@wiking | lisitsyn, pingu | 10:38 |
---|---|---|
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4278 opened by shubham808 | 10:57 |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4278 synchronized by shubham808 | 11:03 |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has joined #shogun | 12:16 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 12:16 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has quit [Quit: Leaving.] | 13:32 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has joined #shogun | 14:44 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 14:44 | |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4278 merged by karlnapf | 14:59 |
sukey1 | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/ebf5004ec53cc71cd6c6dcbab1fd4834fa7522cc by karlnapf | 14:59 |
-shogun-buildbot:#shogun- Build deb1 - libshogun #409 is complete: Failure [failed update shogun (failure)] - http://buildbot.shogun-toolbox.org:8080/#builders/10/builds/409 | 14:59 | |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4276 merged by karlnapf | 15:03 |
sukey1 | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/1240c2b9bab4a5a892393af40ef52577385c04f4 by karlnapf | 15:03 |
@HeikoS | shogun-buildbot: force build | 15:08 |
-shogun-buildbot:#shogun- no builder specified | 15:08 | |
@HeikoS | shogun-buildbot: force build deb1 - libshogun | 15:08 |
-shogun-buildbot:#shogun- no such builder 'deb1' | 15:08 | |
@HeikoS | shogun-buildbot: force build 'deb1 - libshogun' | 15:08 |
sukey1 | [https://github.com/shogun-toolbox/shogun] New commit https://github.com/shogun-toolbox/shogun/commit/54e6d3a02ade975600b41ed7ae342eac28516fd2 by karlnapf | 15:10 |
-shogun-buildbot:#shogun- Build deb1 - libshogun #412 is complete: Success [build successful] - http://buildbot.shogun-toolbox.org:8080/#builders/10/builds/412 | 15:41 | |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4279 opened by karlnapf | 15:46 |
sukey1 | [https://github.com/shogun-toolbox/shogun] Pull Request https://github.com/shogun-toolbox/shogun/pull/4279 synchronized by karlnapf | 15:47 |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has quit [Quit: Leaving.] | 15:50 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has joined #shogun | 16:28 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 16:28 | |
-!- travis-ci [~travis-ci@ec2-54-81-80-255.compute-1.amazonaws.com] has joined #shogun | 16:42 | |
travis-ci | it's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/376824132 | 16:42 |
-!- travis-ci [~travis-ci@ec2-54-81-80-255.compute-1.amazonaws.com] has left #shogun [] | 16:42 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has quit [Quit: Leaving.] | 16:44 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has joined #shogun | 16:50 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 16:50 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has quit [Client Quit] | 16:50 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has joined #shogun | 16:51 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 16:51 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has quit [Quit: Leaving.] | 16:58 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has joined #shogun | 16:59 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 16:59 | |
-!- HeikoS [~heiko@eduroam-int-pat-8-208.ucl.ac.uk] has quit [Ping timeout: 240 seconds] | 17:03 | |
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has joined #shogun | 17:17 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 17:17 | |
-!- HeikoS [~heiko@untrust-out.swc.ucl.ac.uk] has quit [Ping timeout: 250 seconds] | 17:22 | |
-!- travis-ci [~travis-ci@ec2-54-211-38-28.compute-1.amazonaws.com] has joined #shogun | 17:22 | |
travis-ci | it's Heiko Strathmann's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/376826662 | 17:22 |
-!- travis-ci [~travis-ci@ec2-54-211-38-28.compute-1.amazonaws.com] has left #shogun [] | 17:22 | |
-!- HeikoS [~heiko@host86-128-122-53.range86-128.btcentralplus.com] has joined #shogun | 20:28 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 20:28 | |
@HeikoS | lisitsyn: jojo | 20:28 |
lisitsyn | HeikoS: hey | 20:29 |
@HeikoS | lisitsyn: I want your opinion on some | 20:29 |
lisitsyn | sure | 20:29 |
@HeikoS | I have these label conversion methods | 20:29 |
@HeikoS | multiclass_labels(CLabels*) | 20:29 |
@HeikoS | CMulticlassLabels* multiclass_labels(CLabels*)\ | 20:30 |
@HeikoS | so now | 20:30 |
@HeikoS | I am in a situation where I only have a const pointer | 20:30 |
@HeikoS | i.e. | 20:30 |
@HeikoS | const CLabels* | 20:30 |
@HeikoS | actually sorry, the method is Some<CMulticlassLabels> multiclass_labels(CLabels* orig); | 20:30 |
@HeikoS | so now how does that const stuff translate to some? | 20:30 |
@HeikoS | i.e. something where I can only call const methods on | 20:30 |
@HeikoS | I guess we will have this problem also when we move to some everywhere with our const methods | 20:31 |
@HeikoS | lisitsyn: see the problem? | 20:31 |
lisitsyn | not yet, reading | 20:31 |
lisitsyn | :) | 20:31 |
@HeikoS | basically i need some for const pointer | 20:32 |
lisitsyn | interesting | 20:32 |
@HeikoS | it should only allow the -> operator for const methods | 20:33 |
@HeikoS | would that be just | 20:34 |
@HeikoS | Some<const CMulticlassLabels> multiclass_labels(const CLabels* orig); | 20:34 |
@HeikoS | ? | 20:34 |
lisitsyn | or 'const Some<CMulticlassLabels>" | 20:34 |
lisitsyn | :) | 20:34 |
@HeikoS | https://stackoverflow.com/questions/17793333/difference-between-const-shared-ptrt-and-shared-ptrconst-t?utm_medium=organic&utm_source=google_rich_qa&utm_campaign=google_rich_qa | 20:34 |
@HeikoS | but also | 20:34 |
lisitsyn | ah right | 20:35 |
@HeikoS | I would like to avoid to have to define the casting thing some const as well | 20:35 |
lisitsyn | Some<const CMulticlassLabels> | 20:35 |
lisitsyn | but this is going to be quite strange | 20:35 |
lisitsyn | do you really want constness here? | 20:35 |
@HeikoS | well | 20:35 |
@HeikoS | I only have the const pointer to labels | 20:36 |
@HeikoS | and I want to convert | 20:36 |
@HeikoS | ah | 20:36 |
@HeikoS | yeah so either this just casts ( if possible( | 20:36 |
@HeikoS | or it creates a new object and converts the entries | 20:36 |
lisitsyn | HeikoS: I am a bit worried about adding consts around | 20:37 |
lisitsyn | because swig would multiplicate | 20:37 |
@HeikoS | we can also remove const | 20:37 |
@HeikoS | but that is not nice | 20:37 |
@HeikoS | we want const labels and const features | 20:37 |
@HeikoS | for thread safety etc | 20:38 |
@HeikoS | I guess | 20:38 |
@HeikoS | the problem is the casting | 20:38 |
@HeikoS | the labels conversion thingi | 20:38 |
@HeikoS | if it creates a new obj all is good | 20:38 |
@HeikoS | but the casting gives me a reference to the same thing | 20:38 |
@HeikoS | so there need to respect the const | 20:38 |
@HeikoS | i think | 20:39 |
@HeikoS | I will just add | 20:39 |
@HeikoS | Some<const CMulticlassLabels> multiclass_labels(const CLabels* orig); | 20:39 |
@HeikoS | it is just internal | 20:39 |
@HeikoS | not exposed | 20:39 |
lisitsyn | ah ok | 20:39 |
lisitsyn | if it is not swig | 20:39 |
lisitsyn | that sounds ok | 20:39 |
lisitsyn | let me just check one thing | 20:39 |
lisitsyn | ah ok nevermind | 20:39 |
lisitsyn | let me know if it fails | 20:40 |
@HeikoS | it is duplicate code | 20:40 |
-!- HeikoS [~heiko@host86-128-122-53.range86-128.btcentralplus.com] has quit [Excess Flood] | 20:40 | |
lisitsyn | hahah | 20:40 |
-!- HeikoS [~heiko@host86-128-122-53.range86-128.btcentralplus.com] has joined #shogun | 20:40 | |
-!- mode/#shogun [+o HeikoS] by ChanServ | 20:40 | |
@HeikoS | https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/labels/MulticlassLabels.cpp#L226 | 20:40 |
@HeikoS | lisitsyn: ^ | 20:41 |
lisitsyn | haha FLOODER | 20:41 |
@HeikoS | haha :D | 20:41 |
lisitsyn | HeikoS: just one quite abstract idea | 20:41 |
lisitsyn | would it be possible to ensure constness some other way | 20:42 |
lisitsyn | not using the const? :) | 20:42 |
lisitsyn | but nevermind | 20:42 |
@HeikoS | i dont like all the duplicate code | 20:45 |
@HeikoS | lisitsyn: | 20:45 |
lisitsyn | yeah me neither | 20:45 |
@HeikoS | maybe template with trait? | 20:46 |
lisitsyn | yeah | 20:46 |
lisitsyn | that's what I thought of | 20:46 |
@HeikoS | does is_same work for that? | 20:46 |
lisitsyn | specialize for std::decay<T> == CLabels | 20:46 |
@HeikoS | ah | 20:46 |
@HeikoS | maybe we are thinking of different stuff | 20:46 |
@HeikoS | ah no | 20:48 |
@HeikoS | lisitsyn: I dont think it works | 20:48 |
@HeikoS | Some<CMulticlassLabels> multiclass_labels(CLabels* orig); | 20:48 |
lisitsyn | yeah | 20:48 |
@HeikoS | whats the template type? | 20:48 |
@HeikoS | because we want to add const on both CLabels and CMulticlassLabels | 20:48 |
lisitsyn | yeah not trivial | 20:49 |
lisitsyn | HeikoS: I don't see any easy way yet | 20:50 |
@HeikoS | macros :D | 20:50 |
@HeikoS | the best (tm) | 20:50 |
@HeikoS | lisitsyn: discards qualifiers nightmare | 20:56 |
lisitsyn | HeikoS: our objects semantics is not really well suited for constness | 20:57 |
@HeikoS | lisitsyn: how to ensure constness? | 20:57 |
@HeikoS | I have already blocked put of CFeatures | 20:57 |
@HeikoS | via overloading it | 20:57 |
@HeikoS | but i think dropping c++ const is not the best idea | 20:57 |
@HeikoS | need to patch Some::from_raw, SGObject::as, and the labels | 20:59 |
@HeikoS | gnaaaa | 20:59 |
@HeikoS | ok dinner timer will do this later | 20:59 |
@HeikoS | see you | 20:59 |
-!- HeikoS [~heiko@host86-128-122-53.range86-128.btcentralplus.com] has quit [Quit: Leaving.] | 20:59 | |
shogitter | (shubham808) Hi Anyone around ? | 21:13 |
lisitsyn | shubham808 hey | 21:13 |
shogitter | (shubham808) How do I write obj->as<CBinaryLabels>() in python example | 21:14 |
shogitter | (shubham808) Currently in python it's like LabelsFactory.to_binary(obj) but we are getting rid of CLabelsFactory | 21:17 |
lisitsyn | uh we need Heiko there | 21:45 |
-!- witness_ [uid10044@gateway/web/irccloud.com/x-rxuhfdcuqgtjhdrq] has joined #shogun | 23:18 | |
--- Log closed Thu May 10 00:00:00 2018 |
Generated by irclog2html.py 2.10.0 by Marius Gedminas - find it at mg.pov.lt!